mm: report per-page metadata information
Subsystems (10)
v3 cover mm: report per-page metadata information
Changelog:
v3:
- Addressed comment from Matthew Wilcox.
- In free_page_ext, page_pgdat() is now extracted prior to freeing the memory.
v2:
- Fixed the three bugs reported by kernel test robot.
- Enhanced the commit message as recommended by David Hildenbrand.
- Addressed comments from Matthew Wilcox:
- Simplified alloc_vmemmap_page_list() and free_page_ext() as recommended.
- Used the appropriate comment style in mm/vmstat.c.
- Replaced writeout_early_perpage_metadata() with store_early_perpage_metadata() to reduce ambiguity with what swap does.
- Addressed comments from Mike Rapoport:
- Simplified the loop in alloc_vmemmap_page_list().
- Could NOT address a comment to move store_early_perpage_metadata() near where nodes and page allocator are initialized.
- Included the vmalloc()ed page_ext in accounting within free_page_ext().
- Made early_perpage_metadata[MAX_NUMNODES] static.
Previous approaches and discussions
-----------------------------------
v2:
https://lore.kernel.org/all/[email protected]
v1:
https://lore.kernel.org/r/[email protected]
Hi!
This patch adds a new per-node PageMetadata field to /sys/devices/system/node/nodeN/meminfo and a global PageMetadata field to /proc/meminfo. This information can be used by users to see how much memory is being used by per-page metadata, which can vary depending on build configuration, machine architecture, and system use.
Per-page metadata is the amount of memory that Linux needs in order to manage memory at the page granularity. The majority of such memory is used by "struct page" and "page_ext" data structures.
Background
----------
Kernel overhead observability is missing some of the largest allocations during runtime, including vmemmap (struct pages) and page_ext. This patch aims to address this problem by exporting a new metric PageMetadata.
On the contrary, the kernel does provide observibility for boot memory allocations. For example, the metric reserved_pages depicts the pages allocated by the bootmem allocator. This can be simply calculated as present_pages - managed_pages, which are both exported in /proc/zoneinfo. The metric reserved_pages is primarily composed of struct pages and page_ext.
What about the struct pages (allocated by bootmem allocator) that are free'd during hugetlbfs allocations and then allocated by buddy-allocator once hugtlbfs pages are free'd?
/proc/meminfo MemTotal changes: MemTotal does not include memblock allocations but includes buddy allocations. However, during runtime memblock allocations can be shifted into buddy allocations, and therefore become part of MemTotal.
Once the struct pages get allocated by buddy allocator, we lose track of these struct page allocations overhead accounting. Therefore, we must export a new metric that we shall refer to as PageMetadata (exported by node). This shall also comprise the struct page and page_ext allocations made during runtime.
Results and analysis
--------------------
Memory model: Sparsemem-vmemmap
$ echo 1 > /proc/sys/vm/hugetlb_optimize_vmemmap
$ cat /proc/meminfo | grep MemTotal MemTotal: 32918196 kB $ cat /proc/meminfo | grep Meta PageMetadata: 589824 kB $ cat /sys/devices/system/node/node0/meminfo | grep Meta Node 0 PageMetadata: 294912 kB $ cat /sys/devices/system/node/node1/meminfo | grep Meta Node 1 PageMetadata: 294912 kB
AFTER HUGTLBFS RESERVATION
$ echo 512 > /proc/sys/vm/nr_hugepages
$ cat /proc/meminfo | grep MemTotal
MemTotal: 32934580 kB
$ cat /proc/meminfo | grep Meta PageMetadata: 575488 kB $ cat /sys/devices/system/node/node0/meminfo | grep Meta Node 0 PageMetadata: 287744 kB $ cat /sys/devices/system/node/node1/meminfo | grep Meta Node 1 PageMetadata: 287744 kB
AFTER FREEING HUGTLBFS RESERVATION
$ echo 0 > /proc/sys/vm/nr_hugepages $ cat /proc/meminfo | grep MemTotal MemTotal: 32934580 kB $ cat /proc/meminfo | grep Meta PageMetadata: 589824 kB $ cat /sys/devices/system/node/node0/meminfo | grep Meta Node 0 PageMetadata: 294912 kB $ cat /sys/devices/system/node/node1/meminfo | grep Meta Node 1 PageMetadata: 294912 kB
Sourav Panda (1):
mm: report per-page metadata information
Documentation/filesystems/proc.rst | 3 +++ drivers/base/node.c | 2 ++ fs/proc/meminfo.c | 7 +++++++ include/linux/mmzone.h | 3 +++ include/linux/vmstat.h | 4 ++++ mm/hugetlb.c | 8 +++++++- mm/hugetlb_vmemmap.c | 8 +++++++- mm/mm_init.c | 3 +++ mm/page_alloc.c | 1 + mm/page_ext.c | 32 +++++++++++++++++++++--------- mm/sparse-vmemmap.c | 3 +++ mm/sparse.c | 7 ++++++- mm/vmstat.c | 24 ++++++++++++++++++++++ 13 files changed, 93 insertions(+), 12 deletions(-)
Signature · 1 line
2.42.0.820.g83a721a137-goog
PATCH v3 1/1 mm: report per-page metadata information
Adds a new per-node PageMetadata field to /sys/devices/system/node/nodeN/meminfo
and a global PageMetadata field to /proc/meminfo. This information can be used by users to see how much memory is being used by per-page metadata, which can vary depending on build configuration, machine architecture, and system use.
Per-page metadata is the amount of memory that Linux needs in order to manage memory at the page granularity. The majority of such memory is used by "struct page" and "page_ext" data structures. In contrast to most other memory consumption statistics, per-page metadata might not be included in MemTotal. For example, MemTotal does not include memblock allocations but includes buddy allocations. While on the other hand, per-page metadata would include both memblock and buddy allocations.
This memory depends on build configurations, machine architectures, and the way system is used:
Build configuration may include extra fields into "struct page", and enable / disable "page_ext"
Machine architecture defines base page sizes. For example 4K x86, 8K SPARC, 64K ARM64 (optionally), etc. The per-page metadata overhead is smaller on machines with larger page sizes. System use can change per-page overhead by using vmemmap optimizations with hugetlb pages, and emulated pmem devdax pages. Also, boot parameters can determine whether page_ext is needed to be allocated. This memory can be part of MemTotal or be outside MemTotal depending on whether the memory was hot-plugged, booted with, or hugetlb memory was returned back to the system.
--- Documentation/filesystems/proc.rst | 3 +++ drivers/base/node.c | 2 ++ fs/proc/meminfo.c | 7 +++++++ include/linux/mmzone.h | 3 +++ include/linux/vmstat.h | 4 ++++ mm/hugetlb.c | 8 +++++++- mm/hugetlb_vmemmap.c | 8 +++++++- mm/mm_init.c | 3 +++ mm/page_alloc.c | 1 + mm/page_ext.c | 32 +++++++++++++++++++++--------- mm/sparse-vmemmap.c | 3 +++ mm/sparse.c | 7 ++++++- mm/vmstat.c | 24 ++++++++++++++++++++++ 13 files changed, 93 insertions(+), 12 deletions(-)
Documentation/filesystems/proc.rst +3 -0
@@ -987,6 +987,7 @@ Example output. You may not have all of these fields. AnonPages: 4654780 kB Mapped: 266244 kB Shmem: 9976 kB + PageMetadata: 513419 kB KReclaimable: 517708 kB Slab: 660044 kB SReclaimable: 517708 kB
@@ -1089,6 +1090,8 @@ Mapped files which have been mmapped, such as libraries Shmem Total memory used by shared memory (shmem) and tmpfs +PageMetadata + Memory used for per-page metadata KReclaimable Kernel allocations that the kernel will attempt to reclaim under memory pressure. Includes SReclaimable (below), and other
drivers/base/node.c +2 -0
@@ -428,6 +428,7 @@ static ssize_t node_read_meminfo(struct device *dev,"Node %d Mapped: %8lu kB\n" "Node %d AnonPages: %8lu kB\n" "Node %d Shmem: %8lu kB\n" +"Node %d PageMetadata: %8lu kB\n" "Node %d KernelStack: %8lu kB\n" #ifdef CONFIG_SHADOW_CALL_STACK"Node %d ShadowCallStack:%8lu kB\n"
@@ -458,6 +459,7 @@ static ssize_t node_read_meminfo(struct device *dev, nid,K (node_page_state (pgdat,NR_FILE_MAPPED )), nid,K (node_page_state (pgdat,NR_ANON_MAPPED )), nid,K (i.sharedram), + nid,K (node_page_state (pgdat,NR_PAGE_METADATA )), nid,node_page_state (pgdat,NR_KERNEL_STACK_KB ), #ifdef CONFIG_SHADOW_CALL_STACK nid, node_page_state(pgdat, NR_KERNEL_SCS_KB),
fs/proc/meminfo.c +7 -0
@@ -39,7 +39,9 @@ static int meminfo_proc_show(struct seq_file *m, void *v)long available;unsigned long pages[NR_LRU_LISTS ];unsigned long sreclaimable, sunreclaim; +unsigned long nr_page_metadata;int lru; +int nid;si_meminfo (&i);si_swapinfo (&i);
@@ -57,6 +59,10 @@ static int meminfo_proc_show(struct seq_file *m, void *v) sreclaimable =global_node_page_state_pages (NR_SLAB_RECLAIMABLE_B ); sunreclaim =global_node_page_state_pages (NR_SLAB_UNRECLAIMABLE_B ); + nr_page_metadata =0 ; +for_each_online_node (nid) + nr_page_metadata +=node_page_state (NODE_DATA (nid),NR_PAGE_METADATA ); +show_val_kb (m,"MemTotal: " , i.totalram);show_val_kb (m,"MemFree: " , i.freeram);show_val_kb (m,"MemAvailable: " , available);
@@ -104,6 +110,7 @@ static int meminfo_proc_show(struct seq_file *m, void *v)show_val_kb (m,"Mapped: " ,global_node_page_state (NR_FILE_MAPPED ));show_val_kb (m,"Shmem: " , i.sharedram); +show_val_kb (m,"PageMetadata: " , nr_page_metadata);show_val_kb (m,"KReclaimable: " , sreclaimable +global_node_page_state (NR_KERNEL_MISC_RECLAIMABLE ));show_val_kb (m,"Slab: " , sreclaimable + sunreclaim);
include/linux/mmzone.h +3 -0
@@ -207,6 +207,9 @@ enum node_stat_item {PGPROMOTE_SUCCESS ,/* promote successfully */ PGPROMOTE_CANDIDATE ,/* candidate pages to promote */ #endif +NR_PAGE_METADATA ,/* Page metadata size (struct page and page_ext) +* in pages +*/ NR_VM_NODE_STAT_ITEMS };
include/linux/vmstat.h +4 -0
@@ -656,4 +656,8 @@ static inline void lruvec_stat_sub_folio(struct folio *folio, {lruvec_stat_mod_folio (folio, idx, -folio_nr_pages (folio)); } + +void __init mod_node_early_perpage_metadata (int nid,long delta); +void __init store_early_perpage_metadata (void ); +#endif /* _LINUX_VMSTAT_H */
mm/hugetlb.c +7 -1
@@ -1790,6 +1790,10 @@ static void __update_and_free_hugetlb_folio(struct hstate *h,destroy_compound_gigantic_folio (folio,huge_page_order (h));free_gigantic_folio (folio,huge_page_order (h)); }else { +#ifndef CONFIG_SPARSEMEM_VMEMMAP +__mod_node_page_state (NODE_DATA (page_to_nid (&folio->page)), +NR_PAGE_METADATA , -huge_page_order (h)); +#endif __free_pages (&folio->page,huge_page_order (h)); } }
@@ -2175,7 +2179,9 @@ static struct folio *alloc_buddy_hugetlb_folio(struct hstate *h,__count_vm_event (HTLB_BUDDY_PGALLOC_FAIL );return NULL ; } - +#ifndef CONFIG_SPARSEMEM_VMEMMAP +__mod_node_page_state (NODE_DATA (nid),NR_PAGE_METADATA ,huge_page_order (h)); +#endif __count_vm_event (HTLB_BUDDY_PGALLOC );return page_folio (page); }
mm/hugetlb_vmemmap.c +7 -1
@@ -214,6 +214,8 @@ static inline void free_vmemmap_page(struct page *page)free_bootmem_page (page); else__free_page (page ); +__mod_node_page_state (NODE_DATA (page_to_nid (page)), +NR_PAGE_METADATA ,-1 ); }/* Free a list of the vmemmap pages */
@@ -336,6 +338,7 @@ static int vmemmap_remap_free(unsigned long start, unsigned long end, (void *)walk.reuse_addr);list_add (&walk.reuse_page->lru, &vmemmap_pages); } +__mod_node_page_state (NODE_DATA (nid),NR_PAGE_METADATA ,1 );/* * In order to make remapping routine most efficient for the huge pages,
@@ -384,11 +387,14 @@ static int alloc_vmemmap_page_list(unsigned long start, unsigned long end,unsigned long nr_pages = (end - start) >>PAGE_SHIFT ;int nid =page_to_nid ((struct page *)start);struct page *page, *next; +int i; -while (nr_pages--) { +for (i =0 ; i < nr_pages; i++) { page =alloc_pages_node (nid, gfp_mask,0 );if (!page) goto out; +__mod_node_page_state (NODE_DATA (page_to_nid (page)), +NR_PAGE_METADATA ,1 );list_add_tail (&page->lru, list); }
mm/mm_init.c +3 -0
@@ -26,6 +26,7 @@#include <linux/pgtable.h> #include <linux/swap.h> #include <linux/cma.h> +#include <linux/vmstat.h> #include "internal.h" #include "slab.h" #include "shuffle.h"
@@ -1656,6 +1657,8 @@ static void __init alloc_node_mem_map(struct pglist_data *pgdat)panic ("Failed to allocate %ld bytes for node %d memory map\n" , size, pgdat->node_id); pgdat->node_mem_map = map + offset; +mod_node_early_perpage_metadata (pgdat->node_id, +PAGE_ALIGN (size) >>PAGE_SHIFT ); } pr_debug("%s: node %d, pgdat %08lx, node_mem_map %08lx\n", __func__, pgdat->node_id, (unsigned long)pgdat,
mm/page_alloc.c +1 -0
@@ -5443,6 +5443,7 @@ void __init setup_per_cpu_pageset(void)for_each_online_pgdat (pgdat) pgdat->per_cpu_nodestats = alloc_percpu(struct per_cpu_nodestat); +store_early_perpage_metadata (); }__meminit void zone_pcp_init (struct zone *zone)
mm/page_ext.c +23 -9
@@ -201,6 +201,8 @@ static int __init alloc_node_page_ext(int nid)return -ENOMEM ;NODE_DATA (nid)->node_page_ext = base; total_usage += table_size; +__mod_node_page_state (NODE_DATA (nid),NR_PAGE_METADATA , +PAGE_ALIGN (table_size) >>PAGE_SHIFT );return 0 ; }
@@ -255,12 +257,15 @@ static void *__meminit alloc_page_ext(size_t size, int nid)void *addr =NULL ; addr =alloc_pages_exact_nid (nid, size, flags); -if (addr) { +if (addr)kmemleak_alloc (addr, size,1 , flags); -return addr; - } +else + addr =vzalloc_node (size, nid); - addr =vzalloc_node (size, nid); +if (addr) { +mod_node_page_state (NODE_DATA (nid),NR_PAGE_METADATA , +PAGE_ALIGN (size) >>PAGE_SHIFT ); + }return addr; }
@@ -303,18 +308,27 @@ static int __meminit init_section_page_ext(unsigned long pfn, int nid)static void free_page_ext (void *addr) { +size_t table_size; +struct page *page; +struct pglist_data *pgdat; + + table_size = page_ext_size *PAGES_PER_SECTION ; +if (is_vmalloc_addr (addr)) { + page =vmalloc_to_page (addr); + pgdat =page_pgdat (page);vfree (addr); }else { -struct page *page =virt_to_page (addr); -size_t table_size; - - table_size = page_ext_size *PAGES_PER_SECTION ; - + page =virt_to_page (addr); + pgdat =page_pgdat (page);BUG_ON (PageReserved (page));kmemleak_free (addr);free_pages_exact (addr, table_size); } + +__mod_node_page_state (pgdat,NR_PAGE_METADATA , +-1L * (PAGE_ALIGN (table_size) >>PAGE_SHIFT )); + }static void __free_page_ext (unsigned long pfn)
mm/sparse-vmemmap.c +3 -0
@@ -469,5 +469,8 @@ struct page * __meminit __populate_section_memmap(unsigned long pfn,if (r <0 )return NULL ; +__mod_node_page_state (NODE_DATA (nid),NR_PAGE_METADATA , +PAGE_ALIGN (end - start) >>PAGE_SHIFT ); +return pfn_to_page (pfn); }
mm/sparse.c +6 -1
@@ -14,7 +14,7 @@#include <linux/swap.h> #include <linux/swapops.h> #include <linux/bootmem_info.h> - +#include <linux/vmstat.h> #include "internal.h" #include <asm/dma.h>
@@ -465,6 +465,9 @@ static void __init sparse_buffer_init(unsigned long size, int nid)*/ sparsemap_buf =memmap_alloc (size,section_map_size (), addr, nid, true); sparsemap_buf_end = sparsemap_buf + size; +#ifndef CONFIG_SPARSEMEM_VMEMMAP +mod_node_early_perpage_metadata (nid,PAGE_ALIGN (size) >>PAGE_SHIFT ); +#endif }static void __init sparse_buffer_fini (void )
@@ -641,6 +644,8 @@ static void depopulate_section_memmap(unsigned long pfn, unsigned long nr_pages,unsigned long start = (unsigned long )pfn_to_page (pfn);unsigned long end = start + nr_pages *sizeof (struct page ); +__mod_node_page_state (NODE_DATA (page_to_nid (pfn_to_page (pfn))),NR_PAGE_METADATA , + (long )-1 * (PAGE_ALIGN (end - start) >>PAGE_SHIFT ));vmemmap_free (start, end, altmap); }static void free_map_bootmem (struct page *memmap)
mm/vmstat.c +24 -0
@@ -1245,6 +1245,7 @@ const char * const vmstat_text[] = {"pgpromote_success" ,"pgpromote_candidate" , #endif +"nr_page_metadata" ,/* enum writeback_stat_item counters */ "nr_dirty_threshold",
@@ -2274,4 +2275,27 @@ static int __init extfrag_debug_init(void) }module_init (extfrag_debug_init); +#endif + +/* +* Page metadata size (struct page and page_ext) in pages +*/ +static unsigned long early_perpage_metadata[MAX_NUMNODES ]__initdata ; + +void __init mod_node_early_perpage_metadata (int nid,long delta) +{ + early_perpage_metadata[nid] += delta; +} + +void __init store_early_perpage_metadata (void ) +{ +int nid; +struct pglist_data *pgdat; + +for_each_online_pgdat (pgdat) { + nid = pgdat->node_id; +__mod_node_page_state (NODE_DATA (nid),NR_PAGE_METADATA , + early_perpage_metadata[nid]); + } +}
Signature · 1 line
2.42.0.820.g83a721a137-goog
mm/hugetlb.c static void __update_and_free_hugetlb_folio(struct hstate *h, · line 1796
Quoted 9 lines · Sourav Panda
+++
b/mm/hugetlb.cmm/hugetlb.c +4
-0@@ -1790,6 +1790,10 @@ static void __update_and_free_hugetlb_folio(struct hstate *h,destroy_compound_gigantic_folio (folio,huge_page_order (h));free_gigantic_folio (folio,huge_page_order (h)); }else { +#ifndef CONFIG_SPARSEMEM_VMEMMAP +__mod_node_page_state (NODE_DATA (page_to_nid (&folio->page)), +NR_PAGE_METADATA , -huge_page_order (h)); +#endif
surely,
__node_stat_sub_folio(folio, NR_PAGE_METADATA)
mm/hugetlb.c static struct folio *alloc_buddy_hugetlb_folio(struct hstate *h, · line 2183
Quoted 7 lines
mm/hugetlb.c +2
-1@@ -2175,7 +2179,9 @@ static struct folio *alloc_buddy_hugetlb_folio(struct hstate *h,__count_vm_event (HTLB_BUDDY_PGALLOC_FAIL );return NULL ; } - +#ifndef CONFIG_SPARSEMEM_VMEMMAP +__mod_node_page_state (NODE_DATA (nid),NR_PAGE_METADATA ,huge_page_order (h));
__node_stat_add_folio(folio, NR_PAGE_METADATA)
(create the folio first ...)
mm/hugetlb_vmemmap.c static int alloc_vmemmap_page_list(unsigned long start, unsigned long end, · line 397
Quoted 2 lines
mm/hugetlb_vmemmap.c +2
-0+__mod_node_page_state (NODE_DATA (page_to_nid (page)), +NR_PAGE_METADATA ,1 );
Are you allergic to page_pgdat()?
mm/mm_init.c static void __init alloc_node_mem_map(struct pglist_data *pgdat) · line 1661
Quoted 6 lines
mm/mm_init.c +2
-0@@ -1656,6 +1657,8 @@ static void __init alloc_node_mem_map(struct pglist_data *pgdat)panic ("Failed to allocate %ld bytes for node %d memory map\n" , size, pgdat->node_id); pgdat->node_mem_map = map + offset; +mod_node_early_perpage_metadata (pgdat->node_id, +PAGE_ALIGN (size) >>PAGE_SHIFT );
I swear I said to use DIV_ROUND_UP(). Yes, I did:
https://lore.kernel.org/linux-mm/ZS%[email protected]/
Why have you done something different and claimed I said to do it? You've annoyed me now; I shan't review the rest of this.
Quoted 10 lines · Matthew Wilcox
Review static void
Quoted 2 lines · Sourav Panda
+++
b/mm/hugetlb.c(quoted diff) +0
-0@@ -1790,6 +1790,10 @@ static void__update_and_free_hugetlb_folio(struct hstate *h,
mm/hugetlb.c static void __update_and_free_hugetlb_folio(struct hstate *h,
Quoted 6 lines
mm/hugetlb.c +3
-0destroy_compound_gigantic_folio (folio,huge_page_order (h));free_gigantic_folio (folio,huge_page_order (h)); }else { +#ifndef CONFIG_SPARSEMEM_VMEMMAP + __mod_node_page_state(NODE_DATA(page_to_nid(&folio->page)), + NR_PAGE_METADATA,
Quoted 6 lines
-huge_page_order(h));
Review static void · line 1796
Quoted 1 line
(quoted diff) +1
-0+#endifsurely,
__node_stat_sub_folio(folio, NR_PAGE_METADATA)
Thank you for pointing out this. I will replace this __mod_node_page_state call with __node_stat_sub_folio in v4.
Quoted 11 lines
Review static struct folio
Quoted 2 lines
(quoted diff) +0
-0@@ -2175,7 +2179,9 @@ static struct folio*alloc_buddy_hugetlb_folio(struct hstate *h,
mm/hugetlb.c static struct folio *alloc_buddy_hugetlb_folio(struct hstate *h,
Quoted 6 lines
mm/hugetlb.c +2
-1__count_vm_event (HTLB_BUDDY_PGALLOC_FAIL );return NULL ; } - +#ifndef CONFIG_SPARSEMEM_VMEMMAP + __mod_node_page_state(NODE_DATA(nid), NR_PAGE_METADATA,
huge_page_order(h));
Quoted 2 lines
__node_stat_add_folio(folio, NR_PAGE_METADATA)
I agree with this! I will replace this __mod_node_page_state call with __node_stat_add_folio in v4.
Quoted 8 lines
(create the folio first ...)
mm/hugetlb_vmemmap.c static int alloc_vmemmap_page_list(unsigned long start, unsigned long end, · line 397
Quoted 2 lines
mm/hugetlb_vmemmap.c +2
-0+__mod_node_page_state (NODE_DATA (page_to_nid (page)), +NR_PAGE_METADATA ,1 );Are you allergic to
page_pgdat()?
Sorry, I misinterpreted your previous comment to only apply for that Line of code. My sincere apologies. In v4, i will apply this change to the entire patch.
Quoted 4 lines
Review static void __init alloc_node_mem_map(struct
Quoted 2 lines
(quoted diff) +0
-0@@ -1656,6 +1657,8 @@ static void __init alloc_node_mem_map(struct
pglist_data*pgdat)Review static void __init alloc_node_mem_map(struct · line 1657
Quoted 1 line
(quoted diff) +0
-0panic("Failed to allocate %ld bytes for node %d
Quoted 9 lines
memory map\n",
mm/mm_init.c static void __init alloc_node_mem_map(struct pglist_data *pgdat)
Quoted 4 lines
mm/mm_init.c +2
-0size, pgdat->node_id); pgdat->node_mem_map = map + offset; + mod_node_early_perpage_metadata(pgdat->node_id, + PAGE_ALIGN(size) >>
PAGE_SHIFT);I swear I said to use
DIV_ROUND_UP(). Yes, I did:
Yep, you are correct. I missed it. Still getting used to this UI; My bad! I will be careful next time. In v4 I will apply this change to the entire patch.
Quoted 6 lines
https://lore.kernel.org/linux-mm/ZS%[email protected]/
Why have you done something different and claimed I said to do it? You've annoyed me now; I shan't review the rest of this.
Sorry for the errors. I will make all the requested changes in v4 and send it as soon as possible.