pinctrl: tangier: Enable 910 Ohm bias
PATCH 1/1 pinctrl: tangier: Enable 910 Ohm bias
Family 7 (I2C) supports special bias value, i.e. 910 Ohm.
Enable it for configuring pin.
--- drivers/pinctrl/intel/pinctrl-tangier.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/pinctrl/intel/pinctrl-tangier.c +6 -0
@@ -382,6 +382,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,case 2000 : term =BUFCFG_PUPD_VAL_2K ;break ; +case 910 : + term =BUFCFG_PUPD_VAL_910 ; +break ;default :return -EINVAL ; }
@@ -405,6 +408,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,case 2000 : term =BUFCFG_PUPD_VAL_2K ;break ; +case 910 : + term =BUFCFG_PUPD_VAL_910 ; +break ;default :return -EINVAL ; }
Signature · 1 line
2.40.0.1.gaa8946217a0b
Quoted 24 lines · Andy Shevchenko
Family 7 (I2C) supports special bias value, i.e. 910 Ohm.
Enable it for configuring pin.
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/pinctrl/intel/pinctrl-tangier.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/pinctrl/intel/pinctrl-tangier.c +3
-0@@ -382,6 +382,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,case 2000 : term =BUFCFG_PUPD_VAL_2K ;break ; +case 910 : + term =BUFCFG_PUPD_VAL_910 ; +break ;default :return -EINVAL ; }
drivers/pinctrl/intel/pinctrl-tangier.c static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin, · line 416
Quoted 9 lines
drivers/pinctrl/intel/pinctrl-tangier.c +3
-0@@ -405,6 +408,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,case 2000 : term =BUFCFG_PUPD_VAL_2K ;break ; +case 910 : + term =BUFCFG_PUPD_VAL_910 ; +break ;default :return -EINVAL ; }
Ah, I failed to notice this was already preset in the getter.
Looks good,
Raag
Raag Jadav
Reviewed-byQuoted 37 lines · Raag Jadav
Quoted 24 lines · Andy Shevchenko
Family 7 (I2C) supports special bias value, i.e. 910 Ohm.
Enable it for configuring pin.
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/pinctrl/intel/pinctrl-tangier.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/pinctrl/intel/pinctrl-tangier.c +3
-0@@ -382,6 +382,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,case 2000 : term =BUFCFG_PUPD_VAL_2K ;break ; +case 910 : + term =BUFCFG_PUPD_VAL_910 ; +break ;default :return -EINVAL ; }drivers/pinctrl/intel/pinctrl-tangier.c static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin, · line 416
Quoted 9 lines
drivers/pinctrl/intel/pinctrl-tangier.c +3
-0@@ -405,6 +408,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,case 2000 : term =BUFCFG_PUPD_VAL_2K ;break ; +case 910 : + term =BUFCFG_PUPD_VAL_910 ; +break ;default :return -EINVAL ; }Ah, I failed to notice this was already present in the getter.
Quoted 1 line
Looks good,
Quoted 5 lines · Andy Shevchenko
Family 7 (I2C) supports special bias value, i.e. 910 Ohm.
Enable it for configuring pin.
Signed-off-by Andy Shevchenko <[email protected]>
Quoted 5 lines · Andy Shevchenko
Family 7 (I2C) supports special bias value, i.e. 910 Ohm.
Enable it for configuring pin.
Signed-off-by Andy Shevchenko <[email protected]>
Neat,
Yours,
Linus Walleij
Quoted 11 lines · Linus Walleij
Quoted 5 lines · Andy Shevchenko
Family 7 (I2C) supports special bias value, i.e. 910 Ohm.
Enable it for configuring pin.
Signed-off-by Andy Shevchenko <[email protected]>Neat,
Reviewed-by Linus Walleij <[email protected]>
Pushed to my review and testing queue, thanks!
Signature · 2 lines
With Best Regards, Andy Shevchenko