Skip to contentSkip to conversation

pinctrl: tangier: Enable 910 Ohm bias

PATCH In review Andy Shevchenko 4 participants 6 messages Oct 30, 2023 – Nov 13, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: tangier: Enable 910 Ohm bias

Family 7 (I2C) supports special bias value, i.e. 910 Ohm.

Enable it for configuring pin.

---
 drivers/pinctrl/intel/pinctrl-tangier.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/pinctrl/intel/pinctrl-tangier.c +6 -0
index 40dd60c9e526..007bca1cf224 100644
@@ -382,6 +382,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,
 		case 2000:
 			term = BUFCFG_PUPD_VAL_2K;
 			break;
+		case 910:
+			term = BUFCFG_PUPD_VAL_910;
+			break;
 		default:
 			return -EINVAL;
 		}
@@ -405,6 +408,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,
 		case 2000:
 			term = BUFCFG_PUPD_VAL_2K;
 			break;
+		case 910:
+			term = BUFCFG_PUPD_VAL_910;
+			break;
 		default:
 			return -EINVAL;
 		}
Signature · 1 line
2.40.0.1.gaa8946217a0b
#1 lore raw
Quoted 24 lines · Andy Shevchenko

Family 7 (I2C) supports special bias value, i.e. 910 Ohm.

Enable it for configuring pin.

---
 drivers/pinctrl/intel/pinctrl-tangier.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/pinctrl/intel/pinctrl-tangier.c +3 -0
index 40dd60c9e526..007bca1cf224 100644
@@ -382,6 +382,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,
 		case 2000:
 			term = BUFCFG_PUPD_VAL_2K;
 			break;
+		case 910:
+			term = BUFCFG_PUPD_VAL_910;
+			break;
 		default:
 			return -EINVAL;
 		}

drivers/pinctrl/intel/pinctrl-tangier.c static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin, · line 416

Quoted 9 lines
drivers/pinctrl/intel/pinctrl-tangier.c +3 -0
@@ -405,6 +408,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,
 		case 2000:
 			term = BUFCFG_PUPD_VAL_2K;
 			break;
+		case 910:
+			term = BUFCFG_PUPD_VAL_910;
+			break;
 		default:
 			return -EINVAL;
 		}

Ah, I failed to notice this was already preset in the getter.

Looks good,
Raag

Reviewed-by
#2 lore raw
Quoted 37 lines · Raag Jadav
Quoted 24 lines · Andy Shevchenko

Family 7 (I2C) supports special bias value, i.e. 910 Ohm.

Enable it for configuring pin.

---
 drivers/pinctrl/intel/pinctrl-tangier.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/pinctrl/intel/pinctrl-tangier.c +3 -0
index 40dd60c9e526..007bca1cf224 100644
@@ -382,6 +382,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,
 		case 2000:
 			term = BUFCFG_PUPD_VAL_2K;
 			break;
+		case 910:
+			term = BUFCFG_PUPD_VAL_910;
+			break;
 		default:
 			return -EINVAL;
 		}

drivers/pinctrl/intel/pinctrl-tangier.c static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin, · line 416

Quoted 9 lines
drivers/pinctrl/intel/pinctrl-tangier.c +3 -0
@@ -405,6 +408,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,
 		case 2000:
 			term = BUFCFG_PUPD_VAL_2K;
 			break;
+		case 910:
+			term = BUFCFG_PUPD_VAL_910;
+			break;
 		default:
 			return -EINVAL;
 		}

Ah, I failed to notice this was already present in the getter.

Quoted 1 line

Looks good,