Skip to contentSkip to conversation

Kunit to check the longest symbol length

PATCH Superseded Sergio González Collado 4 participants 7 messages Nov 5, 2023 – Nov 10, 2023

Subsystems (3)
Kselftest Library code Rust

v1 of 9 Superseded Latest is v9 →

lore
Share & tools
lore

Sergio González Collado

author
#0 lore raw

PATCH 1/1 Kunit to check the longest symbol length

The longest length of a symbol (KSYM_NAME_LEN) was increased to 512 in the reference [1]. This patch adds a kunit test to check the longest symbol length.

[1] https://lore.kernel.org/lkml/[email protected]/

Signed-off-by Sergio González Collado <[email protected]>
---
 lib/Kconfig.debug          |   9 +++
 lib/Makefile               |   1 +
 lib/longest_symbol_kunit.c | 120 +++++++++++++++++++++++++++++++++++++
 3 files changed, 130 insertions(+)
 create mode 100644 lib/longest_symbol_kunit.c
lib/Kconfig.debug +9 -0
index fa307f93fa2e..7c0ae4373aa6 100644
@@ -2760,6 +2760,15 @@ config FORTIFY_KUNIT_TEST
 	  by the str*() and mem*() family of functions. For testing runtime
 	  traps of FORTIFY_SOURCE, see LKDTM's "FORTIFY_*" tests.
 
+config LONGEST_SYM_KUNIT_TEST
+	tristate "Test the longest symbol possible" if !KUNIT_ALL_TESTS
+	depends on KUNIT && KPROBES
+	default KUNIT_ALL_TESTS
+	help
+	  Tests the longest symbol possible
+
+	  If unsure, say N.
+
 config HW_BREAKPOINT_KUNIT_TEST
 	bool "Test hw_breakpoint constraints accounting" if !KUNIT_ALL_TESTS
 	depends on HAVE_HW_BREAKPOINT
lib/Makefile +1 -0
index 740109b6e2c8..82ac084b6bc6 100644
@@ -402,6 +402,7 @@ obj-$(CONFIG_FORTIFY_KUNIT_TEST) += fortify_kunit.o
 obj-$(CONFIG_STRCAT_KUNIT_TEST) += strcat_kunit.o
 obj-$(CONFIG_STRSCPY_KUNIT_TEST) += strscpy_kunit.o
 obj-$(CONFIG_SIPHASH_KUNIT_TEST) += siphash_kunit.o
+obj-$(CONFIG_LONGEST_SYM_KUNIT_TEST) += longest_symbol_kunit.o
 
 obj-$(CONFIG_GENERIC_LIB_DEVMEM_IS_ALLOWED) += devmem_is_allowed.o
lib/longest_symbol_kunit.c new file +120 -0

120 lines not on this page · raw message

Signature · 1 line
2.39.2
#2 lore raw
In reply to Sergio González Collado
Quoted 6 lines · Sergio González Collado

The longest length of a symbol (KSYM_NAME_LEN) was increased to 512 in the reference [1]. This patch adds a kunit test to check the longest symbol length.

[1] https://lore.kernel.org/lkml/[email protected]/

Quoted 7 lines
Signed-off-by Sergio González Collado <[email protected]>
---
  lib/Kconfig.debug          |   9 +++
  lib/Makefile               |   1 +
  lib/longest_symbol_kunit.c | 120 +++++++++++++++++++++++++++++++++++++
  3 files changed, 130 insertions(+)

create mode 100644 lib/longest_symbol_kunit.c

I am a bit confused why this is *only* sent to the rust-for-linux list. Especially since there is no rust code and the changes do not change anything that Rust code uses.

Shouldn't this go to linux-kernel list and the maintainers of lib/Makefile instead?

Signature · 2 lines
Cheers,
Benno
#3 lore raw
Quoted 15 lines · Benno Lossin
Quoted 6 lines · Sergio González Collado

The longest length of a symbol (KSYM_NAME_LEN) was increased to 512 in the reference [1]. This patch adds a kunit test to check the longest symbol length.

[1] https://lore.kernel.org/lkml/[email protected]/

Quoted 7 lines
Signed-off-by Sergio González Collado <[email protected]>
---
   lib/Kconfig.debug          |   9 +++
   lib/Makefile               |   1 +
   lib/longest_symbol_kunit.c | 120 +++++++++++++++++++++++++++++++++++++
   3 files changed, 130 insertions(+)

create mode 100644 lib/longest_symbol_kunit.c

Quoted 6 lines

I am a bit confused why this is *only* sent to the rust-for-linux list. Especially since there is no rust code and the changes do not change anything that Rust code uses.

Shouldn't this go to linux-kernel list and the maintainers of lib/Makefile instead?

Seems I missed the "To: linux-kself" and others, sorry for the noise.

Signature · 2 lines
Cheers,
Benno
build bot
#4 lore raw
In reply to Sergio González Collado
kernel test robot noticed the following build errors:

Hi Sergio,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.6 next-20231106]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sergio-Gonz-lez-Collado/Kunit-to-check-the-longest-symbol-length/20231106-024653
base:   linus/master
patch link:    https://lore.kernel.org/r/20231105184010.49194-1-sergio.collado%40gmail.com
patch subject: [PATCH] Kunit to check the longest symbol length
config: i386-randconfig-014-20231106 (https://download.01.org/0day-ci/archive/20231107/[email protected]/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231107/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

>> arch/x86/tools/insn_decoder_test: error: malformed line 1810458:

7nnnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
build bot
#5 lore raw
In reply to Sergio González Collado
kernel test robot noticed the following build warnings:

Hi Sergio,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.6 next-20231107]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sergio-Gonz-lez-Collado/Kunit-to-check-the-longest-symbol-length/20231106-024653
base:   linus/master
patch link:    https://lore.kernel.org/r/20231105184010.49194-1-sergio.collado%40gmail.com
patch subject: [PATCH] Kunit to check the longest symbol length
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20231108/[email protected]/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231108/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

>> lib/longest_symbol_kunit.c:16:18: warning: no previous prototype for 'snnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7n' [-Wmissing-prototypes]
      16 | #define DI(name) s##name##name
         |                  ^
   lib/longest_symbol_kunit.c:17:19: note: in expansion of macro 'DI'
      17 | #define DDI(name) DI(n##name##name)
         |                   ^~
   lib/longest_symbol_kunit.c:18:20: note: in expansion of macro 'DDI'
      18 | #define DDDI(name) DDI(n##name##name)
         |                    ^~~
   lib/longest_symbol_kunit.c:19:21: note: in expansion of macro 'DDDI'
      19 | #define DDDDI(name) DDDI(n##name##name)
         |                     ^~~~
   lib/longest_symbol_kunit.c:20:22: note: in expansion of macro 'DDDDI'
      20 | #define DDDDDI(name) DDDDI(n##name##name)
         |                      ^~~~~
   lib/longest_symbol_kunit.c:25:27: note: in expansion of macro 'DDDDDI'
      25 | #define LONGEST_SYM_NAME  DDDDDI(g1h2i3j4k5l6m7n)
         |                           ^~~~~~
   lib/longest_symbol_kunit.c:33:14: note: in expansion of macro 'LONGEST_SYM_NAME'
      33 | noinline int LONGEST_SYM_NAME(void)
         |              ^~~~~~~~~~~~~~~~
   In file included from <command-line>:
   lib/longest_symbol_kunit.c:16:18: warning: no previous prototype for 'snnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7ne' [-Wmissing-prototypes]
      16 | #define DI(name) s##name##name
         |                  ^
   include/linux/compiler_types.h:83:23: note: in definition of macro '___PASTE'
      83 | #define ___PASTE(a,b) a##b
         |                       ^
   lib/longest_symbol_kunit.c:22:21: note: in expansion of macro '__PASTE'
      22 | #define PLUS1(name) __PASTE(name, e)
         |                     ^~~~~~~
   lib/longest_symbol_kunit.c:28:32: note: in expansion of macro 'PLUS1'
      28 | #define LONGEST_SYM_NAME_PLUS1 PLUS1(LONGEST_SYM_NAME)
         |                                ^~~~~
   lib/longest_symbol_kunit.c:17:19: note: in expansion of macro 'DI'
      17 | #define DDI(name) DI(n##name##name)
         |                   ^~
   lib/longest_symbol_kunit.c:18:20: note: in expansion of macro 'DDI'
      18 | #define DDDI(name) DDI(n##name##name)
         |                    ^~~
   lib/longest_symbol_kunit.c:19:21: note: in expansion of macro 'DDDI'
      19 | #define DDDDI(name) DDDI(n##name##name)
         |                     ^~~~
   lib/longest_symbol_kunit.c:20:22: note: in expansion of macro 'DDDDI'
      20 | #define DDDDDI(name) DDDDI(n##name##name)
         |                      ^~~~~
   lib/longest_symbol_kunit.c:25:27: note: in expansion of macro 'DDDDDI'
      25 | #define LONGEST_SYM_NAME  DDDDDI(g1h2i3j4k5l6m7n)
         |                           ^~~~~~

lib/longest_symbol_kunit.c:28:38: note: in expansion of macro 'LONGEST_SYM_NAME'
28 | #define LONGEST_SYM_NAME_PLUS1 PLUS1(LONGEST_SYM_NAME)
| ^~~~~~~~~~~~~~~~
lib/longest_symbol_kunit.c:38:14: note: in expansion of macro 'LONGEST_SYM_NAME_PLUS1'
38 | noinline int LONGEST_SYM_NAME_PLUS1(void)
| ^~~~~~~~~~~~~~~~~~~~~~

vim +/snnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7n +16 lib/longest_symbol_kunit.c

    15	
  > 16	#define DI(name) s##name##name
    17	#define DDI(name) DI(n##name##name)
    18	#define DDDI(name) DDI(n##name##name)
    19	#define DDDDI(name) DDDI(n##name##name)
    20	#define DDDDDI(name) DDDDI(n##name##name)
    21
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#6 lore raw
In reply to Sergio González Collado

lib/Makefile obj-$(CONFIG_FORTIFY_KUNIT_TEST) += fortify_kunit.o · line 408

Quoted 13 lines · Sergio González Collado

[...]

lib/Makefile +1 -0
index 740109b6e2c8..82ac084b6bc6 100644
@@ -402,6 +402,7 @@ obj-$(CONFIG_FORTIFY_KUNIT_TEST) += fortify_kunit.o
  obj-$(CONFIG_STRCAT_KUNIT_TEST) += strcat_kunit.o
  obj-$(CONFIG_STRSCPY_KUNIT_TEST) += strscpy_kunit.o
  obj-$(CONFIG_SIPHASH_KUNIT_TEST) += siphash_kunit.o
+obj-$(CONFIG_LONGEST_SYM_KUNIT_TEST) += longest_symbol_kunit.o
 
  obj-$(CONFIG_GENERIC_LIB_DEVMEM_IS_ALLOWED) += devmem_is_allowed.o

This test is triggering -Wmissing-prototypes, so you might have to either add the prototypes or change the hunk to this.

lib/Makefile +2 -0
index 740109b6e2c8..b9d2577fbbe1 100644
@@ -402,6 +402,8 @@ obj-$(CONFIG_FORTIFY_KUNIT_TEST) += fortify_kunit.o
 obj-$(CONFIG_STRCAT_KUNIT_TEST) += strcat_kunit.o
 obj-$(CONFIG_STRSCPY_KUNIT_TEST) += strscpy_kunit.o
 obj-$(CONFIG_SIPHASH_KUNIT_TEST) += siphash_kunit.o
+obj-$(CONFIG_LONGEST_SYM_KUNIT_TEST) += longest_symbol_kunit.o
+CFLAGS_longest_symbol_kunit.o += $(call cc-disable-warning, missing-prototypes)
 
 obj-$(CONFIG_GENERIC_LIB_DEVMEM_IS_ALLOWED) += devmem_is_allowed.o
Quoted 6 lines
lib/longest_symbol_kunit.c new file +0 -0
new file mode 100644
index 000000000000..6282fbb7e991
[...]

lib/longest_symbol_kunit.c

Quoted 10 lines
lib/longest_symbol_kunit.c new file +10 -0
+
+noinline int LONGEST_SYM_NAME(void)
+{
+	return RETURN_LONGEST_SYM;
+}
+
+noinline int LONGEST_SYM_NAME_PLUS1(void)
+{
+	return RETURN_LONGEST_SYM_PLUS1;
+}

arch/x86/tools/insn_decoder_test.c has a buffer size of 256 that might be too short for these symbols, you might have to increase it for it to work.

Quoted 1 line

[...]