Skip to contentSkip to conversation

Use V4L2 CCI in CCS driver

PATCH Superseded Sakari Ailus 2 participants 15 messages Nov 13, 2023

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Sakari Ailus

author maintainer
#0 lore raw

v2 cover Use V4L2 CCI in CCS driver

Hi folks,

This set adds a few features to the V4L2 CCI library and makes the CCS driver use V4L2 CCI.

The additional features are about storing driver specific information in the CCI registers (besides register address) and obtaining register width using a convenient V4L2 CCI macro.

since v1:

- Fix two SMIAPP register definitions using misspelled CCI macro names.

- Add macros using FIELD_GET() to obtain CCI register address and width, use the macros in V4L2 CCI.

- Use _SHIFT and _MASK for private register range.

- Check CCS driver's private flags only cover driver-private bits of the CCI register definition, using BUILD_BUG_ON().

- Fix CCS CCI register macro generation (register address vs. flag vs. array indices).

- Use a nicer way to check for the guardian value in the limit array, i.e. don't pass the value unconditionally to CCI_REG_WIDTH_BYTES().

- Include linux/bits.h and media/v4l2-cci.h in smiapp-reg-defs.h.

- Improve commit message of the CCS static data register access function rename patch.

Sakari Ailus (6):
media: v4l: cci: Include linux/bits.h
media: v4l: cci: Add driver-private bit definitions
media: v4l: cci: Add macros to obtain register width and address
media: ccs: Generate V4L2 CCI compliant register definitions
media: ccs: Better separate CCS static data access
media: ccs: Use V4L2 CCI for accessing sensor registers

 .../driver-api/media/drivers/ccs/mk-ccs-regs  | 104 +-
 drivers/media/i2c/ccs/ccs-core.c              |  84 +-
 drivers/media/i2c/ccs/ccs-reg-access.c        | 212 +---
 drivers/media/i2c/ccs/ccs-regs.h              | 906 ++++++++---------
 drivers/media/i2c/ccs/ccs.h                   |   2 +
 drivers/media/i2c/ccs/smiapp-reg-defs.h       | 951 +++++++++---------
 drivers/media/v4l2-core/v4l2-cci.c            |   8 +-
 include/media/v4l2-cci.h                      |  11 +
 8 files changed, 1099 insertions(+), 1179 deletions(-)

base-commit: 62bdf633090d684c3ac6d3b46e926c0ac8cef466

Signature · 1 line
2.39.2
author maintainer
#1 lore raw

PATCH v2 1/6 media: v4l: cci: Include linux/bits.h

linux/bits.h is needed for GENMASK(). Include it.

---
 include/media/v4l2-cci.h | 1 +
 1 file changed, 1 insertion(+)
include/media/v4l2-cci.h +1 -0
index 0f6803e4b17e..f2c2962e936b 100644
@@ -7,6 +7,7 @@
 #ifndef _V4L2_CCI_H
 #define _V4L2_CCI_H
 
+#include <linux/bits.h>
 #include <linux/types.h>
 
 struct i2c_client;
Signature · 1 line
2.39.2
author maintainer
#2 lore raw

PATCH v2 2/6 media: v4l: cci: Add driver-private bit definitions

In reply to Sakari Ailus

Provide a few bits for drivers to store private information on register definitions.

---
 include/media/v4l2-cci.h | 5 +++++
 1 file changed, 5 insertions(+)
include/media/v4l2-cci.h +5 -0
index f2c2962e936b..ee469f03e440 100644
@@ -33,6 +33,11 @@ struct cci_reg_sequence {
 #define CCI_REG_ADDR_MASK		GENMASK(15, 0)
 #define CCI_REG_WIDTH_SHIFT		16
 #define CCI_REG_WIDTH_MASK		GENMASK(19, 16)
+/*
+ * Private CCI register flags, for the use of drivers.
+ */
+#define CCI_REG_PRIVATE_SHIFT		28U
+#define CCI_REG_PRIVATE_MASK		GENMASK(31U, CCI_REG_PRIVATE_SHIFT)
 
 #define CCI_REG8(x)			((1 << CCI_REG_WIDTH_SHIFT) | (x))
 #define CCI_REG16(x)			((2 << CCI_REG_WIDTH_SHIFT) | (x))
Signature · 1 line
2.39.2
Reviewed-by on v2 2/6
#3 lore raw

Re: [PATCH v2 2/6] media: v4l: cci: Add driver-private bit definitions

Quoted 14 lines · Sakari Ailus

Provide a few bits for drivers to store private information on register definitions.

---
 include/media/v4l2-cci.h | 5 +++++
 1 file changed, 5 insertions(+)
include/media/v4l2-cci.h +0 -0
index f2c2962e936b..ee469f03e440 100644

include/media/v4l2-cci.h struct cci_reg_sequence { · line 35

Quoted 3 lines
include/media/v4l2-cci.h +0 -0
@@ -33,6 +33,11 @@ struct cci_reg_sequence {
 #define CCI_REG_ADDR_MASK		GENMASK(15, 0)
 #define CCI_REG_WIDTH_SHIFT		16
 #define CCI_REG_WIDTH_MASK		GENMASK(19, 16)

Should these be unsigned too for consistency ?

include/media/v4l2-cci.h struct cci_reg_sequence { · line 40

Quoted 5 lines
include/media/v4l2-cci.h +5 -0
+/*
+ * Private CCI register flags, for the use of drivers.
+ */
+#define CCI_REG_PRIVATE_SHIFT		28U
+#define CCI_REG_PRIVATE_MASK		GENMASK(31U, CCI_REG_PRIVATE_SHIFT)
Quoted 3 lines
include/media/v4l2-cci.h +0 -0
 #define CCI_REG8(x)			((1 << CCI_REG_WIDTH_SHIFT) | (x))
 #define CCI_REG16(x)			((2 << CCI_REG_WIDTH_SHIFT) | (x))
Signature · 3 lines
Regards,

Laurent Pinchart
#4 lore raw

Re: [PATCH v2 2/6] media: v4l: cci: Add driver-private bit definitions

Quoted 21 lines · Laurent Pinchart
Quoted 14 lines · Sakari Ailus

Provide a few bits for drivers to store private information on register definitions.

---
 include/media/v4l2-cci.h | 5 +++++
 1 file changed, 5 insertions(+)
include/media/v4l2-cci.h +0 -0
index f2c2962e936b..ee469f03e440 100644

include/media/v4l2-cci.h struct cci_reg_sequence { · line 35

Quoted 3 lines
include/media/v4l2-cci.h +0 -0
@@ -33,6 +33,11 @@ struct cci_reg_sequence {
 #define CCI_REG_ADDR_MASK		GENMASK(15, 0)
 #define CCI_REG_WIDTH_SHIFT		16
 #define CCI_REG_WIDTH_MASK		GENMASK(19, 16)

Should these be unsigned too for consistency ?

Quoted 5 lines

include/media/v4l2-cci.h struct cci_reg_sequence { · line 40

Quoted 5 lines
include/media/v4l2-cci.h +5 -0
+/*
+ * Private CCI register flags, for the use of drivers.
+ */
+#define CCI_REG_PRIVATE_SHIFT		28U
+#define CCI_REG_PRIVATE_MASK		GENMASK(31U, CCI_REG_PRIVATE_SHIFT)

And actually, for consistency again, I would write

#define CCI_REG_PRIVATE_MASK GENMASK(31U, 28U)

Quoted 4 lines
Quoted 2 lines
include/media/v4l2-cci.h +0 -0
 #define CCI_REG8(x)			((1 << CCI_REG_WIDTH_SHIFT) | (x))
 #define CCI_REG16(x)			((2 << CCI_REG_WIDTH_SHIFT) | (x))
Signature · 3 lines
Regards,

Laurent Pinchart
author maintainer
#5 lore raw

Re: [PATCH v2 2/6] media: v4l: cci: Add driver-private bit definitions

Hi Laurent,

Quoted 30 lines · Laurent Pinchart
Quoted 21 lines · Laurent Pinchart
Quoted 14 lines · Sakari Ailus

Provide a few bits for drivers to store private information on register definitions.

---
 include/media/v4l2-cci.h | 5 +++++
 1 file changed, 5 insertions(+)
include/media/v4l2-cci.h +0 -0
index f2c2962e936b..ee469f03e440 100644

include/media/v4l2-cci.h struct cci_reg_sequence { · line 35

Quoted 3 lines
include/media/v4l2-cci.h +0 -0
@@ -33,6 +33,11 @@ struct cci_reg_sequence {
 #define CCI_REG_ADDR_MASK		GENMASK(15, 0)
 #define CCI_REG_WIDTH_SHIFT		16
 #define CCI_REG_WIDTH_MASK		GENMASK(19, 16)

Should these be unsigned too for consistency ?

Quoted 5 lines

include/media/v4l2-cci.h struct cci_reg_sequence { · line 40

Quoted 5 lines
include/media/v4l2-cci.h +5 -0
+/*
+ * Private CCI register flags, for the use of drivers.
+ */
+#define CCI_REG_PRIVATE_SHIFT		28U
+#define CCI_REG_PRIVATE_MASK		GENMASK(31U, CCI_REG_PRIVATE_SHIFT)

And actually, for consistency again, I would write

Quoted 1 line

#define CCI_REG_PRIVATE_MASK GENMASK(31U, 28U)

I would prefer to use the macro instead.

I can post a patch doing that for the older definitions, too.

It's not urgent though. I'll wait for the endianness patches to get merged.

Signature · 3 lines
Regards,

Sakari Ailus
author maintainer
#6 lore raw

Re: [PATCH v2 2/6] media: v4l: cci: Add driver-private bit definitions

In reply to Laurent Pinchart

Hi Laurent,

Quoted 10 lines · Laurent Pinchart
Quoted 9 lines · Sakari Ailus

Provide a few bits for drivers to store private information on register definitions.

---
 include/media/v4l2-cci.h | 5 +++++
 1 file changed, 5 insertions(+)
Quoted 10 lines

include/media/v4l2-cci.h struct cci_reg_sequence { · line 35

Quoted 8 lines
include/media/v4l2-cci.h +0 -0
index f2c2962e936b..ee469f03e440 100644
@@ -33,6 +33,11 @@ struct cci_reg_sequence {
 #define CCI_REG_ADDR_MASK		GENMASK(15, 0)
 #define CCI_REG_WIDTH_SHIFT		16
 #define CCI_REG_WIDTH_MASK		GENMASK(19, 16)

Should these be unsigned too for consistency ?

I recall someone else was working on a related patch so I decided to wait.

But yes, I agree.

Quoted 8 lines

include/media/v4l2-cci.h struct cci_reg_sequence { · line 40

Quoted 6 lines
include/media/v4l2-cci.h +5 -0
+/*
+ * Private CCI register flags, for the use of drivers.
+ */
+#define CCI_REG_PRIVATE_SHIFT		28U
+#define CCI_REG_PRIVATE_MASK		GENMASK(31U, CCI_REG_PRIVATE_SHIFT)

Thanks!

Quoted 5 lines
Quoted 4 lines
include/media/v4l2-cci.h +0 -0
 #define CCI_REG8(x)			((1 << CCI_REG_WIDTH_SHIFT) | (x))
 #define CCI_REG16(x)			((2 << CCI_REG_WIDTH_SHIFT) | (x))
Signature · 3 lines
Regards,

Sakari Ailus
author maintainer
#7 lore raw

PATCH v2 3/6 media: v4l: cci: Add macros to obtain register width and address

In reply to Sakari Ailus

Add CCI_REG_WIDTH() macro to obtain register width in bits and similarly, CCI_REG_WIDTH_BYTES() to obtain it in bytes.

Also add CCI_REG_ADDR() macro to obtain the address of a register.

Use both macros in v4l2-cci.c, too.

---
 drivers/media/v4l2-core/v4l2-cci.c | 8 ++++----
 include/media/v4l2-cci.h           | 9 +++++++--
 2 files changed, 11 insertions(+), 6 deletions(-)
drivers/media/v4l2-core/v4l2-cci.c +4 -4
index bc2dbec019b0..3179160abde3 100644
@@ -25,8 +25,8 @@ int cci_read(struct regmap *map, u32 reg, u64 *val, int *err)
 	if (err && *err)
 		return *err;
 
-	len = FIELD_GET(CCI_REG_WIDTH_MASK, reg);
-	reg = FIELD_GET(CCI_REG_ADDR_MASK, reg);
+	len = CCI_REG_WIDTH_BYTES(reg);
+	reg = CCI_REG_ADDR(reg);
 
 	ret = regmap_bulk_read(map, reg, buf, len);
 	if (ret) {
@@ -75,8 +75,8 @@ int cci_write(struct regmap *map, u32 reg, u64 val, int *err)
 	if (err && *err)
 		return *err;
 
-	len = FIELD_GET(CCI_REG_WIDTH_MASK, reg);
-	reg = FIELD_GET(CCI_REG_ADDR_MASK, reg);
+	len = CCI_REG_WIDTH_BYTES(reg);
+	reg = CCI_REG_ADDR(reg);
 
 	switch (len) {
 	case 1:
include/media/v4l2-cci.h +7 -2
index ee469f03e440..50df3aa4af1d 100644
@@ -7,6 +7,7 @@
 #ifndef _V4L2_CCI_H
 #define _V4L2_CCI_H
 
+#include <linux/bitfield.h>
 #include <linux/bits.h>
 #include <linux/types.h>
 
@@ -36,8 +37,12 @@ struct cci_reg_sequence {
 /*
  * Private CCI register flags, for the use of drivers.
  */
-#define CCI_REG_PRIVATE_SHIFT		28U
-#define CCI_REG_PRIVATE_MASK		GENMASK(31U, CCI_REG_PRIVATE_SHIFT)
+#define CCI_REG_PRIVATE_SHIFT		28
+#define CCI_REG_PRIVATE_MASK		GENMASK(31, CCI_REG_PRIVATE_SHIFT)
+
+#define CCI_REG_WIDTH_BYTES(x)		FIELD_GET(CCI_REG_WIDTH_MASK, x)
+#define CCI_REG_WIDTH(x)		(CCI_REG_WIDTH_BYTES(x) << 3)
+#define CCI_REG_ADDR(x)			FIELD_GET(CCI_REG_ADDR_MASK, x)
 
 #define CCI_REG8(x)			((1 << CCI_REG_WIDTH_SHIFT) | (x))
 #define CCI_REG16(x)			((2 << CCI_REG_WIDTH_SHIFT) | (x))
Signature · 1 line
2.39.2
author maintainer
#8 lore raw

PATCH v2 4/6 media: ccs: Generate V4L2 CCI compliant register definitions

In reply to Sakari Ailus

Generate register definitions that are fit for use with V4L2 CCI.

---
 .../driver-api/media/drivers/ccs/mk-ccs-regs  | 104 +++++++++++++-----
 1 file changed, 75 insertions(+), 29 deletions(-)
Documentation/driver-api/media/drivers/ccs/mk-ccs-regs +75 -29
index 2a4edc7e051a..01252ee6062b 100755
@@ -82,14 +82,6 @@ for my $fh ($H, $LH) {
 	print $fh "/* $license */\n$copyright$note\n";
 }
 
-sub bit_def($) {
-	my $bit = shift @_;
-
-	return "BIT($bit)" if defined $kernel;
-	return "(1U << $bit)" if $bit =~ /^[a-zA-Z0-9_]+$/;
-	return "(1U << ($bit))";
-}
-
 print $H <<EOF
 #ifndef __${uc_header}__
 #define __${uc_header}__
@@ -97,23 +89,63 @@ print $H <<EOF
 EOF
   ;
 
-print $H "#include <linux/bits.h>\n\n" if defined $kernel;
-
 print $H <<EOF
-#define CCS_FL_BASE		16
+#include <linux/bits.h>
+
+#include <media/v4l2-cci.h>
+
 EOF
-  ;
+	if defined $kernel;
+
+print $H "#define CCS_FL_BASE		" .
+    (defined $kernel ? "CCI_REG_PRIVATE_SHIFT" : 16) . "\n";
+
+my $flag = -1;
+my $all_flags;
+
+sub bit_def($) {
+	my $bit = shift @_;
+
+	if (defined $kernel) {
+		return "BIT$bit" if $bit =~ /^\(.*\)$/;
+		return "BIT($bit)";
+	}
+	return "(1U << $bit)";
+}
+
+sub flag_str($$) {
+	my ($flag, $check) = @_;
 
-print $H "#define CCS_FL_16BIT		" . bit_def("CCS_FL_BASE") . "\n";
-print $H "#define CCS_FL_32BIT		" . bit_def("CCS_FL_BASE + 1") . "\n";
-print $H "#define CCS_FL_FLOAT_IREAL	" . bit_def("CCS_FL_BASE + 2") . "\n";
-print $H "#define CCS_FL_IREAL		" . bit_def("CCS_FL_BASE + 3") . "\n";
+	$$flag++;
+
+	my $flag_str = !$$flag ? "CCS_FL_BASE" : "(CCS_FL_BASE + $$flag)";
+
+	$flag_str = bit_def($flag_str);
+
+	$$check .= " | " if defined $$check;
+
+	$$check .= $flag_str;
+
+	return $flag_str;
+}
+
+if (! defined $kernel) {
+	print $H "#define CCS_FL_16BIT		" . flag_str(\$flag, \$all_flags) . "\n";
+	print $H "#define CCS_FL_32BIT		" . flag_str(\$flag, \$all_flags) . "\n";
+}
+
+print $H "#define CCS_FL_FLOAT_IREAL	" . flag_str(\$flag, \$all_flags) . "\n";
+print $H "#define CCS_FL_IREAL		" . flag_str(\$flag, \$all_flags) . "\n";
+print $H "#define CCS_BUILD_BUG \
+	BUILD_BUG_ON(~CCI_REG_PRIVATE_MASK & ($all_flags))\n"
+    if defined $kernel;
 
 print $H <<EOF
+
 #define CCS_R_ADDR(r)		((r) & 0xffff)
 
 EOF
-  ;
+    if ! defined $kernel;
 
 print $A <<EOF
 #include <stdint.h>
@@ -189,12 +221,12 @@ sub tabconv($) {
 	return (join "\n", @l) . "\n";
 }
 
-sub elem_size(@) {
+sub elem_bits(@) {
 	my @flags = @_;
 
-	return 2 if grep /^16$/, @flags;
-	return 4 if grep /^32$/, @flags;
-	return 1;
+	return 16 if grep /^16$/, @flags;
+	return 32 if grep /^32$/, @flags;
+	return 8;
 }
 
 sub arr_size($) {
@@ -296,9 +328,13 @@ while (<$R>) {
 
 			next if $#{$this{args}} + 1 != scalar keys %{$this{argparams}};
 
-			my $reg_formula = "($this{addr}";
+			my $reg_formula = "$this{addr}";
 			my $lim_formula;
 
+			chop $reg_formula;
+
+			$reg_formula = "(" . $reg_formula if $this{flagstring} ne "";
+
 			foreach my $arg (@{$this{args}}) {
 				my $d = $h->{$arg}->{discontig};
 				my $times = $h->{$arg}->{elsize} != 1 ?
@@ -315,11 +351,13 @@ while (<$R>) {
 				$lim_formula .= (defined $lim_formula ? " + " : "") . "($arg)$times";
 			}
 
-			$reg_formula .= ")\n";
+			$reg_formula .= ")";
 			$lim_formula =~ s/^\(([a-z0-9]+)\)$/$1/i;
 
 			print $H tabconv sprintf("#define %-62s %s", "CCS_R_" . (uc $this{name}) .
-			  $this{arglist}, $reg_formula);
+						 $this{arglist}, $reg_formula .
+						 (($this{flagstring} eq "") ? "" :
+						  " | " . $this{flagstring} . ")") . "\n");
 
 			print $H tabconv $hdr_data;
 			undef $hdr_data;
@@ -369,16 +407,23 @@ while (<$R>) {
 	$name =~ s/[,\.-]/_/g;
 
 	my $flagstring = "";
-	my $size = elem_size(@flags);
-	$flagstring .= "| CCS_FL_16BIT " if $size eq "2";
-	$flagstring .= "| CCS_FL_32BIT " if $size eq "4";
+	my $bits = elem_bits(@flags);
+	if (! defined $kernel) {
+		$flagstring .= "| CCS_FL_16BIT " if $bits == 16;
+		$flagstring .= "| CCS_FL_32BIT " if $bits == 32;
+	}
 	$flagstring .= "| CCS_FL_FLOAT_IREAL " if grep /^float_ireal$/, @flags;
 	$flagstring .= "| CCS_FL_IREAL " if grep /^ireal$/, @flags;
 	$flagstring =~ s/^\| //;
 	$flagstring =~ s/ $//;
 	$flagstring = "($flagstring)" if $flagstring =~ /\|/;
 	my $base_addr = $addr;
-	$addr = "($addr | $flagstring)" if $flagstring ne "";
+	$addr = "CCI_REG$bits($addr)" if defined $kernel;
+
+	if ($flagstring ne "" && !@$args) {
+		$addr = "($addr | $flagstring)";
+		$flagstring = "";
+	}
 
 	my $arglist = @$args ? "(" . (join ", ", @$args) . ")" : "";
 	$hdr_data .= sprintf "#define %-62s %s\n", "CCS_R_" . (uc $name), $addr
@@ -388,11 +433,12 @@ while (<$R>) {
 
 	%this = ( name => $name,
 		  addr => $addr,
+		  flagstring => $flagstring,
 		  base_addr => $base_addr,
 		  argparams => {},
 		  args => $args,
 		  arglist => $arglist,
-		  elsize => $size,
+		  elsize => $bits / 8,
 		);
 
 	if (!@$args) {
Signature · 1 line
2.39.2
author maintainer
#9 lore raw

PATCH v2 5/6 media: ccs: Better separate CCS static data access

In reply to Sakari Ailus

Separate CCS static data read-only register access in ccs-reg-access.c by naming them differently.

The code in this file generally deals with reading and writing registers where as static data (when it comes to ccs_static_read_only()) contains the read-only register values but no hardware registers are accessed in that case.

---
 .../driver-api/media/drivers/ccs/mk-ccs-regs  |  2 +-
 drivers/media/i2c/ccs/ccs-reg-access.c        | 20 +++++++++----------
 2 files changed, 11 insertions(+), 11 deletions(-)
Documentation/driver-api/media/drivers/ccs/mk-ccs-regs +1 -1
index 01252ee6062b..3d3152b45821 100755
@@ -136,7 +136,7 @@ if (! defined $kernel) {
 
 print $H "#define CCS_FL_FLOAT_IREAL	" . flag_str(\$flag, \$all_flags) . "\n";
 print $H "#define CCS_FL_IREAL		" . flag_str(\$flag, \$all_flags) . "\n";
-print $H "#define CCS_BUILD_BUG \
+print $H "#define CCS_BUILD_BUG \\
 	BUILD_BUG_ON(~CCI_REG_PRIVATE_MASK & ($all_flags))\n"
     if defined $kernel;
 
drivers/media/i2c/ccs/ccs-reg-access.c +10 -10
index 25993445f4fe..652d705a2ef5 100644
@@ -197,8 +197,8 @@ static int __ccs_read_addr(struct ccs_sensor *sensor, u32 reg, u32 *val,
 	return 0;
 }
 
-static int __ccs_read_data(struct ccs_reg *regs, size_t num_regs,
-			   u32 reg, u32 *val)
+static int __ccs_static_read_only(struct ccs_reg *regs, size_t num_regs,
+				  u32 reg, u32 *val)
 {
 	unsigned int width = ccs_reg_width(reg);
 	size_t i;
@@ -235,16 +235,16 @@ static int __ccs_read_data(struct ccs_reg *regs, size_t num_regs,
 	return -ENOENT;
 }
 
-static int ccs_read_data(struct ccs_sensor *sensor, u32 reg, u32 *val)
+static int ccs_static_read_only(struct ccs_sensor *sensor, u32 reg, u32 *val)
 {
-	if (!__ccs_read_data(sensor->sdata.sensor_read_only_regs,
-			     sensor->sdata.num_sensor_read_only_regs,
-			     reg, val))
+	if (!__ccs_static_read_only(sensor->sdata.sensor_read_only_regs,
+				    sensor->sdata.num_sensor_read_only_regs,
+				    reg, val))
 		return 0;
 
-	return __ccs_read_data(sensor->mdata.module_read_only_regs,
-			       sensor->mdata.num_module_read_only_regs,
-			       reg, val);
+	return __ccs_static_read_only(sensor->mdata.module_read_only_regs,
+				      sensor->mdata.num_module_read_only_regs,
+				      reg, val);
 }
 
 static int ccs_read_addr_raw(struct ccs_sensor *sensor, u32 reg, u32 *val,
@@ -253,7 +253,7 @@ static int ccs_read_addr_raw(struct ccs_sensor *sensor, u32 reg, u32 *val,
 	int rval;
 
 	if (data) {
-		rval = ccs_read_data(sensor, reg, val);
+		rval = ccs_static_read_only(sensor, reg, val);
 		if (!rval)
 			return 0;
 	}
Signature · 1 line
2.39.2
#10 lore raw

Re: [PATCH v2 5/6] media: ccs: Better separate CCS static data access

Hi Sakari,

Thank you for the patch.

Quoted 2 lines · Sakari Ailus

Separate CCS static data read-only register access in ccs-reg-access.c by naming them differently.

"naming the access functions differently"

Quoted 16 lines

The code in this file generally deals with reading and writing registers where as static data (when it comes to ccs_static_read_only()) contains the read-only register values but no hardware registers are accessed in that case.

---
 .../driver-api/media/drivers/ccs/mk-ccs-regs  |  2 +-
 drivers/media/i2c/ccs/ccs-reg-access.c        | 20 +++++++++----------
 2 files changed, 11 insertions(+), 11 deletions(-)
Documentation/driver-api/media/drivers/ccs/mk-ccs-regs +0 -0
index 01252ee6062b..3d3152b45821 100755

Documentation/driver-api/media/drivers/ccs/mk-ccs-regs if (! defined $kernel) { · line 139

Quoted 5 lines
Documentation/driver-api/media/drivers/ccs/mk-ccs-regs +1 -1
@@ -136,7 +136,7 @@ if (! defined $kernel) {
 
 print $H "#define CCS_FL_FLOAT_IREAL	" . flag_str(\$flag, \$all_flags) . "\n";
 print $H "#define CCS_FL_IREAL		" . flag_str(\$flag, \$all_flags) . "\n";
-print $H "#define CCS_BUILD_BUG \
+print $H "#define CCS_BUILD_BUG \\

This doesn't seem related.

Quoted 8 lines
Documentation/driver-api/media/drivers/ccs/mk-ccs-regs +0 -0
 	BUILD_BUG_ON(~CCI_REG_PRIVATE_MASK & ($all_flags))\n"
     if defined $kernel;
 
drivers/media/i2c/ccs/ccs-reg-access.c +0 -0
index 25993445f4fe..652d705a2ef5 100644

drivers/media/i2c/ccs/ccs-reg-access.c static int __ccs_read_addr(struct ccs_sensor *sensor, u32 reg, u32 *val, · line 200

Quoted 6 lines
drivers/media/i2c/ccs/ccs-reg-access.c +1 -2
@@ -197,8 +197,8 @@ static int __ccs_read_addr(struct ccs_sensor *sensor, u32 reg, u32 *val,
 	return 0;
 }
 
-static int __ccs_read_data(struct ccs_reg *regs, size_t num_regs,
-			   u32 reg, u32 *val)
+static int __ccs_static_read_only(struct ccs_reg *regs, size_t num_regs,

"static read only" sounds weird when interpreting "read" as a verb. And if "read" is not a verb, you're missing a verb :-) Maybe __ccs_read_state_data() would be a better name ? Same below.

Quoted 37 lines
drivers/media/i2c/ccs/ccs-reg-access.c +9 -8
+				  u32 reg, u32 *val)
 {
 	unsigned int width = ccs_reg_width(reg);
 	size_t i;
@@ -235,16 +235,16 @@ static int __ccs_read_data(struct ccs_reg *regs, size_t num_regs,
 	return -ENOENT;
 }
 
-static int ccs_read_data(struct ccs_sensor *sensor, u32 reg, u32 *val)
+static int ccs_static_read_only(struct ccs_sensor *sensor, u32 reg, u32 *val)
 {
-	if (!__ccs_read_data(sensor->sdata.sensor_read_only_regs,
-			     sensor->sdata.num_sensor_read_only_regs,
-			     reg, val))
+	if (!__ccs_static_read_only(sensor->sdata.sensor_read_only_regs,
+				    sensor->sdata.num_sensor_read_only_regs,
+				    reg, val))
 		return 0;
 
-	return __ccs_read_data(sensor->mdata.module_read_only_regs,
-			       sensor->mdata.num_module_read_only_regs,
-			       reg, val);
+	return __ccs_static_read_only(sensor->mdata.module_read_only_regs,
+				      sensor->mdata.num_module_read_only_regs,
+				      reg, val);
 }
 
 static int ccs_read_addr_raw(struct ccs_sensor *sensor, u32 reg, u32 *val,
@@ -253,7 +253,7 @@ static int ccs_read_addr_raw(struct ccs_sensor *sensor, u32 reg, u32 *val,
 	int rval;
 
 	if (data) {
-		rval = ccs_read_data(sensor, reg, val);
+		rval = ccs_static_read_only(sensor, reg, val);
 		if (!rval)
 			return 0;
 	}
Signature · 3 lines
Regards,

Laurent Pinchart
author maintainer
#11 lore raw

Re: [PATCH v2 5/6] media: ccs: Better separate CCS static data access

Quoted 27 lines · Laurent Pinchart

Hi Sakari,

Thank you for the patch.

Quoted 2 lines · Sakari Ailus

Separate CCS static data read-only register access in ccs-reg-access.c by naming them differently.

"naming the access functions differently"

Quoted 17 lines

The code in this file generally deals with reading and writing registers where as static data (when it comes to ccs_static_read_only()) contains the read-only register values but no hardware registers are accessed in that case.

---
 .../driver-api/media/drivers/ccs/mk-ccs-regs  |  2 +-
 drivers/media/i2c/ccs/ccs-reg-access.c        | 20 +++++++++----------
 2 files changed, 11 insertions(+), 11 deletions(-)
Documentation/driver-api/media/drivers/ccs/mk-ccs-regs +0 -0
index 01252ee6062b..3d3152b45821 100755
@@ -136,7 +136,7 @@ if (! defined $kernel) {
 
Quoted 6 lines

Documentation/driver-api/media/drivers/ccs/mk-ccs-regs if (! defined $kernel) { · line 139

Quoted 4 lines
Documentation/driver-api/media/drivers/ccs/mk-ccs-regs +1 -1
 print $H "#define CCS_FL_FLOAT_IREAL	" . flag_str(\$flag, \$all_flags) . "\n";
 print $H "#define CCS_FL_IREAL		" . flag_str(\$flag, \$all_flags) . "\n";
-print $H "#define CCS_BUILD_BUG \
+print $H "#define CCS_BUILD_BUG \\

This doesn't seem related.

Oops. This was meant to go to the previous patch. I'll address this in v3...

Quoted 12 lines
Quoted 12 lines
Documentation/driver-api/media/drivers/ccs/mk-ccs-regs +0 -0
 	BUILD_BUG_ON(~CCI_REG_PRIVATE_MASK & ($all_flags))\n"
     if defined $kernel;
 
drivers/media/i2c/ccs/ccs-reg-access.c +0 -0
index 25993445f4fe..652d705a2ef5 100644
@@ -197,8 +197,8 @@ static int __ccs_read_addr(struct ccs_sensor *sensor, u32 reg, u32 *val,
 	return 0;
 }
 
Quoted 7 lines

drivers/media/i2c/ccs/ccs-reg-access.c static int __ccs_read_addr(struct ccs_sensor *sensor, u32 reg, u32 *val, · line 200

Quoted 3 lines
drivers/media/i2c/ccs/ccs-reg-access.c +1 -2
-static int __ccs_read_data(struct ccs_reg *regs, size_t num_regs,
-			   u32 reg, u32 *val)
+static int __ccs_static_read_only(struct ccs_reg *regs, size_t num_regs,

"static read only" sounds weird when interpreting "read" as a verb. And if "read" is not a verb, you're missing a verb :-) Maybe __ccs_read_state_data() would be a better name ? Same below.

Why state_data? I prefer to use terms used in the spec, not come up with new ones.

There are also other blocks in static data beseides read-only register values.

How about ccs_static_data_read_only_reg(), would that be more informative in your opinion?

Quoted 39 lines
Quoted 38 lines
drivers/media/i2c/ccs/ccs-reg-access.c +9 -8
+				  u32 reg, u32 *val)
 {
 	unsigned int width = ccs_reg_width(reg);
 	size_t i;
@@ -235,16 +235,16 @@ static int __ccs_read_data(struct ccs_reg *regs, size_t num_regs,
 	return -ENOENT;
 }
 
-static int ccs_read_data(struct ccs_sensor *sensor, u32 reg, u32 *val)
+static int ccs_static_read_only(struct ccs_sensor *sensor, u32 reg, u32 *val)
 {
-	if (!__ccs_read_data(sensor->sdata.sensor_read_only_regs,
-			     sensor->sdata.num_sensor_read_only_regs,
-			     reg, val))
+	if (!__ccs_static_read_only(sensor->sdata.sensor_read_only_regs,
+				    sensor->sdata.num_sensor_read_only_regs,
+				    reg, val))
 		return 0;
 
-	return __ccs_read_data(sensor->mdata.module_read_only_regs,
-			       sensor->mdata.num_module_read_only_regs,
-			       reg, val);
+	return __ccs_static_read_only(sensor->mdata.module_read_only_regs,
+				      sensor->mdata.num_module_read_only_regs,
+				      reg, val);
 }
 
 static int ccs_read_addr_raw(struct ccs_sensor *sensor, u32 reg, u32 *val,
@@ -253,7 +253,7 @@ static int ccs_read_addr_raw(struct ccs_sensor *sensor, u32 reg, u32 *val,
 	int rval;
 
 	if (data) {
-		rval = ccs_read_data(sensor, reg, val);
+		rval = ccs_static_read_only(sensor, reg, val);
 		if (!rval)
 			return 0;
 	}
Signature · 3 lines
Regards,

Sakari Ailus
#12 lore raw

Re: [PATCH v2 5/6] media: ccs: Better separate CCS static data access

Quoted 58 lines · Sakari Ailus
Quoted 27 lines · Laurent Pinchart

Hi Sakari,

Thank you for the patch.

Quoted 2 lines · Sakari Ailus

Separate CCS static data read-only register access in ccs-reg-access.c by naming them differently.

"naming the access functions differently"

Quoted 17 lines

The code in this file generally deals with reading and writing registers where as static data (when it comes to ccs_static_read_only()) contains the read-only register values but no hardware registers are accessed in that case.

---
 .../driver-api/media/drivers/ccs/mk-ccs-regs  |  2 +-
 drivers/media/i2c/ccs/ccs-reg-access.c        | 20 +++++++++----------
 2 files changed, 11 insertions(+), 11 deletions(-)
Documentation/driver-api/media/drivers/ccs/mk-ccs-regs +0 -0
index 01252ee6062b..3d3152b45821 100755
@@ -136,7 +136,7 @@ if (! defined $kernel) {
 
Quoted 6 lines

Documentation/driver-api/media/drivers/ccs/mk-ccs-regs if (! defined $kernel) { · line 139

Quoted 4 lines
Documentation/driver-api/media/drivers/ccs/mk-ccs-regs +1 -1
 print $H "#define CCS_FL_FLOAT_IREAL	" . flag_str(\$flag, \$all_flags) . "\n";
 print $H "#define CCS_FL_IREAL		" . flag_str(\$flag, \$all_flags) . "\n";
-print $H "#define CCS_BUILD_BUG \
+print $H "#define CCS_BUILD_BUG \\

This doesn't seem related.

Oops. This was meant to go to the previous patch. I'll address this in v3...

Quoted 12 lines
Quoted 12 lines
Documentation/driver-api/media/drivers/ccs/mk-ccs-regs +0 -0
 	BUILD_BUG_ON(~CCI_REG_PRIVATE_MASK & ($all_flags))\n"
     if defined $kernel;
 
drivers/media/i2c/ccs/ccs-reg-access.c +0 -0
index 25993445f4fe..652d705a2ef5 100644
@@ -197,8 +197,8 @@ static int __ccs_read_addr(struct ccs_sensor *sensor, u32 reg, u32 *val,
 	return 0;
 }
 
Quoted 7 lines

drivers/media/i2c/ccs/ccs-reg-access.c static int __ccs_read_addr(struct ccs_sensor *sensor, u32 reg, u32 *val, · line 200

Quoted 3 lines
drivers/media/i2c/ccs/ccs-reg-access.c +1 -2
-static int __ccs_read_data(struct ccs_reg *regs, size_t num_regs,
-			   u32 reg, u32 *val)
+static int __ccs_static_read_only(struct ccs_reg *regs, size_t num_regs,

"static read only" sounds weird when interpreting "read" as a verb. And if "read" is not a verb, you're missing a verb :-) Maybe __ccs_read_state_data() would be a better name ? Same below.

Quoted 2 lines

Why state_data? I prefer to use terms used in the spec, not come up with new ones.

Sorry, I mean __ccs_read_static_data(). I'm working on a patch related to V4L2 subdev state at the moment :-)

Quoted 5 lines

There are also other blocks in static data beseides read-only register values.

How about ccs_static_data_read_only_reg(), would that be more informative in your opinion?

ccs_static_data_read_ro_reg() would work for me. I interpret ccs_static_data_read_only_reg() as "read just the register and nothing else".

Quoted 37 lines
Quoted 37 lines
Quoted 37 lines
drivers/media/i2c/ccs/ccs-reg-access.c +9 -8
+				  u32 reg, u32 *val)
 {
 	unsigned int width = ccs_reg_width(reg);
 	size_t i;
@@ -235,16 +235,16 @@ static int __ccs_read_data(struct ccs_reg *regs, size_t num_regs,
 	return -ENOENT;
 }
 
-static int ccs_read_data(struct ccs_sensor *sensor, u32 reg, u32 *val)
+static int ccs_static_read_only(struct ccs_sensor *sensor, u32 reg, u32 *val)
 {
-	if (!__ccs_read_data(sensor->sdata.sensor_read_only_regs,
-			     sensor->sdata.num_sensor_read_only_regs,
-			     reg, val))
+	if (!__ccs_static_read_only(sensor->sdata.sensor_read_only_regs,
+				    sensor->sdata.num_sensor_read_only_regs,
+				    reg, val))
 		return 0;
 
-	return __ccs_read_data(sensor->mdata.module_read_only_regs,
-			       sensor->mdata.num_module_read_only_regs,
-			       reg, val);
+	return __ccs_static_read_only(sensor->mdata.module_read_only_regs,
+				      sensor->mdata.num_module_read_only_regs,
+				      reg, val);
 }
 
 static int ccs_read_addr_raw(struct ccs_sensor *sensor, u32 reg, u32 *val,
@@ -253,7 +253,7 @@ static int ccs_read_addr_raw(struct ccs_sensor *sensor, u32 reg, u32 *val,
 	int rval;
 
 	if (data) {
-		rval = ccs_read_data(sensor, reg, val);
+		rval = ccs_static_read_only(sensor, reg, val);
 		if (!rval)
 			return 0;
 	}
Signature · 3 lines
Regards,

Laurent Pinchart
author maintainer
#13 lore raw

Re: [PATCH v2 5/6] media: ccs: Better separate CCS static data access

Quoted 68 lines · Laurent Pinchart
Quoted 58 lines · Sakari Ailus
Quoted 27 lines · Laurent Pinchart

Hi Sakari,

Thank you for the patch.

Quoted 2 lines · Sakari Ailus

Separate CCS static data read-only register access in ccs-reg-access.c by naming them differently.

"naming the access functions differently"

Quoted 17 lines

The code in this file generally deals with reading and writing registers where as static data (when it comes to ccs_static_read_only()) contains the read-only register values but no hardware registers are accessed in that case.

---
 .../driver-api/media/drivers/ccs/mk-ccs-regs  |  2 +-
 drivers/media/i2c/ccs/ccs-reg-access.c        | 20 +++++++++----------
 2 files changed, 11 insertions(+), 11 deletions(-)
Documentation/driver-api/media/drivers/ccs/mk-ccs-regs +0 -0
index 01252ee6062b..3d3152b45821 100755
@@ -136,7 +136,7 @@ if (! defined $kernel) {
 
Quoted 6 lines

Documentation/driver-api/media/drivers/ccs/mk-ccs-regs if (! defined $kernel) { · line 139

Quoted 4 lines
Documentation/driver-api/media/drivers/ccs/mk-ccs-regs +1 -1
 print $H "#define CCS_FL_FLOAT_IREAL	" . flag_str(\$flag, \$all_flags) . "\n";
 print $H "#define CCS_FL_IREAL		" . flag_str(\$flag, \$all_flags) . "\n";
-print $H "#define CCS_BUILD_BUG \
+print $H "#define CCS_BUILD_BUG \\

This doesn't seem related.

Oops. This was meant to go to the previous patch. I'll address this in v3...

Quoted 12 lines
Quoted 12 lines
Documentation/driver-api/media/drivers/ccs/mk-ccs-regs +0 -0
 	BUILD_BUG_ON(~CCI_REG_PRIVATE_MASK & ($all_flags))\n"
     if defined $kernel;
 
drivers/media/i2c/ccs/ccs-reg-access.c +0 -0
index 25993445f4fe..652d705a2ef5 100644
@@ -197,8 +197,8 @@ static int __ccs_read_addr(struct ccs_sensor *sensor, u32 reg, u32 *val,
 	return 0;
 }
 
Quoted 7 lines

drivers/media/i2c/ccs/ccs-reg-access.c static int __ccs_read_addr(struct ccs_sensor *sensor, u32 reg, u32 *val, · line 200

Quoted 3 lines
drivers/media/i2c/ccs/ccs-reg-access.c +1 -2
-static int __ccs_read_data(struct ccs_reg *regs, size_t num_regs,
-			   u32 reg, u32 *val)
+static int __ccs_static_read_only(struct ccs_reg *regs, size_t num_regs,

"static read only" sounds weird when interpreting "read" as a verb. And if "read" is not a verb, you're missing a verb :-) Maybe __ccs_read_state_data() would be a better name ? Same below.

Quoted 2 lines

Why state_data? I prefer to use terms used in the spec, not come up with new ones.

Sorry, I mean __ccs_read_static_data(). I'm working on a patch related to V4L2 subdev state at the moment :-)

Quoted 3 lines

There are also other blocks in static data beseides read-only register values.

Quoted 6 lines
Quoted 2 lines

How about ccs_static_data_read_only_reg(), would that be more informative in your opinion?

ccs_static_data_read_ro_reg() would work for me. I interpret ccs_static_data_read_only_reg() as "read just the register and nothing else".

ccs_static_data_read_ro_reg() seems reasonable, I'll use it in v3.

There will be more similarly named functions in the future.

Signature · 1 line
Sakari Ailus
author maintainer
#14 lore raw

PATCH v2 6/6 media: ccs: Use V4L2 CCI for accessing sensor registers

In reply to Sakari Ailus

Use V4L2 CCI for accessing device's registers. The 8-bit compatibility read option is removed but this is supported by regmap through other means.

Also the CCS register definitions are re-generated with V4L2 CCI definitions. The older SMIA++ register definitions have been manually converted.

---
 drivers/media/i2c/ccs/ccs-core.c        |  84 +--
 drivers/media/i2c/ccs/ccs-reg-access.c  | 192 +----
 drivers/media/i2c/ccs/ccs-regs.h        | 906 +++++++++++-----------
 drivers/media/i2c/ccs/ccs.h             |   2 +
 drivers/media/i2c/ccs/smiapp-reg-defs.h | 951 ++++++++++++------------
 5 files changed, 999 insertions(+), 1136 deletions(-)
drivers/media/i2c/ccs/ccs-core.c +42 -42
index d210b6c87db4..88eec1e9932e 100644
@@ -25,8 +25,9 @@
 #include <linux/slab.h>
 #include <linux/smiapp.h>
 #include <linux/v4l2-mediabus.h>
-#include <media/v4l2-fwnode.h>
+#include <media/v4l2-cci.h>
 #include <media/v4l2-device.h>
+#include <media/v4l2-fwnode.h>
 #include <uapi/linux/ccs.h>
 
 #include "ccs.h"
@@ -98,7 +99,7 @@ static int ccs_limit_ptr(struct ccs_sensor *sensor, unsigned int limit,
 	linfo = &ccs_limits[ccs_limit_offsets[limit].info];
 
 	if (WARN_ON(!sensor->ccs_limits) ||
-	    WARN_ON(offset + ccs_reg_width(linfo->reg) >
+	    WARN_ON(offset + CCI_REG_WIDTH_BYTES(linfo->reg) >
 		    ccs_limit_offsets[limit + 1].lim))
 		return -EINVAL;
 
@@ -124,7 +125,7 @@ void ccs_replace_limit(struct ccs_sensor *sensor,
 	dev_dbg(&client->dev, "quirk: 0x%8.8x \"%s\" %u = %u, 0x%x\n",
 		linfo->reg, linfo->name, offset, val, val);
 
-	ccs_assign_limit(ptr, ccs_reg_width(linfo->reg), val);
+	ccs_assign_limit(ptr, CCI_REG_WIDTH_BYTES(linfo->reg), val);
 }
 
 u32 ccs_get_limit(struct ccs_sensor *sensor, unsigned int limit,
@@ -138,7 +139,7 @@ u32 ccs_get_limit(struct ccs_sensor *sensor, unsigned int limit,
 	if (ret)
 		return 0;
 
-	switch (ccs_reg_width(ccs_limits[ccs_limit_offsets[limit].info].reg)) {
+	switch (CCI_REG_WIDTH_BYTES(ccs_limits[ccs_limit_offsets[limit].info].reg)) {
 	case sizeof(u8):
 		val = *(u8 *)ptr;
 		break;
@@ -176,7 +177,7 @@ static int ccs_read_all_limits(struct ccs_sensor *sensor)
 
 	for (i = 0, l = 0, ptr = alloc; ccs_limits[i].size; i++) {
 		u32 reg = ccs_limits[i].reg;
-		unsigned int width = ccs_reg_width(reg);
+		unsigned int width = CCI_REG_WIDTH_BYTES(reg);
 		unsigned int j;
 
 		if (l == CCS_L_LAST) {
@@ -2725,66 +2726,54 @@ static int ccs_identify_module(struct ccs_sensor *sensor)
 	rval = ccs_read(sensor, MODULE_MANUFACTURER_ID,
 			&minfo->mipi_manufacturer_id);
 	if (!rval && !minfo->mipi_manufacturer_id)
-		rval = ccs_read_addr_8only(sensor,
-					   SMIAPP_REG_U8_MANUFACTURER_ID,
-					   &minfo->smia_manufacturer_id);
+		rval = ccs_read_addr(sensor, SMIAPP_REG_U8_MANUFACTURER_ID,
+				     &minfo->smia_manufacturer_id);
 	if (!rval)
-		rval = ccs_read_addr_8only(sensor, CCS_R_MODULE_MODEL_ID,
-					   &minfo->model_id);
+		rval = ccs_read(sensor, MODULE_MODEL_ID, &minfo->model_id);
 	if (!rval)
-		rval = ccs_read_addr_8only(sensor,
-					   CCS_R_MODULE_REVISION_NUMBER_MAJOR,
-					   &rev);
+		rval = ccs_read(sensor, MODULE_REVISION_NUMBER_MAJOR, &rev);
 	if (!rval) {
-		rval = ccs_read_addr_8only(sensor,
-					   CCS_R_MODULE_REVISION_NUMBER_MINOR,
-					   &minfo->revision_number);
+		rval = ccs_read(sensor, MODULE_REVISION_NUMBER_MINOR,
+				&minfo->revision_number);
 		minfo->revision_number |= rev << 8;
 	}
 	if (!rval)
-		rval = ccs_read_addr_8only(sensor, CCS_R_MODULE_DATE_YEAR,
-					   &minfo->module_year);
+		rval = ccs_read(sensor, MODULE_DATE_YEAR, &minfo->module_year);
 	if (!rval)
-		rval = ccs_read_addr_8only(sensor, CCS_R_MODULE_DATE_MONTH,
-					   &minfo->module_month);
+		rval = ccs_read(sensor, MODULE_DATE_MONTH,
+				&minfo->module_month);
 	if (!rval)
-		rval = ccs_read_addr_8only(sensor, CCS_R_MODULE_DATE_DAY,
-					   &minfo->module_day);
+		rval = ccs_read(sensor, MODULE_DATE_DAY, &minfo->module_day);
 
 	/* Sensor info */
 	if (!rval)
 		rval = ccs_read(sensor, SENSOR_MANUFACTURER_ID,
 				&minfo->sensor_mipi_manufacturer_id);
 	if (!rval && !minfo->sensor_mipi_manufacturer_id)
-		rval = ccs_read_addr_8only(sensor,
-					   CCS_R_SENSOR_MANUFACTURER_ID,
-					   &minfo->sensor_smia_manufacturer_id);
+		rval = ccs_read(sensor, SENSOR_MANUFACTURER_ID,
+				&minfo->sensor_smia_manufacturer_id);
 	if (!rval)
-		rval = ccs_read_addr_8only(sensor,
-					   CCS_R_SENSOR_MODEL_ID,
-					   &minfo->sensor_model_id);
+		rval = ccs_read(sensor, SENSOR_MODEL_ID,
+				&minfo->sensor_model_id);
 	if (!rval)
-		rval = ccs_read_addr_8only(sensor,
-					   CCS_R_SENSOR_REVISION_NUMBER,
-					   &minfo->sensor_revision_number);
+		rval = ccs_read(sensor, SENSOR_REVISION_NUMBER,
+				&minfo->sensor_revision_number);
 	if (!rval && !minfo->sensor_revision_number)
-		rval = ccs_read_addr_8only(sensor,
-					   CCS_R_SENSOR_REVISION_NUMBER_16,
-					   &minfo->sensor_revision_number);
+		rval = ccs_read(sensor, SENSOR_REVISION_NUMBER_16,
+				&minfo->sensor_revision_number);
 	if (!rval)
-		rval = ccs_read_addr_8only(sensor,
-					   CCS_R_SENSOR_FIRMWARE_VERSION,
-					   &minfo->sensor_firmware_version);
+		rval = ccs_read(sensor, SENSOR_FIRMWARE_VERSION,
+				&minfo->sensor_firmware_version);
 
 	/* SMIA */
 	if (!rval)
 		rval = ccs_read(sensor, MIPI_CCS_VERSION, &minfo->ccs_version);
 	if (!rval && !minfo->ccs_version)
-		rval = ccs_read_addr_8only(sensor, SMIAPP_REG_U8_SMIA_VERSION,
-					   &minfo->smia_version);
+		rval = ccs_read_addr(sensor, SMIAPP_REG_U8_SMIA_VERSION,
+				     &minfo->smia_version);
 	if (!rval && !minfo->ccs_version)
-		rval = ccs_read_addr_8only(sensor, SMIAPP_REG_U8_SMIAPP_VERSION,
-					   &minfo->smiapp_version);
+		rval = ccs_read_addr(sensor, SMIAPP_REG_U8_SMIAPP_VERSION,
+				     &minfo->smiapp_version);
 
 	if (rval) {
 		dev_err(&client->dev, "sensor detection failed\n");
@@ -3318,6 +3307,13 @@ static int ccs_probe(struct i2c_client *client)
 	if (IS_ERR(sensor->xshutdown))
 		return PTR_ERR(sensor->xshutdown);
 
+	sensor->regmap = devm_cci_regmap_init_i2c(client, 16);
+	if (IS_ERR(sensor->regmap)) {
+		dev_err(&client->dev, "can't initialise CCI (%ld)\n",
+			PTR_ERR(sensor->regmap));
+		return PTR_ERR(sensor->regmap);
+	}
+
 	rval = ccs_power_on(&client->dev);
 	if (rval < 0)
 		return rval;
@@ -3648,12 +3644,16 @@ static int ccs_module_init(void)
 {
 	unsigned int i, l;
 
+	CCS_BUILD_BUG;
+
 	for (i = 0, l = 0; ccs_limits[i].size && l < CCS_L_LAST; i++) {
 		if (!(ccs_limits[i].flags & CCS_L_FL_SAME_REG)) {
 			ccs_limit_offsets[l + 1].lim =
 				ALIGN(ccs_limit_offsets[l].lim +
 				      ccs_limits[i].size,
-				      ccs_reg_width(ccs_limits[i + 1].reg));
+				      ccs_limits[i + 1].reg ?
+				      CCI_REG_WIDTH_BYTES(ccs_limits[i + 1].reg) :
+				      1U);
 			ccs_limit_offsets[l].info = i;
 			l++;
 		} else {
drivers/media/i2c/ccs/ccs-reg-access.c +25 -167

258 lines not on this page · raw message

drivers/media/i2c/ccs/ccs-regs.h +453 -453

1,354 lines not on this page · raw message

drivers/media/i2c/ccs/ccs.h +2 -0
index 2c013d96adcc..096573845a10 100644
@@ -13,6 +13,7 @@
 #define __CCS_H__
 
 #include <linux/mutex.h>
+#include <linux/regmap.h>
 #include <media/v4l2-ctrls.h>
 #include <media/v4l2-subdev.h>
 
@@ -211,6 +212,7 @@ struct ccs_sensor {
 	struct clk *ext_clk;
 	struct gpio_desc *xshutdown;
 	struct gpio_desc *reset;
+	struct regmap *regmap;
 	void *ccs_limits;
 	u8 nbinning_subtypes;
 	struct ccs_binning_subtype binning_subtypes[CCS_LIM_BINNING_SUB_TYPE_MAX_N + 1];
drivers/media/i2c/ccs/smiapp-reg-defs.h +477 -474

958 lines not on this page · raw message

Signature · 1 line
2.39.2