Skip to contentSkip to conversation

dt-bindings: lcdif: Properly describe the i.MX23 interrupts

PATCH Superseded Fabio Estevam 3 participants 3 messages Dec 5, 2023 – Dec 6, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: lcdif: Properly describe the i.MX23 interrupts

From: Fabio Estevam <[email protected]>

i.MX23 has two LCDIF interrupts instead of a single one like other i.MX devices.

Take this into account for properly describing the i.MX23 LCDIF interrupts.

This fixes the following dt-schema warning:

imx23-olinuxino.dtb: lcdif@80030000: interrupts: [[46], [45]] is too long
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#

---
Changes since v1:
- Fix typo in commit log (i.MX23 has two LCDIF interrupts).

 .../devicetree/bindings/display/fsl,lcdif.yaml   | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +15 -1
index fc11ab5fc465..c4228b893766 100644
@@ -51,7 +51,10 @@ properties:
     minItems: 1
 
   interrupts:
-    maxItems: 1
+    items:
+      - description: LCDIF DMA interrupt
+      - description: LCDIF Error interrupt
+    minItems: 1
 
   power-domains:
     maxItems: 1
@@ -131,6 +134,17 @@ allOf:
     then:
       required:
         - power-domains
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx23-lcdif
+    then:
+      properties:
+        interrupts:
+          minItems: 2
+          maxItems: 2
 
 examples:
   - |
Signature · 1 line
2.34.1
maintainer Reviewed-by on v2 1/1
#1 lore raw
Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

i.MX23 has two LCDIF interrupts instead of a single one like other i.MX devices.

Take this into account for properly describing the i.MX23 LCDIF interrupts.

Quoted 6 lines

This fixes the following dt-schema warning:

imx23-olinuxino.dtb: lcdif@80030000: interrupts: [[46], [45]] is too long
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#

Indeed

#2 lore raw
In reply to Fabio Estevam
Quoted 42 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

i.MX23 has two LCDIF interrupts instead of a single one like other i.MX devices.

Take this into account for properly describing the i.MX23 LCDIF interrupts.

This fixes the following dt-schema warning:

imx23-olinuxino.dtb: lcdif@80030000: interrupts: [[46], [45]] is too long
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#

---
Changes since v1:
- Fix typo in commit log (i.MX23 has two LCDIF interrupts).

 .../devicetree/bindings/display/fsl,lcdif.yaml   | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +5 -1
index fc11ab5fc465..c4228b893766 100644
@@ -51,7 +51,10 @@ properties:
     minItems: 1
 
   interrupts:
-    maxItems: 1
+    items:
+      - description: LCDIF DMA interrupt
+      - description: LCDIF Error interrupt
+    minItems: 1
 
   power-domains:
     maxItems: 1
@@ -131,6 +134,17 @@ allOf:
     then:
       required:
         - power-domains
+  - if:

Documentation/devicetree/bindings/display/fsl,lcdif.yaml allOf: · line 147

Quoted 10 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +10 -0
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx23-lcdif
+    then:
+      properties:
+        interrupts:
+          minItems: 2
+          maxItems: 2

Either missing else: or update of other variants to limit interrupts to 1.

Best regards,
Krzysztof