Skip to contentSkip to conversation

dt-bindings: lcdif: Properly describe the i.MX23 interrupts

PATCH Applied Fabio Estevam 3 participants 3 messages Dec 6, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: lcdif: Properly describe the i.MX23 interrupts

From: Fabio Estevam <[email protected]>

i.MX23 has two LCDIF interrupts instead of a single one like other i.MX devices.

Take this into account for properly describing the i.MX23 LCDIF interrupts.

This fixes the following dt-schema warning:

imx23-olinuxino.dtb: lcdif@80030000: interrupts: [[46], [45]] is too long
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#

---
Changes since v1:
- Add missing else to limit the number of irqs for the other variants. (Krzysztof)

 .../bindings/display/fsl,lcdif.yaml           | 20 ++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +19 -1
index fc11ab5fc465..1c2be8d6f633 100644
@@ -51,7 +51,10 @@ properties:
     minItems: 1
 
   interrupts:
-    maxItems: 1
+    items:
+      - description: LCDIF DMA interrupt
+      - description: LCDIF Error interrupt
+    minItems: 1
 
   power-domains:
     maxItems: 1
@@ -131,6 +134,21 @@ allOf:
     then:
       required:
         - power-domains
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx23-lcdif
+    then:
+      properties:
+        interrupts:
+          minItems: 2
+          maxItems: 2
+    else:
+      properties:
+        interrupts:
+          maxItems: 1
 
 examples:
   - |
Signature · 1 line
2.34.1
Acked-by on v2 1/1
#1 lore raw
Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

i.MX23 has two LCDIF interrupts instead of a single one like other i.MX devices.

Take this into account for properly describing the i.MX23 LCDIF interrupts.

Quoted 7 lines

This fixes the following dt-schema warning:

imx23-olinuxino.dtb: lcdif@80030000: interrupts: [[46], [45]] is too long
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#

Thanks,
Conor.

maintainer Applied
#2 lore raw
In reply to Fabio Estevam
Quoted 13 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

i.MX23 has two LCDIF interrupts instead of a single one like other i.MX devices.

Take this into account for properly describing the i.MX23 LCDIF interrupts.

This fixes the following dt-schema warning:

imx23-olinuxino.dtb: lcdif@80030000: interrupts: [[46], [45]] is too long
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#

Quoted 9 lines

---
Changes since v1:
- Add missing else to limit the number of irqs for the other variants. (Krzysztof)

 .../bindings/display/fsl,lcdif.yaml           | 20 ++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

Applied, thanks!