perf stat: Fix hard coded ll miss units
Ian Rogers
reviewerPATCH 1/1 perf stat: Fix hard coded ll miss units
Copy-paste error where LL cache misses are reported as l1i.
Suggested-by Guillaume Endignoux <[email protected]>
Fixes 0a57b910807a ("perf stat: Use counts rather than saved_value")
Signed-off-by Ian Rogers <[email protected]>
--- tools/perf/util/stat-shadow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/stat-shadow.c +1 -1
@@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,static const double color_ratios[3 ] = {20.0 ,10.0 ,5.0 };print_ratio (config, evsel, aggr_idx, misses, out,STAT_LL_CACHE , color_ratios, -"of all L1-icache accesses" ); +"of all LL-cache accesses" ); } static void print_dtlb_miss(struct perf_stat_config *config,
Signature · 1 line
2.43.0.472.g3155946c3a-goog
Ian Rogers
reviewerQuoted 6 lines · Ian Rogers
Copy-paste error where LL cache misses are reported as l1i.
Suggested-by Guillaume Endignoux <[email protected]>Fixes 0a57b910807a ("perf stat: Use counts rather than saved_value")Signed-off-by Ian Rogers <[email protected]>
Ping. Trivial 1 character fix but no reviews :-(
Thanks,
Ian
Quoted 20 lines
--- tools/perf/util/stat-shadow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/util/stat-shadow.c +1
-2@@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,static const double color_ratios[3 ] = {20.0 ,10.0 ,5.0 };print_ratio (config, evsel, aggr_idx, misses, out,STAT_LL_CACHE , color_ratios, -"of all L1-icache accesses" ); +"of all LL-cache accesses" ); } static void print_dtlb_miss(struct perf_stat_config *config, --2.43.0.472.g3155946c3a-goog
Liang, Kan
Reviewed-byQuoted 8 lines · Ian Rogers
Quoted 6 lines · Ian Rogers
Copy-paste error where LL cache misses are reported as l1i.
Suggested-by Guillaume Endignoux <[email protected]>Fixes 0a57b910807a ("perf stat: Use counts rather than saved_value")Signed-off-by Ian Rogers <[email protected]>
Reviewed-by Kan Liang <[email protected]>
Thanks,
Kan
Quoted 26 lines
Ping. Trivial 1 character fix but no reviews :-(
Thanks,
IanQuoted 20 lines
--- tools/perf/util/stat-shadow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/util/stat-shadow.c +1
-2@@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,static const double color_ratios[3 ] = {20.0 ,10.0 ,5.0 };print_ratio (config, evsel, aggr_idx, misses, out,STAT_LL_CACHE , color_ratios, -"of all L1-icache accesses" ); +"of all LL-cache accesses" ); } static void print_dtlb_miss(struct perf_stat_config *config, --2.43.0.472.g3155946c3a-goog
Em Tue, Jan 02, 2024 at 03:01:55PM -0500, Liang, Kan escreveu:
Quoted 13 lines · Ian Rogers
Quoted 8 lines · Ian Rogers
Quoted 6 lines
Copy-paste error where LL cache misses are reported as l1i.
Suggested-by Guillaume Endignoux <[email protected]>Fixes 0a57b910807a ("perf stat: Use counts rather than saved_value")Signed-off-by Ian Rogers <[email protected]>Reviewed-by Kan Liang <[email protected]>
Thanks, applied to perf-tools-next.
- Arnaldo
Quoted 29 lines
Thanks,
KanQuoted 26 lines
Ping. Trivial 1 character fix but no reviews :-(
Thanks,
IanQuoted 20 lines
--- tools/perf/util/stat-shadow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/util/stat-shadow.c +1
-2@@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,static const double color_ratios[3 ] = {20.0 ,10.0 ,5.0 };print_ratio (config, evsel, aggr_idx, misses, out,STAT_LL_CACHE , color_ratios, -"of all L1-icache accesses" ); +"of all LL-cache accesses" ); } static void print_dtlb_miss(struct perf_stat_config *config, --2.43.0.472.g3155946c3a-goog
Signature · 1 line
- Arnaldo