Skip to contentSkip to conversation

perf stat: Fix hard coded ll miss units

PATCH Applied Ian Rogers 3 participants 4 messages Dec 11, 2023 – Jan 3, 2024 perf events

lore
Share & tools
lore

Ian Rogers

author reviewer
#0 lore raw

PATCH 1/1 perf stat: Fix hard coded ll miss units

Copy-paste error where LL cache misses are reported as l1i.

Fixes 0a57b910807a ("perf stat: Use counts rather than saved_value")
---
 tools/perf/util/stat-shadow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/stat-shadow.c +1 -1
index 1c5c3eeba4cf..e31426167852 100644
@@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,
 	static const double color_ratios[3] = {20.0, 10.0, 5.0};
 
 	print_ratio(config, evsel, aggr_idx, misses, out, STAT_LL_CACHE, color_ratios,
-		    "of all L1-icache accesses");
+		    "of all LL-cache accesses");
 }
 
 static void print_dtlb_miss(struct perf_stat_config *config,
Signature · 1 line
2.43.0.472.g3155946c3a-goog
author reviewer
#1 lore raw
Quoted 6 lines · Ian Rogers

Copy-paste error where LL cache misses are reported as l1i.

Fixes 0a57b910807a ("perf stat: Use counts rather than saved_value")

Ping. Trivial 1 character fix but no reviews :-(

Thanks,
Ian

Quoted 20 lines
---
 tools/perf/util/stat-shadow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/stat-shadow.c +1 -2
index 1c5c3eeba4cf..e31426167852 100644
@@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,
        static const double color_ratios[3] = {20.0, 10.0, 5.0};
 
        print_ratio(config, evsel, aggr_idx, misses, out, STAT_LL_CACHE, color_ratios,
-                   "of all L1-icache accesses");
+                   "of all LL-cache accesses");
 }
 
 static void print_dtlb_miss(struct perf_stat_config *config,
--

2.43.0.472.g3155946c3a-goog

Reviewed-by
#2 lore raw
Quoted 8 lines · Ian Rogers
Quoted 6 lines · Ian Rogers

Copy-paste error where LL cache misses are reported as l1i.

Fixes 0a57b910807a ("perf stat: Use counts rather than saved_value")

Thanks,
Kan

Quoted 26 lines

Ping. Trivial 1 character fix but no reviews :-(

Thanks,
Ian

Quoted 20 lines
---
 tools/perf/util/stat-shadow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/stat-shadow.c +1 -2
index 1c5c3eeba4cf..e31426167852 100644
@@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,
        static const double color_ratios[3] = {20.0, 10.0, 5.0};
 
        print_ratio(config, evsel, aggr_idx, misses, out, STAT_LL_CACHE, color_ratios,
-                   "of all L1-icache accesses");
+                   "of all LL-cache accesses");
 }
 
 static void print_dtlb_miss(struct perf_stat_config *config,
--

2.43.0.472.g3155946c3a-goog

maintainer Applied
#3 lore raw

Em Tue, Jan 02, 2024 at 03:01:55PM -0500, Liang, Kan escreveu:

Quoted 13 lines · Ian Rogers
Quoted 8 lines · Ian Rogers
Quoted 6 lines

Copy-paste error where LL cache misses are reported as l1i.

Fixes 0a57b910807a ("perf stat: Use counts rather than saved_value")

Thanks, applied to perf-tools-next.

- Arnaldo

Quoted 29 lines

Thanks,
Kan

Quoted 26 lines

Ping. Trivial 1 character fix but no reviews :-(

Thanks,
Ian

Quoted 20 lines
---
 tools/perf/util/stat-shadow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/stat-shadow.c +1 -2
index 1c5c3eeba4cf..e31426167852 100644
@@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,
        static const double color_ratios[3] = {20.0, 10.0, 5.0};
 
        print_ratio(config, evsel, aggr_idx, misses, out, STAT_LL_CACHE, color_ratios,
-                   "of all L1-icache accesses");
+                   "of all LL-cache accesses");
 }
 
 static void print_dtlb_miss(struct perf_stat_config *config,
--

2.43.0.472.g3155946c3a-goog

Signature · 1 line
- Arnaldo