clk: microchip: mpfs-ccc: replace include of asm-generic/errno-base.h
Subsystems (3)
PATCH 1/1 clk: microchip: mpfs-ccc: replace include of asm-generic/errno-base.h
From: Conor Dooley <[email protected]>
As evidenced by the fact that only 2 other drivers include this header, it is not a normal thing to do. Including the regular version of this header is far more conventional for drivers.
--
CC: Conor Dooley <[email protected]>
CC: Daire McNamara <[email protected]>
CC: Michael Turquette <[email protected]>
CC: Stephen Boyd <[email protected]>
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- drivers/clk/microchip/clk-mpfs-ccc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/microchip/clk-mpfs-ccc.c +1 -1
@@ -4,8 +4,8 @@* * Copyright (C) 2022 Microchip Technology Inc. and its subsidiaries */ -#include "asm-generic/errno-base.h" #include <linux/clk-provider.h> +#include <linux/errno.h> #include <linux/io.h> #include <linux/module.h> #include <linux/platform_device.h>
Signature · 1 line
2.39.2
Quoted 5 lines · Conor Dooley
From: Conor Dooley <[email protected]>
As evidenced by the fact that only 2 other drivers include this header, it is not a normal thing to do. Including the regular version of this header is far more conventional for drivers.
ACK. Includes of asm-generic/anything.h are fine in arch/*/include/* and (under some circumstances) in include/*; anywhere else they are very dubious, including outright bugs (io_uring/uring_cmd.h include of asm-generic/ioctls.h, for example).
Quoting Conor Dooley (2023-12-14 02:59:57)
Quoted 8 lines
From: Conor Dooley <[email protected]>
As evidenced by the fact that only 2 other drivers include this header, it is not a normal thing to do. Including the regular version of this header is far more conventional for drivers.
CC Al Viro <[email protected]>Signed-off-by Conor Dooley <[email protected]>
Quoted 9 lines
--
CC: Conor Dooley <[email protected]>
CC: Daire McNamara <[email protected]>
CC: Michael Turquette <[email protected]>
CC: Stephen Boyd <[email protected]>
CC: [email protected]
CC: [email protected]
CC: [email protected]
---
Applied to clk-next