Skip to contentSkip to conversation

clk: microchip: mpfs-ccc: replace include of asm-generic/errno-base.h

PATCH Applied Conor Dooley 3 participants 3 messages Dec 14, 2023 – Dec 17, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: microchip: mpfs-ccc: replace include of asm-generic/errno-base.h

From: Conor Dooley <[email protected]>

As evidenced by the fact that only 2 other drivers include this header, it is not a normal thing to do. Including the regular version of this header is far more conventional for drivers.

--
CC: Conor Dooley <[email protected]>
CC: Daire McNamara <[email protected]>
CC: Michael Turquette <[email protected]>
CC: Stephen Boyd <[email protected]>
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 drivers/clk/microchip/clk-mpfs-ccc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/microchip/clk-mpfs-ccc.c +1 -1
index bce61c45e967..3a3ea2d142f8 100644
@@ -4,8 +4,8 @@
  *
  * Copyright (C) 2022 Microchip Technology Inc. and its subsidiaries
  */
-#include "asm-generic/errno-base.h"
 #include <linux/clk-provider.h>
+#include <linux/errno.h>
 #include <linux/io.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
Signature · 1 line
2.39.2
#1 lore raw
Quoted 5 lines · Conor Dooley

From: Conor Dooley <[email protected]>

As evidenced by the fact that only 2 other drivers include this header, it is not a normal thing to do. Including the regular version of this header is far more conventional for drivers.

ACK. Includes of asm-generic/anything.h are fine in arch/*/include/* and (under some circumstances) in include/*; anywhere else they are very dubious, including outright bugs (io_uring/uring_cmd.h include of asm-generic/ioctls.h, for example).

maintainer Applied
#2 lore raw
In reply to Conor Dooley

Quoting Conor Dooley (2023-12-14 02:59:57)

Quoted 8 lines

From: Conor Dooley <[email protected]>

As evidenced by the fact that only 2 other drivers include this header, it is not a normal thing to do. Including the regular version of this header is far more conventional for drivers.

Quoted 9 lines

--
CC: Conor Dooley <[email protected]>
CC: Daire McNamara <[email protected]>
CC: Michael Turquette <[email protected]>
CC: Stephen Boyd <[email protected]>
CC: [email protected]
CC: [email protected]
CC: [email protected]
---

Applied to clk-next