arm: dts: marvell: clearfog-gtr: miscellaneous enhancements
Subsystems (2)
v2 cover arm: dts: marvell: clearfog-gtr: miscellaneous enhancements
Dear Maintainers,
The initially merged device-tree for Clearfog GTR devices contained various subtle mistakes and omissions:
- missing board-specific compatible strings
- missing pinctrl entries
- missing second sfp connector
- invalid sfp loss-of-signal gpio
- mismatch of labels between dsa ports and enclosure
Most notably this had caused functional issues with the sfp connectors.
This patch-set first converts the armada-38x dt-bindings to yaml. New bindings are added specifically for the Clearfog GTR boards, and for the already in-place clearfog base and pro boards' compatible strings.
Secondly pinctrl nodes are added for all referenced gpios for independence from bootloader defaults. U-Boot is shared between armada-388 clearfog, and armada-385 clearfog gtr.
Further remove an invalid io from the first sfp connector description, and add descriptions for the secondary sfp connector which is driven by dsa switch port number 9.
Finally labels of dsa switch ports were updated to match the enclosure. That patch is not suitable for stable.
Josua Mayer (8):
dt-bindings: marvell: a38x: convert the soc compatibles description to
yaml
dt-bindings: marvell: a38x: add solidrun armada 385 clearfog gtr
boards
dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards
arm: dts: marvell: clearfog-gtr: add board-specific compatible strings
arm: dts: marvell: clearfog-gtr: sort pinctrl nodes alphabetically
arm: dts: marvell: clearfog-gtr: add missing pinctrl for all used
gpios
arm: dts: marvell: clearfog-gtr-l8: add support for second sfp
connector
arm: dts: marvell: clearfog-gtr-l8: align port numbers with enclosure
.../bindings/arm/marvell/armada-38x.txt | 27 ------ .../bindings/arm/marvell/armada-38x.yaml | 61 ++++++++++++++ .../marvell/armada-385-clearfog-gtr-l8.dts | 38 +++++++-- .../marvell/armada-385-clearfog-gtr-s4.dts | 2 + .../dts/marvell/armada-385-clearfog-gtr.dtsi | 84 ++++++++++++++----- 5 files changed, 155 insertions(+), 57 deletions(-) delete mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.txt create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
Signature · 7 lines
2.35.3 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v2 1/8 dt-bindings: marvell: a38x: convert the soc compatibles description to yaml
Convert the existing txt binding for armada-38x socs to DT schema format.
--- .../bindings/arm/marvell/armada-38x.txt | 27 --------------- .../bindings/arm/marvell/armada-38x.yaml | 33 +++++++++++++++++++ 2 files changed, 33 insertions(+), 27 deletions(-) delete mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.txt create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
Documentation/devicetree/bindings/arm/marvell/armada-38x.txt deleted +0 -27
@@ -1,27 +0,0 @@ -Marvell Armada 38x Platforms Device Tree Bindings -------------------------------------------------- - -Boards with a SoC of the Marvell Armada 38x family shall have the -following property: - -Required root node property: - - - compatible: must contain "marvell,armada380" - -In addition, boards using the Marvell Armada 385 SoC shall have the -following property before the previous one: - -Required root node property: - -compatible: must contain "marvell,armada385" - -In addition, boards using the Marvell Armada 388 SoC shall have the -following property before the previous one: - -Required root node property: - -compatible: must contain "marvell,armada388" - -Example: - -compatible = "marvell,a385-rd", "marvell,armada385", "marvell,armada380";
Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml new file +33 -0
@@ -0,0 +1,33 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Marvell Armada 38x Platforms + +maintainers: + - Gregory CLEMENT <[email protected]> + +properties: + $nodename: + const: '/' + compatible: + oneOf: + + - description: Armada 380 SoC + items: + - const: marvell,armada380 + + - description: Armada 385 SoC + items: + - const: marvell,armada385 + - const: marvell,armada380 + + - description: Armada 388 SoC + items: + - const: marvell,armada388 + - const: marvell,armada385 + - const: marvell,armada380 + +additionalProperties: true
Signature · 7 lines
2.35.3 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v2 1/8] dt-bindings: marvell: a38x: convert the soc compatibles description to yaml
Quoted 4 lines · Josua Mayer
Convert the existing txt binding for armada-38x socs to DT schema format.
Signed-off-by Josua Mayer <[email protected]>
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.
You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
Quoted 11 lines
Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml new file +11
-0+ +properties: + $nodename: + const: '/' + compatible: + oneOf: + + - description: Armada 380 SoC + items: + - const: marvell,armada380 +
Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml line 31
Quoted 10 lines
Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml new file +10
-0+ - description: Armada 385 SoC + items: + - const: marvell,armada385 + - const: marvell,armada380 + + - description: Armada 388 SoC + items: + - const: marvell,armada388 + - const: marvell,armada385 + - const: marvell,armada380
These should not be used alone, so such schema is not what we want. We want boards to be documented with these SoCs.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v2 1/8] dt-bindings: marvell: a38x: convert the soc compatibles description to yaml
Am 24.12.23 um 15:57 schrieb Krzysztof Kozlowski:
Quoted 10 lines · Josua Mayer
Quoted 4 lines
Convert the existing txt binding for armada-38x socs to DT schema format.
Signed-off-by Josua Mayer <[email protected]>Please use
scripts/get_maintainers.plto get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.
Quoted 6 lines
You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
I am sorry ...
I will verify what get_maintainers said ...
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#select-the-recipients-for-your-patch
I got confused from this guide - what to do when it tells me 3 or more lists.
Should I take the most specific one? Or all of them? I.e.:
[email protected] (moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...) [email protected] (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
[email protected] (open list)
Quoted 16 lines
Quoted 16 lines
Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml new file +15
-0+ +properties: + $nodename: + const: '/' + compatible: + oneOf: + + - description: Armada 380 SoC + items: + - const: marvell,armada380 + + - description: Armada 385 SoC + items: + - const: marvell,armada385 + - const: marvell,armada380
Quoted 8 lines
Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml line 31
Quoted 6 lines
Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml new file +6
-0+ + - description: Armada 388 SoC + items: + - const: marvell,armada388 + - const: marvell,armada385 + - const: marvell,armada380These should not be used alone, so such schema is not what we want. We want boards to be documented with these SoCs.
There is only one Marvell example for armada-8k:Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
I mirrored how that conversion had been done from text to yaml. If only boards belong in the yaml, then the conversion from txt will create an empty file,
to which I could then add specific boards on top.
Quoted 4 lines
Best regards,
Krzysztof
sincerely
Josua Mayer
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v2 1/8] dt-bindings: marvell: a38x: convert the soc compatibles description to yaml
Quoted 25 lines · Josua Mayer
Am 24.12.23 um 15:57 schrieb Krzysztof Kozlowski:
Quoted 10 lines · Josua Mayer
Quoted 4 lines
Convert the existing txt binding for armada-38x socs to DT schema format.
Signed-off-by Josua Mayer <[email protected]>Please use
scripts/get_maintainers.plto get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.Quoted 6 lines
You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
I am sorry ...
I will verify whatget_maintainerssaid ...https://www.kernel.org/doc/html/latest/process/submitting-patches.html#select-the-recipients-for-your-patch
I got confused from this guide - what to do when it tells me 3 or more lists.
Should I take the most specific one? Or all of them? I.e.:
Quoted 5 lines
[email protected] (moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...) [email protected] (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
[email protected] (open list)
The same what b4 and all scripts are doing: all lists. Why even bothering in selective remove of people or lists?
Quoted 25 lines
Quoted 17 lines
Quoted 17 lines
Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml new file +15
-0+ +properties: + $nodename: + const: '/' + compatible: + oneOf: + + - description: Armada 380 SoC + items: + - const: marvell,armada380 + + - description: Armada 385 SoC + items: + - const: marvell,armada385 + - const: marvell,armada380Quoted 8 lines
Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml line 31
Quoted 6 lines
Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml new file +6
-0+ + - description: Armada 388 SoC + items: + - const: marvell,armada388 + - const: marvell,armada385 + - const: marvell,armada380These should not be used alone, so such schema is not what we want. We want boards to be documented with these SoCs.
Quoted 7 lines
There is only one Marvell example for armada-8k:
Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yamlI mirrored how that conversion had been done from text to yaml. If only boards belong in the yaml, then the conversion from txt will create an empty file,
to which I could then add specific boards on top.
Marvell is a mess, someone should really take care about these files...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v2 1/8] dt-bindings: marvell: a38x: convert the soc compatibles description to yaml
Am 24.12.23 um 16:52 schrieb Krzysztof Kozlowski:
Quoted 26 lines · Josua Mayer
Quoted 25 lines
Am 24.12.23 um 15:57 schrieb Krzysztof Kozlowski:
Quoted 10 lines · Josua Mayer
Quoted 4 lines
Convert the existing txt binding for armada-38x socs to DT schema format.
Signed-off-by Josua Mayer <[email protected]>Please use
scripts/get_maintainers.plto get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.Quoted 6 lines
You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
I am sorry ...
I will verify whatget_maintainerssaid ...https://www.kernel.org/doc/html/latest/process/submitting-patches.html#select-the-recipients-for-your-patch
I got confused from this guide - what to do when it tells me 3 or more lists.
Should I take the most specific one? Or all of them? I.e.:
Quoted 7 lines
Quoted 5 lines
[email protected] (moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...) [email protected] (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
[email protected] (open list)The same what b4 and all scripts are doing: all lists. Why even bothering in selective remove of people or lists?
Understood, thank you.
Quoted 27 lines
Quoted 27 lines
Quoted 16 lines
Quoted 16 lines
Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml new file +15
-0+ +properties: + $nodename: + const: '/' + compatible: + oneOf: + + - description: Armada 380 SoC + items: + - const: marvell,armada380 + + - description: Armada 385 SoC + items: + - const: marvell,armada385 + - const: marvell,armada380Quoted 8 lines
Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml line 31
Quoted 6 lines
Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml new file +6
-0+ + - description: Armada 388 SoC + items: + - const: marvell,armada388 + - const: marvell,armada385 + - const: marvell,armada380These should not be used alone, so such schema is not what we want. We want boards to be documented with these SoCs.
There is only one Marvell example for armada-8k:
Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
Quoted 6 lines
Quoted 4 lines
I mirrored how that conversion had been done from text to yaml. If only boards belong in the yaml, then the conversion from txt will create an empty file,
to which I could then add specific boards on top.Marvell is a mess, someone should really take care about these files...
Okay ... so better to re-open discussion once I submit properly?
Quoted 4 lines
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel