x86/vdso: shrink vdso/vdso32-setup.i via IWYU
Subsystems (3)
PATCH 1/1 x86/vdso: shrink vdso/vdso32-setup.i via IWYU
This diff uses an open source tool include-what-you-use (IWYU) to modify the include list, changing indirect includes to direct includes. IWYU is implemented using the IWYUScripts github repository which is a tool that is currently undergoing development. These changes seek to improve build times.
This change to vdso/vdso32-setup.c resulted in a preprocessed size of vdso/vdso32-setup.i from 44009 lines to 18572 lines (-58%) for the x86 defconfig.
---
--- arch/x86/entry/vdso/vdso32-setup.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
arch/x86/entry/vdso/vdso32-setup.c +4 -6
@@ -8,13 +8,11 @@*/ #include <linux/init.h> -#include <linux/smp.h> -#include <linux/kernel.h> -#include <linux/mm_types.h> -#include <linux/elf.h> +#include <linux/kstrtox.h> +#include <linux/printk.h> +#include <linux/stddef.h> -#include <asm/processor.h> -#include <asm/vdso.h> +#include <asm/cache.h> #ifdef CONFIG_COMPAT_VDSO #define VDSO_DEFAULT 0
---
base-commit: f5837722ffecbbedf1b1dbab072a063565f0dad1
change-id: 20231228-vdso32setup-8e336d60ac3e
Best regards,
Signature · 1 line
Tanzir Hasan <[email protected]>
Quoted 7 lines · Tanzir Hasan
This diff uses an open source tool include-what-you-use (IWYU) to modify the include list, changing indirect includes to direct includes. IWYU is implemented using the IWYUScripts github repository which is a tool that is currently undergoing development. These changes seek to improve build times.
Quoted 8 lines
This change to
vdso/vdso32-setup.cresulted in a preprocessed size of vdso/vdso32-setup.i from 44009 lines to 18572 lines (-58%) for the x86 defconfig.---
Signed-off-by Tanzir Hasan <[email protected]>
^ Your signed off by tag is "below the fold" (---), so it will not be retained when applied. (Bad)
If you're using b4 to send patches, let's triple check whether you're putting your SOB on the "meta" commit (probably what's going wrong) as opposed to the commit itself (good). Why don't you check that and then send me a v2 privately, so I can help you check?
Quoted 35 lines
--- arch/x86/entry/vdso/vdso32-setup.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)arch/x86/entry/vdso/vdso32-setup.c +4
-7@@ -8,13 +8,11 @@*/ #include <linux/init.h> -#include <linux/smp.h> -#include <linux/kernel.h> -#include <linux/mm_types.h> -#include <linux/elf.h> +#include <linux/kstrtox.h> +#include <linux/printk.h> +#include <linux/stddef.h> -#include <asm/processor.h> -#include <asm/vdso.h> +#include <asm/cache.h> #ifdef CONFIG_COMPAT_VDSO #define VDSO_DEFAULT 0 ---base-commit:
f5837722ffecbbedf1b1dbab072a063565f0dad1
change-id: 20231228-vdso32setup-8e336d60ac3eBest regards,
--
Tanzir Hasan <[email protected]>
Signature · 2 lines
Thanks, ~Nick Desaulniers