Add phyBOARD-Segin-i.MX93 support

PATCH Superseded Mathieu Othacehe 4 participants 8 messages Jan 19, 2024 – Jan 22, 2024

Subsystems (2)

Device tree bindings Arm i.MX and Layerscape

lore

Share & tools

lore

Mathieu Othacehe

author

2024-01-19 09:28 UTC #0 lore raw

v3 cover Add phyBOARD-Segin-i.MX93 support

Hello,

This adds support for the phyBOARD-Segin-i.MX93 board.

Thanks,

Signed-off-by Mathieu Othacehe <[email protected]>

---
Changes in v3:
- Update documentation to match PHYTEC naming
- Remove useless properties
- Update pinmux from PHYTEC downstream kernel
Changes in v2:
- Remove useless line
- Add missing reserved-memory entries

v2: https://lore.kernel.org/linux-devicetree/[email protected]/

Mathieu Othacehe (2):
dt-bindings: arm: fsl: Add phyBOARD-Segin-i.MX93
arm64: dts: imx93: Add phyBOARD-Segin-i.MX93 support

 .../devicetree/bindings/arm/fsl.yaml          |   6 +
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../dts/freescale/imx93-phyboard-segin.dts    | 119 ++++++++++++++++++
 .../boot/dts/freescale/imx93-phycore-som.dtsi |  56 +++++++++
 4 files changed, 182 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts
 create mode 100644 arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi

Signature · 1 line

2.41.0

Mathieu Othacehe

author

2024-01-19 09:28 UTC #1 lore raw

PATCH v3 1/2 dt-bindings: arm: fsl: Add phyBOARD-Segin-i.MX93

Add support for phyBOARD-Segin-i.MX93 board.

Signed-off-by Mathieu Othacehe <[email protected]>

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Documentation/devicetree/bindings/arm/fsl.yaml +6 -0

index 228dcc5c7d6f..b6c523d02d29 100644
@@ -1275,6 +1275,12 @@ properties:
           - const: tq,imx93-tqma9352        # TQ-Systems GmbH i.MX93 TQMa93xxCA/LA SOM
           - const: fsl,imx93
 
+      - description: PHYTEC phyCORE-i.MX93 SoM based boards
+        items:
+          - const: phytec,imx93-phyboard-segin # phyBOARD-Segin with i.MX93
+          - const: phytec,imx93-phycore-som    # phyCORE-i.MX93 SoM
+          - const: fsl,imx93
+
       - description:
           Freescale Vybrid Platform Device Tree Bindings

Signature · 1 line

2.41.0

Conor Dooley

Acked-by on v3 1/2

2024-01-19 16:35 UTC #2 lore raw

Re: [PATCH v3 1/2] dt-bindings: arm: fsl: Add phyBOARD-Segin-i.MX93

Quoted 3 lines · Mathieu Othacehe

Add support for phyBOARD-Segin-i.MX93 board.
Signed-off-by Mathieu Othacehe <[email protected]>

Acked-by Conor Dooley <[email protected]>

Cheers,
Conor.

Quoted 24 lines

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Documentation/devicetree/bindings/arm/fsl.yaml +6 -0

index 228dcc5c7d6f..b6c523d02d29 100644
@@ -1275,6 +1275,12 @@ properties:
           - const: tq,imx93-tqma9352        # TQ-Systems GmbH i.MX93 TQMa93xxCA/LA SOM
           - const: fsl,imx93
 
+      - description: PHYTEC phyCORE-i.MX93 SoM based boards
+        items:
+          - const: phytec,imx93-phyboard-segin # phyBOARD-Segin with i.MX93
+          - const: phytec,imx93-phycore-som    # phyCORE-i.MX93 SoM
+          - const: fsl,imx93
+
       - description:
           Freescale Vybrid Platform Device Tree Bindings

Signature · 1 line

2.41.0

Mathieu Othacehe

author

2024-01-19 09:28 UTC #3 lore raw

PATCH v3 2/2 arm64: dts: imx93: Add phyBOARD-Segin-i.MX93 support

In reply to Mathieu Othacehe

Add basic support for phyBOARD-Segin-i.MX93.
Main features are:
* SD-Card
* UART
* I2C
* eMMC

Signed-off-by Mathieu Othacehe <[email protected]>

---
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../dts/freescale/imx93-phyboard-segin.dts    | 119 ++++++++++++++++++
 .../boot/dts/freescale/imx93-phycore-som.dtsi |  56 +++++++++
 3 files changed, 176 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts
 create mode 100644 arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi

arch/arm64/boot/dts/freescale/Makefile +1 -0

index 2e027675d7bb..65db918c821c 100644
@@ -201,6 +201,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8qxp-colibri-iris-v2.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8qxp-mek.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8ulp-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-evk.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-segin.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxca.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxla.dtb

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts new file +119 -0

119 lines not on this page · raw message

arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi new file +56 -0

56 lines not on this page · raw message

Signature · 1 line

2.41.0

Stefan Wahren

2024-01-19 10:12 UTC #4 lore raw

Re: [PATCH v3 2/2] arm64: dts: imx93: Add phyBOARD-Segin-i.MX93 support

Hi Mathieu,

[dropped [email protected] because of unavailability]

Am 19.01.24 um 10:28 schrieb Mathieu Othacehe:

Quoted 76 lines

Add basic support for phyBOARD-Segin-i.MX93.
Main features are:
* SD-Card
* UART
* I2C
* eMMC

Signed-off-by Mathieu Othacehe <[email protected]>

---
  arch/arm64/boot/dts/freescale/Makefile        |   1 +
  .../dts/freescale/imx93-phyboard-segin.dts    | 119 ++++++++++++++++++
  .../boot/dts/freescale/imx93-phycore-som.dtsi |  56 +++++++++
  3 files changed, 176 insertions(+)

create mode 100644 arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts create mode 100644 arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi

arch/arm64/boot/dts/freescale/Makefile +1 -0

index 2e027675d7bb..65db918c821c 100644
@@ -201,6 +201,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8qxp-colibri-iris-v2.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx8qxp-mek.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx8ulp-evk.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-evk.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-segin.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxca.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxla.dtb

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts new file +42 -0

new file mode 100644
index 000000000000..b256c5e42550
@@ -0,0 +1,119 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2023 PHYTEC Messtechnik GmbH
+ * Christoph Stoidner <[email protected]>
+ * Copyright (C) 2024 Mathieu Othacehe <[email protected]>
+ *
+ */
+/dts-v1/;
+
+#include "imx93-phycore-som.dtsi"
+
+/{
+	model = "PHYTEC phyBOARD-Segin-i.MX93";
+	compatible = "phytec,imx93-phyboard-segin", "phytec,imx93-phycore-som",
+		     "fsl,imx93";
+
+	chosen {
+		stdout-path = &lpuart1;
+	};
+
+	reg_usdhc2_vmmc: regulator-usdhc2 {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio3 7 GPIO_ACTIVE_HIGH>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_reg_usdhc2_vmmc>;
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-name = "VSD_3V3";
+	};
+};
+
+/* Console */
+&lpuart1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart1>;
+	status = "okay";
+};
+
+/* eMMC */
+&usdhc1 {
+	no-1-8-v;

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts line 52

Quoted 10 lines

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts new file +10 -0

+};
+
+/* SD-Card */
+&usdhc2 {
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc2_default>, <&pinctrl_usdhc2_cd>;
+	pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_cd>;
+	pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_cd>;
+	bus-width = <4>;
+	cd-gpios = <&gpio3 00 GPIO_ACTIVE_LOW>;

just a nit:

s/00/0/

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts line 58

Quoted 7 lines

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts new file +6 -0
+	no-mmc;
+	no-sdio;
+	vmmc-supply = <&reg_usdhc2_vmmc>;
+	status = "okay";
+};
+

According to the documentation there are GPIOs accessible. Those on the expansion header X16 could be named via gpio-line-name this makes it easier to access via libgpiod. Also there seems to be LEDs and switches on the phyBOARD.

Best regards

Mathieu Othacehe

author

2024-01-22 09:39 UTC #5 lore raw

Re: [PATCH v3 2/2] arm64: dts: imx93: Add phyBOARD-Segin-i.MX93 support

Hello Stefan,

Quoted 4 lines

According to the documentation there are GPIOs accessible. Those on the expansion header X16 could be named via gpio-line-name this makes it easier to access via libgpiod. Also there seems to be LEDs and switches on the phyBOARD.

I will add gpio-line-name for the two accessible GPIOs on X16 that are not mapped to specific functions. I will also add the heartbeat LED that is located on the SoM. Regarding the two switches on the phyBOARD, they reset the CPU and the board so I am not sure that they can have an entry in the device tree.

Thanks,

Mathieu

Wadim Egorov

2024-01-22 02:42 UTC #6 lore raw

Re: [PATCH v3 2/2] arm64: dts: imx93: Add phyBOARD-Segin-i.MX93 support

In reply to Mathieu Othacehe

Hi,

Am 19.01.24 um 10:28 schrieb Mathieu Othacehe:

Quoted 5 lines

Add basic support for phyBOARD-Segin-i.MX93.
Main features are:
* SD-Card
* UART
* I2C

It seems you did not configured any I2C bus/device. So maybe drop it from the currently supported feature list?

Quoted 29 lines

* eMMC

Signed-off-by Mathieu Othacehe <[email protected]>

---
  arch/arm64/boot/dts/freescale/Makefile        |   1 +
  .../dts/freescale/imx93-phyboard-segin.dts    | 119 ++++++++++++++++++
  .../boot/dts/freescale/imx93-phycore-som.dtsi |  56 +++++++++
  3 files changed, 176 insertions(+)

create mode 100644 arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts create mode 100644 arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi

arch/arm64/boot/dts/freescale/Makefile +1 -0

index 2e027675d7bb..65db918c821c 100644
@@ -201,6 +201,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8qxp-colibri-iris-v2.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx8qxp-mek.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx8ulp-evk.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-evk.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-segin.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxca.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxla.dtb

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts new file +0 -0

new file mode 100644
index 000000000000..b256c5e42550

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts line 4

Quoted 4 lines

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts new file +4 -0

@@ -0,0 +1,119 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2023 PHYTEC Messtechnik GmbH
+ * Christoph Stoidner <[email protected]>

you dropped me from the Authors list :(

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts line 6

Quoted 2 lines

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts new file +2 -0
+ * Copyright (C) 2024 Mathieu Othacehe <[email protected]>
+ *

It would be nice if you could link the product page,
https://www.phytec.de/produkte/system-on-modules/phycore-imx-91-93/

Quoted 13 lines

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts new file +13 -0

+ */
+/dts-v1/;
+
+#include "imx93-phycore-som.dtsi"
+
+/{
+	model = "PHYTEC phyBOARD-Segin-i.MX93";
+	compatible = "phytec,imx93-phyboard-segin", "phytec,imx93-phycore-som",
+		     "fsl,imx93";
+
+	chosen {
+		stdout-path = &lpuart1;
+	};

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts line 29

Quoted 10 lines

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts new file +10 -0

+
+	reg_usdhc2_vmmc: regulator-usdhc2 {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio3 7 GPIO_ACTIVE_HIGH>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_reg_usdhc2_vmmc>;
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-name = "VSD_3V3";

Regulator name is VCC_SD

Quoted 23 lines

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts new file +23 -0

+	};
+};
+
+/* Console */
+&lpuart1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart1>;
+	status = "okay";
+};
+
+/* eMMC */
+&usdhc1 {
+	no-1-8-v;
+};
+
+/* SD-Card */
+&usdhc2 {
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc2_default>, <&pinctrl_usdhc2_cd>;
+	pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_cd>;
+	pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_cd>;
+	bus-width = <4>;
+	cd-gpios = <&gpio3 00 GPIO_ACTIVE_LOW>;

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts line 62

Quoted 10 lines

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts new file +10 -0
+	no-mmc;
+	no-sdio;
+	vmmc-supply = <&reg_usdhc2_vmmc>;
+	status = "okay";
+};
+
+/* Watchdog */
+&wdog3 {
+	status = "okay";
+};

Move the watchdog part to the SoM device tree as it not related to the carrier board design.

Quoted 63 lines

arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts new file +57 -0

+
+&iomuxc {
+	pinctrl_uart1: uart1grp {
+		fsl,pins = <
+			MX93_PAD_UART1_RXD__LPUART1_RX		0x31e
+			MX93_PAD_UART1_TXD__LPUART1_TX		0x30e
+		>;
+	};
+
+	pinctrl_reg_usdhc2_vmmc: regusdhc2vmmcgrp {
+		fsl,pins = <
+			MX93_PAD_SD2_RESET_B__GPIO3_IO07	0x31e
+		>;
+	};
+
+	pinctrl_usdhc2_cd: usdhc2cdgrp {
+		fsl,pins = <
+			MX93_PAD_SD2_CD_B__GPIO3_IO00		0x31e
+		>;
+	};
+
+	pinctrl_usdhc2_default: usdhc2grp {
+		fsl,pins = <
+			MX93_PAD_SD2_CLK__USDHC2_CLK		0x179e
+			MX93_PAD_SD2_CMD__USDHC2_CMD		0x139e
+			MX93_PAD_SD2_DATA0__USDHC2_DATA0	0x138e
+			MX93_PAD_SD2_DATA1__USDHC2_DATA1	0x138e
+			MX93_PAD_SD2_DATA2__USDHC2_DATA2	0x138e
+			MX93_PAD_SD2_DATA3__USDHC2_DATA3	0x139e
+			MX93_PAD_SD2_VSELECT__USDHC2_VSELECT	0x51e
+		>;
+	};
+
+	pinctrl_usdhc2_100mhz: usdhc2grp {
+		fsl,pins = <
+			MX93_PAD_SD2_CLK__USDHC2_CLK            0x179e
+			MX93_PAD_SD2_CMD__USDHC2_CMD            0x139e
+			MX93_PAD_SD2_DATA0__USDHC2_DATA0        0x138e
+			MX93_PAD_SD2_DATA1__USDHC2_DATA1        0x138e
+			MX93_PAD_SD2_DATA2__USDHC2_DATA2        0x139e
+			MX93_PAD_SD2_DATA3__USDHC2_DATA3        0x139e
+			MX93_PAD_SD2_VSELECT__USDHC2_VSELECT    0x51e
+		>;
+	};
+
+	pinctrl_usdhc2_200mhz: usdhc2grp {
+		fsl,pins = <
+			MX93_PAD_SD2_CLK__USDHC2_CLK            0x178e
+			MX93_PAD_SD2_CMD__USDHC2_CMD            0x139e
+			MX93_PAD_SD2_DATA0__USDHC2_DATA0        0x139e
+			MX93_PAD_SD2_DATA1__USDHC2_DATA1        0x139e
+			MX93_PAD_SD2_DATA2__USDHC2_DATA2        0x139e
+			MX93_PAD_SD2_DATA3__USDHC2_DATA3        0x139e
+			MX93_PAD_SD2_VSELECT__USDHC2_VSELECT    0x51e
+		>;
+	};
+};

arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi new file +0 -0

new file mode 100644
index 000000000000..0cc156b3c24e

arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi line 4

Quoted 4 lines

arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi new file +4 -0

@@ -0,0 +1,56 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2023 PHYTEC Messtechnik GmbH
+ * Christoph Stoidner <[email protected]>

Same here, you dropped me from the Authors list :(

arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi line 8

Quoted 4 lines

arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi new file +4 -0
+ * Copyright (C) 2024 Mathieu Othacehe <[email protected]>
+ *
+ */
+/dts-v1/;

I don't think you need the dts-v1 here as this file gets included by carrier boards that already defining it.

Regards,
Wadim

Quoted 48 lines

arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi new file +48 -0

+
+#include "imx93.dtsi"
+
+/{
+	model = "PHYTEC phyCORE-i.MX93";
+	compatible = "phytec,imx93-phycore-som", "fsl,imx93";
+
+	reserved-memory {
+		ranges;
+		#address-cells = <2>;
+		#size-cells = <2>;
+
+		linux,cma {
+			compatible = "shared-dma-pool";
+			reusable;
+			alloc-ranges = <0 0x80000000 0 0x40000000>;
+			size = <0 0x10000000>;
+			linux,cma-default;
+		};
+	};
+};
+
+/* eMMC */
+&usdhc1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usdhc1>;
+	bus-width = <8>;
+	non-removable;
+	status = "okay";
+};
+
+&iomuxc {
+	pinctrl_usdhc1: usdhc1grp {
+		fsl,pins = <
+			MX93_PAD_SD1_CLK__USDHC1_CLK		0x179e
+			MX93_PAD_SD1_CMD__USDHC1_CMD		0x1386
+			MX93_PAD_SD1_DATA0__USDHC1_DATA0	0x138e
+			MX93_PAD_SD1_DATA1__USDHC1_DATA1	0x1386
+			MX93_PAD_SD1_DATA2__USDHC1_DATA2	0x138e
+			MX93_PAD_SD1_DATA3__USDHC1_DATA3	0x1386
+			MX93_PAD_SD1_DATA4__USDHC1_DATA4	0x1386
+			MX93_PAD_SD1_DATA5__USDHC1_DATA5	0x1386
+			MX93_PAD_SD1_DATA6__USDHC1_DATA6	0x1386
+			MX93_PAD_SD1_DATA7__USDHC1_DATA7	0x1386
+			MX93_PAD_SD1_STROBE__USDHC1_STROBE	0x179e
+		>;
+	};
+};

Mathieu Othacehe

author

2024-01-22 07:44 UTC #7 lore raw

Re: [PATCH v3 2/2] arm64: dts: imx93: Add phyBOARD-Segin-i.MX93 support

Hello,

Quoted 4 lines

Quoted 2 lines
+ * Copyright (C) 2023 PHYTEC Messtechnik GmbH
+ * Christoph Stoidner <[email protected]>
you dropped me from the Authors list :(

I must have used an old downstream device tree without your name in the Authors list, sorry about that.

Took your remarks into account.

Thanks,

Mathieu