Skip to contentSkip to conversation

staging: Remove EMMA Mobile USB Gadget and board staging support

PATCH In review Geert Uytterhoeven 3 participants 8 messages Jan 22, 2024 – Jan 24, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover staging: Remove EMMA Mobile USB Gadget and board staging support

Hi Greg,

Board staging was introduced to host temporarily legacy board support for platforms that are under active conversion to DT. Currently it hosts:
1. USB Gadget support for the Kyoto Microcomputer Co. KZM-A9-Dual (KZM9D) development board,
2. Display support for the Atmark Techno Armadillo-800-EVA development board.

During the last few years, the KZM9D development board didn't receive much love. Also, no one really cared about the EMMA Mobile USB Gadget driver, which is also hosted under staging. Recently, the SH-Mobile LCDC DRM driver and Armadillo-800-EVA display support have been converted to DT.

Hence this patch series removes all board staging support, together with the now unused EMMA Mobile USB Gadget driver.

Changes compared to v1:
- Drop RFC, widen audience,
- Drop EMMA Mobile EV2 clkdev registration patch (merged),
- Add Acked-by,
- Remove Armadillo-800-EVA and core board staging code, too.

Thanks!

[1] "[PATCH/RFC 0/3] Remove KZM9D board staging support"

    https://lore.kernel.org/all/[email protected]/

Geert Uytterhoeven (4):
staging: emxx_udc: Remove EMMA Mobile USB Gadget driver
staging: board: Remove KZM9D board staging code
staging: board: Remove Armadillo-800-EVA board staging code
staging: Remove board staging code

 drivers/staging/Kconfig                 |    4 -
 drivers/staging/Makefile                |    2 -
 drivers/staging/board/Kconfig           |   12 -
 drivers/staging/board/Makefile          |    4 -
 drivers/staging/board/TODO              |    2 -
 drivers/staging/board/armadillo800eva.c |   88 -
 drivers/staging/board/board.c           |  204 --
 drivers/staging/board/board.h           |   46 -
 drivers/staging/board/kzm9d.c           |   26 -
 drivers/staging/emxx_udc/Kconfig        |   11 -
 drivers/staging/emxx_udc/Makefile       |    2 -
 drivers/staging/emxx_udc/TODO           |    6 -
 drivers/staging/emxx_udc/emxx_udc.c     | 3223 -----------------------
 drivers/staging/emxx_udc/emxx_udc.h     |  554 ----
 14 files changed, 4184 deletions(-)
 delete mode 100644 drivers/staging/board/Kconfig
 delete mode 100644 drivers/staging/board/Makefile
 delete mode 100644 drivers/staging/board/TODO
 delete mode 100644 drivers/staging/board/armadillo800eva.c
 delete mode 100644 drivers/staging/board/board.c
 delete mode 100644 drivers/staging/board/board.h
 delete mode 100644 drivers/staging/board/kzm9d.c
 delete mode 100644 drivers/staging/emxx_udc/Kconfig
 delete mode 100644 drivers/staging/emxx_udc/Makefile
 delete mode 100644 drivers/staging/emxx_udc/TODO
 delete mode 100644 drivers/staging/emxx_udc/emxx_udc.c
 delete mode 100644 drivers/staging/emxx_udc/emxx_udc.h
Signature · 12 lines
2.34.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
#1 lore raw

PATCH v2 1/4 staging: emxx_udc: Remove EMMA Mobile USB Gadget driver

No one stepped up to complete the EMMA Mobile USB Gadget driver, bring it up to non-staging standards, and convert it to device tree.

---
v2:
- Add Acked-by.

---
 drivers/staging/Kconfig             |    2 -
 drivers/staging/Makefile            |    1 -
 drivers/staging/emxx_udc/Kconfig    |   11 -
 drivers/staging/emxx_udc/Makefile   |    2 -
 drivers/staging/emxx_udc/TODO       |    6 -
 drivers/staging/emxx_udc/emxx_udc.c | 3223 ---------------------------
 drivers/staging/emxx_udc/emxx_udc.h |  554 -----
 7 files changed, 3799 deletions(-)
 delete mode 100644 drivers/staging/emxx_udc/Kconfig
 delete mode 100644 drivers/staging/emxx_udc/Makefile
 delete mode 100644 drivers/staging/emxx_udc/TODO
 delete mode 100644 drivers/staging/emxx_udc/emxx_udc.c
 delete mode 100644 drivers/staging/emxx_udc/emxx_udc.h
drivers/staging/Kconfig +0 -2
index 784b9f673ead0c55..b8f777036bb22fe5 100644
@@ -46,8 +46,6 @@ source "drivers/staging/iio/Kconfig"
 
 source "drivers/staging/sm750fb/Kconfig"
 
-source "drivers/staging/emxx_udc/Kconfig"
-
 source "drivers/staging/nvec/Kconfig"
 
 source "drivers/staging/media/Kconfig"
drivers/staging/Makefile +0 -1
index 2ea99c7b05d978aa..5bf357782d8377c5 100644
@@ -14,7 +14,6 @@ obj-$(CONFIG_VT6656)		+= vt6656/
 obj-$(CONFIG_VME_BUS)		+= vme_user/
 obj-$(CONFIG_IIO)		+= iio/
 obj-$(CONFIG_FB_SM750)		+= sm750fb/
-obj-$(CONFIG_USB_EMXX)		+= emxx_udc/
 obj-$(CONFIG_MFD_NVEC)		+= nvec/
 obj-$(CONFIG_STAGING_BOARD)	+= board/
 obj-$(CONFIG_LTE_GDM724X)	+= gdm724x/
drivers/staging/emxx_udc/Kconfig deleted +0 -11
deleted file mode 100644
index e7a95b3b6a2f742a..0000000000000000
@@ -1,11 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-config USB_EMXX
-	tristate "EMXX USB Function Device Controller"
-	depends on USB_GADGET && (ARCH_RENESAS || COMPILE_TEST)
-	help
-	   The Emma Mobile series of SoCs from Renesas Electronics and
-	   former NEC Electronics include USB Function hardware.
-
-	   Say "y" to link the driver statically, or "m" to build a
-	   dynamically linked module called "emxx_udc" and force all
-	   gadget drivers to also be dynamically linked.
drivers/staging/emxx_udc/Makefile deleted +0 -2
deleted file mode 100644
index 569c5e9a9baeff06..0000000000000000
@@ -1,2 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-obj-$(CONFIG_USB_EMXX)	:= emxx_udc.o
drivers/staging/emxx_udc/TODO deleted +0 -6
deleted file mode 100644
index 471529a470c706bf..0000000000000000
@@ -1,6 +0,0 @@
-* add clock framework support (platform device with CCF needs special care)
-* break out board-specific VBUS GPIO to work with multiplatform
-* convert VBUS GPIO to use GPIO descriptors from <linux/gpio/consumer.h>
-  and stop using the old GPIO API
-* DT bindings
-* move driver into drivers/usb/gadget/
drivers/staging/emxx_udc/emxx_udc.c deleted +0 -3223

2,966 lines not on this page · raw message

drivers/staging/emxx_udc/emxx_udc.h deleted +0 -554

554 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.34.1

Part of the diff is not shown here. View the raw message.

#2 lore raw

PATCH v2 2/4 staging: board: Remove KZM9D board staging code

In reply to Geert Uytterhoeven

With the EMMA Mobile USB Gadget staging driver removed, there is no longer any use for the EMEV2 KZM9D board staging code.

---
v2:
- Add Acked-by.

---
 drivers/staging/board/Makefile |  1 -
 drivers/staging/board/kzm9d.c  | 26 --------------------------
 2 files changed, 27 deletions(-)
 delete mode 100644 drivers/staging/board/kzm9d.c
drivers/staging/board/Makefile +0 -1
index ed7839752e129abb..5db091b5ca01596a 100644
@@ -1,4 +1,3 @@
 # SPDX-License-Identifier: GPL-2.0
 obj-y	:= board.o
-obj-$(CONFIG_ARCH_EMEV2)	+= kzm9d.o
 obj-$(CONFIG_ARCH_R8A7740)	+= armadillo800eva.o
drivers/staging/board/kzm9d.c deleted +0 -26
deleted file mode 100644
index d449a837414e6934..0000000000000000
@@ -1,26 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/* Staging board support for KZM9D. Enable not-yet-DT-capable devices here. */
-
-#include <linux/kernel.h>
-#include <linux/platform_device.h>
-#include "board.h"
-
-static struct resource usbs1_res[] __initdata = {
-	DEFINE_RES_MEM(0xe2800000, 0x2000),
-	DEFINE_RES_IRQ(159),
-};
-
-static void __init kzm9d_init(void)
-{
-	board_staging_gic_setup_xlate("arm,pl390", 32);
-
-	if (!board_staging_dt_node_available(usbs1_res,
-					     ARRAY_SIZE(usbs1_res))) {
-		board_staging_gic_fixup_resources(usbs1_res,
-						  ARRAY_SIZE(usbs1_res));
-		platform_device_register_simple("emxx_udc", -1, usbs1_res,
-						ARRAY_SIZE(usbs1_res));
-	}
-}
-
-board_staging("renesas,kzm9d", kzm9d_init);
Signature · 1 line
2.34.1
#3 lore raw

PATCH v2 3/4 staging: board: Remove Armadillo-800-EVA board staging code

In reply to Geert Uytterhoeven

Since commits 1399ebacbf590dfb ("drm: renesas: shmobile: Add DT support"), 138588e9fa237f97 ("ARM: dts: renesas: r8a7740: Add LCDC nodes"), and c9a0ed13382660c9 ("ARM: dts: renesas: armadillo800eva: Add LCD panel"), there is no longer any use for the Atmark Techno Armadillo-800-EVA board staging code.

---
v2:
- New.

---
 drivers/staging/board/Makefile          |  1 -
 drivers/staging/board/armadillo800eva.c | 88 -------------------------
 2 files changed, 89 deletions(-)
 delete mode 100644 drivers/staging/board/armadillo800eva.c
drivers/staging/board/Makefile +0 -1
index 5db091b5ca01596a..b6a00c93c2cc10dd 100644
@@ -1,3 +1,2 @@
 # SPDX-License-Identifier: GPL-2.0
 obj-y	:= board.o
-obj-$(CONFIG_ARCH_R8A7740)	+= armadillo800eva.o
drivers/staging/board/armadillo800eva.c deleted +0 -88

88 lines not on this page · raw message

Signature · 1 line
2.34.1
Acked-by on v2 3/4
#4 lore raw

Re: [PATCH v2 3/4] staging: board: Remove Armadillo-800-EVA board staging code

Quoted 10 lines · Geert Uytterhoeven

Since commits 1399ebacbf590dfb ("drm: renesas: shmobile: Add DT support"), 138588e9fa237f97 ("ARM: dts: renesas: r8a7740: Add LCDC nodes"), and c9a0ed13382660c9 ("ARM: dts: renesas: armadillo800eva: Add LCD panel"), there is no longer any use for the Atmark Techno Armadillo-800-EVA board staging code.

---
v2:
- New.

Hooray! \o/

#5 lore raw

PATCH v2 4/4 staging: Remove board staging code

In reply to Geert Uytterhoeven

There are no more users of the board staging code.

---
v2:
- New.

---
 drivers/staging/Kconfig        |   2 -
 drivers/staging/Makefile       |   1 -
 drivers/staging/board/Kconfig  |  12 --
 drivers/staging/board/Makefile |   2 -
 drivers/staging/board/TODO     |   2 -
 drivers/staging/board/board.c  | 204 ---------------------------------
 drivers/staging/board/board.h  |  46 --------
 7 files changed, 269 deletions(-)
 delete mode 100644 drivers/staging/board/Kconfig
 delete mode 100644 drivers/staging/board/Makefile
 delete mode 100644 drivers/staging/board/TODO
 delete mode 100644 drivers/staging/board/board.c
 delete mode 100644 drivers/staging/board/board.h
drivers/staging/Kconfig +0 -2
index b8f777036bb22fe5..5175b1c4f1619863 100644
@@ -50,8 +50,6 @@ source "drivers/staging/nvec/Kconfig"
 
 source "drivers/staging/media/Kconfig"
 
-source "drivers/staging/board/Kconfig"
-
 source "drivers/staging/gdm724x/Kconfig"
 
 source "drivers/staging/fbtft/Kconfig"
drivers/staging/Makefile +0 -1
index 5bf357782d8377c5..67399c0ad8719cb5 100644
@@ -15,7 +15,6 @@ obj-$(CONFIG_VME_BUS)		+= vme_user/
 obj-$(CONFIG_IIO)		+= iio/
 obj-$(CONFIG_FB_SM750)		+= sm750fb/
 obj-$(CONFIG_MFD_NVEC)		+= nvec/
-obj-$(CONFIG_STAGING_BOARD)	+= board/
 obj-$(CONFIG_LTE_GDM724X)	+= gdm724x/
 obj-$(CONFIG_FB_TFT)		+= fbtft/
 obj-$(CONFIG_MOST)		+= most/
drivers/staging/board/Kconfig deleted +0 -12
deleted file mode 100644
index b49216768ef699f6..0000000000000000
@@ -1,12 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-config STAGING_BOARD
-	bool "Staging Board Support"
-	depends on OF_ADDRESS && OF_IRQ && HAVE_CLK
-	help
-	  Staging board base is to support continuous upstream
-	  in-tree development and integration of platform devices.
-
-	  Helps developers integrate devices as platform devices for
-	  device drivers that only provide platform device bindings.
-	  This in turn allows for incremental development of both
-	  hardware feature support and DT binding work in parallel.
drivers/staging/board/Makefile deleted +0 -2
deleted file mode 100644
index b6a00c93c2cc10dd..0000000000000000
@@ -1,2 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-obj-y	:= board.o
drivers/staging/board/TODO deleted +0 -2
deleted file mode 100644
index 8db70e10aa67448a..0000000000000000
@@ -1,2 +0,0 @@
-* replace platform device code with DT nodes once the driver supports DT
-* remove staging board code when no more platform devices are needed
drivers/staging/board/board.c deleted +0 -204

204 lines not on this page · raw message

drivers/staging/board/board.h deleted +0 -46

46 lines not on this page · raw message

Signature · 1 line
2.34.1
#7 lore raw
In reply to Geert Uytterhoeven
Quoted 25 lines · Geert Uytterhoeven

Hi Greg,

Board staging was introduced to host temporarily legacy board support for platforms that are under active conversion to DT. Currently it hosts:
1. USB Gadget support for the Kyoto Microcomputer Co. KZM-A9-Dual (KZM9D) development board,
2. Display support for the Atmark Techno Armadillo-800-EVA development board.

During the last few years, the KZM9D development board didn't receive much love. Also, no one really cared about the EMMA Mobile USB Gadget driver, which is also hosted under staging. Recently, the SH-Mobile LCDC DRM driver and Armadillo-800-EVA display support have been converted to DT.

Hence this patch series removes all board staging support, together with the now unused EMMA Mobile USB Gadget driver.

Changes compared to v1:
- Drop RFC, widen audience,
- Drop EMMA Mobile EV2 clkdev registration patch (merged),
- Add Acked-by,
- Remove Armadillo-800-EVA and core board staging code, too.

Quoted 4 lines

Thanks!

[1] "[PATCH/RFC 0/3] Remove KZM9D board staging support"

    https://lore.kernel.org/all/[email protected]/

Nice, thanks for this, all now queued up.

greg k-h