Skip to contentSkip to conversation

dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement

PATCH In review Stefan Eichenberger 5 participants 6 messages Jan 30, 2024 – Feb 9, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement

From: Stefan Eichenberger <[email protected]>

The peer-hub is used to model the relationship between the USB 2 and USB 3 hub. However, it is possible to only connect USB 2 without having USB 3. Therefore, the peer-hub property should not be marked as required.

---
 Documentation/devicetree/bindings/usb/microchip,usb5744.yaml | 2 --
 1 file changed, 2 deletions(-)
Documentation/devicetree/bindings/usb/microchip,usb5744.yaml +0 -2
index 6d4cfd943f58..14dbb70b08fa 100644
@@ -71,8 +71,6 @@ allOf:
         i2c-bus: false
     else:
       $ref: /schemas/usb/usb-device.yaml
-      required:
-        - peer-hub
 
 additionalProperties: false
 
Signature · 1 line
2.40.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Stefan Eichenberger

From: Stefan Eichenberger <[email protected]>

The peer-hub is used to model the relationship between the USB 2 and USB 3 hub. However, it is possible to only connect USB 2 without having USB 3. Therefore, the peer-hub property should not be marked as required.

This was noticed while adding this HUB in the DTS on a board in which USB3 is not supported. To some extent this is fix.

Quoted 1 line

Francesco

Reviewed-by on v1 1/1
#2 lore raw
In reply to Stefan Eichenberger
Quoted 16 lines · Stefan Eichenberger

From: Stefan Eichenberger <[email protected]>

The peer-hub is used to model the relationship between the USB 2 and USB 3 hub. However, it is possible to only connect USB 2 without having USB 3. Therefore, the peer-hub property should not be marked as required.

---
  Documentation/devicetree/bindings/usb/microchip,usb5744.yaml | 2 --
  1 file changed, 2 deletions(-)
Documentation/devicetree/bindings/usb/microchip,usb5744.yaml +0 -0
index 6d4cfd943f58..14dbb70b08fa 100644

Documentation/devicetree/bindings/usb/microchip,usb5744.yaml allOf: · line 76

Quoted 8 lines
Documentation/devicetree/bindings/usb/microchip,usb5744.yaml +0 -2
@@ -71,8 +71,6 @@ allOf:
          i2c-bus: false
      else:
        $ref: /schemas/usb/usb-device.yaml
-      required:
-        - peer-hub
 
  additionalProperties: false
 

Looks good.

Thanks,
Michal

Acked-by on v1 1/1
#3 lore raw
In reply to Stefan Eichenberger
Quoted 7 lines · Stefan Eichenberger

From: Stefan Eichenberger <[email protected]>

The peer-hub is used to model the relationship between the USB 2 and USB 3 hub. However, it is possible to only connect USB 2 without having USB 3. Therefore, the peer-hub property should not be marked as required.

Cheers,
Conor.

#4 lore raw
In reply to Stefan Eichenberger

Hi Greg,

Quoted 5 lines · Stefan Eichenberger

From: Stefan Eichenberger <[email protected]>

The peer-hub is used to model the relationship between the USB 2 and USB 3 hub. However, it is possible to only connect USB 2 without having USB 3. Therefore, the peer-hub property should not be marked as required.

I just wanted to ask if everything is okay with the patch and if its fine to apply it or if it needs some updates?

Regards,
Stefan

maintainer
#5 lore raw
Quoted 11 lines · Stefan Eichenberger

Hi Greg,

Quoted 5 lines · Stefan Eichenberger

From: Stefan Eichenberger <[email protected]>

The peer-hub is used to model the relationship between the USB 2 and USB 3 hub. However, it is possible to only connect USB 2 without having USB 3. Therefore, the peer-hub property should not be marked as required.

I just wanted to ask if everything is okay with the patch and if its fine to apply it or if it needs some updates?

That was only 10 days ago, please give us a chance to catch up on reviews.

In the meantime, while waiting, please review other changes on the lists, that way yours moves higher up in the queue. Any reason why you can't do that now?

thanks,

greg k-h