dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement
Subsystems (2)
PATCH 1/1 dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement
From: Stefan Eichenberger <[email protected]>
The peer-hub is used to model the relationship between the USB 2 and USB 3 hub. However, it is possible to only connect USB 2 without having USB 3. Therefore, the peer-hub property should not be marked as required.
--- Documentation/devicetree/bindings/usb/microchip,usb5744.yaml | 2 -- 1 file changed, 2 deletions(-)
Documentation/devicetree/bindings/usb/microchip,usb5744.yaml +0 -2
@@ -71,8 +71,6 @@ allOf: i2c-bus: false else: $ref: /schemas/usb/usb-device.yaml - required: - - peer-hub additionalProperties: false
Signature · 1 line
2.40.1
Quoted 5 lines · Stefan Eichenberger
From: Stefan Eichenberger <[email protected]>
The peer-hub is used to model the relationship between the USB 2 and USB 3 hub. However, it is possible to only connect USB 2 without having USB 3. Therefore, the peer-hub property should not be marked as required.
This was noticed while adding this HUB in the DTS on a board in which USB3 is not supported. To some extent this is fix.
Quoted 1 line
Signed-off-by Stefan Eichenberger <[email protected]>
Francesco
Quoted 16 lines · Stefan Eichenberger
From: Stefan Eichenberger <[email protected]>
The peer-hub is used to model the relationship between the USB 2 and USB 3 hub. However, it is possible to only connect USB 2 without having USB 3. Therefore, the peer-hub property should not be marked as required.
Signed-off-by Stefan Eichenberger <[email protected]>--- Documentation/devicetree/bindings/usb/microchip,usb5744.yaml | 2 -- 1 file changed, 2 deletions(-)Documentation/devicetree/bindings/usb/microchip,usb5744.yaml +0
-0
Documentation/devicetree/bindings/usb/microchip,usb5744.yaml allOf: · line 76
Quoted 8 lines
Documentation/devicetree/bindings/usb/microchip,usb5744.yaml +0
-2@@ -71,8 +71,6 @@ allOf: i2c-bus: false else: $ref: /schemas/usb/usb-device.yaml - required: - - peer-hub additionalProperties: false
Looks good.
Thanks,
Michal
Quoted 7 lines · Stefan Eichenberger
From: Stefan Eichenberger <[email protected]>
The peer-hub is used to model the relationship between the USB 2 and USB 3 hub. However, it is possible to only connect USB 2 without having USB 3. Therefore, the peer-hub property should not be marked as required.
Signed-off-by Stefan Eichenberger <[email protected]>
Cheers,
Conor.
Hi Greg,
Quoted 5 lines · Stefan Eichenberger
From: Stefan Eichenberger <[email protected]>
The peer-hub is used to model the relationship between the USB 2 and USB 3 hub. However, it is possible to only connect USB 2 without having USB 3. Therefore, the peer-hub property should not be marked as required.
I just wanted to ask if everything is okay with the patch and if its fine to apply it or if it needs some updates?
Regards,
Stefan
Greg KH
maintainerQuoted 11 lines · Stefan Eichenberger
Hi Greg,
Quoted 5 lines · Stefan Eichenberger
From: Stefan Eichenberger <[email protected]>
The peer-hub is used to model the relationship between the USB 2 and USB 3 hub. However, it is possible to only connect USB 2 without having USB 3. Therefore, the peer-hub property should not be marked as required.
I just wanted to ask if everything is okay with the patch and if its fine to apply it or if it needs some updates?
That was only 10 days ago, please give us a chance to catch up on reviews.
In the meantime, while waiting, please review other changes on the lists, that way yours moves higher up in the queue. Any reason why you can't do that now?
thanks,
greg k-h