dt-bindings: misc: xlnx,sd-fec: convert bindings to yaml
Dragan Cvetic
maintainerPATCH v4 1/1 dt-bindings: misc: xlnx,sd-fec: convert bindings to yaml
Convert AMD (Xilinx) sd-fec bindings to yaml format, so it can validate dt-entries as well as any future additions to yaml.
Change in clocks is due to IP is itself configurable and only the first two clocks are in all combinations. The last 6 clocks can be present in some of them. It means order is not really fixed and any combination is possible.
Interrupt may or may not be present.
The documentation for sd-fec bindings is now YAML, so update the MAINTAINERS file.
Update the link to the new yaml file in xilinx_sdfec.rst.
---
Changes in v2:
---
Drop clocks description.
Use "contains:" with enum for optional clock-names and update comment explaining diference from the original DT binding file. Remove trailing full stops.
Add more details in sdfec-code description.
Set sdfec-code to "string" not "string-array"
---
Changes in v3:
Fix a mistake in example, set interrupt type to 0.
---
Changes in v4:
Set interrupt type to high level sensitive.
Remove '|' from descriptions, no need to preserve format. Remove not needed empty line.
--- .../devicetree/bindings/misc/xlnx,sd-fec.txt | 58 -------- .../devicetree/bindings/misc/xlnx,sd-fec.yaml | 137 ++++++++++++++++++ Documentation/misc-devices/xilinx_sdfec.rst | 2 +- MAINTAINERS | 2 +- 4 files changed, 139 insertions(+), 60 deletions(-) delete mode 100644 Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt create mode 100644 Documentation/devicetree/bindings/misc/xlnx,sd-fec.yaml
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0 -58
@@ -1,58 +0,0 @@ -* Xilinx SDFEC(16nm) IP * - -The Soft Decision Forward Error Correction (SDFEC) Engine is a Hard IP block -which provides high-throughput LDPC and Turbo Code implementations. -The LDPC decode & encode functionality is capable of covering a range of -customer specified Quasi-cyclic (QC) codes. The Turbo decode functionality -principally covers codes used by LTE. The FEC Engine offers significant -power and area savings versus implementations done in the FPGA fabric. - - -Required properties: -- compatible: Must be "xlnx,sd-fec-1.1" -- clock-names : List of input clock names from the following: - - "core_clk", Main processing clock for processing core (required) - - "s_axi_aclk", AXI4-Lite memory-mapped slave interface clock (required) - - "s_axis_din_aclk", DIN AXI4-Stream Slave interface clock (optional) - - "s_axis_din_words-aclk", DIN_WORDS AXI4-Stream Slave interface clock (optional) - - "s_axis_ctrl_aclk", Control input AXI4-Stream Slave interface clock (optional) - - "m_axis_dout_aclk", DOUT AXI4-Stream Master interface clock (optional) - - "m_axis_dout_words_aclk", DOUT_WORDS AXI4-Stream Master interface clock (optional) - - "m_axis_status_aclk", Status output AXI4-Stream Master interface clock (optional) -- clocks : Clock phandles (see clock_bindings.txt for details). -- reg: Should contain Xilinx SDFEC 16nm Hardened IP block registers - location and length. -- xlnx,sdfec-code : Should contain "ldpc" or "turbo" to describe the codes - being used. -- xlnx,sdfec-din-words : A value 0 indicates that the DIN_WORDS interface is - driven with a fixed value and is not present on the device, a value of 1 - configures the DIN_WORDS to be block based, while a value of 2 configures the - DIN_WORDS input to be supplied for each AXI transaction. -- xlnx,sdfec-din-width : Configures the DIN AXI stream where a value of 1 - configures a width of "1x128b", 2 a width of "2x128b" and 4 configures a width - of "4x128b". -- xlnx,sdfec-dout-words : A value 0 indicates that the DOUT_WORDS interface is - driven with a fixed value and is not present on the device, a value of 1 - configures the DOUT_WORDS to be block based, while a value of 2 configures the - DOUT_WORDS input to be supplied for each AXI transaction. -- xlnx,sdfec-dout-width : Configures the DOUT AXI stream where a value of 1 - configures a width of "1x128b", 2 a width of "2x128b" and 4 configures a width - of "4x128b". -Optional properties: -- interrupts: should contain SDFEC interrupt number - -Example ---------------------------------------- - sd_fec_0: sd-fec@a0040000 { - compatible = "xlnx,sd-fec-1.1"; - clock-names = "core_clk","s_axi_aclk","s_axis_ctrl_aclk","s_axis_din_aclk","m_axis_status_aclk","m_axis_dout_aclk"; - clocks = <&misc_clk_2>,<&misc_clk_0>,<&misc_clk_1>,<&misc_clk_1>,<&misc_clk_1>, <&misc_clk_1>; - reg = <0x0 0xa0040000 0x0 0x40000>; - interrupt-parent = <&axi_intc>; - interrupts = <1 0>; - xlnx,sdfec-code = "ldpc"; - xlnx,sdfec-din-words = <0>; - xlnx,sdfec-din-width = <2>; - xlnx,sdfec-dout-words = <0>; - xlnx,sdfec-dout-width = <1>; - };
Documentation/devicetree/bindings/misc/xlnx,sd-fec.yaml new file +137 -0
137 lines not on this page · raw message
Documentation/misc-devices/xilinx_sdfec.rst +1 -1
@@ -29,7 +29,7 @@ follows: - Does not support shared LDPC code table wraparound The device tree entry is described in: -`linux-xlnx/Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt <https://github.com/Xilinx/linux-xlnx/blob/master/Documentation/devicetree/bindings/misc/xlnx%2Csd-fec.txt>`_ +`linux-xlnx/Documentation/devicetree/bindings/misc/xlnx,sd-fec.yaml <https://github.com/Xilinx/linux-xlnx/blob/master/Documentation/devicetree/bindings/misc/xlnx%2Csd-fec.yaml>`_ Modes of Operation
MAINTAINERS +1 -1
@@ -24157,7 +24157,7 @@ XILINX SD-FEC IP CORES M: Derek Kiernan <[email protected]> M: Dragan Cvetic <[email protected]> S: Maintained -F: Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt +F: Documentation/devicetree/bindings/misc/xlnx,sd-fec.yaml F: Documentation/misc-devices/xilinx_sdfec.rst F: drivers/misc/Kconfig F: drivers/misc/Makefile
Signature · 1 line
2.34.1
Quoted 11 lines · Dragan Cvetic
Convert AMD (Xilinx) sd-fec bindings to yaml format, so it can validate dt-entries as well as any future additions to yaml.
Change in clocks is due to IP is itself configurable and only the first two clocks are in all combinations. The last 6 clocks can be present in some of them. It means order is not really fixed and any combination is possible.
Interrupt may or may not be present.
The documentation for sd-fec bindings is now YAML, so update theMAINTAINERSfile.
Update the link to the new yaml file inxilinx_sdfec.rst.
Quoted 1 line
Signed-off-by Dragan Cvetic <[email protected]>
You need to fix your way of sending patches.
b4 diff '<[email protected]>' Grabbing thread from lore.kernel.org/all/[email protected]/t.mbox.gz Checking for older revisions
Grabbing search results from lore.kernel.org
---
Analyzing 12 messages in the thread
ERROR: Could not auto-find previous revision
Run "b4 am -T" manually, then "b4 diff -m mbx1 mbx2"
And it is the same for other versions.
---
This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.
https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
Best regards,
Krzysztof
Rob Herring
maintainerQuoted 154 lines · Dragan Cvetic
Convert AMD (Xilinx) sd-fec bindings to yaml format, so it can validate dt-entries as well as any future additions to yaml.
Change in clocks is due to IP is itself configurable and only the first two clocks are in all combinations. The last 6 clocks can be present in some of them. It means order is not really fixed and any combination is possible.
Interrupt may or may not be present.
The documentation for sd-fec bindings is now YAML, so update theMAINTAINERSfile.
Update the link to the new yaml file inxilinx_sdfec.rst.Signed-off-by Dragan Cvetic <[email protected]>---
Changes in v2:
---
Drop clocks description.
Use "contains:" with enum for optional clock-names and update comment explaining diference from the original DT binding file. Remove trailing full stops.
Add more details in sdfec-code description.
Set sdfec-code to "string" not "string-array"
---
Changes in v3:
Fix a mistake in example, set interrupt type to 0.
---
Changes in v4:
Set interrupt type to high level sensitive.
Remove '|' from descriptions, no need to preserve format. Remove not needed empty line.--- .../devicetree/bindings/misc/xlnx,sd-fec.txt | 58 -------- .../devicetree/bindings/misc/xlnx,sd-fec.yaml | 137 ++++++++++++++++++ Documentation/misc-devices/xilinx_sdfec.rst | 2 +- MAINTAINERS | 2 +- 4 files changed, 139 insertions(+), 60 deletions(-) delete mode 100644 Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt create mode 100644 Documentation/devicetree/bindings/misc/xlnx,sd-fec.yamlDocumentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0
-58@@ -1,58 +0,0 @@ -* Xilinx SDFEC(16nm) IP * - -The Soft Decision Forward Error Correction (SDFEC) Engine is a Hard IP block -which provides high-throughput LDPC and Turbo Code implementations. -The LDPC decode & encode functionality is capable of covering a range of -customer specified Quasi-cyclic (QC) codes. The Turbo decode functionality -principally covers codes used by LTE. The FEC Engine offers significant -power and area savings versus implementations done in the FPGA fabric. - - -Required properties: -- compatible: Must be "xlnx,sd-fec-1.1" -- clock-names : List of input clock names from the following: - - "core_clk", Main processing clock for processing core (required) - - "s_axi_aclk", AXI4-Lite memory-mapped slave interface clock (required) - - "s_axis_din_aclk", DIN AXI4-Stream Slave interface clock (optional) - - "s_axis_din_words-aclk", DIN_WORDS AXI4-Stream Slave interface clock (optional) - - "s_axis_ctrl_aclk", Control input AXI4-Stream Slave interface clock (optional) - - "m_axis_dout_aclk", DOUT AXI4-Stream Master interface clock (optional) - - "m_axis_dout_words_aclk", DOUT_WORDS AXI4-Stream Master interface clock (optional) - - "m_axis_status_aclk", Status output AXI4-Stream Master interface clock (optional) -- clocks : Clock phandles (see clock_bindings.txt for details). -- reg: Should contain Xilinx SDFEC 16nm Hardened IP block registers - location and length. -- xlnx,sdfec-code : Should contain "ldpc" or "turbo" to describe the codes - being used. -- xlnx,sdfec-din-words : A value 0 indicates that the DIN_WORDS interface is - driven with a fixed value and is not present on the device, a value of 1 - configures the DIN_WORDS to be block based, while a value of 2 configures the - DIN_WORDS input to be supplied for each AXI transaction. -- xlnx,sdfec-din-width : Configures the DIN AXI stream where a value of 1 - configures a width of "1x128b", 2 a width of "2x128b" and 4 configures a width - of "4x128b". -- xlnx,sdfec-dout-words : A value 0 indicates that the DOUT_WORDS interface is - driven with a fixed value and is not present on the device, a value of 1 - configures the DOUT_WORDS to be block based, while a value of 2 configures the - DOUT_WORDS input to be supplied for each AXI transaction. -- xlnx,sdfec-dout-width : Configures the DOUT AXI stream where a value of 1 - configures a width of "1x128b", 2 a width of "2x128b" and 4 configures a width - of "4x128b". -Optional properties: -- interrupts: should contain SDFEC interrupt number - -Example ---------------------------------------- - sd_fec_0: sd-fec@a0040000 { - compatible = "xlnx,sd-fec-1.1"; - clock-names = "core_clk","s_axi_aclk","s_axis_ctrl_aclk","s_axis_din_aclk","m_axis_status_aclk","m_axis_dout_aclk"; - clocks = <&misc_clk_2>,<&misc_clk_0>,<&misc_clk_1>,<&misc_clk_1>,<&misc_clk_1>, <&misc_clk_1>; - reg = <0x0 0xa0040000 0x0 0x40000>; - interrupt-parent = <&axi_intc>; - interrupts = <1 0>; - xlnx,sdfec-code = "ldpc"; - xlnx,sdfec-din-words = <0>; - xlnx,sdfec-din-width = <2>; - xlnx,sdfec-dout-words = <0>; - xlnx,sdfec-dout-width = <1>; - };Documentation/devicetree/bindings/misc/xlnx,sd-fec.yaml new file +46
-0@@ -0,0 +1,137 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/misc/xlnx,sd-fec.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Xilinx SDFEC(16nm) IP + +maintainers: + - Cvetic, Dragan <[email protected]> + - Erim, Salih <[email protected]> + +description: + The Soft Decision Forward Error Correction (SDFEC) Engine is a Hard IP block + which provides high-throughput LDPC and Turbo Code implementations. + The LDPC decode & encode functionality is capable of covering a range of + customer specified Quasi-cyclic (QC) codes. The Turbo decode functionality + principally covers codes used by LTE. The FEC Engine offers significant + power and area savings versus implementations done in the FPGA fabric. + +properties: + compatible: + const: xlnx,sd-fec-1.1 + + reg: + maxItems: 1 + + clocks: + minItems: 2 + maxItems: 8 + additionalItems: true + items: + - description: Main processing clock for processing core + - description: AXI4-Lite memory-mapped slave interface clock + - description: Control input AXI4-Stream Slave interface clock + - description: DIN AXI4-Stream Slave interface clock + - description: Status output AXI4-Stream Master interface clock + - description: DOUT AXI4-Stream Master interface clock + - description: DIN_WORDS AXI4-Stream Slave interface clock + - description: DOUT_WORDS AXI4-Stream Master interface clock + + clock-names: + minItems: 2 + maxItems: 8 + additionalItems: true + items:
Documentation/devicetree/bindings/misc/xlnx,sd-fec.yaml line 56
Quoted 10 lines
Documentation/devicetree/bindings/misc/xlnx,sd-fec.yaml new file +10
-0+ - const: core_clk + - const: s_axi_aclk + contains: + enum: + - s_axis_ctrl_aclk + - s_axis_din_aclk + - m_axis_status_aclk + - m_axis_dout_aclk + - s_axis_din_words_aclk + - m_axis_dout_words_aclk
This doesn't do what you think. It requires at least one of these clocks be present, so then at least 3 clocks. It also allows anything else to be present. You need:
allOf:
- minItems: 2
maxItems: 8
additionalItems: true
items:
- const: core_clk
- const: s_axi_aclk
- items:
enum:
- core_clk
- s_axi_aclk
- s_axis_ctrl_aclk
- s_axis_din_aclk
- m_axis_status_aclk
- m_axis_dout_aclk
- s_axis_din_words_aclk
- m_axis_dout_words_aclk
Cvetic, Dragan
maintainerHi Rob,
Quoted 215 lines
-----Original Message-----
From: Rob Herring <[email protected]>
Sent: Wednesday, January 31, 2024 2:23 PM
To: Cvetic, Dragan <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; Kiernan, Derek <[email protected]>; Jonathan Corbet <[email protected]>; Simek, Michal <[email protected]>; Erim, Salih <[email protected]>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <[email protected]>; open list <linux- [email protected]>; open list:DOCUMENTATION <linux- [email protected]>; moderated list:ARM/ZYNQ ARCHITECTURE <linux-arm- [email protected]>
Subject: Re: [PATCH v4] dt-bindings: misc: xlnx,sd-fec: convert bindings to yamlQuoted 29 lines · Dragan Cvetic
Convert AMD (Xilinx) sd-fec bindings to yaml format, so it can validate dt-entries as well as any future additions to yaml.
Change in clocks is due to IP is itself configurable and only the first two clocks are in all combinations. The last 6 clocks can be present in some of them. It means order is not really fixed and any combination is possible.
Interrupt may or may not be present.
The documentation for sd-fec bindings is now YAML, so update theMAINTAINERSfile.
Update the link to the new yaml file inxilinx_sdfec.rst.Signed-off-by Dragan Cvetic <[email protected]>---
Changes in v2:
---
Drop clocks description.
Use "contains:" with enum for optional clock-names and update comment explaining diference from the original DT binding file. Remove trailing full stops.
Add more details in sdfec-code description.
Set sdfec-code to "string" not "string-array"
---
Changes in v3:
Fix a mistake in example, set interrupt type to 0.
---
Changes in v4:
Set interrupt type to high level sensitive.
Remove '|' from descriptions, no need to preserve format. Remove not needed empty line.Quoted 7 lines
--- .../devicetree/bindings/misc/xlnx,sd-fec.txt | 58 -------- .../devicetree/bindings/misc/xlnx,sd-fec.yaml | 137 ++++++++++++++++++ Documentation/misc-devices/xilinx_sdfec.rst | 2 +- MAINTAINERS | 2 +- 4 files changed, 139 insertions(+), 60 deletions(-) delete mode 100644 Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt
Quoted 1 line
create mode 100644 Documentation/devicetree/bindings/misc/xlnx,sd-
fec.yamlReview
Quoted 2 lines
(quoted diff) +0
-0
b/Documentation/devicetree/bindings/misc/xlnx,sd-fec.txtQuoted 12 lines
deleted file mode 100644
index e3289634fa30..000000000000Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0
-7@@ -1,58 +0,0 @@ -* Xilinx SDFEC(16nm) IP * - -The Soft Decision Forward Error Correction (SDFEC) Engine is a Hard IP block -which provides high-throughput LDPC and Turbo Code implementations. -The LDPC decode & encode functionality is capable of covering a range of -customer specified Quasi-cyclic (QC) codes. The Turbo decode functionality -principally covers codes used by LTE. The FEC Engine offers significantDocumentation/devicetree/bindings/misc/xlnx,sd-fec.txt line 17
Quoted 10 lines
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0
-10-power and area savings versus implementations done in the FPGA fabric. - - -Required properties: -- compatible: Must be "xlnx,sd-fec-1.1" -- clock-names : List of input clock names from the following: - - "core_clk", Main processing clock for processing core (required) - - "s_axi_aclk", AXI4-Lite memory-mapped slave interface clock (required) - - "s_axis_din_aclk", DIN AXI4-Stream Slave interface clock (optional) - - "s_axis_din_words-aclk", DIN_WORDS AXI4-Stream Slave interface clock(optional)
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt line 18
Quoted 1 line
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0
-1- - "s_axis_ctrl_aclk", Control input AXI4-Stream Slave interface clock(optional)
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt line 19
Quoted 1 line
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0
-1- - "m_axis_dout_aclk", DOUT AXI4-Stream Master interface clock(optional)
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt line 20
Quoted 1 line
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0
-1- - "m_axis_dout_words_aclk", DOUT_WORDS AXI4-Stream Masterinterface clock (optional)
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt line 21
Quoted 1 line
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0
-1- - "m_axis_status_aclk", Status output AXI4-Stream Master interface clock(optional)
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt
Quoted 8 lines
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0
-8-- clocks : Clock phandles (see clock_bindings.txt for details). -- reg: Should contain Xilinx SDFEC 16nm Hardened IP block registers - location and length. -- xlnx,sdfec-code : Should contain "ldpc" or "turbo" to describe the codes - being used. -- xlnx,sdfec-din-words : A value 0 indicates that the DIN_WORDS interface is - driven with a fixed value and is not present on the device, a value of 1 - configures the DIN_WORDS to be block based, while a value of 2configures the
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt
Quoted 3 lines
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0
-3- DIN_WORDS input to be supplied for each AXI transaction. -- xlnx,sdfec-din-width : Configures the DIN AXI stream where a value of 1 - configures a width of "1x128b", 2 a width of "2x128b" and 4 configures awidth
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt line 34
Quoted 2 lines
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0
-2- of "4x128b". -- xlnx,sdfec-dout-words : A value 0 indicates that the DOUT_WORDSinterface is
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt line 36
Quoted 2 lines
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0
-2- driven with a fixed value and is not present on the device, a value of 1 - configures the DOUT_WORDS to be block based, while a value of 2configures the
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt line 38
Quoted 2 lines
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0
-2- DOUT_WORDS input to be supplied for each AXI transaction. -- xlnx,sdfec-dout-width : Configures the DOUT AXI stream where a value of1
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt line 39
Quoted 1 line
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0
-1- configures a width of "1x128b", 2 a width of "2x128b" and 4 configures awidth
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt
Quoted 9 lines
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0
-9- of "4x128b". -Optional properties: -- interrupts: should contain SDFEC interrupt number - -Example ---------------------------------------- - sd_fec_0: sd-fec@a0040000 { - compatible = "xlnx,sd-fec-1.1"; - clock-names ="core_clk","s_axi_aclk","s_axis_ctrl_aclk","s_axis_din_aclk","m_axis_status_acl k","m_axis_dout_aclk";
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt line 49
Quoted 1 line
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0
-1- clocks =<&misc_clk_2>,<&misc_clk_0>,<&misc_clk_1>,<&misc_clk_1>,<&misc_clk_1>, <
&misc_clk_1>;Review
Quoted 10 lines
Documentation/devicetree/bindings/misc/xlnx,sd-fec.txt deleted +0
-9- reg = <0x0 0xa0040000 0x0 0x40000>; - interrupt-parent = <&axi_intc>; - interrupts = <1 0>; - xlnx,sdfec-code = "ldpc"; - xlnx,sdfec-din-words = <0>; - xlnx,sdfec-din-width = <2>; - xlnx,sdfec-dout-words = <0>; - xlnx,sdfec-dout-width = <1>; - };(quoted diff) +0
-0
b/Documentation/devicetree/bindings/misc/xlnx,sd-fec.yamlQuoted 9 lines
new file mode 100644
index 000000000000..7be8439861a9Documentation/devicetree/bindings/misc/xlnx,sd-fec.yaml new file +4
-0@@ -0,0 +1,137 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/misc/xlnx,sd-fec.yaml#Documentation/devicetree/bindings/misc/xlnx,sd-fec.yaml line 14
Quoted 10 lines
Documentation/devicetree/bindings/misc/xlnx,sd-fec.yaml new file +10
-0+$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Xilinx SDFEC(16nm) IP + +maintainers: + - Cvetic, Dragan <[email protected]> + - Erim, Salih <[email protected]> + +description: + The Soft Decision Forward Error Correction (SDFEC) Engine is a Hard IPblock
Documentation/devicetree/bindings/misc/xlnx,sd-fec.yaml
Quoted 3 lines
Documentation/devicetree/bindings/misc/xlnx,sd-fec.yaml new file +3
-0+ which provides high-throughput LDPC and Turbo Code implementations. + The LDPC decode & encode functionality is capable of covering a range of + customer specified Quasi-cyclic (QC) codes. The Turbo decodefunctionality
Quoted 29 lines
Documentation/devicetree/bindings/misc/xlnx,sd-fec.yaml new file +29
-0+ principally covers codes used by LTE. The FEC Engine offers significant + power and area savings versus implementations done in the FPGA fabric. + +properties: + compatible: + const: xlnx,sd-fec-1.1 + + reg: + maxItems: 1 + + clocks: + minItems: 2 + maxItems: 8 + additionalItems: true + items: + - description: Main processing clock for processing core + - description: AXI4-Lite memory-mapped slave interface clock + - description: Control input AXI4-Stream Slave interface clock + - description: DIN AXI4-Stream Slave interface clock + - description: Status output AXI4-Stream Master interface clock + - description: DOUT AXI4-Stream Master interface clock + - description: DIN_WORDS AXI4-Stream Slave interface clock + - description: DOUT_WORDS AXI4-Stream Master interface clock + + clock-names: + minItems: 2 + maxItems: 8 + additionalItems: true + items:Documentation/devicetree/bindings/misc/xlnx,sd-fec.yaml line 56
Quoted 10 lines
Documentation/devicetree/bindings/misc/xlnx,sd-fec.yaml new file +10
-0+ - const: core_clk + - const: s_axi_aclk + contains: + enum: + - s_axis_ctrl_aclk + - s_axis_din_aclk + - m_axis_status_aclk + - m_axis_dout_aclk + - s_axis_din_words_aclk + - m_axis_dout_words_aclkThis doesn't do what you think. It requires at least one of these clocks be present, so then at least 3 clocks. It also allows anything else to be present. You need:
allOf:
- minItems: 2
maxItems: 8
additionalItems: true
items:
- const:core_clk
- const:s_axi_aclk
- items:
enum:
Quoted 8 lines
-
core_clk
-s_axi_aclk
-s_axis_ctrl_aclk
-s_axis_din_aclk
-m_axis_status_aclk
-m_axis_dout_aclk
-s_axis_din_words_aclk
-m_axis_dout_words_aclk
Will do it in the next patch
Kind Regards
Dragan