Skip to contentSkip to conversation

dt-bindings: trivial-devices: Add qca,spidev

PATCH Superseded Paweł Owoc 2 participants 7 messages Feb 5, 2024 – Feb 6, 2024 Device tree bindings

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 dt-bindings: trivial-devices: Add qca,spidev

Add Qualcomm QCA4024 to trivial devices.

---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
index 79dcd92c4a43..50efbdf2a735 100644
@@ -309,6 +309,8 @@ properties:
           - plx,pex8648
             # Pulsedlight LIDAR range-finding sensor
           - pulsedlight,lidar-lite-v2
+            # Qualcomm QCA4024 Multi-mode Bluetooth and 802.15.4 SoC
+          - qca,spidev
             # Renesas HS3001 Temperature and Relative Humidity Sensors
           - renesas,hs3001
             # Renesas ISL29501 time-of-flight sensor
Signature · 1 line
2.43.0
#1 lore raw
Quoted 12 lines · Paweł Owoc

Add Qualcomm QCA4024 to trivial devices.

---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/trivial-devices.yaml +0 -0
index 79dcd92c4a43..50efbdf2a735 100644

Documentation/devicetree/bindings/trivial-devices.yaml properties: · line 313

Quoted 5 lines
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
@@ -309,6 +309,8 @@ properties:
           - plx,pex8648
             # Pulsedlight LIDAR range-finding sensor
           - pulsedlight,lidar-lite-v2
+            # Qualcomm QCA4024 Multi-mode Bluetooth and 802.15.4 SoC
+          - qca,spidev

There is no such hardware as spidev and you even mentioned it is called QCA4024, not spidev. Please don't use that name but a real name.

Also, I have doubts that Bluetooth is a trivial device. Such devices need supplies, have reset/powerdown GPIOs.

Best regards,
Krzysztof

author
#2 lore raw
Quoted 9 lines · Krzysztof Kozlowski
Quoted 7 lines · Paweł Owoc

Add Qualcomm QCA4024 to trivial devices.

---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)
Quoted 14 lines

Documentation/devicetree/bindings/trivial-devices.yaml properties: · line 313

Quoted 10 lines
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
index 79dcd92c4a43..50efbdf2a735 100644
@@ -309,6 +309,8 @@ properties:
           - plx,pex8648
             # Pulsedlight LIDAR range-finding sensor
           - pulsedlight,lidar-lite-v2
+            # Qualcomm QCA4024 Multi-mode Bluetooth and 802.15.4 SoC
+          - qca,spidev

There is no such hardware as spidev and you even mentioned it is called QCA4024, not spidev. Please don't use that name but a real name.

The compatibility will be changed to "qca4024" and a new patch version will be prepared.

Quoted 6 lines

Also, I have doubts that Bluetooth is a trivial device. Such devices need supplies, have reset/powerdown GPIOs.

Best regards,
Krzysztof

#3 lore raw
Quoted 25 lines · On 06/02/2024 17:11, frut3k7 wrote:
Quoted 9 lines · Krzysztof Kozlowski
Quoted 7 lines · Paweł Owoc

Add Qualcomm QCA4024 to trivial devices.

---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)
Quoted 14 lines

Documentation/devicetree/bindings/trivial-devices.yaml properties: · line 313

Quoted 10 lines
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
index 79dcd92c4a43..50efbdf2a735 100644
@@ -309,6 +309,8 @@ properties:
           - plx,pex8648
             # Pulsedlight LIDAR range-finding sensor
           - pulsedlight,lidar-lite-v2
+            # Qualcomm QCA4024 Multi-mode Bluetooth and 802.15.4 SoC
+          - qca,spidev

There is no such hardware as spidev and you even mentioned it is called QCA4024, not spidev. Please don't use that name but a real name.

Quoted 2 lines

The compatibility will be changed to "qca4024" and a new patch version will be prepared.

That would be ok except:

Quoted 3 lines
Quoted 3 lines

Also, I have doubts that Bluetooth is a trivial device. Such devices need supplies, have reset/powerdown GPIOs.

this is not resolved. Bluetooth chips are not trivial devices. This one particular exposes several interfaces to the host, needs a clock and power supply.

Best regards,
Krzysztof

author
#4 lore raw
Quoted 33 lines · Krzysztof Kozlowski
Quoted 25 lines · On 06/02/2024 17:11, frut3k7 wrote:
Quoted 9 lines · Krzysztof Kozlowski
Quoted 7 lines · Paweł Owoc

Add Qualcomm QCA4024 to trivial devices.

---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)
Quoted 14 lines

Documentation/devicetree/bindings/trivial-devices.yaml properties: · line 313

Quoted 10 lines
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
index 79dcd92c4a43..50efbdf2a735 100644
@@ -309,6 +309,8 @@ properties:
           - plx,pex8648
             # Pulsedlight LIDAR range-finding sensor
           - pulsedlight,lidar-lite-v2
+            # Qualcomm QCA4024 Multi-mode Bluetooth and 802.15.4 SoC
+          - qca,spidev

There is no such hardware as spidev and you even mentioned it is called QCA4024, not spidev. Please don't use that name but a real name.

Quoted 2 lines

The compatibility will be changed to "qca4024" and a new patch version will be prepared.

That would be ok except:

Quoted 1 line
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines

Also, I have doubts that Bluetooth is a trivial device. Such devices need supplies, have reset/powerdown GPIOs.

this is not resolved. Bluetooth chips are not trivial devices. This one particular exposes several interfaces to the host, needs a clock and power supply.

Device is used over QUP4 SPI controller inside of IPQ8074:
https://lore.kernel.org/all/[email protected]/
I'm not sure if these pin settings should be upstreamed as they are specific to this platform:
https://github.com/openwrt/openwrt/pull/14051/files#diff-ed3fbf0226fbdc76c9c160f2f2b9e988120df472480b9861abe7a46796558115R81-R111

Quoted 3 lines

Best regards,
Krzysztof

#5 lore raw
Quoted 27 lines · On 06/02/2024 17:34, frut3k7 wrote:
Quoted 20 lines
Quoted 14 lines
Quoted 5 lines
Quoted 5 lines
Documentation/devicetree/bindings/trivial-devices.yaml +0 -0
index 79dcd92c4a43..50efbdf2a735 100644
@@ -309,6 +309,8 @@ properties:
Quoted 9 lines

Documentation/devicetree/bindings/trivial-devices.yaml properties: · line 313

Quoted 5 lines
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
           - plx,pex8648
             # Pulsedlight LIDAR range-finding sensor
           - pulsedlight,lidar-lite-v2
+            # Qualcomm QCA4024 Multi-mode Bluetooth and 802.15.4 SoC
+          - qca,spidev

There is no such hardware as spidev and you even mentioned it is called QCA4024, not spidev. Please don't use that name but a real name.

Quoted 2 lines

The compatibility will be changed to "qca4024" and a new patch version will be prepared.

That would be ok except:

Quoted 1 line
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines

Also, I have doubts that Bluetooth is a trivial device. Such devices need supplies, have reset/powerdown GPIOs.

this is not resolved. Bluetooth chips are not trivial devices. This one particular exposes several interfaces to the host, needs a clock and power supply.

Quoted 5 lines

Device is used over QUP4 SPI controller inside of IPQ8074:
https://lore.kernel.org/all/[email protected]/
I'm not sure if these pin settings should be upstreamed as they are specific to this platform:
https://github.com/openwrt/openwrt/pull/14051/files#diff-ed3fbf0226fbdc76c9c160f2f2b9e988120df472480b9861abe7a46796558115R81-R111

Why do you think qca4024 is specific to this platform? Judging by Qualcomm website: it is not.

Best regards,
Krzysztof

author
#6 lore raw
Quoted 29 lines · Krzysztof Kozlowski
Quoted 27 lines · On 06/02/2024 17:34, frut3k7 wrote:
Quoted 27 lines
Quoted 14 lines
Quoted 5 lines
Quoted 5 lines
Documentation/devicetree/bindings/trivial-devices.yaml +0 -0
index 79dcd92c4a43..50efbdf2a735 100644
@@ -309,6 +309,8 @@ properties:
Quoted 9 lines

Documentation/devicetree/bindings/trivial-devices.yaml properties: · line 313

Quoted 5 lines
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
           - plx,pex8648
             # Pulsedlight LIDAR range-finding sensor
           - pulsedlight,lidar-lite-v2
+            # Qualcomm QCA4024 Multi-mode Bluetooth and 802.15.4 SoC
+          - qca,spidev

There is no such hardware as spidev and you even mentioned it is called QCA4024, not spidev. Please don't use that name but a real name.

Quoted 2 lines

The compatibility will be changed to "qca4024" and a new patch version will be prepared.

That would be ok except:

Quoted 3 lines
Quoted 3 lines

Also, I have doubts that Bluetooth is a trivial device. Such devices need supplies, have reset/powerdown GPIOs.

this is not resolved. Bluetooth chips are not trivial devices. This one particular exposes several interfaces to the host, needs a clock and power supply.

Quoted 9 lines
Quoted 5 lines

Device is used over QUP4 SPI controller inside of IPQ8074:
https://lore.kernel.org/all/[email protected]/
I'm not sure if these pin settings should be upstreamed as they are specific to this platform:
https://github.com/openwrt/openwrt/pull/14051/files#diff-ed3fbf0226fbdc76c9c160f2f2b9e988120df472480b9861abe7a46796558115R81-R111

Why do you think qca4024 is specific to this platform? Judging by Qualcomm website: it is not.

Unfortunately, I do not have access to the documentation for this SoC. Currently, even after adding support, communication with the SoC is not possible. QAPI (Qualcomm API) support is missing.

Quoted 3 lines

Best regards,
Krzysztof