kvm: arm64: allow the VM to select DEVICE_* and NORMAL_NC for IO memory
Subsystems (6)
v8 cover kvm: arm64: allow the VM to select DEVICE_* and NORMAL_NC for IO memory
From: Ankit Agrawal <[email protected]>
Currently, KVM for ARM64 maps at stage 2 memory that is considered device with DEVICE_nGnRE memory attributes; this setting overrides (per ARM architecture [1]) any device MMIO mapping present at stage 1, resulting in a set-up whereby a guest operating system cannot determine device MMIO mapping memory attributes on its own but it is always overridden by the KVM stage 2 default.
This set-up does not allow guest operating systems to select device memory attributes independently from KVM stage-2 mappings (refer to [1], "Combining stage 1 and stage 2 memory type attributes"), which turns out to be an issue in that guest operating systems (e.g. Linux) may request to map devices MMIO regions with memory attributes that guarantee better performance (e.g. gathering attribute - that for some devices can generate larger PCIe memory writes TLPs) and specific operations (e.g. unaligned transactions) such as the NormalNC memory type.
The default device stage 2 mapping was chosen in KVM for ARM64 since it was considered safer (i.e. it would not allow guests to trigger uncontained failures ultimately crashing the machine) but this turned out to be asynchronous (SError) defeating the purpose.
For these reasons, relax the KVM stage 2 device memory attributes from DEVICE_nGnRE to Normal-NC.
Generalizing to other devices may be problematic, however. E.g. GICv2 VCPU interface, which is effectively a shared peripheral, can allow a guest to affect another guest's interrupt distribution. Hence limit the change to VFIO PCI as caution. This is achieved by making the VFIO PCI core module set a flag that is tested by KVM to activate the code. This could be extended to other devices in the future once that is deemed safe.
[1] section D8.5 - DDI0487J_a_a-profile_architecture_reference_manual.pdf
Applied over v6.8-rc5.
History
=======
v7 -> v8
- Changed commit message of patches 2/4 and 4/4 to include detailed description of the VM_ALLOW_ANY_UNCACHED flag posted by Jason in the commit message.
- Added more detailed comment in the vfio_pci_core about VM_ALLOW_ANY_UNCACHED flag.
- Rebased to v6.8-rc5.
v6 -> v7
- Changed VM_VFIO_ALLOW_WC to VM_ALLOW_ANY_UNCACHED based on suggestion from Alex Williamson.
- Refactored stage2_set_prot_attr() based on Will's suggestion to reorganize the switch cases. Also updated the case to return -EINVAL when both KVM_PGTABLE_PROT_DEVICE and KVM_PGTABLE_PROT_NORMAL_NC set.
- Fixed nits pointed by Oliver and Catalin.
v5 -> v6
- Rebased to v6.8-rc2
v4 -> v5
- Moved the cover letter description text to patch 1/4.
- Cleaned up stage2_set_prot_attr() based on Marc Zyngier suggestions.
- Moved the mm header file changes to a separate patch.
- Rebased to v6.7-rc3.
v3 -> v4
- Moved the vfio-pci change to use the VM_VFIO_ALLOW_WC into separate patch.
- Added check to warn on the case NORMAL_NC and DEVICE are set simultaneously.
- Fixed miscellaneous nitpicks suggested in v3.
v2 -> v3
- Added a new patch (and converted to patch series) suggested by Catalin Marinas to ensure the code changes are restricted to VFIO PCI devices.
- Introduced VM_VFIO_ALLOW_WC flag for VFIO PCI to communicate with VMM.
- Reverted GIC mapping to DEVICE.
v1 -> v2
- Updated commit log to the one posted by
Lorenzo Pieralisi <[email protected]> (Thanks!)
- Added new flag to represent the NORMAL_NC setting. Updated stage2_set_prot_attr() to handle new flag.
v7 Link:
https://lore.kernel.org/all/[email protected]/
Ankit Agrawal (4):
kvm: arm64: introduce new flag for non-cacheable IO memory
mm: introduce new flag to indicate wc safe
kvm: arm64: set io memory s2 pte as normalnc for vfio pci device
vfio: convey kvm that the vfio-pci device is wc safe
arch/arm64/include/asm/kvm_pgtable.h | 2 ++ arch/arm64/include/asm/memory.h | 2 ++ arch/arm64/kvm/hyp/pgtable.c | 24 +++++++++++++++++++----- arch/arm64/kvm/mmu.c | 14 ++++++++++---- drivers/vfio/pci/vfio_pci_core.c | 18 +++++++++++++++++- include/linux/mm.h | 14 ++++++++++++++ 6 files changed, 64 insertions(+), 10 deletions(-)
Signature · 1 line
2.34.1
PATCH v8 1/4 kvm: arm64: introduce new flag for non-cacheable IO memory
From: Ankit Agrawal <[email protected]>
Currently, KVM for ARM64 maps at stage 2 memory that is considered device (i.e. it is not RAM) with DEVICE_nGnRE memory attributes; this setting overrides (as per the ARM architecture [1]) any device MMIO mapping present at stage 1, resulting in a set-up whereby a guest operating system cannot determine device MMIO mapping memory attributes on its own but it is always overridden by the KVM stage 2 default.
This set-up does not allow guest operating systems to select device memory attributes independently from KVM stage-2 mappings (refer to [1], "Combining stage 1 and stage 2 memory type attributes"), which turns out to be an issue in that guest operating systems (e.g. Linux) may request to map devices MMIO regions with memory attributes that guarantee better performance (e.g. gathering attribute - that for some devices can generate larger PCIe memory writes TLPs) and specific operations (e.g. unaligned transactions) such as the NormalNC memory type.
The default device stage 2 mapping was chosen in KVM for ARM64 since it was considered safer (i.e. it would not allow guests to trigger uncontained failures ultimately crashing the machine) but this turned out to be asynchronous (SError) defeating the purpose.
Failures containability is a property of the platform and is independent from the memory type used for MMIO device memory mappings.
Actually, DEVICE_nGnRE memory type is even more problematic than Normal-NC memory type in terms of faults containability in that e.g. aborts triggered on DEVICE_nGnRE loads cannot be made, architecturally, synchronous (i.e. that would imply that the processor should issue at most 1 load transaction at a time - it cannot pipeline them - otherwise the synchronous abort semantics would break the no-speculation attribute attached to DEVICE_XXX memory).
This means that regardless of the combined stage1+stage2 mappings a platform is safe if and only if device transactions cannot trigger uncontained failures and that in turn relies on platform capabilities and the device type being assigned (i.e. PCIe AER/DPC error containment and RAS architecture[3]); therefore the default KVM device stage 2 memory attributes play no role in making device assignment safer for a given platform (if the platform design adheres to design guidelines outlined in [3]) and therefore can be relaxed.
For all these reasons, relax the KVM stage 2 device memory attributes from DEVICE_nGnRE to Normal-NC.
The NormalNC was chosen over a different Normal memory type default at stage-2 (e.g. Normal Write-through) to avoid cache allocation/snooping.
Relaxing S2 KVM device MMIO mappings to Normal-NC is not expected to trigger any issue on guest device reclaim use cases either (i.e. device MMIO unmap followed by a device reset) at least for PCIe devices, in that in PCIe a device reset is architected and carried out through PCI config space transactions that are naturally ordered with respect to MMIO transactions according to the PCI ordering rules.
Having Normal-NC S2 default puts guests in control (thanks to stage1+stage2 combined memory attributes rules [1]) of device MMIO regions memory mappings, according to the rules described in [1] and summarized here ([(S1) - stage1], [(S2) - stage 2]):
S1 | S2 | Result NORMAL-WB | NORMAL-NC | NORMAL-NC NORMAL-WT | NORMAL-NC | NORMAL-NC NORMAL-NC | NORMAL-NC | NORMAL-NC DEVICE<attr> | NORMAL-NC | DEVICE<attr>
It is worth noting that currently, to map devices MMIO space to user space in a device pass-through use case the VFIO framework applies memory attributes derived from pgprot_noncached() settings applied to VMAs, which result in device-nGnRnE memory attributes for the stage-1 VMM mappings.
This means that a userspace mapping for device MMIO space carried out with the current VFIO framework and a guest OS mapping for the same MMIO space may result in a mismatched alias as described in [2].
Defaulting KVM device stage-2 mappings to Normal-NC attributes does not change anything in this respect, in that the mismatched aliases would only affect (refer to [2] for a detailed explanation) ordering between the userspace and GuestOS mappings resulting stream of transactions (i.e. it does not cause loss of property for either stream of transactions on its own), which is harmless given that the userspace and GuestOS access to the device is carried out through independent transactions streams.
A Normal-NC flag is not present today. So add a new kvm_pgtable_prot (KVM_PGTABLE_PROT_NORMAL_NC) flag for it, along with its corresponding PTE value 0x5 (0b101) determined from [1].
Lastly, adapt the stage2 PTE property setter function (stage2_set_prot_attr) to handle the NormalNC attribute.
[1] section D8.5.5 - DDI0487J_a_a-profile_architecture_reference_manual.pdf
[2] section B2.8 - DDI0487J_a_a-profile_architecture_reference_manual.pdf
[3] sections 1.7.7.3/1.8.5.2/appendix C - DEN0029H_SBSA_7.1.pdf
--- arch/arm64/include/asm/kvm_pgtable.h | 2 ++ arch/arm64/include/asm/memory.h | 2 ++ arch/arm64/kvm/hyp/pgtable.c | 24 +++++++++++++++++++----- 3 files changed, 23 insertions(+), 5 deletions(-)
arch/arm64/include/asm/kvm_pgtable.h +2 -0
@@ -197,6 +197,7 @@ enum kvm_pgtable_stage2_flags {* @KVM_PGTABLE_PROT_W: Write permission. * @KVM_PGTABLE_PROT_R: Read permission. * @KVM_PGTABLE_PROT_DEVICE: Device attributes. +* @KVM_PGTABLE_PROT_NORMAL_NC: Normal noncacheable attributes. * @KVM_PGTABLE_PROT_SW0: Software bit 0. * @KVM_PGTABLE_PROT_SW1: Software bit 1. * @KVM_PGTABLE_PROT_SW2: Software bit 2.
@@ -208,6 +209,7 @@ enum kvm_pgtable_prot {KVM_PGTABLE_PROT_R =BIT (2 ),KVM_PGTABLE_PROT_DEVICE =BIT (3 ), +KVM_PGTABLE_PROT_NORMAL_NC =BIT (4 ),KVM_PGTABLE_PROT_SW0 =BIT (55 ), KVM_PGTABLE_PROT_SW1 = BIT(56),
arch/arm64/include/asm/memory.h +2 -0
@@ -173,6 +173,7 @@* Memory types for Stage-2 translation */ #define MT_S2_NORMAL 0xf +#define MT_S2_NORMAL_NC 0x5#define MT_S2_DEVICE_nGnRE 0x1/*
@@ -180,6 +181,7 @@* Stage-2 enforces Normal-WB and Device-nGnRE */ #define MT_S2_FWB_NORMAL 6 +#define MT_S2_FWB_NORMAL_NC 5#define MT_S2_FWB_DEVICE_nGnRE 1#ifdef CONFIG_ARM64_4K_PAGES
arch/arm64/kvm/hyp/pgtable.c +19 -5
@@ -717,15 +717,29 @@ void kvm_tlb_flush_vmid_range(struct kvm_s2_mmu *mmu,static int stage2_set_prot_attr (struct kvm_pgtable *pgt,enum kvm_pgtable_prot prot,kvm_pte_t *ptep) { -bool device = prot &KVM_PGTABLE_PROT_DEVICE ; -kvm_pte_t attr = device ?KVM_S2_MEMATTR (pgt, DEVICE_nGnRE) : -KVM_S2_MEMATTR (pgt,NORMAL ); +kvm_pte_t attr;u32 sh =KVM_PTE_LEAF_ATTR_LO_S2_SH_IS ; +switch (prot & (KVM_PGTABLE_PROT_DEVICE | +KVM_PGTABLE_PROT_NORMAL_NC )) { +case KVM_PGTABLE_PROT_DEVICE |KVM_PGTABLE_PROT_NORMAL_NC : +return -EINVAL ; +case KVM_PGTABLE_PROT_DEVICE : +if (prot &KVM_PGTABLE_PROT_X ) +return -EINVAL ; + attr =KVM_S2_MEMATTR (pgt, DEVICE_nGnRE); +break ; +case KVM_PGTABLE_PROT_NORMAL_NC : +if (prot &KVM_PGTABLE_PROT_X ) +return -EINVAL ; + attr =KVM_S2_MEMATTR (pgt,NORMAL_NC ); +break ; +default : + attr =KVM_S2_MEMATTR (pgt,NORMAL ); + } +if (!(prot &KVM_PGTABLE_PROT_X )) attr |=KVM_PTE_LEAF_ATTR_HI_S2_XN ; -else if (device) -return -EINVAL ;if (prot &KVM_PGTABLE_PROT_R ) attr |=KVM_PTE_LEAF_ATTR_LO_S2_S2AP_R ;
Signature · 1 line
2.34.1
Re: [PATCH v8 1/4] kvm: arm64: introduce new flag for non-cacheable IO memory
Quoted 97 lines · On Tue, Feb 20, 2024 at 12:59:23PM +0530, [email protected] wrote:
From: Ankit Agrawal <[email protected]>
Currently, KVM for ARM64 maps at stage 2 memory that is considered device (i.e. it is not RAM) with
DEVICE_nGnREmemory attributes; this setting overrides (as per the ARM architecture [1]) any device MMIO mapping present at stage 1, resulting in a set-up whereby a guest operating system cannot determine device MMIO mapping memory attributes on its own but it is always overridden by the KVM stage 2 default.This set-up does not allow guest operating systems to select device memory attributes independently from KVM stage-2 mappings (refer to [1], "Combining stage 1 and stage 2 memory type attributes"), which turns out to be an issue in that guest operating systems (e.g. Linux) may request to map devices MMIO regions with memory attributes that guarantee better performance (e.g. gathering attribute - that for some devices can generate larger PCIe memory writes TLPs) and specific operations (e.g. unaligned transactions) such as the NormalNC memory type.
The default device stage 2 mapping was chosen in KVM for ARM64 since it was considered safer (i.e. it would not allow guests to trigger uncontained failures ultimately crashing the machine) but this turned out to be asynchronous (SError) defeating the purpose.
Failures containability is a property of the platform and is independent from the memory type used for MMIO device memory mappings.
Actually,
DEVICE_nGnREmemory type is even more problematic than Normal-NC memory type in terms of faults containability in that e.g. aborts triggered onDEVICE_nGnREloads cannot be made, architecturally, synchronous (i.e. that would imply that the processor should issue at most 1 load transaction at a time - it cannot pipeline them - otherwise the synchronous abort semantics would break the no-speculation attribute attached toDEVICE_XXXmemory).This means that regardless of the combined stage1+stage2 mappings a platform is safe if and only if device transactions cannot trigger uncontained failures and that in turn relies on platform capabilities and the device type being assigned (i.e. PCIe AER/DPC error containment and RAS architecture[3]); therefore the default KVM device stage 2 memory attributes play no role in making device assignment safer for a given platform (if the platform design adheres to design guidelines outlined in [3]) and therefore can be relaxed.
For all these reasons, relax the KVM stage 2 device memory attributes from
DEVICE_nGnREto Normal-NC.The NormalNC was chosen over a different Normal memory type default at stage-2 (e.g. Normal Write-through) to avoid cache allocation/snooping.
Relaxing S2 KVM device MMIO mappings to Normal-NC is not expected to trigger any issue on guest device reclaim use cases either (i.e. device MMIO unmap followed by a device reset) at least for PCIe devices, in that in PCIe a device reset is architected and carried out through PCI config space transactions that are naturally ordered with respect to MMIO transactions according to the PCI ordering rules.
Having Normal-NC S2 default puts guests in control (thanks to stage1+stage2 combined memory attributes rules [1]) of device MMIO regions memory mappings, according to the rules described in [1] and summarized here ([(S1) - stage1], [(S2) - stage 2]):
S1 | S2 | Result NORMAL-WB | NORMAL-NC | NORMAL-NC NORMAL-WT | NORMAL-NC | NORMAL-NC NORMAL-NC | NORMAL-NC | NORMAL-NC DEVICE<attr> | NORMAL-NC | DEVICE<attr>It is worth noting that currently, to map devices MMIO space to user space in a device pass-through use case the VFIO framework applies memory attributes derived from
pgprot_noncached()settings applied to VMAs, which result in device-nGnRnE memory attributes for the stage-1 VMM mappings.This means that a userspace mapping for device MMIO space carried out with the current VFIO framework and a guest OS mapping for the same MMIO space may result in a mismatched alias as described in [2].
Defaulting KVM device stage-2 mappings to Normal-NC attributes does not change anything in this respect, in that the mismatched aliases would only affect (refer to [2] for a detailed explanation) ordering between the userspace and GuestOS mappings resulting stream of transactions (i.e. it does not cause loss of property for either stream of transactions on its own), which is harmless given that the userspace and GuestOS access to the device is carried out through independent transactions streams.
A Normal-NC flag is not present today. So add a new
kvm_pgtable_prot(KVM_PGTABLE_PROT_NORMAL_NC) flag for it, along with its corresponding PTE value0x5(0b101) determined from [1].Lastly, adapt the stage2 PTE property setter function (
stage2_set_prot_attr) to handle the NormalNC attribute.[1] section D8.5.5 - DDI0487J_a_a-profile_architecture_reference_manual.pdf
[2] section B2.8 - DDI0487J_a_a-profile_architecture_reference_manual.pdf
[3] sections 1.7.7.3/1.8.5.2/appendix C - DEN0029H_SBSA_7.1.pdf
Quoted 8 lines
Suggested-by Jason Gunthorpe <[email protected]>Acked-by Catalin Marinas <[email protected]>Signed-off-by Ankit Agrawal <[email protected]>--- arch/arm64/include/asm/kvm_pgtable.h | 2 ++ arch/arm64/include/asm/memory.h | 2 ++ arch/arm64/kvm/hyp/pgtable.c | 24 +++++++++++++++++++----- 3 files changed, 23 insertions(+), 5 deletions(-)
Will
Re: [PATCH v8 1/4] kvm: arm64: introduce new flag for non-cacheable IO memory
In reply to [email protected]Quoted 90 lines · On Tue, Feb 20, 2024 at 12:59:23PM +0530, [email protected] wrote:
From: Ankit Agrawal <[email protected]>
Currently, KVM for ARM64 maps at stage 2 memory that is considered device (i.e. it is not RAM) with
DEVICE_nGnREmemory attributes; this setting overrides (as per the ARM architecture [1]) any device MMIO mapping present at stage 1, resulting in a set-up whereby a guest operating system cannot determine device MMIO mapping memory attributes on its own but it is always overridden by the KVM stage 2 default.This set-up does not allow guest operating systems to select device memory attributes independently from KVM stage-2 mappings (refer to [1], "Combining stage 1 and stage 2 memory type attributes"), which turns out to be an issue in that guest operating systems (e.g. Linux) may request to map devices MMIO regions with memory attributes that guarantee better performance (e.g. gathering attribute - that for some devices can generate larger PCIe memory writes TLPs) and specific operations (e.g. unaligned transactions) such as the NormalNC memory type.
The default device stage 2 mapping was chosen in KVM for ARM64 since it was considered safer (i.e. it would not allow guests to trigger uncontained failures ultimately crashing the machine) but this turned out to be asynchronous (SError) defeating the purpose.
Failures containability is a property of the platform and is independent from the memory type used for MMIO device memory mappings.
Actually,
DEVICE_nGnREmemory type is even more problematic than Normal-NC memory type in terms of faults containability in that e.g. aborts triggered onDEVICE_nGnREloads cannot be made, architecturally, synchronous (i.e. that would imply that the processor should issue at most 1 load transaction at a time - it cannot pipeline them - otherwise the synchronous abort semantics would break the no-speculation attribute attached toDEVICE_XXXmemory).This means that regardless of the combined stage1+stage2 mappings a platform is safe if and only if device transactions cannot trigger uncontained failures and that in turn relies on platform capabilities and the device type being assigned (i.e. PCIe AER/DPC error containment and RAS architecture[3]); therefore the default KVM device stage 2 memory attributes play no role in making device assignment safer for a given platform (if the platform design adheres to design guidelines outlined in [3]) and therefore can be relaxed.
For all these reasons, relax the KVM stage 2 device memory attributes from
DEVICE_nGnREto Normal-NC.The NormalNC was chosen over a different Normal memory type default at stage-2 (e.g. Normal Write-through) to avoid cache allocation/snooping.
Relaxing S2 KVM device MMIO mappings to Normal-NC is not expected to trigger any issue on guest device reclaim use cases either (i.e. device MMIO unmap followed by a device reset) at least for PCIe devices, in that in PCIe a device reset is architected and carried out through PCI config space transactions that are naturally ordered with respect to MMIO transactions according to the PCI ordering rules.
Having Normal-NC S2 default puts guests in control (thanks to stage1+stage2 combined memory attributes rules [1]) of device MMIO regions memory mappings, according to the rules described in [1] and summarized here ([(S1) - stage1], [(S2) - stage 2]):
S1 | S2 | Result NORMAL-WB | NORMAL-NC | NORMAL-NC NORMAL-WT | NORMAL-NC | NORMAL-NC NORMAL-NC | NORMAL-NC | NORMAL-NC DEVICE<attr> | NORMAL-NC | DEVICE<attr>It is worth noting that currently, to map devices MMIO space to user space in a device pass-through use case the VFIO framework applies memory attributes derived from
pgprot_noncached()settings applied to VMAs, which result in device-nGnRnE memory attributes for the stage-1 VMM mappings.This means that a userspace mapping for device MMIO space carried out with the current VFIO framework and a guest OS mapping for the same MMIO space may result in a mismatched alias as described in [2].
Defaulting KVM device stage-2 mappings to Normal-NC attributes does not change anything in this respect, in that the mismatched aliases would only affect (refer to [2] for a detailed explanation) ordering between the userspace and GuestOS mappings resulting stream of transactions (i.e. it does not cause loss of property for either stream of transactions on its own), which is harmless given that the userspace and GuestOS access to the device is carried out through independent transactions streams.
A Normal-NC flag is not present today. So add a new
kvm_pgtable_prot(KVM_PGTABLE_PROT_NORMAL_NC) flag for it, along with its corresponding PTE value0x5(0b101) determined from [1].
Quoted 7 lines
Lastly, adapt the stage2 PTE property setter function (
stage2_set_prot_attr) to handle the NormalNC attribute.[1] section D8.5.5 - DDI0487J_a_a-profile_architecture_reference_manual.pdf
[2] section B2.8 - DDI0487J_a_a-profile_architecture_reference_manual.pdf
[3] sections 1.7.7.3/1.8.5.2/appendix C - DEN0029H_SBSA_7.1.pdf
A couple of Link: tags would not hurt in my opinion, lest we forget:
Quoted 91 lines
Suggested-by Jason Gunthorpe <[email protected]>Acked-by Catalin Marinas <[email protected]>Signed-off-by Ankit Agrawal <[email protected]>--- arch/arm64/include/asm/kvm_pgtable.h | 2 ++ arch/arm64/include/asm/memory.h | 2 ++ arch/arm64/kvm/hyp/pgtable.c | 24 +++++++++++++++++++----- 3 files changed, 23 insertions(+), 5 deletions(-)arch/arm64/include/asm/kvm_pgtable.h +2
-0@@ -197,6 +197,7 @@ enum kvm_pgtable_stage2_flags {* @KVM_PGTABLE_PROT_W: Write permission. * @KVM_PGTABLE_PROT_R: Read permission. * @KVM_PGTABLE_PROT_DEVICE: Device attributes. +* @KVM_PGTABLE_PROT_NORMAL_NC: Normal noncacheable attributes. * @KVM_PGTABLE_PROT_SW0: Software bit 0. * @KVM_PGTABLE_PROT_SW1: Software bit 1. * @KVM_PGTABLE_PROT_SW2: Software bit 2. @@ -208,6 +209,7 @@ enum kvm_pgtable_prot {KVM_PGTABLE_PROT_R =BIT (2 ),KVM_PGTABLE_PROT_DEVICE =BIT (3 ), +KVM_PGTABLE_PROT_NORMAL_NC =BIT (4 ),KVM_PGTABLE_PROT_SW0 =BIT (55 ), KVM_PGTABLE_PROT_SW1 = BIT(56),arch/arm64/include/asm/memory.h +2
-0@@ -173,6 +173,7 @@* Memory types for Stage-2 translation */ #define MT_S2_NORMAL 0xf +#define MT_S2_NORMAL_NC 0x5#define MT_S2_DEVICE_nGnRE 0x1/* @@ -180,6 +181,7 @@* Stage-2 enforces Normal-WB and Device-nGnRE */ #define MT_S2_FWB_NORMAL 6 +#define MT_S2_FWB_NORMAL_NC 5#define MT_S2_FWB_DEVICE_nGnRE 1#ifdef CONFIG_ARM64_4K_PAGES arch/arm64/kvm/hyp/pgtable.c +19
-5@@ -717,15 +717,29 @@ void kvm_tlb_flush_vmid_range(struct kvm_s2_mmu *mmu,static int stage2_set_prot_attr (struct kvm_pgtable *pgt,enum kvm_pgtable_prot prot,kvm_pte_t *ptep) { -bool device = prot &KVM_PGTABLE_PROT_DEVICE ; -kvm_pte_t attr = device ?KVM_S2_MEMATTR (pgt, DEVICE_nGnRE) : -KVM_S2_MEMATTR (pgt,NORMAL ); +kvm_pte_t attr;u32 sh =KVM_PTE_LEAF_ATTR_LO_S2_SH_IS ; +switch (prot & (KVM_PGTABLE_PROT_DEVICE | +KVM_PGTABLE_PROT_NORMAL_NC )) { +case KVM_PGTABLE_PROT_DEVICE |KVM_PGTABLE_PROT_NORMAL_NC : +return -EINVAL ; +case KVM_PGTABLE_PROT_DEVICE : +if (prot &KVM_PGTABLE_PROT_X ) +return -EINVAL ; + attr =KVM_S2_MEMATTR (pgt, DEVICE_nGnRE); +break ; +case KVM_PGTABLE_PROT_NORMAL_NC : +if (prot &KVM_PGTABLE_PROT_X ) +return -EINVAL ; + attr =KVM_S2_MEMATTR (pgt,NORMAL_NC ); +break ; +default : + attr =KVM_S2_MEMATTR (pgt,NORMAL ); + } +if (!(prot &KVM_PGTABLE_PROT_X )) attr |=KVM_PTE_LEAF_ATTR_HI_S2_XN ; -else if (device) -return -EINVAL ;if (prot &KVM_PGTABLE_PROT_R ) attr |=KVM_PTE_LEAF_ATTR_LO_S2_S2AP_R ;Signature · 1 line
2.34.1
Re: [PATCH v8 1/4] kvm: arm64: introduce new flag for non-cacheable IO memory
Quoted 9 lines
Quoted 8 lines
Lastly, adapt the stage2 PTE property setter function (
stage2_set_prot_attr) to handle the NormalNC attribute.[1] section D8.5.5 - DDI0487J_a_a-profile_architecture_reference_manual.pdf
[2] section B2.8 - DDI0487J_a_a-profile_architecture_reference_manual.pdf
[3] sections 1.7.7.3/1.8.5.2/appendix C - DEN0029H_SBSA_7.1.pdf
Quoted 4 lines
A couple of Link: tags would not hurt in my opinion, lest we forget:
Agreed, will add.
PATCH v8 2/4 mm: introduce new flag to indicate wc safe
In reply to [email protected]From: Ankit Agrawal <[email protected]>
The VM_ALLOW_ANY_UNCACHED flag is implemented for ARM64, allowing KVM stage 2 device mapping attributes to use NormalNC rather than DEVICE_nGnRE, which allows guest mappings supporting combining attributes (WC). ARM does not architecturally guarantee this is safe, and indeed some MMIO regions like the GICv2 VCPU interface can trigger uncontained faults if NormalNC is used.
Even worse we expect there are platforms where even DEVICE_nGnRE can allow uncontained faults in corner cases. Unfortunately existing ARM IP requires platform integration to take responsibility to prevent this.
To safely use VFIO in KVM the platform must guarantee full safety in the guest where no action taken against a MMIO mapping can trigger an uncontained failure. We belive that most VFIO PCI platforms support this for both mapping types, at least in common flows, based on some expectations of how PCI IP is integrated. This can be enabled more broadly, for instance into vfio-platform drivers, but only after the platform vendor completes auditing for safety.
The VMA flag VM_ALLOW_ANY_UNCACHED was found to be the simplest and cleanest way to communicate the information from VFIO to KVM that mapping the region in S2 as NormalNC is safe. KVM consumes it to activate the code that does the S2 mapping as NormalNC.
--- include/linux/mm.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
include/linux/mm.h +14 -0
@@ -391,6 +391,20 @@ extern unsigned int kobjsize(const void *objp);# define VM_UFFD_MINOR VM_NONE#endif /* CONFIG_HAVE_ARCH_USERFAULTFD_MINOR */ +/* +* This flag is used to connect VFIO to arch specific KVM code. It +* indicates that the memory under this VMA is safe for use with any +* non-cachable memory type inside KVM. Some VFIO devices, on some +* platforms, are thought to be unsafe and can cause machine crashes +* if KVM does not lock down the memory type. +*/ +#ifdef CONFIG_64BIT +#define VM_ALLOW_ANY_UNCACHED_BIT 39 +#define VM_ALLOW_ANY_UNCACHED BIT(VM_ALLOW_ANY_UNCACHED_BIT) +#else +#define VM_ALLOW_ANY_UNCACHED VM_NONE +#endif +/* Bits set in the VMA until the stack is in its final location */ #define VM_STACK_INCOMPLETE_SETUP (VM_RAND_READ | VM_SEQ_READ | VM_STACK_EARLY)
Signature · 1 line
2.34.1
Re: [PATCH v8 2/4] mm: introduce new flag to indicate wc safe
Quoted 9 lines · Ankit Agrawal
From: Ankit Agrawal <[email protected]>
The
VM_ALLOW_ANY_UNCACHEDflag is implemented for ARM64, allowing KVM stage 2 device mapping attributes to use NormalNC rather thanDEVICE_nGnRE, which allows guest mappings supporting combining attributes (WC). ARM does not architecturally guarantee this is safe, and indeed some MMIO regions like the GICv2 VCPU interface can trigger uncontained faults if NormalNC is used.
Quoted 7 lines
Even worse we expect there are platforms where even
DEVICE_nGnREcan allow uncontained faults in corner cases. Unfortunately existing ARM IP requires platform integration to take responsibility to prevent this.To safely use VFIO in KVM the platform must guarantee full safety in the guest where no action taken against a MMIO mapping can trigger an uncontained failure. We belive that most VFIO PCI platforms support this
A nit, let's use passive voice in the patch comment. Also belive is mostly a typo.
Quoted 43 lines
for both mapping types, at least in common flows, based on some expectations of how PCI IP is integrated. This can be enabled more broadly, for instance into vfio-platform drivers, but only after the platform vendor completes auditing for safety.
The VMA flag
VM_ALLOW_ANY_UNCACHEDwas found to be the simplest and cleanest way to communicate the information from VFIO to KVM that mapping the region in S2 as NormalNC is safe. KVM consumes it to activate the code that does the S2 mapping as NormalNC.Suggested-by Catalin Marinas <[email protected]>Reviewed-by Jason Gunthorpe <[email protected]>Signed-off-by Ankit Agrawal <[email protected]>--- include/linux/mm.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+)include/linux/mm.h +14
-0@@ -391,6 +391,20 @@ extern unsigned int kobjsize(const void *objp);# define VM_UFFD_MINOR VM_NONE#endif /* CONFIG_HAVE_ARCH_USERFAULTFD_MINOR */ +/* +* This flag is used to connect VFIO to arch specific KVM code. It +* indicates that the memory under this VMA is safe for use with any +* non-cachable memory type inside KVM. Some VFIO devices, on some +* platforms, are thought to be unsafe and can cause machine crashes +* if KVM does not lock down the memory type. +*/ +#ifdef CONFIG_64BIT +#define VM_ALLOW_ANY_UNCACHED_BIT 39 +#define VM_ALLOW_ANY_UNCACHED BIT(VM_ALLOW_ANY_UNCACHED_BIT) +#else +#define VM_ALLOW_ANY_UNCACHED VM_NONE +#endif +/* Bits set in the VMA until the stack is in its final location */ #define VM_STACK_INCOMPLETE_SETUP (VM_RAND_READ | VM_SEQ_READ | VM_STACK_EARLY)
Re: [PATCH v8 2/4] mm: introduce new flag to indicate wc safe
Quoted 6 lines
Quoted 3 lines
To safely use VFIO in KVM the platform must guarantee full safety in the guest where no action taken against a MMIO mapping can trigger an uncontained failure. We belive that most VFIO PCI platforms support this
A nit, let's use passive voice in the patch comment. Also belive is mostly a typo.
Sure, will do.
Re: [PATCH v8 2/4] mm: introduce new flag to indicate wc safe
Quoted 8 lines · Ankit Agrawal
Quoted 6 lines
Quoted 3 lines
To safely use VFIO in KVM the platform must guarantee full safety in the guest where no action taken against a MMIO mapping can trigger an uncontained failure. We belive that most VFIO PCI platforms support this
A nit, let's use passive voice in the patch comment. Also belive is mostly a typo.
Sure, will do.
Also patch 4 has the same nit. It should be fixed as well.
Re: [PATCH v8 2/4] mm: introduce new flag to indicate wc safe
Quoted 9 lines
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
To safely use VFIO in KVM the platform must guarantee full safety in the guest where no action taken against a MMIO mapping can trigger an uncontained failure. We belive that most VFIO PCI platforms support this
A nit, let's use passive voice in the patch comment. Also belive is mostly a typo.
Sure, will do.
Also patch 4 has the same nit. It should be fixed as well.
Yes.
Re: [PATCH v8 2/4] mm: introduce new flag to indicate wc safe
In reply to Ankit AgrawalQuoted 9 lines · Ankit Agrawal
Quoted 6 lines
Quoted 3 lines
To safely use VFIO in KVM the platform must guarantee full safety in the guest where no action taken against a MMIO mapping can trigger an uncontained failure. We belive that most VFIO PCI platforms support this
A nit, let's use passive voice in the patch comment. Also belive is mostly a typo.
Sure, will do.
s/we expect/the expectation is that/
s/We belive/The assumption is/
If it's just that, likely no need to resend. Maintainers usually can fix that up when applying (otherwise, they'll let you know :) ).
Signature · 3 lines
Cheers, David / dhildenb
Re: [PATCH v8 2/4] mm: introduce new flag to indicate wc safe
Quoted 14 lines · David Hildenbrand
External email: Use caution opening links or attachments
Quoted 10 lines · Ankit Agrawal
Quoted 9 lines
Quoted 5 lines
To safely use VFIO in KVM the platform must guarantee full safety in the
guest where no action taken against a MMIO mapping can trigger an uncontained failure. We belive that most VFIO PCI platforms support thisA nit, let's use passive voice in the patch comment. Also belive is mostly
a typo.
Quoted 9 lines
Quoted 2 lines
Sure, will do.
s/we expect/the expectation is that/
s/We belive/The assumption is/If it's just that, likely no need to resend. Maintainers usually can fix that up when applying (otherwise, they'll let you know :) ).
Many thanks! :)
Quoted 5 lines
Signature · 3 lines
Cheers, David / dhildenb
Re: [PATCH v8 2/4] mm: introduce new flag to indicate wc safe
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines
Quoted 9 lines
Quoted 5 lines
To safely use VFIO in KVM the platform must guarantee full safety in the
guest where no action taken against a MMIO mapping can trigger an uncontained failure. We belive that most VFIO PCI platforms support thisA nit, let's use passive voice in the patch comment. Also belive is mostly
a typo.Sure, will do.
Quoted 7 lines
Quoted 6 lines
s/we expect/the expectation is that/
s/We belive/The assumption is/If it's just that, likely no need to resend. Maintainers usually can fix that up when applying (otherwise, they'll let you know :) ).
Many thanks! :)
Good to know, thanks David.
PATCH v8 3/4 kvm: arm64: set io memory s2 pte as normalnc for vfio pci device
In reply to [email protected]From: Ankit Agrawal <[email protected]>
To provide VM with the ability to get device IO memory with NormalNC property, map device MMIO in KVM for ARM64 at stage2 as NormalNC. Having NormalNC S2 default puts guests in control (based on [1], "Combining stage 1 and stage 2 memory type attributes") of device MMIO regions memory mappings. The rules are summarized below:
([(S1) - stage1], [(S2) - stage 2])
S1 | S2 | Result NORMAL-WB | NORMAL-NC | NORMAL-NC NORMAL-WT | NORMAL-NC | NORMAL-NC NORMAL-NC | NORMAL-NC | NORMAL-NC DEVICE<attr> | NORMAL-NC | DEVICE<attr>
Still this cannot be generalized to non PCI devices such as GICv2. There is insufficient information and uncertainity in the behavior of non PCI driver. A driver must indicate support using the new flag VM_ALLOW_ANY_UNCACHED.
Adapt KVM to make use of the flag VM_ALLOW_ANY_UNCACHED as indicator to activate the S2 setting to NormalNc.
[1] section D8.5.5 of DDI0487J_a_a-profile_architecture_reference_manual.pdf
--- arch/arm64/kvm/mmu.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)
arch/arm64/kvm/mmu.c +10 -4
@@ -1381,7 +1381,7 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa,int ret =0 ;bool write_fault, writable, force_pte = false;bool exec_fault, mte_allowed; -bool device = false; +bool device = false, vfio_allow_any_uc = false;unsigned long mmu_seq;struct kvm *kvm = vcpu->kvm;struct kvm_mmu_memory_cache *memcache = &vcpu->arch.mmu_page_cache;
@@ -1472,6 +1472,8 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, gfn = fault_ipa >>PAGE_SHIFT ; mte_allowed =kvm_vma_mte_allowed (vma); + vfio_allow_any_uc = vma->vm_flags &VM_ALLOW_ANY_UNCACHED ; +/* Don't use the VMA after the unlock -- it may have vanished */ vma =NULL ;
@@ -1557,10 +1559,14 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa,if (exec_fault) prot |=KVM_PGTABLE_PROT_X ; -if (device) - prot |=KVM_PGTABLE_PROT_DEVICE ; -else if (cpus_have_final_cap (ARM64_HAS_CACHE_DIC )) +if (device) { +if (vfio_allow_any_uc) + prot |=KVM_PGTABLE_PROT_NORMAL_NC ; +else + prot |=KVM_PGTABLE_PROT_DEVICE ; + }else if (cpus_have_final_cap (ARM64_HAS_CACHE_DIC )) { prot |=KVM_PGTABLE_PROT_X ; + }/* * Under the premise of getting a FSC_PERM fault, we just need to relax
Signature · 1 line
2.34.1
Marc Zyngier
maintainerRe: [PATCH v8 3/4] kvm: arm64: set io memory s2 pte as normalnc for vfio pci device
Quoted 24 lines · On Tue, 20 Feb 2024 07:29:25 +0000, <[email protected]> wrote:
From: Ankit Agrawal <[email protected]>
To provide VM with the ability to get device IO memory with NormalNC property, map device MMIO in KVM for ARM64 at stage2 as NormalNC. Having NormalNC S2 default puts guests in control (based on [1], "Combining stage 1 and stage 2 memory type attributes") of device MMIO regions memory mappings. The rules are summarized below:
([(S1) - stage1], [(S2) - stage 2])S1 | S2 | Result NORMAL-WB | NORMAL-NC | NORMAL-NC NORMAL-WT | NORMAL-NC | NORMAL-NC NORMAL-NC | NORMAL-NC | NORMAL-NC DEVICE<attr> | NORMAL-NC | DEVICE<attr>Still this cannot be generalized to non PCI devices such as GICv2. There is insufficient information and uncertainity in the behavior of non PCI driver. A driver must indicate support using the new flag
VM_ALLOW_ANY_UNCACHED.Adapt KVM to make use of the flag
VM_ALLOW_ANY_UNCACHEDas indicator to activate the S2 setting to NormalNc.
Quoted 6 lines
[1] section D8.5.5 of DDI0487J_a_a-profile_architecture_reference_manual.pdf
Suggested-by Catalin Marinas <[email protected]>Acked-by Jason Gunthorpe <[email protected]>Reviewed-by Catalin Marinas <[email protected]>Signed-off-by Ankit Agrawal <[email protected]>
Since people have asked for various commit message updates, I'll add my own: for the KVM/arm64 tree, the convention for the subject line is "KVM: arm64: Something starting with a capital".
Thanks,
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
PATCH v8 4/4 vfio: convey kvm that the vfio-pci device is wc safe
In reply to [email protected]From: Ankit Agrawal <[email protected]>
The VM_ALLOW_ANY_UNCACHED flag is implemented for ARM64, allowing KVM stage 2 device mapping attributes to use Normal-NC rather than DEVICE_nGnRE, which allows guest mappings supporting combining attributes (WC). ARM does not architecturally guarantee this is safe, and indeed some MMIO regions like the GICv2 VCPU interface can trigger uncontained faults if Normal-NC is used.
To safely use VFIO in KVM the platform must guarantee full safety in the guest where no action taken against a MMIO mapping can trigger an uncontained failure. We belive that most VFIO PCI platforms support this for both mapping types, at least in common flows, based on some expectations of how PCI IP is integrated. So make vfio-pci set the VM_ALLOW_ANY_UNCACHED flag.
--- drivers/vfio/pci/vfio_pci_core.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)
drivers/vfio/pci/vfio_pci_core.c +17 -1
@@ -1862,8 +1862,24 @@ int vfio_pci_core_mmap(struct vfio_device *core_vdev, struct vm_area_struct *vma/* * See remap_pfn_range(), called from vfio_pci_fault() but we can't * change vm_flags within the fault handler. Set them now. +* +* VM_ALLOW_ANY_UNCACHED: The VMA flag is implemented for ARM64, +* allowing KVM stage 2 device mapping attributes to use Normal-NC +* rather than DEVICE_nGnRE, which allows guest mappings +* supporting combining attributes (WC). ARM does not +* architecturally guarantee this is safe, and indeed some MMIO +* regions like the GICv2 VCPU interface can trigger uncontained +* faults if Normal-NC is used. +* +* To safely use VFIO in KVM the platform must guarantee full +* safety in the guest where no action taken against a MMIO +* mapping can trigger an uncontained failure. We belive that +* most VFIO PCI platforms support this for both mapping types, +* at least in common flows, based on some expectations of how +* PCI IP is integrated. So set VM_ALLOW_ANY_UNCACHED in VMA flags. */ -vm_flags_set (vma,VM_IO |VM_PFNMAP |VM_DONTEXPAND |VM_DONTDUMP ); +vm_flags_set (vma,VM_ALLOW_ANY_UNCACHED |VM_IO |VM_PFNMAP | +VM_DONTEXPAND |VM_DONTDUMP ); vma->vm_ops = &vfio_pci_mmap_ops;return 0 ;
Signature · 1 line
2.34.1
Catalin Marinas
maintainerRe: [PATCH v8 4/4] vfio: convey kvm that the vfio-pci device is wc safe
drivers/vfio/pci/vfio_pci_core.c int vfio_pci_core_mmap(struct vfio_device *core_vdev, struct vm_area_struct *vma · line 1869
Quoted 13 lines · On Tue, Feb 20, 2024 at 12:59:26PM +0530, [email protected] wrote:
drivers/vfio/pci/vfio_pci_core.c +5
-0@@ -1862,8 +1862,24 @@ int vfio_pci_core_mmap(struct vfio_device *core_vdev, struct vm_area_struct *vma/* * See remap_pfn_range(), called from vfio_pci_fault() but we can't * change vm_flags within the fault handler. Set them now. +* +* VM_ALLOW_ANY_UNCACHED: The VMA flag is implemented for ARM64, +* allowing KVM stage 2 device mapping attributes to use Normal-NC +* rather than DEVICE_nGnRE, which allows guest mappings +* supporting combining attributes (WC). ARM does not
Nitpick: "supporting write-combining" (if you plan to respin).
Signature · 1 line
Catalin
Re: [PATCH v8 4/4] vfio: convey kvm that the vfio-pci device is wc safe
Quoted 7 lines
Quoted 7 lines
drivers/vfio/pci/vfio_pci_core.c +0
-0@@ -1862,8 +1862,24 @@ int vfio_pci_core_mmap(struct vfio_device *core_vdev, struct vm_area_struct *vma /** See remap_pfn_range(), called from vfio_pci_fault() but we can't
Quoted 8 lines
drivers/vfio/pci/vfio_pci_core.c int vfio_pci_core_mmap(struct vfio_device *core_vdev, struct vm_area_struct *vma · line 1869
Quoted 6 lines
drivers/vfio/pci/vfio_pci_core.c +5
-0* change vm_flags within the fault handler. Set them now. + * + * VM_ALLOW_ANY_UNCACHED: The VMA flag is implemented for ARM64, + * allowing KVM stage 2 device mapping attributes to use Normal-NC + * rather than DEVICE_nGnRE, which allows guest mappings + * supporting combining attributes (WC). ARM does notNitpick: "supporting write-combining" (if you plan to respin).
Ack.
Re: [PATCH v8 4/4] vfio: convey kvm that the vfio-pci device is wc safe
In reply to [email protected]Quoted 45 lines · On Tue, 20 Feb 2024 12:59:26 +0530 <[email protected]> wrote:
From: Ankit Agrawal <[email protected]>
The
VM_ALLOW_ANY_UNCACHEDflag is implemented for ARM64, allowing KVM stage 2 device mapping attributes to use Normal-NC rather thanDEVICE_nGnRE, which allows guest mappings supporting combining attributes (WC). ARM does not architecturally guarantee this is safe, and indeed some MMIO regions like the GICv2 VCPU interface can trigger uncontained faults if Normal-NC is used.To safely use VFIO in KVM the platform must guarantee full safety in the guest where no action taken against a MMIO mapping can trigger an uncontained failure. We belive that most VFIO PCI platforms support this for both mapping types, at least in common flows, based on some expectations of how PCI IP is integrated. So make vfio-pci set the
VM_ALLOW_ANY_UNCACHEDflag.Suggested-by Catalin Marinas <[email protected]>Acked-by Jason Gunthorpe <[email protected]>Acked-by Catalin Marinas <[email protected]>Reviewed-by David Hildenbrand <[email protected]>Signed-off-by Ankit Agrawal <[email protected]>--- drivers/vfio/pci/vfio_pci_core.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)drivers/vfio/pci/vfio_pci_core.c +12
-0@@ -1862,8 +1862,24 @@ int vfio_pci_core_mmap(struct vfio_device *core_vdev, struct vm_area_struct *vma/* * See remap_pfn_range(), called from vfio_pci_fault() but we can't * change vm_flags within the fault handler. Set them now. +* +* VM_ALLOW_ANY_UNCACHED: The VMA flag is implemented for ARM64, +* allowing KVM stage 2 device mapping attributes to use Normal-NC +* rather than DEVICE_nGnRE, which allows guest mappings +* supporting combining attributes (WC). ARM does not +* architecturally guarantee this is safe, and indeed some MMIO +* regions like the GICv2 VCPU interface can trigger uncontained +* faults if Normal-NC is used. +* +* To safely use VFIO in KVM the platform must guarantee full +* safety in the guest where no action taken against a MMIO +* mapping can trigger an uncontained failure. We belive that
drivers/vfio/pci/vfio_pci_core.c int vfio_pci_core_mmap(struct vfio_device *core_vdev, struct vm_area_struct *vma · line 1885
Quoted 10 lines
drivers/vfio/pci/vfio_pci_core.c +5
-1+* most VFIO PCI platforms support this for both mapping types, +* at least in common flows, based on some expectations of how +* PCI IP is integrated. So set VM_ALLOW_ANY_UNCACHED in VMA flags. */ -vm_flags_set (vma,VM_IO |VM_PFNMAP |VM_DONTEXPAND |VM_DONTDUMP ); +vm_flags_set (vma,VM_ALLOW_ANY_UNCACHED |VM_IO |VM_PFNMAP | +VM_DONTEXPAND |VM_DONTDUMP ); vma->vm_ops = &vfio_pci_mmap_ops;return 0 ;
Quoted 36 lines · On Tue, 20 Feb 2024 07:29:22 +0000, <[email protected]> wrote:
From: Ankit Agrawal <[email protected]>
Currently, KVM for ARM64 maps at stage 2 memory that is considered device with
DEVICE_nGnREmemory attributes; this setting overrides (per ARM architecture [1]) any device MMIO mapping present at stage 1, resulting in a set-up whereby a guest operating system cannot determine device MMIO mapping memory attributes on its own but it is always overridden by the KVM stage 2 default.This set-up does not allow guest operating systems to select device memory attributes independently from KVM stage-2 mappings (refer to [1], "Combining stage 1 and stage 2 memory type attributes"), which turns out to be an issue in that guest operating systems (e.g. Linux) may request to map devices MMIO regions with memory attributes that guarantee better performance (e.g. gathering attribute - that for some devices can generate larger PCIe memory writes TLPs) and specific operations (e.g. unaligned transactions) such as the NormalNC memory type.
The default device stage 2 mapping was chosen in KVM for ARM64 since it was considered safer (i.e. it would not allow guests to trigger uncontained failures ultimately crashing the machine) but this turned out to be asynchronous (SError) defeating the purpose.
For these reasons, relax the KVM stage 2 device memory attributes from
DEVICE_nGnREto Normal-NC.Generalizing to other devices may be problematic, however. E.g. GICv2 VCPU interface, which is effectively a shared peripheral, can allow a guest to affect another guest's interrupt distribution. Hence limit the change to VFIO PCI as caution. This is achieved by making the VFIO PCI core module set a flag that is tested by KVM to activate the code. This could be extended to other devices in the future once that is deemed safe.
Quoted 3 lines
[1] section D8.5 - DDI0487J_a_a-profile_architecture_reference_manual.pdf
Applied over v6.8-rc5.
For the series,
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.