KVM: arm64: Allow the VM to select DEVICE_* and NORMAL_NC for IO memory
Status from this message: Applied to kvmarm/next, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v9 Latest4 patches 4 repliesApplied
- v84 patches 15 repliesSuperseded
- v74 patches 12 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v6 | 4 patches | 14 replies | Superseded | |
| v5 | 4 patches | 0 replies | Superseded | |
| v4 | 3 patches | 3 replies | Superseded | |
| v3 | 2 patches | 16 replies | Superseded | |
| v2 | 1 patch | 38 replies | Superseded |
Changes in v9 from the cover letter
- Collected Reviewed-by and Acked-by.
- Updated the commit messages in 2/4 and 4/4 to passive voice and fix spelling error.
- Updated subjects to align with convention of using capitalized first letter.
- Added links in 1/4 on the previous conversation for tracking purpose.
Patches in v9 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | KVM: arm64: Introduce new flag for non-cacheable IO memoryarch/ arch/ arch/ | +23 | 0 replies | |
| 2/4 | mm: Introduce new flag to indicate wc safeinclude/ | +14 | 0 replies | |
| 3/4 | KVM: arm64: Set io memory s2 pte as normalnc for vfio pci devicearch/ | +10 | 0 replies | |
| 4/4 | vfio: Convey kvm that the vfio-pci device is wc safedrivers/ | +18 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Catalin Marinas | Will Deacon | Marc Zyngier | Jason Gunthorpe | David Hildenbrand | Alex Williamson |
|---|---|---|---|---|---|---|
| Series | A-b | |||||
| 1/4 | A-b | A-b | R-b | |||
| 2/4 | R-b | R-b | A-b | |||
| 3/4 | R-b | R-b | A-b | |||
| 4/4 | A-b | R-b | A-b | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.
Cover letter [PATCH v9 0/4] KVM: arm64: Allow the VM to select DEVICE_* and NORMAL_NC for IO memory
From: Ankit Agrawal <[email protected]>
Currently, KVM for ARM64 maps at stage 2 memory that is considered device with DEVICE_nGnRE memory attributes; this setting overrides (per ARM architecture [1]) any device MMIO mapping present at stage 1, resulting in a set-up whereby a guest operating system cannot determine device MMIO mapping memory attributes on its own but it is always overridden by the KVM stage 2 default.
This set-up does not allow guest operating systems to select device memory attributes independently from KVM stage-2 mappings (refer to [1], "Combining stage 1 and stage 2 memory type attributes"), which turns out to be an issue in that guest operating systems (e.g. Linux) may request to map devices MMIO regions with memory attributes that guarantee better performance (e.g. gathering attribute - that for some devices can generate larger PCIe memory writes TLPs) and specific operations (e.g. unaligned transactions) such as the NormalNC memory type.
The default device stage 2 mapping was chosen in KVM for ARM64 since it was considered safer (i.e. it would not allow guests to trigger uncontained failures ultimately crashing the machine) but this turned out to be asynchronous (SError) defeating the purpose.
For these reasons, relax the KVM stage 2 device memory attributes from DEVICE_nGnRE to Normal-NC.
Generalizing to other devices may be problematic, however. E.g. GICv2 VCPU interface, which is effectively a shared peripheral, can allow a guest to affect another guest's interrupt distribution. Hence limit the change to VFIO PCI as caution. This is achieved by making the VFIO PCI core module set a flag that is tested by KVM to activate the code. This could be extended to other devices in the future once that is deemed safe.
[1] section D8.5 - DDI0487J_a_a-profile_architecture_reference_manual.pdf
Applied over v6.8-rc5.
History
=======
v8 -> v9
- Collected Reviewed-by and Acked-by.
- Updated the commit messages in 2/4 and 4/4 to passive voice and fix spelling error.
- Updated subjects to align with convention of using capitalized first letter.
- Added links in 1/4 on the previous conversation for tracking purpose.
v7 -> v8
- Changed commit message of patches 2/4 and 4/4 to include detailed description of the VM_ALLOW_ANY_UNCACHED flag posted by Jason in the commit message.
- Added more detailed comment in the vfio_pci_core about VM_ALLOW_ANY_UNCACHED flag.
- Rebased to v6.8-rc5.
v6 -> v7
- Changed VM_VFIO_ALLOW_WC to VM_ALLOW_ANY_UNCACHED based on suggestion from Alex Williamson.
- Refactored stage2_set_prot_attr() based on Will's suggestion to reorganize the switch cases. Also updated the case to return -EINVAL when both KVM_PGTABLE_PROT_DEVICE and KVM_PGTABLE_PROT_NORMAL_NC set.
- Fixed nits pointed by Oliver and Catalin.
v5 -> v6
- Rebased to v6.8-rc2
v4 -> v5
- Moved the cover letter description text to patch 1/4.
- Cleaned up stage2_set_prot_attr() based on Marc Zyngier suggestions.
- Moved the mm header file changes to a separate patch.
- Rebased to v6.7-rc3.
v3 -> v4
- Moved the vfio-pci change to use the VM_VFIO_ALLOW_WC into separate patch.
- Added check to warn on the case NORMAL_NC and DEVICE are set simultaneously.
- Fixed miscellaneous nitpicks suggested in v3.
v2 -> v3
- Added a new patch (and converted to patch series) suggested by Catalin Marinas to ensure the code changes are restricted to VFIO PCI devices.
- Introduced VM_VFIO_ALLOW_WC flag for VFIO PCI to communicate with VMM.
- Reverted GIC mapping to DEVICE.
v1 -> v2
- Updated commit log to the one posted by
Lorenzo Pieralisi <[email protected]> (Thanks!)
- Added new flag to represent the NORMAL_NC setting. Updated stage2_set_prot_attr() to handle new flag.
v8 Link:
https://lore.kernel.org/all/[email protected]/
Ankit Agrawal (4):
KVM: arm64: Introduce new flag for non-cacheable IO memory
mm: Introduce new flag to indicate wc safe
KVM: arm64: Set io memory s2 pte as normalnc for vfio pci device
vfio: Convey kvm that the vfio-pci device is wc safe
arch/arm64/include/asm/kvm_pgtable.h | 2 ++ arch/arm64/include/asm/memory.h | 2 ++ arch/arm64/kvm/hyp/pgtable.c | 24 +++++++++++++++++++----- arch/arm64/kvm/mmu.c | 14 ++++++++++---- drivers/vfio/pci/vfio_pci_core.c | 19 ++++++++++++++++++- include/linux/mm.h | 14 ++++++++++++++ 6 files changed, 65 insertions(+), 10 deletions(-)
Signature · 1 line
2.34.1