Skip to contentSkip to conversation

dt-bindings: mmc: fsl-imx-mmc: Document the required clocks

PATCH In review Fabio Estevam 3 participants 3 messages Feb 22, 2024 – Feb 28, 2024

Subsystems (3)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v2 1/1 dt-bindings: mmc: fsl-imx-mmc: Document the required clocks

From: Fabio Estevam <[email protected]>

The fsl-imx-mmc hardware needs two clocks to operate: ipg and per.

Document these required clocks.

This fixes the following schema warning:

imx27-apf27dev.dtb: mmc@10014000: Unevaluated properties are not allowed ('clock-names', 'clocks' were unexpected)
from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-mmc.yaml#

---
Changes since v2:
- None. Just fixed a typo in the dt list.

 .../devicetree/bindings/mmc/fsl-imx-mmc.yaml         | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml +12 -0
index 221f5bc047bd..7911316fbd6a 100644
@@ -24,6 +24,14 @@ properties:
   reg:
     maxItems: 1
 
+  clocks:
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: ipg
+      - const: per
+
   interrupts:
     maxItems: 1
 
@@ -34,6 +42,8 @@ properties:
     const: rx-tx
 
 required:
+  - clocks
+  - clock-names
   - compatible
   - reg
   - interrupts
@@ -46,6 +56,8 @@ examples:
         compatible = "fsl,imx27-mmc", "fsl,imx21-mmc";
         reg = <0x10014000 0x1000>;
         interrupts = <11>;
+        clocks = <&clks 29>, <&clks 60>;
+        clock-names = "ipg", "per";
         dmas = <&dma 7>;
         dma-names = "rx-tx";
         bus-width = <4>;
Signature · 1 line
2.34.1
#2 lore raw
In reply to Fabio Estevam
Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The fsl-imx-mmc hardware needs two clocks to operate: ipg and per.

Quoted 8 lines

Document these required clocks.

This fixes the following schema warning:

imx27-apf27dev.dtb: mmc@10014000: Unevaluated properties are not allowed ('clock-names', 'clocks' were unexpected)
from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-mmc.yaml#

Applied for next, thanks!

Kind regards
Uffe

Quoted 47 lines

---
Changes since v2:
- None. Just fixed a typo in the dt list.

 .../devicetree/bindings/mmc/fsl-imx-mmc.yaml         | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml +12 -1
index 221f5bc047bd..7911316fbd6a 100644
@@ -24,6 +24,14 @@ properties:
   reg:
     maxItems: 1
 
+  clocks:
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: ipg
+      - const: per
+
   interrupts:
     maxItems: 1
 
@@ -34,6 +42,8 @@ properties:
     const: rx-tx
 
 required:
+  - clocks
+  - clock-names
   - compatible
   - reg
   - interrupts
@@ -46,6 +56,8 @@ examples:
         compatible = "fsl,imx27-mmc", "fsl,imx21-mmc";
         reg = <0x10014000 0x1000>;
         interrupts = <11>;
+        clocks = <&clks 29>, <&clks 60>;
+        clock-names = "ipg", "per";
         dmas = <&dma 7>;
         dma-names = "rx-tx";
         bus-width = <4>;
--

2.34.1