dax: remove SLAB_MEM_SPREAD flag usage
PATCH 1/1 dax: remove SLAB_MEM_SPREAD flag usage
From: Chengming Zhou <[email protected]>
The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.
--- drivers/dax/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dax/super.c +1 -1
@@ -547,7 +547,7 @@ static int dax_fs_init(void) dax_cache =kmem_cache_create ("dax_cache" ,sizeof (struct dax_device ),0 , (SLAB_HWCACHE_ALIGN |SLAB_RECLAIM_ACCOUNT | -SLAB_MEM_SPREAD |SLAB_ACCOUNT ), +SLAB_ACCOUNT ), init_once);if (!dax_cache)return -ENOMEM ;
Signature · 1 line
2.40.1
Dave Jiang
maintainerQuoted 4 lines · On 2/24/24 6:47 AM, [email protected] wrote:
From: Chengming Zhou <[email protected]>
The
SLAB_MEM_SPREADflag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.
Can you please provide a Link tag to the lore post that indicates SLAB_MEM_SPREAD flag is now a no-op?
Quoted 19 lines
Signed-off-by Chengming Zhou <[email protected]>--- drivers/dax/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/dax/super.c +1
-1@@ -547,7 +547,7 @@ static int dax_fs_init(void) dax_cache =kmem_cache_create ("dax_cache" ,sizeof (struct dax_device ),0 , (SLAB_HWCACHE_ALIGN |SLAB_RECLAIM_ACCOUNT | -SLAB_MEM_SPREAD |SLAB_ACCOUNT ), +SLAB_ACCOUNT ), init_once);if (!dax_cache)return -ENOMEM ;
Quoted 9 lines · Dave Jiang
Quoted 4 lines · On 2/24/24 6:47 AM, [email protected] wrote:
From: Chengming Zhou <[email protected]>
The
SLAB_MEM_SPREADflag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.Can you please provide a Link tag to the lore post that indicates
SLAB_MEM_SPREADflag is now a no-op?
Update changelog to make it clearer:
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the series[1] went on to mark it obsolete explicitly to avoid confusion for users. Here we can just remove all its users, which has no any functional change.
[1] https://lore.kernel.org/all/[email protected]/
Thanks!
Quoted 19 lines
Quoted 19 lines
Signed-off-by Chengming Zhou <[email protected]>--- drivers/dax/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/dax/super.c +1
-1@@ -547,7 +547,7 @@ static int dax_fs_init(void) dax_cache =kmem_cache_create ("dax_cache" ,sizeof (struct dax_device ),0 , (SLAB_HWCACHE_ALIGN |SLAB_RECLAIM_ACCOUNT | -SLAB_MEM_SPREAD |SLAB_ACCOUNT ), +SLAB_ACCOUNT ), init_once);if (!dax_cache)return -ENOMEM ;
Quoted 20 lines · Chengming Zhou
Quoted 9 lines · Dave Jiang
Quoted 4 lines · On 2/24/24 6:47 AM, [email protected] wrote:
From: Chengming Zhou <[email protected]>
The
SLAB_MEM_SPREADflag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.Can you please provide a Link tag to the lore post that indicates
SLAB_MEM_SPREADflag is now a no-op?Update changelog to make it clearer:
The
SLAB_MEM_SPREADflag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit16a1d968358a("mm/slab: removemm/slab.candslab_def.h"). And the series[1] went on to mark it obsolete explicitly to avoid confusion for users. Here we can just remove all its users, which has no any functional change.
Quoted 3 lines
[1] https://lore.kernel.org/all/[email protected]/
Thanks!
With the updated changelog, you can add
Quoted 20 lines
Quoted 20 lines
Quoted 20 lines
Signed-off-by Chengming Zhou <[email protected]>---
drivers/dax/super.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/dax/super.c +0
-0@@ -547,7 +547,7 @@ static int dax_fs_init(void)
dax_cache= kmem_cache_create("dax_cache",sizeof(struct dax_device), 0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|drivers/dax/super.c +1
-1- SLAB_MEM_SPREAD|SLAB_ACCOUNT), + SLAB_ACCOUNT),
init_once);
if (!dax_cache)
return-ENOMEM;