Skip to contentSkip to conversation

dax: remove SLAB_MEM_SPREAD flag usage

PATCH In review [email protected] 3 participants 4 messages Feb 24, 2024 – Feb 28, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dax: remove SLAB_MEM_SPREAD flag usage

From: Chengming Zhou <[email protected]>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.

---
 drivers/dax/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dax/super.c +1 -1
index 54e528779877..cff0a15b7236 100644
@@ -547,7 +547,7 @@ static int dax_fs_init(void)
 
 	dax_cache = kmem_cache_create("dax_cache", sizeof(struct dax_device), 0,
 			(SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
-			 SLAB_MEM_SPREAD|SLAB_ACCOUNT),
+			 SLAB_ACCOUNT),
 			init_once);
 	if (!dax_cache)
 		return -ENOMEM;
Signature · 1 line
2.40.1
maintainer
#1 lore raw
Quoted 4 lines · On 2/24/24 6:47 AM, [email protected] wrote:

From: Chengming Zhou <[email protected]>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.

Can you please provide a Link tag to the lore post that indicates SLAB_MEM_SPREAD flag is now a no-op?

Quoted 19 lines
---
 drivers/dax/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dax/super.c +1 -1
index 54e528779877..cff0a15b7236 100644
@@ -547,7 +547,7 @@ static int dax_fs_init(void)
 
 	dax_cache = kmem_cache_create("dax_cache", sizeof(struct dax_device), 0,
 			(SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
-			 SLAB_MEM_SPREAD|SLAB_ACCOUNT),
+			 SLAB_ACCOUNT),
 			init_once);
 	if (!dax_cache)
 		return -ENOMEM;
#2 lore raw
Quoted 9 lines · Dave Jiang
Quoted 4 lines · On 2/24/24 6:47 AM, [email protected] wrote:

From: Chengming Zhou <[email protected]>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.

Can you please provide a Link tag to the lore post that indicates SLAB_MEM_SPREAD flag is now a no-op?

Update changelog to make it clearer:

The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the series[1] went on to mark it obsolete explicitly to avoid confusion for users. Here we can just remove all its users, which has no any functional change.

[1] https://lore.kernel.org/all/[email protected]/

Thanks!

Quoted 19 lines
Quoted 19 lines
---
 drivers/dax/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dax/super.c +1 -1
index 54e528779877..cff0a15b7236 100644
@@ -547,7 +547,7 @@ static int dax_fs_init(void)
 
 	dax_cache = kmem_cache_create("dax_cache", sizeof(struct dax_device), 0,
 			(SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
-			 SLAB_MEM_SPREAD|SLAB_ACCOUNT),
+			 SLAB_ACCOUNT),
 			init_once);
 	if (!dax_cache)
 		return -ENOMEM;
maintainer Reviewed-by
#3 lore raw
Quoted 20 lines · Chengming Zhou
Quoted 9 lines · Dave Jiang
Quoted 4 lines · On 2/24/24 6:47 AM, [email protected] wrote:

From: Chengming Zhou <[email protected]>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.

Can you please provide a Link tag to the lore post that indicates SLAB_MEM_SPREAD flag is now a no-op?

Update changelog to make it clearer:

The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the series[1] went on to mark it obsolete explicitly to avoid confusion for users. Here we can just remove all its users, which has no any functional change.

Quoted 3 lines

[1] https://lore.kernel.org/all/[email protected]/

Thanks!

With the updated changelog, you can add

Quoted 20 lines
Quoted 20 lines
Quoted 20 lines

---
 drivers/dax/super.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dax/super.c +0 -0
index 54e528779877..cff0a15b7236 100644
@@ -547,7 +547,7 @@ static int dax_fs_init(void)


  dax_cache = kmem_cache_create("dax_cache", sizeof(struct dax_device), 0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|

drivers/dax/super.c +1 -1
-			 SLAB_MEM_SPREAD|SLAB_ACCOUNT),
+			 SLAB_ACCOUNT),

  init_once);
  if (!dax_cache)
  return -ENOMEM;