i2c: remove redundant condition
Subsystems (2)
PATCH 1/1 i2c: remove redundant condition
I2C_M_RD is defined as 1 and flag & I2C_M_RD is one or zero no need one more condition to get the value
Signed-off-by Hsin-Yu.Chen <[email protected]>
--- include/linux/i2c.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/i2c.h +1 -1
@@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap)static inline u8 i2c_8bit_addr_from_msg (const struct i2c_msg *msg) { -return (msg->addr <<1 ) | (msg->flags &I2C_M_RD ?1 :0 ); +return (msg->addr <<1 ) | (msg->flags &I2C_M_RD ); }u8 *i2c_get_dma_safe_msg_buf (struct i2c_msg *msg,unsigned int threshold);
Signature · 1 line
2.38.1
Hi Hsin-Yu,
Quoted 2 lines · Hsin-Yu.Chen
I2C_M_RDis defined as 1 andflag & I2C_M_RDis one or zero no need one more condition to get the value
this can be written a bit better as:
/no need one more/no need for an additional/
Quoted 1 line
Signed-off-by Hsin-Yu.Chen <[email protected]>
anyway:
Reviewed-by Andi Shyti <[email protected]>
Thanks,
Andi
Quoted 20 lines
--- include/linux/i2c.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/i2c.h +1
-1@@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap)static inline u8 i2c_8bit_addr_from_msg (const struct i2c_msg *msg) { -return (msg->addr <<1 ) | (msg->flags &I2C_M_RD ?1 :0 ); +return (msg->addr <<1 ) | (msg->flags &I2C_M_RD ); }u8 *i2c_get_dma_safe_msg_buf (struct i2c_msg *msg,unsigned int threshold);Signature · 1 line
2.38.1