Skip to contentSkip to conversation

i2c: remove redundant condition

PATCH In review Hsin-Yu.Chen 2 participants 2 messages Mar 5, 2024 – Mar 6, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: remove redundant condition

I2C_M_RD is defined as 1 and flag & I2C_M_RD is one or zero no need one more condition to get the value

---
 include/linux/i2c.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/i2c.h +1 -1
index 652ecb7abeda..363dde9ef94f 100644
@@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap)
 
 static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg)
 {
-	return (msg->addr << 1) | (msg->flags & I2C_M_RD ? 1 : 0);
+	return (msg->addr << 1) | (msg->flags & I2C_M_RD);
 }
 
 u8 *i2c_get_dma_safe_msg_buf(struct i2c_msg *msg, unsigned int threshold);
Signature · 1 line
2.38.1
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi Hsin-Yu,

Quoted 2 lines · Hsin-Yu.Chen

I2C_M_RD is defined as 1 and flag & I2C_M_RD is one or zero no need one more condition to get the value

this can be written a bit better as:

/no need one more/no need for an additional/

Quoted 1 line

anyway:

Thanks,
Andi

Quoted 20 lines
---
 include/linux/i2c.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/i2c.h +1 -1
index 652ecb7abeda..363dde9ef94f 100644
@@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap)
 
 static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg)
 {
-	return (msg->addr << 1) | (msg->flags & I2C_M_RD ? 1 : 0);
+	return (msg->addr << 1) | (msg->flags & I2C_M_RD);
 }
 
 u8 *i2c_get_dma_safe_msg_buf(struct i2c_msg *msg, unsigned int threshold);
Signature · 1 line
2.38.1