perf build: Pretend scandirat is missing with msan
Ian Rogers
reviewerPATCH 1/1 perf build: Pretend scandirat is missing with msan
Memory sanitizer lacks an interceptor for scandirat, reporting all memory it allocates as uninitialized. Memory sanitizer has a scandir interceptor so use the fallback function in this case. This allows perf test to run under memory sanitizer.
--- tools/perf/Makefile.config | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
tools/perf/Makefile.config +4 -1
@@ -486,7 +486,10 @@ ifdef NO_DWARF endif ifeq ($(feature-scandirat), 1) - CFLAGS += -DHAVE_SCANDIRAT_SUPPORT + # Ignore having scandirat with memory sanitizer that lacks an interceptor. + ifeq ($(filter s% -fsanitize=memory%,$(EXTRA_CFLAGS),),) + CFLAGS += -DHAVE_SCANDIRAT_SUPPORT + endif endif ifeq ($(feature-sched_getcpu), 1)
Signature · 1 line
2.44.0.291.gc1ea87d7ee-goog
Ian Rogers
reviewerQuoted 7 lines · Ian Rogers
Memory sanitizer lacks an interceptor for scandirat, reporting all memory it allocates as uninitialized. Memory sanitizer has a scandir interceptor so use the fallback function in this case. This allows perf test to run under memory sanitizer.
Signed-off-by Ian Rogers <[email protected]>
Note, as msan needs to instrument memory allocations libraries need to be compiled with it. I lacked the msan built libraries and so built with:
``` $ make -C tools/perf O=/tmp/perf DEBUG=1 EXTRA_CFLAGS="-O0 -g -fno-omit-frame-pointer -fsanitize=memory -fsanitize-memory-track-origins" CC=clang CXX=clang++ HOSTCC=clang NO_LIBTRACEEVENT=1 NO_LIBELF=1 BUILD_BPF_SKEL=0 NO_LIBPFM=1 ```
oh, I disabled libbpf here as the bpf system call also lacks msan interceptors.
Thanks,
Ian
Quoted 23 lines
--- tools/perf/Makefile.config | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)tools/perf/Makefile.config +4
-2@@ -486,7 +486,10 @@ ifdef NO_DWARF endif ifeq ($(feature-scandirat), 1) - CFLAGS += -DHAVE_SCANDIRAT_SUPPORT + # Ignore having scandirat with memory sanitizer that lacks an interceptor. + ifeq ($(filter s% -fsanitize=memory%,$(EXTRA_CFLAGS),),) + CFLAGS += -DHAVE_SCANDIRAT_SUPPORT + endif endif ifeq ($(feature-sched_getcpu), 1) --2.44.0.291.gc1ea87d7ee-goog
Arnaldo Carvalho de Melo
maintainerQuoted 16 lines · Ian Rogers
Quoted 7 lines · Ian Rogers
Memory sanitizer lacks an interceptor for scandirat, reporting all memory it allocates as uninitialized. Memory sanitizer has a scandir interceptor so use the fallback function in this case. This allows perf test to run under memory sanitizer.
Signed-off-by Ian Rogers <[email protected]>Note, as msan needs to instrument memory allocations libraries need to be compiled with it. I lacked the msan built libraries and so built with:
```$ make -C tools/perf O=/tmp/perf DEBUG=1 EXTRA_CFLAGS="-O0 -g(quoted diff) +0
-2-fno-omit-frame-pointer -fsanitize=memory -fsanitize-memory-track-origins" CC=clang CXX=clang++ HOSTCC=clang
Quoted 3 lines
NO_LIBTRACEEVENT=1 NO_LIBELF=1 BUILD_BPF_SKEL=0 NO_LIBPFM=1
```
oh, I disabled libbpf here as the bpf system call also lacks msan interceptors.
I added the above notes to the cset message.
- Arnaldo
Quoted 26 lines
Thanks,
IanQuoted 23 lines
--- tools/perf/Makefile.config | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)tools/perf/Makefile.config +4
-2@@ -486,7 +486,10 @@ ifdef NO_DWARF endif ifeq ($(feature-scandirat), 1) - CFLAGS += -DHAVE_SCANDIRAT_SUPPORT + # Ignore having scandirat with memory sanitizer that lacks an interceptor. + ifeq ($(filter s% -fsanitize=memory%,$(EXTRA_CFLAGS),),) + CFLAGS += -DHAVE_SCANDIRAT_SUPPORT + endif endif ifeq ($(feature-sched_getcpu), 1) --2.44.0.291.gc1ea87d7ee-goog
Quoted 4 lines · Ian Rogers
Memory sanitizer lacks an interceptor for scandirat, reporting all memory it allocates as uninitialized. Memory sanitizer has a scandir interceptor so use the fallback function in this case. This allows perf test to run under memory sanitizer.
Thanks, applied to perf-tools-next,
- Arnaldo
Quoted 23 lines
Signed-off-by Ian Rogers <[email protected]>--- tools/perf/Makefile.config | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)tools/perf/Makefile.config +4
-1@@ -486,7 +486,10 @@ ifdef NO_DWARF endif ifeq ($(feature-scandirat), 1) - CFLAGS += -DHAVE_SCANDIRAT_SUPPORT + # Ignore having scandirat with memory sanitizer that lacks an interceptor. + ifeq ($(filter s% -fsanitize=memory%,$(EXTRA_CFLAGS),),) + CFLAGS += -DHAVE_SCANDIRAT_SUPPORT + endif endif ifeq ($(feature-sched_getcpu), 1)Signature · 1 line
2.44.0.291.gc1ea87d7ee-goog