Skip to contentSkip to conversation

perf build: Pretend scandirat is missing with msan

PATCH Applied Ian Rogers 2 participants 4 messages Mar 20, 2024 – Apr 25, 2024 perf events

lore
Share & tools
lore

Ian Rogers

author reviewer
#0 lore raw

PATCH 1/1 perf build: Pretend scandirat is missing with msan

Memory sanitizer lacks an interceptor for scandirat, reporting all memory it allocates as uninitialized. Memory sanitizer has a scandir interceptor so use the fallback function in this case. This allows perf test to run under memory sanitizer.

---
 tools/perf/Makefile.config | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
tools/perf/Makefile.config +4 -1
index 1fe8df97fe88..74e0b17050b5 100644
@@ -486,7 +486,10 @@ ifdef NO_DWARF
 endif
 
 ifeq ($(feature-scandirat), 1)
-  CFLAGS += -DHAVE_SCANDIRAT_SUPPORT
+  # Ignore having scandirat with memory sanitizer that lacks an interceptor.
+  ifeq ($(filter s% -fsanitize=memory%,$(EXTRA_CFLAGS),),)
+    CFLAGS += -DHAVE_SCANDIRAT_SUPPORT
+  endif
 endif
 
 ifeq ($(feature-sched_getcpu), 1)
Signature · 1 line
2.44.0.291.gc1ea87d7ee-goog
author reviewer
#1 lore raw
Quoted 7 lines · Ian Rogers

Memory sanitizer lacks an interceptor for scandirat, reporting all memory it allocates as uninitialized. Memory sanitizer has a scandir interceptor so use the fallback function in this case. This allows perf test to run under memory sanitizer.

Note, as msan needs to instrument memory allocations libraries need to be compiled with it. I lacked the msan built libraries and so built with:

```
$ make -C tools/perf O=/tmp/perf DEBUG=1 EXTRA_CFLAGS="-O0 -g
-fno-omit-frame-pointer -fsanitize=memory
-fsanitize-memory-track-origins" CC=clang CXX=clang++ HOSTCC=clang
NO_LIBTRACEEVENT=1 NO_LIBELF=1 BUILD_BPF_SKEL=0 NO_LIBPFM=1
```

oh, I disabled libbpf here as the bpf system call also lacks msan interceptors.

Thanks,
Ian

Quoted 23 lines
---
 tools/perf/Makefile.config | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
tools/perf/Makefile.config +4 -2
index 1fe8df97fe88..74e0b17050b5 100644
@@ -486,7 +486,10 @@ ifdef NO_DWARF
 endif
 
 ifeq ($(feature-scandirat), 1)
-  CFLAGS += -DHAVE_SCANDIRAT_SUPPORT
+  # Ignore having scandirat with memory sanitizer that lacks an interceptor.
+  ifeq ($(filter s% -fsanitize=memory%,$(EXTRA_CFLAGS),),)
+    CFLAGS += -DHAVE_SCANDIRAT_SUPPORT
+  endif
 endif
 
 ifeq ($(feature-sched_getcpu), 1)
--

2.44.0.291.gc1ea87d7ee-goog

#2 lore raw
Quoted 16 lines · Ian Rogers
Quoted 7 lines · Ian Rogers

Memory sanitizer lacks an interceptor for scandirat, reporting all memory it allocates as uninitialized. Memory sanitizer has a scandir interceptor so use the fallback function in this case. This allows perf test to run under memory sanitizer.

Note, as msan needs to instrument memory allocations libraries need to be compiled with it. I lacked the msan built libraries and so built with:
```

$ make -C tools/perf O=/tmp/perf DEBUG=1 EXTRA_CFLAGS="-O0 -g
(quoted diff) +0 -2
-fno-omit-frame-pointer -fsanitize=memory
-fsanitize-memory-track-origins" CC=clang CXX=clang++ HOSTCC=clang
Quoted 3 lines

NO_LIBTRACEEVENT=1 NO_LIBELF=1 BUILD_BPF_SKEL=0 NO_LIBPFM=1
```
oh, I disabled libbpf here as the bpf system call also lacks msan interceptors.

I added the above notes to the cset message.

- Arnaldo

Quoted 26 lines

Thanks,
Ian

Quoted 23 lines
---
 tools/perf/Makefile.config | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
tools/perf/Makefile.config +4 -2
index 1fe8df97fe88..74e0b17050b5 100644
@@ -486,7 +486,10 @@ ifdef NO_DWARF
 endif
 
 ifeq ($(feature-scandirat), 1)
-  CFLAGS += -DHAVE_SCANDIRAT_SUPPORT
+  # Ignore having scandirat with memory sanitizer that lacks an interceptor.
+  ifeq ($(filter s% -fsanitize=memory%,$(EXTRA_CFLAGS),),)
+    CFLAGS += -DHAVE_SCANDIRAT_SUPPORT
+  endif
 endif
 
 ifeq ($(feature-sched_getcpu), 1)
--

2.44.0.291.gc1ea87d7ee-goog

maintainer Applied
#3 lore raw
In reply to Ian Rogers
Quoted 4 lines · Ian Rogers

Memory sanitizer lacks an interceptor for scandirat, reporting all memory it allocates as uninitialized. Memory sanitizer has a scandir interceptor so use the fallback function in this case. This allows perf test to run under memory sanitizer.

Thanks, applied to perf-tools-next,

- Arnaldo

Quoted 23 lines
---
 tools/perf/Makefile.config | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
tools/perf/Makefile.config +4 -1
index 1fe8df97fe88..74e0b17050b5 100644
@@ -486,7 +486,10 @@ ifdef NO_DWARF
 endif
 
 ifeq ($(feature-scandirat), 1)
-  CFLAGS += -DHAVE_SCANDIRAT_SUPPORT
+  # Ignore having scandirat with memory sanitizer that lacks an interceptor.
+  ifeq ($(filter s% -fsanitize=memory%,$(EXTRA_CFLAGS),),)
+    CFLAGS += -DHAVE_SCANDIRAT_SUPPORT
+  endif
 endif
 
 ifeq ($(feature-sched_getcpu), 1)
Signature · 1 line
2.44.0.291.gc1ea87d7ee-goog