Skip to contentSkip to conversation

dt-bindings: arm: ti: Add BeagleY-AI

PATCH Applied Robert Nelson 5 participants 12 messages Mar 28, 2024 – Apr 23, 2024

Subsystems (2)
Device tree bindings Arm/Texas Instruments K3 architecture

v1 of 4 Applied Latest is v4 →

lore
Share & tools
lore

Robert Nelson

author
#0 lore raw

PATCH 1/2 dt-bindings: arm: ti: Add BeagleY-AI

This board is based on ti,j722s

https://beagley-ai.org/
https://openbeagle.org/beagley-ai/beagley-ai

Signed-off-by Robert Nelson <[email protected]>
CC Rob Herring <[email protected]>
CC Nishanth Menon <[email protected]>
CC Jared McArthur <[email protected]>
CC Jason Kridner <[email protected]>
CC Deepak Khatri <[email protected]>
---
 Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/ti/k3.yaml +1 -0
index 52b51fd7044e..ca23b7e6a35e 100644
@@ -134,6 +134,7 @@ properties:
       - description: K3 J722S SoC and Boards
         items:
           - enum:
+              - beagle,j722s-beagley-ai
               - ti,j722s-evm
           - const: ti,j722s
Signature · 1 line
2.39.2
author
#1 lore raw

PATCH 2/2 arm64: dts: ti: Add k3-j722s-beagley-ai

BeagleBoard.org BeagleY-AI is an easy to use, affordable open source hardware single board computer based on the Texas Instruments AM67A, which features a quad-core 64-bit Arm CPU subsystem, 2 general-purpose digital-signal-processors (DSP) and matrix-multiply-accelerators (MMA), GPU, vision and deep learning accelerators, and multiple Arm Cortex-R5 cores for low-power, low-latency GPIO control.

https://beagley-ai.org/
https://openbeagle.org/beagley-ai/beagley-ai

Signed-off-by Robert Nelson <[email protected]>
CC Nishanth Menon <[email protected]>
CC Jared McArthur <[email protected]>
CC Jason Kridner <[email protected]>
CC Deepak Khatri <[email protected]>
---
 arch/arm64/boot/dts/ti/Makefile               |   1 +
 .../arm64/boot/dts/ti/k3-j722s-beagley-ai.dts | 373 ++++++++++++++++++
 2 files changed, 374 insertions(+)
 create mode 100644 arch/arm64/boot/dts/ti/k3-j722s-beagley-ai.dts
arch/arm64/boot/dts/ti/Makefile +1 -0
index 9a722c2473fb..c76b41f86527 100644
@@ -95,6 +95,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb
 dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm-pcie1-ep.dtbo
 
 # Boards with J722s SoC
+dtb-$(CONFIG_ARCH_K3) += k3-j722s-beagley-ai.dtb
 dtb-$(CONFIG_ARCH_K3) += k3-j722s-evm.dtb
 
 # Boards with J784s4 SoC
arch/arm64/boot/dts/ti/k3-j722s-beagley-ai.dts new file +373 -0

373 lines not on this page · raw message

Signature · 1 line
2.39.2
author
#2 lore raw

Re: [PATCH 2/2] arm64: dts: ti: Add k3-j722s-beagley-ai

Quoted 10 lines · Robert Nelson

BeagleBoard.org BeagleY-AI is an easy to use, affordable open source hardware single board computer based on the Texas Instruments AM67A, which features a quad-core 64-bit Arm CPU subsystem, 2 general-purpose digital-signal-processors (DSP) and matrix-multiply-accelerators (MMA), GPU, vision and deep learning accelerators, and multiple Arm Cortex-R5 cores for low-power, low-latency GPIO control.

https://beagley-ai.org/
https://openbeagle.org/beagley-ai/beagley-ai

@Jason Kridner we need this to become public when you are ready ^ ;)

Boot log:

https://gist.github.com/RobertCNelson/9db8ea04848e7ce2ca52c038fab0e1b7

Signature · 2 lines
Robert Nelson
https://rcn-ee.com/
#3 lore raw

Re: [PATCH 2/2] arm64: dts: ti: Add k3-j722s-beagley-ai

Quoted 13 lines · Robert Nelson
Quoted 8 lines · Robert Nelson

BeagleBoard.org BeagleY-AI is an easy to use, affordable open source hardware single board computer based on the Texas Instruments AM67A, which features a quad-core 64-bit Arm CPU subsystem, 2 general-purpose digital-signal-processors (DSP) and matrix-multiply-accelerators (MMA), GPU, vision and deep learning accelerators, and multiple Arm Cortex-R5 cores for low-power, low-latency GPIO control.

Quoted 5 lines
Quoted 2 lines

https://beagley-ai.org/
https://openbeagle.org/beagley-ai/beagley-ai

@Jason Kridner we need this to become public when you are ready ^ ;)

Did I mess up? Should already be public. We should make a github.com mirror though for up-time/visibility/bandwidth.

Quoted 7 lines

Boot log:

https://gist.github.com/RobertCNelson/9db8ea04848e7ce2ca52c038fab0e1b7

--
Robert Nelson
https://rcn-ee.com/

author
#4 lore raw

Re: [PATCH 2/2] arm64: dts: ti: Add k3-j722s-beagley-ai

Quoted 14 lines · Jason Kridner
Quoted 14 lines · Robert Nelson
Quoted 8 lines · Robert Nelson

BeagleBoard.org BeagleY-AI is an easy to use, affordable open source hardware single board computer based on the Texas Instruments AM67A, which features a quad-core 64-bit Arm CPU subsystem, 2 general-purpose digital-signal-processors (DSP) and matrix-multiply-accelerators (MMA), GPU, vision and deep learning accelerators, and multiple Arm Cortex-R5 cores for low-power, low-latency GPIO control.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

https://beagley-ai.org/
https://openbeagle.org/beagley-ai/beagley-ai

@Jason Kridner we need this to become public when you are ready ^ ;)

Did I mess up? Should already be public. We should make a github.com mirror though for up-time/visibility/bandwidth.

Thanks Jason, it seems to work in incognito mode now, so we are good!

Regards,

Signature · 2 lines
Robert Nelson
https://rcn-ee.com/
maintainer
#5 lore raw
In reply to Robert Nelson
Quoted 11 lines · Robert Nelson

This board is based on ti,j722s

https://beagley-ai.org/
https://openbeagle.org/beagley-ai/beagley-ai

Signed-off-by Robert Nelson <[email protected]>
CC Rob Herring <[email protected]>
CC Nishanth Menon <[email protected]>
CC Jared McArthur <[email protected]>
CC Jason Kridner <[email protected]>
CC Deepak Khatri <[email protected]>
Quoted 4 lines
---
 Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
 1 file changed, 1 insertion(+)

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y ti/k3-j722s-beagley-ai.dtb' for [email protected]:

arch/arm64/boot/dts/ti/k3-j722s-beagley-ai.dtb: pinctrl@f4000: 'vdd-3v3-sd-pins-default' does not match any of the regexes: '-pins(-[0-9]+)?$|-pin$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/pinctrl/pinctrl-single.yaml#

maintainer Acked-by on v1 1/2
#6 lore raw
In reply to Robert Nelson
Quoted 11 lines · Robert Nelson

This board is based on ti,j722s

https://beagley-ai.org/
https://openbeagle.org/beagley-ai/beagley-ai

Signed-off-by Robert Nelson <[email protected]>
CC Rob Herring <[email protected]>
CC Nishanth Menon <[email protected]>
CC Jared McArthur <[email protected]>
CC Jason Kridner <[email protected]>
CC Deepak Khatri <[email protected]>
Quoted 4 lines
---
 Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
 1 file changed, 1 insertion(+)
Acked-by Rob Herring <[email protected]>
maintainer Applied
#7 lore raw
In reply to Robert Nelson

Hi Robert Nelson,

Quoted 6 lines · Robert Nelson

This board is based on ti,j722s

https://beagley-ai.org/
https://openbeagle.org/beagley-ai/beagley-ai

Robert,
I did a couple of sync as part of rebase - but for the future, please be aware of [2]

I have applied the following to branch ti-k3-dts-next on [1]. Thank you!

[1/2] dt-bindings: arm: ti: Add BeagleY-AI

      commit: d2b3e3b544d7e657406db3bdcdc296f02f4f07c9
[2/2] arm64: dts: ti: Add k3-j722s-beagley-ai
      commit: f6a61274cc851e1dbae82b5fa2d3e7087dccf85b

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
[2] https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#8 lore raw
In reply to Robert Nelson
Quoted 20 lines · Robert Nelson

This board is based on ti,j722s

https://beagley-ai.org/
https://openbeagle.org/beagley-ai/beagley-ai

Signed-off-by Robert Nelson <[email protected]>
CC Rob Herring <[email protected]>
CC Nishanth Menon <[email protected]>
CC Jared McArthur <[email protected]>
CC Jason Kridner <[email protected]>
CC Deepak Khatri <[email protected]>
---
  Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
  1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/ti/k3.yaml +0 -0
index 52b51fd7044e..ca23b7e6a35e 100644

Documentation/devicetree/bindings/arm/ti/k3.yaml properties: · line 137

Quoted 4 lines
Documentation/devicetree/bindings/arm/ti/k3.yaml +1 -0
@@ -134,6 +134,7 @@ properties:
        - description: K3 J722S SoC and Boards
          items:
            - enum:
+              - beagle,j722s-beagley-ai

Recommend "beagle,am67-beagley-ai". The "J722s" is the family name, the part used on this board is the AM67. We do the same for the SK boards, for example, the SK-AM69 uses the AM69 part from the J784s4 family, so it is called k3-am69-sk.dts with compatible = "ti,am69-sk", "ti,j784s4";

This would otherwise be the first board with a specific part attached but uses the SoC family name instead of that specific part name in the DT file/name. Only the EVMs should have the family name since we sell versions of those with all the different parts swapped onto it. I don't imagine you will be selling BeagleY's with TDA4VEN, TDA4AEN, DRA82x, etc.. All your docs and other collateral use "AM67", using the same here would help avoid confusion.

Andrew

Quoted 3 lines
Documentation/devicetree/bindings/arm/ti/k3.yaml +0 -0
                - ti,j722s-evm
            - const: ti,j722s
author
#9 lore raw
Quoted 42 lines · Andrew Davis
Quoted 20 lines · Robert Nelson

This board is based on ti,j722s

https://beagley-ai.org/
https://openbeagle.org/beagley-ai/beagley-ai

Signed-off-by Robert Nelson <[email protected]>
CC Rob Herring <[email protected]>
CC Nishanth Menon <[email protected]>
CC Jared McArthur <[email protected]>
CC Jason Kridner <[email protected]>
CC Deepak Khatri <[email protected]>
---
  Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
  1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/ti/k3.yaml +0 -0
index 52b51fd7044e..ca23b7e6a35e 100644

Documentation/devicetree/bindings/arm/ti/k3.yaml properties: · line 137

Quoted 4 lines
Documentation/devicetree/bindings/arm/ti/k3.yaml +1 -0
@@ -134,6 +134,7 @@ properties:
        - description: K3 J722S SoC and Boards
          items:
            - enum:
+              - beagle,j722s-beagley-ai

Recommend "beagle,am67-beagley-ai". The "J722s" is the family name, the part used on this board is the AM67. We do the same for the SK boards, for example, the SK-AM69 uses the AM69 part from the J784s4 family, so it is called k3-am69-sk.dts with compatible = "ti,am69-sk", "ti,j784s4";

This would otherwise be the first board with a specific part attached but uses the SoC family name instead of that specific part name in the DT file/name. Only the EVMs should have the family name since we sell versions of those with all the different parts swapped onto it. I don't imagine you will be selling BeagleY's with TDA4VEN, TDA4AEN, DRA82x, etc.. All your docs and other collateral use "AM67", using the same here would help avoid confusion.

Quoted 1 line

Andrew

Andrew, would you like us to model this just like the AM69-SK? and also rename the device tree? or just the bindings..

k3-j722s-beagley-ai.dtb -> k3-am67-beagley-ai.dtb or even the am67a k3-am67a-beagley-ai.dtb ?

Regards,

Signature · 2 lines
Robert Nelson
https://rcn-ee.com/
maintainer
#10 lore raw
Quoted 43 lines · Robert Nelson
Quoted 42 lines · Andrew Davis
Quoted 20 lines · Robert Nelson

This board is based on ti,j722s

https://beagley-ai.org/
https://openbeagle.org/beagley-ai/beagley-ai

Signed-off-by Robert Nelson <[email protected]>
CC Rob Herring <[email protected]>
CC Nishanth Menon <[email protected]>
CC Jared McArthur <[email protected]>
CC Jason Kridner <[email protected]>
CC Deepak Khatri <[email protected]>
---
  Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
  1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/ti/k3.yaml +0 -0
index 52b51fd7044e..ca23b7e6a35e 100644

Documentation/devicetree/bindings/arm/ti/k3.yaml properties: · line 137

Quoted 4 lines
Documentation/devicetree/bindings/arm/ti/k3.yaml +1 -0
@@ -134,6 +134,7 @@ properties:
        - description: K3 J722S SoC and Boards
          items:
            - enum:
+              - beagle,j722s-beagley-ai

Recommend "beagle,am67-beagley-ai". The "J722s" is the family name, the part used on this board is the AM67. We do the same for the SK boards, for example, the SK-AM69 uses the AM69 part from the J784s4 family, so it is called k3-am69-sk.dts with compatible = "ti,am69-sk", "ti,j784s4";

This would otherwise be the first board with a specific part attached but uses the SoC family name instead of that specific part name in the DT file/name. Only the EVMs should have the family name since we sell versions of those with all the different parts swapped onto it. I don't imagine you will be selling BeagleY's with TDA4VEN, TDA4AEN, DRA82x, etc.. All your docs and other collateral use "AM67", using the same here would help avoid confusion.

Quoted 8 lines
Quoted 1 line

Andrew

Andrew, would you like us to model this just like the AM69-SK? and also rename the device tree? or just the bindings..

k3-j722s-beagley-ai.dtb -> k3-am67-beagley-ai.dtb or even the am67a k3-am67a-beagley-ai.dtb ?

Will drop these patches off the queue for now. please respin as needed.

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#11 lore raw
In reply to Robert Nelson
Quoted 43 lines · Robert Nelson
Quoted 42 lines · Andrew Davis
Quoted 20 lines · Robert Nelson

This board is based on ti,j722s

https://beagley-ai.org/
https://openbeagle.org/beagley-ai/beagley-ai

Signed-off-by Robert Nelson <[email protected]>
CC Rob Herring <[email protected]>
CC Nishanth Menon <[email protected]>
CC Jared McArthur <[email protected]>
CC Jason Kridner <[email protected]>
CC Deepak Khatri <[email protected]>
---
   Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
   1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/ti/k3.yaml +0 -0
index 52b51fd7044e..ca23b7e6a35e 100644

Documentation/devicetree/bindings/arm/ti/k3.yaml properties: · line 137

Quoted 4 lines
Documentation/devicetree/bindings/arm/ti/k3.yaml +1 -0
@@ -134,6 +134,7 @@ properties:
         - description: K3 J722S SoC and Boards
           items:
             - enum:
+              - beagle,j722s-beagley-ai

Recommend "beagle,am67-beagley-ai". The "J722s" is the family name, the part used on this board is the AM67. We do the same for the SK boards, for example, the SK-AM69 uses the AM69 part from the J784s4 family, so it is called k3-am69-sk.dts with compatible = "ti,am69-sk", "ti,j784s4";

This would otherwise be the first board with a specific part attached but uses the SoC family name instead of that specific part name in the DT file/name. Only the EVMs should have the family name since we sell versions of those with all the different parts swapped onto it. I don't imagine you will be selling BeagleY's with TDA4VEN, TDA4AEN, DRA82x, etc.. All your docs and other collateral use "AM67", using the same here would help avoid confusion.

Quoted 8 lines
Quoted 1 line

Andrew

Andrew, would you like us to model this just like the AM69-SK? and also rename the device tree? or just the bindings..

k3-j722s-beagley-ai.dtb -> k3-am67-beagley-ai.dtb or even the am67a k3-am67a-beagley-ai.dtb ?

Yes, rename binding and dtb name would be great. Better now then have the name confuse folks forever.

AM67A is more correct than AM67 (which is the spin without AI), given this is an AI focused device I'd imagine you'll be using the "a" version.

Andrew

Quoted 2 lines

Regards,