Skip to contentSkip to conversation

arm64: dts: stratix10: socdk: drop unneeded flash address/size-cells

PATCH In review Krzysztof Kozlowski 3 participants 7 messages Apr 1, 2024 – Jun 6, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/4 arm64: dts: stratix10: socdk: drop unneeded flash address/size-cells

Flash node uses single "partition" node to describe partitions, so remove deprecated address/size-cells properties to also fix dtc W=1 warnings:

socfpga_stratix10_socdk.dts:182.10-211.4: Warning (avoid_unnecessary_addr_size): /soc@0/spi@ff8d2000/flash@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

---
 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 --
 1 file changed, 2 deletions(-)
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts +0 -2
index 26173f0b0051..4eee777ef1a1 100644
@@ -180,8 +180,6 @@ rtc@68 {
 &qspi {
 	status = "okay";
 	flash@0 {
-		#address-cells = <1>;
-		#size-cells = <1>;
 		compatible = "micron,mt25qu02g", "jedec,spi-nor";
 		reg = <0>;
 		spi-max-frequency = <100000000>;
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/4 arm64: dts: stratix10: socdk_nand: drop unneeded flash address/size-cells

Flash node uses single "partition" node to describe partitions, so remove deprecated address/size-cells properties to also fix dtc W=1 warnings:

socfpga_stratix10_socdk_nand.dts:171.10-200.4: Warning (avoid_unnecessary_addr_size): /soc@0/spi@ff8d2000/flash@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

---
 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts | 2 --
 1 file changed, 2 deletions(-)
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts +0 -2
index 81d0e914a77c..7c53cb9621e5 100644
@@ -169,8 +169,6 @@ rtc@68 {
 &qspi {
 	status = "okay";
 	flash@0 {
-		#address-cells = <1>;
-		#size-cells = <1>;
 		compatible = "micron,mt25qu02g", "jedec,spi-nor";
 		reg = <0>;
 		spi-max-frequency = <100000000>;
Signature · 1 line
2.34.1
#2 lore raw

PATCH 3/4 arm64: dts: agilex: socdk: drop unneeded flash address/size-cells

In reply to Krzysztof Kozlowski

Flash node uses single "partition" node to describe partitions, so remove deprecated address/size-cells properties to also fix dtc W=1 warnings:

socfpga_agilex_socdk.dts:108.10-137.4: Warning (avoid_unnecessary_addr_size): /soc@0/spi@ff8d2000/flash@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

---
 arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts | 2 --
 1 file changed, 2 deletions(-)
arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts +0 -2
index ad99aefeb185..b31cfa6b802d 100644
@@ -106,8 +106,6 @@ &watchdog0 {
 &qspi {
 	status = "okay";
 	flash@0 {
-		#address-cells = <1>;
-		#size-cells = <1>;
 		compatible = "micron,mt25qu02g", "jedec,spi-nor";
 		reg = <0>;
 		spi-max-frequency = <100000000>;
Signature · 1 line
2.34.1
#3 lore raw

PATCH 4/4 arm64: dts: n5x: socdk: drop unneeded flash address/size-cells

In reply to Krzysztof Kozlowski

Flash node uses single "partition" node to describe partitions, so remove deprecated address/size-cells properties to also fix dtc W=1 warnings:

socfpga_n5x_socdk.dts:85.10-114.4: Warning (avoid_unnecessary_addr_size): /soc@0/spi@ff8d2000/flash@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

---
 arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts | 2 --
 1 file changed, 2 deletions(-)
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts +0 -2
index 2d70a92c2090..7952c7f47cc2 100644
@@ -83,8 +83,6 @@ &osc1 {
 &qspi {
 	status = "okay";
 	flash@0 {
-		#address-cells = <1>;
-		#size-cells = <1>;
 		compatible = "micron,mt25qu02g", "jedec,spi-nor";
 		reg = <0>;
 		spi-max-frequency = <100000000>;
Signature · 1 line
2.34.1
maintainer
#4 lore raw
In reply to Krzysztof Kozlowski
Quoted 16 lines · Krzysztof Kozlowski

Flash node uses single "partition" node to describe partitions, so remove deprecated address/size-cells properties to also fix dtc W=1 warnings:

socfpga_stratix10_socdk.dts:182.10-211.4: Warning (avoid_unnecessary_addr_size): /soc@0/spi@ff8d2000/flash@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

---
  arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 --
  1 file changed, 2 deletions(-)
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts +0 -0
index 26173f0b0051..4eee777ef1a1 100644

arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts rtc@68 { · line 185

Quoted 8 lines
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts +0 -2
@@ -180,8 +180,6 @@ rtc@68 {
  &qspi {
  	status = "okay";
  	flash@0 {
-		#address-cells = <1>;
-		#size-cells = <1>;
  		compatible = "micron,mt25qu02g", "jedec,spi-nor";
  		reg = <0>;
  		spi-max-frequency = <100000000>;

All patches applied!

Thanks,
Dinh

#5 lore raw
Quoted 12 lines · Dinh Nguyen
Quoted 11 lines · Krzysztof Kozlowski

Flash node uses single "partition" node to describe partitions, so remove deprecated address/size-cells properties to also fix dtc W=1 warnings:

socfpga_stratix10_socdk.dts:182.10-211.4: Warning (avoid_unnecessary_addr_size): /soc@0/spi@ff8d2000/flash@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

---
  arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 --
  1 file changed, 2 deletions(-)
Quoted 15 lines

arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts rtc@68 { · line 185

Quoted 13 lines
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts +0 -2
index 26173f0b0051..4eee777ef1a1 100644
@@ -180,8 +180,6 @@ rtc@68 {
  &qspi {
  	status = "okay";
  	flash@0 {
-		#address-cells = <1>;
-		#size-cells = <1>;
  		compatible = "micron,mt25qu02g", "jedec,spi-nor";
  		reg = <0>;
  		spi-max-frequency = <100000000>;

All patches applied!

This was two months ago, so it should reach v6.10-rc1. It is neither in v6.10-rc1 nor in linux-next.

Are you sure you applied this?

Are your trees in linux-next?

Best regards,
Krzysztof

maintainer
#6 lore raw
Quoted 29 lines · Krzysztof Kozlowski
Quoted 12 lines · Dinh Nguyen
Quoted 11 lines · Krzysztof Kozlowski

Flash node uses single "partition" node to describe partitions, so remove deprecated address/size-cells properties to also fix dtc W=1 warnings:

    socfpga_stratix10_socdk.dts:182.10-211.4: Warning (avoid_unnecessary_addr_size): /soc@0/spi@ff8d2000/flash@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
---
   arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 --
   1 file changed, 2 deletions(-)
Quoted 15 lines

arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts rtc@68 { · line 185

Quoted 13 lines
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts +0 -2
index 26173f0b0051..4eee777ef1a1 100644
@@ -180,8 +180,6 @@ rtc@68 {
   &qspi {
   	status = "okay";
   	flash@0 {
-		#address-cells = <1>;
-		#size-cells = <1>;
   		compatible = "micron,mt25qu02g", "jedec,spi-nor";
   		reg = <0>;
   		spi-max-frequency = <100000000>;

All patches applied!

Quoted 6 lines

This was two months ago, so it should reach v6.10-rc1. It is neither in v6.10-rc1 nor in linux-next.

Are you sure you applied this?

Are your trees in linux-next?

I apologize, I miss the PR for the v6.10. I have it queue for v6.11.

Dinh