Skip to contentSkip to conversation

test_migrate_unmapped_collection test fails during skip

PATCH In review Jan Richter 2 participants 2 messages Apr 19, 2024 KVM

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 test_migrate_unmapped_collection test fails during skip

The test_migrate_unmapped_collection test fails when the errata requirements are not met and the test should be skipped. Instead of being skipped, the test returns ERROR: Test exit before migration point.

This is caused by changes in commit fa8914bccc22 ("migration: Add a migrate_skip command") which changes the behaviour of skipped migration tests. This fixes this issue by adding migrate_skip() method to test_migrate_unmapped_collection.

Fixes fa8914bccc22 ("migration: Add a migrate_skip command")

---
Changes from v1->v2:
1. typo fix meet/met
2. commit reference changed
3. Fixes tag added

 arm/gic.c | 1 +
 1 file changed, 1 insertion(+)
arm/gic.c +1 -0
index bbf828f1..256dd80d 100644
@@ -829,6 +829,7 @@ static void test_migrate_unmapped_collection(void)
 	if (!errata(ERRATA_UNMAPPED_COLLECTIONS)) {
 		report_skip("Skipping test, as this test hangs without the fix. "
 			    "Set %s=y to enable.", ERRATA_UNMAPPED_COLLECTIONS);
+		migrate_skip();
 		return;
 	}
 
Signature · 1 line
2.44.0
#1 lore raw
Quoted 36 lines · Jan Richter

The test_migrate_unmapped_collection test fails when the errata requirements are not met and the test should be skipped. Instead of being skipped, the test returns ERROR: Test exit before migration point.

This is caused by changes in commit fa8914bccc22 ("migration: Add a migrate_skip command") which changes the behaviour of skipped migration tests. This fixes this issue by adding migrate_skip() method to test_migrate_unmapped_collection.

Fixes fa8914bccc22 ("migration: Add a migrate_skip command")

---
Changes from v1->v2:
1. typo fix meet/met
2. commit reference changed
3. Fixes tag added

 arm/gic.c | 1 +
 1 file changed, 1 insertion(+)
arm/gic.c +1 -0
index bbf828f1..256dd80d 100644
@@ -829,6 +829,7 @@ static void test_migrate_unmapped_collection(void)
 	if (!errata(ERRATA_UNMAPPED_COLLECTIONS)) {
 		report_skip("Skipping test, as this test hangs without the fix. "
 			    "Set %s=y to enable.", ERRATA_UNMAPPED_COLLECTIONS);
+		migrate_skip();
 		return;
 	}
 
Signature · 1 line
2.44.0

Merged.

Thanks,
drew