Skip to contentSkip to conversation

test_migrate_unmapped_collection test fails during skip

PATCH Superseded Jan Richter 2 participants 3 messages Apr 18, 2024 – Apr 19, 2024 KVM

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test_migrate_unmapped_collection test fails during skip

The test_migrate_unmapped_collection test fails when the errata requirements are not meet and the test should be skipped. Instead of being skipped, the test returns ERROR: Test exit before migration point.

This is caused by changes in fa8914bccc226db86bd70d71bfd6022db252fc78 which changes the behaviour of skipped migration tests. This fixes this issue by adding migrate_skip() method to test_migrate_unmapped_collection.

---
 arm/gic.c | 1 +
 1 file changed, 1 insertion(+)
arm/gic.c +1 -0
index bbf828f1..256dd80d 100644
@@ -829,6 +829,7 @@ static void test_migrate_unmapped_collection(void)
 	if (!errata(ERRATA_UNMAPPED_COLLECTIONS)) {
 		report_skip("Skipping test, as this test hangs without the fix. "
 			    "Set %s=y to enable.", ERRATA_UNMAPPED_COLLECTIONS);
+		migrate_skip();
 		return;
 	}
 
Signature · 1 line
2.44.0
#1 lore raw
Quoted 2 lines · Jan Richter

The test_migrate_unmapped_collection test fails when the errata requirements are not meet and the test should be skipped. Instead of

met

Quoted 4 lines

being skipped, the test returns ERROR: Test exit before migration point.

This is caused by changes in fa8914bccc226db86bd70d71bfd6022db252fc78

Please use the standard way of referencing commits, which, in this case, would be

commit fa8914bccc22 ("migration: Add a migrate_skip command")

Quoted 3 lines

which changes the behaviour of skipped migration tests. This fixes this issue by adding migrate_skip() method to test_migrate_unmapped_collection.

And we should add a Fixes tag

Fixes fa8914bccc22 ("migration: Add a migrate_skip command")
Quoted 21 lines
---
 arm/gic.c | 1 +
 1 file changed, 1 insertion(+)
arm/gic.c +1 -0
index bbf828f1..256dd80d 100644
@@ -829,6 +829,7 @@ static void test_migrate_unmapped_collection(void)
 	if (!errata(ERRATA_UNMAPPED_COLLECTIONS)) {
 		report_skip("Skipping test, as this test hangs without the fix. "
 			    "Set %s=y to enable.", ERRATA_UNMAPPED_COLLECTIONS);
+		migrate_skip();
 		return;
 	}
 
Signature · 1 line
2.44.0

Otherwise LGTM

Thanks,
drew

#2 lore raw
Quoted 42 lines · Andrew Jones
Quoted 2 lines · Jan Richter

The test_migrate_unmapped_collection test fails when the errata requirements are not meet and the test should be skipped. Instead of

met

Quoted 4 lines

being skipped, the test returns ERROR: Test exit before migration point.

This is caused by changes in fa8914bccc226db86bd70d71bfd6022db252fc78

Please use the standard way of referencing commits, which, in this case, would be

commit fa8914bccc22 ("migration: Add a migrate_skip command")

Quoted 3 lines

which changes the behaviour of skipped migration tests. This fixes this issue by adding migrate_skip() method to test_migrate_unmapped_collection.

And we should add a Fixes tag

Fixes fa8914bccc22 ("migration: Add a migrate_skip command")
Quoted 18 lines
---
 arm/gic.c | 1 +
 1 file changed, 1 insertion(+)
arm/gic.c +1 -0
index bbf828f1..256dd80d 100644
@@ -829,6 +829,7 @@ static void test_migrate_unmapped_collection(void)
 	if (!errata(ERRATA_UNMAPPED_COLLECTIONS)) {
 		report_skip("Skipping test, as this test hangs without the fix. "
 			    "Set %s=y to enable.", ERRATA_UNMAPPED_COLLECTIONS);
+		migrate_skip();
 		return;
 	}
 
Quoted 9 lines
Quoted 3 lines
Signature · 1 line
2.44.0

Otherwise LGTM

Thanks,
drew

Hi Drew,

thanks for the review. I will send new version with fixed commit message.

- Jan