Skip to contentSkip to conversation

vfio/pci: fix potential memory leak in vfio_intx_enable()

PATCH Applied Ye Bin 4 participants 4 messages Apr 15, 2024 – Apr 23, 2024

Subsystems (2)
lore
Share & tools
lore

Ye Bin

author
#0 lore raw

PATCH 1/1 vfio/pci: fix potential memory leak in vfio_intx_enable()

If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak.

Fixes 18c198c96a81 ("vfio/pci: Create persistent INTx handler")
---
 drivers/vfio/pci/vfio_pci_intrs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/vfio/pci/vfio_pci_intrs.c +3 -1
index fb5392b749ff..e80c5d75b541 100644
@@ -277,8 +277,10 @@ static int vfio_intx_enable(struct vfio_pci_core_device *vdev,
 		return -ENOMEM;
 
 	ctx = vfio_irq_ctx_alloc(vdev, 0);
-	if (!ctx)
+	if (!ctx) {
+		kfree(name);
 		return -ENOMEM;
+	}
 
 	ctx->name = name;
 	ctx->trigger = trigger;
Signature · 1 line
2.31.1
#3 lore raw
In reply to Ye Bin
Quoted 7 lines · On Mon, 15 Apr 2024 09:50:29 +0800 Ye Bin <[email protected]> wrote:

If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak.

Fixes 18c198c96a81 ("vfio/pci: Create persistent INTx handler")
---
 drivers/vfio/pci/vfio_pci_intrs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Applied to vfio next branch for v6.10. Thanks!

Alex