vfio/pci: fix potential memory leak in vfio_intx_enable()
Subsystems (2)
PATCH 1/1 vfio/pci: fix potential memory leak in vfio_intx_enable()
If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak.
Fixes 18c198c96a81 ("vfio/pci: Create persistent INTx handler")
Signed-off-by Ye Bin <[email protected]>
--- drivers/vfio/pci/vfio_pci_intrs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/vfio/pci/vfio_pci_intrs.c +3 -1
@@ -277,8 +277,10 @@ static int vfio_intx_enable(struct vfio_pci_core_device *vdev,return -ENOMEM ; ctx =vfio_irq_ctx_alloc (vdev,0 ); -if (!ctx) +if (!ctx) { +kfree (name);return -ENOMEM ; + } ctx->name = name; ctx->trigger = trigger;
Signature · 1 line
2.31.1
Quoted 7 lines
From: Ye Bin <[email protected]>
Sent: Monday, April 15, 2024 9:50 AMIf
vfio_irq_ctx_alloc()failed will lead to 'name' memory leak.Fixes 18c198c96a81 ("vfio/pci: Create persistent INTx handler")Signed-off-by Ye Bin <[email protected]>
Reviewed-by Kevin Tian <[email protected]>
Quoted 5 lines · Ye Bin
If
vfio_irq_ctx_alloc()failed will lead to 'name' memory leak.Fixes 18c198c96a81 ("vfio/pci: Create persistent INTx handler")Signed-off-by Ye Bin <[email protected]>---
Thank you for catching this.
Acked-by Reinette Chatre <[email protected]>
Reinette
Alex Williamson
AppliedQuoted 7 lines · On Mon, 15 Apr 2024 09:50:29 +0800 Ye Bin <[email protected]> wrote:
If
vfio_irq_ctx_alloc()failed will lead to 'name' memory leak.Fixes 18c198c96a81 ("vfio/pci: Create persistent INTx handler")Signed-off-by Ye Bin <[email protected]>--- drivers/vfio/pci/vfio_pci_intrs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Applied to vfio next branch for v6.10. Thanks!
Alex