Skip to contentSkip to conversation

PCI/ASPM: Add notes about enabling PCI-PM L1SS to pci_enable_link_state(_locked)

PATCH Superseded Jian-Hong Pan 1 participant 1 message Apr 24, 2024 PCI

v5 of 12 Superseded Latest is v12 →

lore
Share & tools
lore
#0 lore raw

PATCH v5 2/4 PCI/ASPM: Add notes about enabling PCI-PM L1SS to pci_enable_link_state(_locked)

According to "PCIe r6.0, sec 5.5.4", add note about D0 requirement in pci_enable_link_state() kernel-doc.

---
v3:
- Fix as readable comments

v4:
- The same

v5:
- Tweak and simplify the commit message

 drivers/pci/pcie/aspm.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/pci/pcie/aspm.c +6 -0
index 2428d278e015..91a8b35b1ae2 100644
@@ -1446,6 +1446,9 @@ static int __pci_enable_link_state(struct pci_dev *pdev, int state, bool locked)
  * touch the LNKCTL register. Also note that this does not enable states
  * disabled by pci_disable_link_state(). Return 0 or a negative errno.
  *
+ * Note: Ensure devices are in D0 before enabling PCI-PM L1 PM Substates, per
+ * PCIe r6.0, sec 5.5.4.
+ *
  * @pdev: PCI device
  * @state: Mask of ASPM link states to enable
  */
@@ -1462,6 +1465,9 @@ EXPORT_SYMBOL(pci_enable_link_state);
  * can't touch the LNKCTL register. Also note that this does not enable states
  * disabled by pci_disable_link_state(). Return 0 or a negative errno.
  *
+ * Note: Ensure devices are in D0 before enabling PCI-PM L1 PM Substates, per
+ * PCIe r6.0, sec 5.5.4.
+ *
  * @pdev: PCI device
  * @state: Mask of ASPM link states to enable
  *
Signature · 1 line
2.44.0