Skip to contentSkip to conversation

drm/amdgpu: fix the warning about the expression (int)size - len

PATCH Superseded Jesse Zhang 2 participants 2 messages Apr 25, 2024

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: fix the warning about the expression (int)size - len

Converting size from size_t to int may overflow.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +3 -2
index f5d0fa207a88..b828aad4f35e 100644
@@ -2065,12 +2065,13 @@ static ssize_t amdgpu_reset_dump_register_list_write(struct file *f,
 	struct amdgpu_device *adev = (struct amdgpu_device *)file_inode(f)->i_private;
 	char reg_offset[11];
 	uint32_t *new = NULL, *tmp = NULL;
-	int ret, i = 0, len = 0;
+	int ret, i = 0;
+	unsigned int len = 0;
 
 	do {
 		memset(reg_offset, 0, 11);
 		if (copy_from_user(reg_offset, buf + len,
-					min(10, ((int)size-len)))) {
+					min(10, (size-len)))) {
 			ret = -EFAULT;
 			goto error_free;
 		}
Signature · 1 line
2.25.1
maintainer
#1 lore raw

Am 25.04.24 um 08:20 schrieb Jesse Zhang:

Quoted 12 lines

Converting size from size_t to int may overflow.

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +0 -0
index f5d0fa207a88..b828aad4f35e 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c static ssize_t amdgpu_reset_dump_register_list_write(struct file *f, · line 2069

Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +2 -1
@@ -2065,12 +2065,13 @@ static ssize_t amdgpu_reset_dump_register_list_write(struct file *f,
  	struct amdgpu_device *adev = (struct amdgpu_device *)file_inode(f)->i_private;
  	char reg_offset[11];
  	uint32_t *new = NULL, *tmp = NULL;
-	int ret, i = 0, len = 0;
+	int ret, i = 0;
+	unsigned int len = 0;

Please keep reverse xmas tree order here, apart from that looks good to me.

Regards,
Christian.

Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +1 -1
  	do {
  		memset(reg_offset, 0, 11);
  		if (copy_from_user(reg_offset, buf + len,
-					min(10, ((int)size-len)))) {
+					min(10, (size-len)))) {
  			ret = -EFAULT;
  			goto error_free;
  		}