f2fs: zone: fix to don't trigger OPU on pinfile for direct IO
Chao Yu
maintainerPATCH 1/1 f2fs: zone: fix to don't trigger OPU on pinfile for direct IO
Otherwise, it breaks pinfile's sematics.
--- fs/f2fs/data.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/f2fs/data.c +2 -1
@@ -1596,7 +1596,8 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag)/* use out-place-update for direct IO under LFS mode */ if (map->m_may_create && - (is_hole || (f2fs_lfs_mode (sbi) && flag ==F2FS_GET_BLOCK_DIO ))) { + (is_hole || (flag ==F2FS_GET_BLOCK_DIO && (f2fs_lfs_mode (sbi) && + (!f2fs_sb_has_blkzoned (sbi) || !f2fs_is_pinned_file (inode)))))) {if (unlikely (f2fs_cp_error (sbi))) { err = -EIO ; goto sync_out;
Signature · 1 line
2.40.1
Dear Chao,
Quoted 14 lines · Chao Yu
Otherwise, it breaks pinfile's sematics.
Cc Daeho Jeong <[email protected]>Signed-off-by Chao Yu <[email protected]>--- fs/f2fs/data.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)fs/f2fs/data.c +0
-0
fs/f2fs/data.c int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag) · line 1600
Quoted 6 lines
fs/f2fs/data.c +2
-1@@ -1596,7 +1596,8 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag)/* use out-place-update for direct IO under LFS mode */ if (map->m_may_create && - (is_hole || (f2fs_lfs_mode (sbi) && flag ==F2FS_GET_BLOCK_DIO ))) { + (is_hole || (flag ==F2FS_GET_BLOCK_DIO && (f2fs_lfs_mode (sbi) && + (!f2fs_sb_has_blkzoned (sbi) || !f2fs_is_pinned_file (inode)))))) {
Excuse me I a little question, should pin files not be written in OPU mode regardless of device type(conventional or zone)? thanks!
Quoted 12 lines
fs/f2fs/data.c +0
-1if (unlikely (f2fs_cp_error (sbi))) { err = -EIO ; goto sync_out; --2.40.1
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Chao Yu
maintainerQuoted 18 lines · Zhiguo Niu
Dear Chao,
Quoted 15 lines · Chao Yu
Otherwise, it breaks pinfile's sematics.
Cc Daeho Jeong <[email protected]>Signed-off-by Chao Yu <[email protected]>--- fs/f2fs/data.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)fs/f2fs/data.c +0
-0@@ -1596,7 +1596,8 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag)
Quoted 7 lines
fs/f2fs/data.c int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag) · line 1600
Quoted 5 lines
fs/f2fs/data.c +2
-1/* use out-place-update for direct IO under LFS mode */ if (map->m_may_create && - (is_hole || (f2fs_lfs_mode (sbi) && flag ==F2FS_GET_BLOCK_DIO ))) { + (is_hole || (flag ==F2FS_GET_BLOCK_DIO && (f2fs_lfs_mode (sbi) && + (!f2fs_sb_has_blkzoned (sbi) || !f2fs_is_pinned_file (inode)))))) {Excuse me I a little question, should pin files not be written in OPU mode regardless of device type(conventional or zone)?
Agreed, so it looks we need remove !f2fs_sb_has_blkzoned condition here...
Thanks,
Quoted 13 lines
thanks!
Quoted 12 lines
fs/f2fs/data.c +0
-1if (unlikely (f2fs_cp_error (sbi))) { err = -EIO ; goto sync_out; --2.40.1
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 24 lines · Chao Yu
Otherwise, it breaks pinfile's sematics.
Cc Daeho Jeong <[email protected]>Signed-off-by Chao Yu <[email protected]>--- fs/f2fs/data.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)fs/f2fs/data.c +2
-2@@ -1596,7 +1596,8 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag)/* use out-place-update for direct IO under LFS mode */ if (map->m_may_create && - (is_hole || (f2fs_lfs_mode (sbi) && flag ==F2FS_GET_BLOCK_DIO ))) { + (is_hole || (flag ==F2FS_GET_BLOCK_DIO && (f2fs_lfs_mode (sbi) && + (!f2fs_sb_has_blkzoned (sbi) || !f2fs_is_pinned_file (inode)))))) {if (unlikely (f2fs_cp_error (sbi))) { err = -EIO ; goto sync_out; --
Quoted 1 line
2.40.1
So, we block overwrite io for the pinfile here.
static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from)
{
...
if (f2fs_is_pinned_file(inode) &&
!f2fs_overwrite_io(inode, pos, count)) {
ret = -EIO;
goto out_unlock;
}Quoted 1 line
Chao Yu
maintainerQuoted 16 lines · Daeho Jeong
Quoted 15 lines · Chao Yu
Otherwise, it breaks pinfile's sematics.
Cc Daeho Jeong <[email protected]>Signed-off-by Chao Yu <[email protected]>--- fs/f2fs/data.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)fs/f2fs/data.c +0
-0@@ -1596,7 +1596,8 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag)
Quoted 12 lines
Quoted 10 lines
fs/f2fs/data.c +2
-2/* use out-place-update for direct IO under LFS mode */ if (map->m_may_create && - (is_hole || (f2fs_lfs_mode (sbi) && flag ==F2FS_GET_BLOCK_DIO ))) { + (is_hole || (flag ==F2FS_GET_BLOCK_DIO && (f2fs_lfs_mode (sbi) && + (!f2fs_sb_has_blkzoned (sbi) || !f2fs_is_pinned_file (inode)))))) {if (unlikely (f2fs_cp_error (sbi))) { err = -EIO ; goto sync_out; --2.40.1
So, we block overwrite io for the pinfile here.
I guess you mean we blocked append write for pinfile, right?
Quoted 7 lines
static
ssize_tf2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from){
...if (f2fs_is_pinned_file(inode) && !f2fs_overwrite_io(inode, pos, count)) {
If !f2fs_overwrite_io() is true, it means it may trigger append write on pinfile?
Thanks,
Quoted 6 lines
ret = -EIO; goto out_unlock; }Quoted 1 line
Quoted 36 lines · Chao Yu
Quoted 16 lines · Daeho Jeong
Quoted 15 lines · Chao Yu
Otherwise, it breaks pinfile's sematics.
Cc Daeho Jeong <[email protected]>Signed-off-by Chao Yu <[email protected]>--- fs/f2fs/data.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)fs/f2fs/data.c +0
-0@@ -1596,7 +1596,8 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag)Quoted 12 lines
Quoted 10 lines
fs/f2fs/data.c +2
-2/* use out-place-update for direct IO under LFS mode */ if (map->m_may_create && - (is_hole || (f2fs_lfs_mode (sbi) && flag ==F2FS_GET_BLOCK_DIO ))) { + (is_hole || (flag ==F2FS_GET_BLOCK_DIO && (f2fs_lfs_mode (sbi) && + (!f2fs_sb_has_blkzoned (sbi) || !f2fs_is_pinned_file (inode)))))) {if (unlikely (f2fs_cp_error (sbi))) { err = -EIO ; goto sync_out; --2.40.1
So, we block overwrite io for the pinfile here.
I guess you mean we blocked append write for pinfile, right?
Quoted 3 lines
static
ssize_tf2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from)
Quoted 7 lines
Quoted 4 lines
{
...if (f2fs_is_pinned_file(inode) && !f2fs_overwrite_io(inode, pos, count)) {If !f2fs_overwrite_io() is true, it means it may trigger append write on pinfile?
Yes, I missed it. Thanks~
Quoted 9 lines
Thanks,
Quoted 6 lines
ret = -EIO; goto out_unlock; }Quoted 1 line