Skip to contentSkip to conversation

Add PCIe overlay for am642-phyboard-electra

PATCH Superseded Nathan Morrisson 2 participants 4 messages May 13, 2024 – Jun 10, 2024

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover Add PCIe overlay for am642-phyboard-electra

Remove PCIe pinmuxing from the am642-phyboard-electra device tree and provide an overlay to mux and enable PCIe.

v3:
- Fix typo from .dtbs to -dtbs in Makefile for overlay testing

v2:
- Fix double space typo
- Remove redundant status = okay

Nathan Morrisson (2):
arm64: dts: ti: am642-phyboard-electra: Remove PCIe pinmuxing
arm64: dts: ti: am642-phyboard-electra: Add overlay to enable PCIe

 arch/arm64/boot/dts/ti/Makefile               |  3 +
 .../k3-am642-phyboard-electra-pcie-usb2.dtso  | 87 +++++++++++++++++++
 .../dts/ti/k3-am642-phyboard-electra-rdk.dts  | 12 ---
 3 files changed, 90 insertions(+), 12 deletions(-)
 create mode 100644 arch/arm64/boot/dts/ti/k3-am642-phyboard-electra-pcie-usb2.dtso
Signature · 1 line
2.25.1
#1 lore raw

PATCH v3 1/2 arm64: dts: ti: am642-phyboard-electra: Remove PCIe pinmuxing

Remove pinmuxing for PCIe so that we can add it in an overlay.

---
v3: No change

v2: No change

 .../boot/dts/ti/k3-am642-phyboard-electra-rdk.dts    | 12 ------------
 1 file changed, 12 deletions(-)
arch/arm64/boot/dts/ti/k3-am642-phyboard-electra-rdk.dts +0 -12
index 6df331ccb970..30729b49dd69 100644
@@ -190,18 +190,6 @@ AM64X_IOPAD(0x02a8, PIN_OUTPUT, 0)	/* (E19) USB0_DRVVBUS */
 		>;
 	};
 
-	pcie_usb_sel_pins_default: pcie-usb-sel-default-pins {
-		pinctrl-single,pins = <
-			AM64X_IOPAD(0x017c, PIN_OUTPUT, 7)	/* (T1) PRG0_PRU0_GPO7.GPIO1_7 */
-		>;
-	};
-
-	pcie0_pins_default: pcie0-default-pins {
-		pinctrl-single,pins = <
-			AM64X_IOPAD(0x0098, PIN_OUTPUT, 7)	/* (W19) GPMC0_WAIT0.GPIO0_37 */
-		>;
-	};
-
 	user_leds_pins_default: user-leds-default-pins {
 		pinctrl-single,pins = <
 			AM64X_IOPAD(0x003c, PIN_OUTPUT, 7)	/* (T20) GPMC0_AD0.GPIO0_15 */
Signature · 1 line
2.25.1
#2 lore raw

PATCH v3 2/2 arm64: dts: ti: am642-phyboard-electra: Add overlay to enable PCIe

In reply to Nathan Morrisson

Add an overlay to enable PCIe on the am642-phyboard-electra. This will disable USB3 and restrict us to USB2.

---
v3:
- Fix typo from .dtbs to -dtbs in Makefile for overlay testing

v2:
- Fix double space typo
- Remove redundant status = okay

 arch/arm64/boot/dts/ti/Makefile               |  3 +
 .../k3-am642-phyboard-electra-pcie-usb2.dtso  | 87 +++++++++++++++++++
 2 files changed, 90 insertions(+)
 create mode 100644 arch/arm64/boot/dts/ti/k3-am642-phyboard-electra-pcie-usb2.dtso
arch/arm64/boot/dts/ti/Makefile +3 -0
index 2c327cc320cf..1906711b9b77 100644
@@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-am642-hummingboard-t-pcie.dtb
 dtb-$(CONFIG_ARCH_K3) += k3-am642-hummingboard-t-usb3.dtb
 dtb-$(CONFIG_ARCH_K3) += k3-am642-phyboard-electra-rdk.dtb
 dtb-$(CONFIG_ARCH_K3) += k3-am642-phyboard-electra-gpio-fan.dtbo
+dtb-$(CONFIG_ARCH_K3) += k3-am642-phyboard-electra-pcie-usb2.dtbo
 dtb-$(CONFIG_ARCH_K3) += k3-am642-sk.dtb
 dtb-$(CONFIG_ARCH_K3) += k3-am642-tqma64xxl-mbax4xxl.dtb
 dtb-$(CONFIG_ARCH_K3) += k3-am64-tqma64xxl-mbax4xxl-sdcard.dtbo
@@ -134,6 +135,8 @@ k3-am642-evm-icssg1-dualemac-dtbs := \
 	k3-am642-evm.dtb k3-am642-evm-icssg1-dualemac.dtbo
 k3-am642-phyboard-electra-gpio-fan-dtbs := \
 	k3-am642-phyboard-electra-rdk.dtb k3-am642-phyboard-electra-gpio-fan.dtbo
+k3-am642-phyboard-electra-pcie-usb2-dtbs := \
+	k3-am642-phyboard-electra-rdk.dtb k3-am642-phyboard-electra-pcie-usb2.dtbo
 k3-am642-tqma64xxl-mbax4xxl-sdcard-dtbs := \
 	k3-am642-tqma64xxl-mbax4xxl.dtb k3-am64-tqma64xxl-mbax4xxl-sdcard.dtbo
 k3-am642-tqma64xxl-mbax4xxl-wlan-dtbs := \
arch/arm64/boot/dts/ti/k3-am642-phyboard-electra-pcie-usb2.dtso new file +87 -0

87 lines not on this page · raw message

Signature · 1 line
2.25.1
#3 lore raw

Re: [PATCH v3 2/2] arm64: dts: ti: am642-phyboard-electra: Add overlay to enable PCIe

Hi

Quoted 3 lines · Nathan Morrisson

Add an overlay to enable PCIe on the am642-phyboard-electra. This will disable USB3 and restrict us to USB2.

Commit message still doesn't answer why? Could you explain why the overlay is needed

I am guessing USB3 and PCIe are exclusive at SoC level and board has capabilities for both? So, please add the same to commit message.

[...]

Signature · 2 lines
Regards
Vignesh