Skip to contentSkip to conversation

drm/i915/dp_mst: Enable link training fallback

PATCH Superseded Imre Deak 6 participants 61 messages May 20, 2024 – Jun 10, 2024

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Imre Deak

author
#0 lore raw

v2 cover drm/i915/dp_mst: Enable link training fallback

This is v2 of [1], addressing the feedback comments from Jani and Ville:

- Use a more generic 'link' substruct instead of 'link_train'. (Patch 2)
- Add the debugfs entries from intel_dp_link_training.c . (Patch 17-21)
- Add the link state check work to intel_digital_port instead of intel_dp, to allow using it later for HDMI. (Patch 7)
- Keep using the atomic state to look up MST connectors, avoiding the access to any object's current state. (Patch 9)
- Add a separate debugfs entry to get the max link rate/lane count. (Patch 18)

[1] https://lore.kernel.org/all/[email protected]

Cc Jani Nikula <[email protected]>
Cc Ville Syrjälä <[email protected]>

Imre Deak (21):
drm/i915/dp_mst: Align TUs to avoid splitting symbols across MTPs drm/i915/dp: Move link train params to a substruct in intel_dp drm/i915/dp: Move link train fallback to intel_dp_link_training.c drm/i915/dp: Sanitize intel_dp_get_link_train_fallback_values() drm/i915: Factor out function to modeset commit a set of pipes drm/i915/dp: Use a commit modeset for link retraining MST links drm/i915/dp: Recheck link state after modeset
drm/i915/dp: Reduce link params only after retrying with unchanged
params
drm/i915/dp: Pass atomic state to link training function drm/i915/dp: Send a link training modeset-retry uevent to all MST
connectors
drm/i915/dp: Use check link state work in the hotplug handler drm/i915/dp: Use check link state work in the detect handler drm/i915/dp: Use check link state work in the HPD IRQ handler drm/i915/dp: Disable link retraining after the last fallback step drm/i915/dp_mst: Reset intel_dp->link_trained during disabling drm/i915/dp_mst: Enable link training fallback for MST drm/i915/dp: Add debugfs entries to set a target link rate/lane count drm/i915/dp: Add debugfs entries to get the max link rate/lane count drm/i915/dp: Add debugfs entry to force link training failure drm/i915/dp: Add debugfs entry to force link retrain drm/i915/dp: Add debugfs entry for link training info

 drivers/gpu/drm/i915/display/g4x_dp.c         |  29 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      |  64 +-
 drivers/gpu/drm/i915/display/intel_ddi.h      |   4 +
 drivers/gpu/drm/i915/display/intel_display.c  |  34 ++
 drivers/gpu/drm/i915/display/intel_display.h  |   3 +
 .../drm/i915/display/intel_display_debugfs.c  |   2 +
 .../drm/i915/display/intel_display_types.h    |  26 +-
 drivers/gpu/drm/i915/display/intel_dp.c       | 241 ++++----
 drivers/gpu/drm/i915/display/intel_dp.h       |   8 +-
 .../drm/i915/display/intel_dp_link_training.c | 545 +++++++++++++++++-
 .../drm/i915/display/intel_dp_link_training.h |   8 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |  30 +-
 12 files changed, 805 insertions(+), 189 deletions(-)
Signature · 1 line
2.43.3
author
#1 lore raw

PATCH v2 1/21 drm/i915/dp_mst: Align TUs to avoid splitting symbols across MTPs

Symbols consisting of multiple (4) TU timeslots may get split across MTPs when using 2 or 1 link lanes. Avoid this, as required by Bspec by aligning the allocated TUs to 2 when using 2 lanes and 4 when using 1 lane.

Atm, we also have to align the PBNs used to allocate BW along the MST path, since DRM core keeps track of its own TU value, derived from the PBN and that TU value must match what the driver calculates.

On some platforms the alignment is only required on 8b/10b links, a follow-up patch will remove the limitation for those.

Bspec: 49266, 68922

---
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 27 ++++++++++++++++++---
 1 file changed, 23 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/display/intel_dp_mst.c +23 -4
index c772ba19c5477..c9c5d235744ab 100644
@@ -207,6 +207,7 @@ static int intel_dp_mst_find_vcpi_slots_for_bpp(struct intel_encoder *encoder,
 		int remote_bw_overhead;
 		int link_bpp_x16;
 		int remote_tu;
+		fixed20_12 pbn;
 
 		drm_dbg_kms(&i915->drm, "Trying bpp %d\n", bpp);
 
@@ -237,11 +238,29 @@ static int intel_dp_mst_find_vcpi_slots_for_bpp(struct intel_encoder *encoder,
 		 * crtc_state->dp_m_n.tu), provided that the driver doesn't
 		 * enable SSC on the corresponding link.
 		 */
-		crtc_state->pbn = intel_dp_mst_calc_pbn(adjusted_mode->crtc_clock,
-							link_bpp_x16,
-							remote_bw_overhead);
+		pbn.full = dfixed_const(intel_dp_mst_calc_pbn(adjusted_mode->crtc_clock,
+							      link_bpp_x16,
+							      remote_bw_overhead));
+		remote_tu = DIV_ROUND_UP(pbn.full, mst_state->pbn_div.full);
 
-		remote_tu = DIV_ROUND_UP(dfixed_const(crtc_state->pbn), mst_state->pbn_div.full);
+		/*
+		 * Aligning the TUs ensures that symbols consisting of multiple
+		 * (4) symbol cycles don't get split between two consecutive
+		 * MTPs, as required by Bspec.
+		 * TODO: remove the alignment restriction for 128b/132b links
+		 * on some platforms, where Bspec allows this.
+		 */
+		remote_tu = ALIGN(remote_tu, 4 / crtc_state->lane_count);
+
+		/*
+		 * Also align PBNs accordingly, since MST core will derive its
+		 * own copy of TU from the PBN in drm_dp_atomic_find_time_slots().
+		 * The above comment about the difference between the PBN
+		 * allocated for the whole path and the TUs allocated for the
+		 * first branch device's link also applies here.
+		 */
+		pbn.full = remote_tu * mst_state->pbn_div.full;
+		crtc_state->pbn = dfixed_trunc(pbn);
 
 		drm_WARN_ON(&i915->drm, remote_tu < crtc_state->dp_m_n.tu);
 		crtc_state->dp_m_n.tu = remote_tu;
Signature · 1 line
2.43.3
Reviewed-by on v2 1/21
#2 lore raw

Re: [PATCH v2 01/21] drm/i915/dp_mst: Align TUs to avoid splitting symbols across MTPs

Quoted 9 lines · Imre Deak

Symbols consisting of multiple (4) TU timeslots may get split across MTPs when using 2 or 1 link lanes. Avoid this, as required by Bspec by aligning the allocated TUs to 2 when using 2 lanes and 4 when using 1 lane.

Atm, we also have to align the PBNs used to allocate BW along the MST path, since DRM core keeps track of its own TU value, derived from the PBN and that TU value must match what the driver calculates.

Quoted 6 lines

On some platforms the alignment is only required on 8b/10b links, a follow-up patch will remove the limitation for those.

Bspec: 49266, 68922

Quoted 52 lines
---
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 27 ++++++++++++++++++---
 1 file changed, 23 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/display/intel_dp_mst.c +23 -4
index c772ba19c5477..c9c5d235744ab 100644
@@ -207,6 +207,7 @@ static int intel_dp_mst_find_vcpi_slots_for_bpp(struct intel_encoder *encoder,
 		int remote_bw_overhead;
 		int link_bpp_x16;
 		int remote_tu;
+		fixed20_12 pbn;
 
 		drm_dbg_kms(&i915->drm, "Trying bpp %d\n", bpp);
 
@@ -237,11 +238,29 @@ static int intel_dp_mst_find_vcpi_slots_for_bpp(struct intel_encoder *encoder,
 		 * crtc_state->dp_m_n.tu), provided that the driver doesn't
 		 * enable SSC on the corresponding link.
 		 */
-		crtc_state->pbn = intel_dp_mst_calc_pbn(adjusted_mode->crtc_clock,
-							link_bpp_x16,
-							remote_bw_overhead);
+		pbn.full = dfixed_const(intel_dp_mst_calc_pbn(adjusted_mode->crtc_clock,
+							      link_bpp_x16,
+							      remote_bw_overhead));
+		remote_tu = DIV_ROUND_UP(pbn.full, mst_state->pbn_div.full);
 
-		remote_tu = DIV_ROUND_UP(dfixed_const(crtc_state->pbn), mst_state->pbn_div.full);
+		/*
+		 * Aligning the TUs ensures that symbols consisting of multiple
+		 * (4) symbol cycles don't get split between two consecutive
+		 * MTPs, as required by Bspec.
+		 * TODO: remove the alignment restriction for 128b/132b links
+		 * on some platforms, where Bspec allows this.
+		 */
+		remote_tu = ALIGN(remote_tu, 4 / crtc_state->lane_count);
+
+		/*
+		 * Also align PBNs accordingly, since MST core will derive its
+		 * own copy of TU from the PBN in drm_dp_atomic_find_time_slots().
+		 * The above comment about the difference between the PBN
+		 * allocated for the whole path and the TUs allocated for the
+		 * first branch device's link also applies here.
+		 */
+		pbn.full = remote_tu * mst_state->pbn_div.full;
+		crtc_state->pbn = dfixed_trunc(pbn);
 
 		drm_WARN_ON(&i915->drm, remote_tu < crtc_state->dp_m_n.tu);
 		crtc_state->dp_m_n.tu = remote_tu;
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
author
#3 lore raw

PATCH v2 2/21 drm/i915/dp: Move link train params to a substruct in intel_dp

In reply to Imre Deak

For clarity move the link training parameters updated during link training based on the pass/fail LT result under a substruct in intel_dp. This prepares for later patches in this patchset adding similar params here. Rename intel_dp_reset_max_link_params() to intel_dp_reset_link_params() to better reflect what state gets reset.

v2: Add the parameters to a more generic link substruct. (Jani)

---
 .../drm/i915/display/intel_display_types.h    | 13 ++++----
 drivers/gpu/drm/i915/display/intel_dp.c       | 30 +++++++++----------
 2 files changed, 23 insertions(+), 20 deletions(-)
drivers/gpu/drm/i915/display/intel_display_types.h +8 -5
index 9678c2b157f6f..1e44a23ca2125 100644
@@ -1739,7 +1739,6 @@ struct intel_dp {
 	u8 lane_count;
 	u8 sink_count;
 	bool link_trained;
-	bool reset_link_params;
 	bool use_max_params;
 	u8 dpcd[DP_RECEIVER_CAP_SIZE];
 	u8 psr_dpcd[EDP_PSR_RECEIVER_CAP_SIZE];
@@ -1760,10 +1759,14 @@ struct intel_dp {
 	/* intersection of source and sink rates */
 	int num_common_rates;
 	int common_rates[DP_MAX_SUPPORTED_RATES];
-	/* Max lane count for the current link */
-	int max_link_lane_count;
-	/* Max rate for the current link */
-	int max_link_rate;
+	struct {
+		/* TODO: move the rest of link specific fields to here */
+		/* Max lane count for the current link */
+		int max_lane_count;
+		/* Max rate for the current link */
+		int max_rate;
+	} link;
+	bool reset_link_params;
 	int mso_link_count;
 	int mso_pixel_overlap;
 	/* sink or branch descriptor */
drivers/gpu/drm/i915/display/intel_dp.c +15 -15
index c0a3b6d506817..ceedd3ef41946 100644
@@ -372,13 +372,13 @@ int intel_dp_max_common_lane_count(struct intel_dp *intel_dp)
 
 int intel_dp_max_lane_count(struct intel_dp *intel_dp)
 {
-	switch (intel_dp->max_link_lane_count) {
+	switch (intel_dp->link.max_lane_count) {
 	case 1:
 	case 2:
 	case 4:
-		return intel_dp->max_link_lane_count;
+		return intel_dp->link.max_lane_count;
 	default:
-		MISSING_CASE(intel_dp->max_link_lane_count);
+		MISSING_CASE(intel_dp->link.max_lane_count);
 		return 1;
 	}
 }
@@ -644,7 +644,7 @@ static bool intel_dp_link_params_valid(struct intel_dp *intel_dp, int link_rate,
 	 * boot-up.
 	 */
 	if (link_rate == 0 ||
-	    link_rate > intel_dp->max_link_rate)
+	    link_rate > intel_dp->link.max_rate)
 		return false;
 
 	if (lane_count == 0 ||
@@ -705,8 +705,8 @@ int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 				    "Retrying Link training for eDP with same parameters\n");
 			return 0;
 		}
-		intel_dp->max_link_rate = intel_dp_common_rate(intel_dp, index - 1);
-		intel_dp->max_link_lane_count = lane_count;
+		intel_dp->link.max_rate = intel_dp_common_rate(intel_dp, index - 1);
+		intel_dp->link.max_lane_count = lane_count;
 	} else if (lane_count > 1) {
 		if (intel_dp_is_edp(intel_dp) &&
 		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
@@ -716,8 +716,8 @@ int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 				    "Retrying Link training for eDP with same parameters\n");
 			return 0;
 		}
-		intel_dp->max_link_rate = intel_dp_max_common_rate(intel_dp);
-		intel_dp->max_link_lane_count = lane_count >> 1;
+		intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
+		intel_dp->link.max_lane_count = lane_count >> 1;
 	} else {
 		drm_err(&i915->drm, "Link Training Unsuccessful\n");
 		return -1;
@@ -1382,7 +1382,7 @@ intel_dp_max_link_rate(struct intel_dp *intel_dp)
 {
 	int len;
 
-	len = intel_dp_common_len_rate_limit(intel_dp, intel_dp->max_link_rate);
+	len = intel_dp_common_len_rate_limit(intel_dp, intel_dp->link.max_rate);
 
 	return intel_dp_common_rate(intel_dp, len - 1);
 }
@@ -3017,10 +3017,10 @@ void intel_dp_set_link_params(struct intel_dp *intel_dp,
 	intel_dp->lane_count = lane_count;
 }
 
-static void intel_dp_reset_max_link_params(struct intel_dp *intel_dp)
+static void intel_dp_reset_link_params(struct intel_dp *intel_dp)
 {
-	intel_dp->max_link_lane_count = intel_dp_max_common_lane_count(intel_dp);
-	intel_dp->max_link_rate = intel_dp_max_common_rate(intel_dp);
+	intel_dp->link.max_lane_count = intel_dp_max_common_lane_count(intel_dp);
+	intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
 }
 
 /* Enable backlight PWM and backlight PP control. */
@@ -3355,7 +3355,7 @@ void intel_dp_sync_state(struct intel_encoder *encoder,
 	intel_dp_tunnel_resume(intel_dp, crtc_state, dpcd_updated);
 
 	if (crtc_state)
-		intel_dp_reset_max_link_params(intel_dp);
+		intel_dp_reset_link_params(intel_dp);
 }
 
 bool intel_dp_initial_fastset_check(struct intel_encoder *encoder,
@@ -5889,7 +5889,7 @@ intel_dp_detect(struct drm_connector *connector,
 	 * supports link training fallback params.
 	 */
 	if (intel_dp->reset_link_params || intel_dp->is_mst) {
-		intel_dp_reset_max_link_params(intel_dp);
+		intel_dp_reset_link_params(intel_dp);
 		intel_dp->reset_link_params = false;
 	}
 
@@ -6741,7 +6741,7 @@ intel_dp_init_connector(struct intel_digital_port *dig_port,
 
 	intel_dp_set_source_rates(intel_dp);
 	intel_dp_set_common_rates(intel_dp);
-	intel_dp_reset_max_link_params(intel_dp);
+	intel_dp_reset_link_params(intel_dp);
 
 	/* init MST on ports that can support it */
 	intel_dp_mst_encoder_init(dig_port,
Signature · 1 line
2.43.3
author
#4 lore raw

PATCH v2 3/21 drm/i915/dp: Move link train fallback to intel_dp_link_training.c

In reply to Imre Deak

Move the functions used to reduce the link parameters during link training to intel_dp_link_training.c .

---
 drivers/gpu/drm/i915/display/intel_dp.c       | 76 +------------------
 drivers/gpu/drm/i915/display/intel_dp.h       |  4 +-
 .../drm/i915/display/intel_dp_link_training.c | 73 ++++++++++++++++++
 3 files changed, 77 insertions(+), 76 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +2 -74
index ceedd3ef41946..81e620dd33bb7 100644
@@ -329,7 +329,7 @@ static int intel_dp_common_len_rate_limit(const struct intel_dp *intel_dp,
 				       intel_dp->num_common_rates, max_rate);
 }
 
-static int intel_dp_common_rate(struct intel_dp *intel_dp, int index)
+int intel_dp_common_rate(struct intel_dp *intel_dp, int index)
 {
 	if (drm_WARN_ON(&dp_to_i915(intel_dp)->drm,
 			index < 0 || index >= intel_dp->num_common_rates))
@@ -604,7 +604,7 @@ static int intersect_rates(const int *source_rates, int source_len,
 }
 
 /* return index of rate in rates array, or -1 if not found */
-static int intel_dp_rate_index(const int *rates, int len, int rate)
+int intel_dp_rate_index(const int *rates, int len, int rate)
 {
 	int i;
 
@@ -654,78 +654,6 @@ static bool intel_dp_link_params_valid(struct intel_dp *intel_dp, int link_rate,
 	return true;
 }
 
-static bool intel_dp_can_link_train_fallback_for_edp(struct intel_dp *intel_dp,
-						     int link_rate,
-						     u8 lane_count)
-{
-	/* FIXME figure out what we actually want here */
-	const struct drm_display_mode *fixed_mode =
-		intel_panel_preferred_fixed_mode(intel_dp->attached_connector);
-	int mode_rate, max_rate;
-
-	mode_rate = intel_dp_link_required(fixed_mode->clock, 18);
-	max_rate = intel_dp_max_link_data_rate(intel_dp, link_rate, lane_count);
-	if (mode_rate > max_rate)
-		return false;
-
-	return true;
-}
-
-int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
-					    int link_rate, u8 lane_count)
-{
-	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
-	int index;
-
-	/*
-	 * TODO: Enable fallback on MST links once MST link compute can handle
-	 * the fallback params.
-	 */
-	if (intel_dp->is_mst) {
-		drm_err(&i915->drm, "Link Training Unsuccessful\n");
-		return -1;
-	}
-
-	if (intel_dp_is_edp(intel_dp) && !intel_dp->use_max_params) {
-		drm_dbg_kms(&i915->drm,
-			    "Retrying Link training for eDP with max parameters\n");
-		intel_dp->use_max_params = true;
-		return 0;
-	}
-
-	index = intel_dp_rate_index(intel_dp->common_rates,
-				    intel_dp->num_common_rates,
-				    link_rate);
-	if (index > 0) {
-		if (intel_dp_is_edp(intel_dp) &&
-		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
-							      intel_dp_common_rate(intel_dp, index - 1),
-							      lane_count)) {
-			drm_dbg_kms(&i915->drm,
-				    "Retrying Link training for eDP with same parameters\n");
-			return 0;
-		}
-		intel_dp->link.max_rate = intel_dp_common_rate(intel_dp, index - 1);
-		intel_dp->link.max_lane_count = lane_count;
-	} else if (lane_count > 1) {
-		if (intel_dp_is_edp(intel_dp) &&
-		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
-							      intel_dp_max_common_rate(intel_dp),
-							      lane_count >> 1)) {
-			drm_dbg_kms(&i915->drm,
-				    "Retrying Link training for eDP with same parameters\n");
-			return 0;
-		}
-		intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
-		intel_dp->link.max_lane_count = lane_count >> 1;
-	} else {
-		drm_err(&i915->drm, "Link Training Unsuccessful\n");
-		return -1;
-	}
-
-	return 0;
-}
-
 u32 intel_dp_mode_to_fec_clock(u32 mode_clock)
 {
 	return div_u64(mul_u32_u32(mode_clock, DP_DSC_FEC_OVERHEAD_FACTOR),
drivers/gpu/drm/i915/display/intel_dp.h +2 -2
index aad2223df2a35..e7b47e7bcd98b 100644
@@ -55,8 +55,6 @@ void intel_dp_connector_sync_state(struct intel_connector *connector,
 				   const struct intel_crtc_state *crtc_state);
 void intel_dp_set_link_params(struct intel_dp *intel_dp,
 			      int link_rate, int lane_count);
-int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
-					    int link_rate, u8 lane_count);
 int intel_dp_get_active_pipes(struct intel_dp *intel_dp,
 			      struct drm_modeset_acquire_ctx *ctx,
 			      u8 *pipe_mask);
@@ -107,6 +105,8 @@ int intel_dp_config_required_rate(const struct intel_crtc_state *crtc_state);
 int intel_dp_rate_select(struct intel_dp *intel_dp, int rate);
 int intel_dp_max_common_rate(struct intel_dp *intel_dp);
 int intel_dp_max_common_lane_count(struct intel_dp *intel_dp);
+int intel_dp_common_rate(struct intel_dp *intel_dp, int index);
+int intel_dp_rate_index(const int *rates, int len, int rate);
 void intel_dp_update_sink_caps(struct intel_dp *intel_dp);
 
 void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock,
drivers/gpu/drm/i915/display/intel_dp_link_training.c +73 -0

85 lines not on this page · raw message

Signature · 1 line
2.43.3
Reviewed-by on v2 3/21
#5 lore raw

Re: [PATCH v2 03/21] drm/i915/dp: Move link train fallback to intel_dp_link_training.c

Quoted 4 lines · Imre Deak

Move the functions used to reduce the link parameters during link training to intel_dp_link_training.c .

Quoted 222 lines
---
 drivers/gpu/drm/i915/display/intel_dp.c       | 76 +------------------
 drivers/gpu/drm/i915/display/intel_dp.h       |  4 +-
 .../drm/i915/display/intel_dp_link_training.c | 73 ++++++++++++++++++
 3 files changed, 77 insertions(+), 76 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +2 -74
index ceedd3ef41946..81e620dd33bb7 100644
@@ -329,7 +329,7 @@ static int intel_dp_common_len_rate_limit(const struct intel_dp *intel_dp,
 				       intel_dp->num_common_rates, max_rate);
 }
 
-static int intel_dp_common_rate(struct intel_dp *intel_dp, int index)
+int intel_dp_common_rate(struct intel_dp *intel_dp, int index)
 {
 	if (drm_WARN_ON(&dp_to_i915(intel_dp)->drm,
 			index < 0 || index >= intel_dp->num_common_rates))
@@ -604,7 +604,7 @@ static int intersect_rates(const int *source_rates, int source_len,
 }
 
 /* return index of rate in rates array, or -1 if not found */
-static int intel_dp_rate_index(const int *rates, int len, int rate)
+int intel_dp_rate_index(const int *rates, int len, int rate)
 {
 	int i;
 
@@ -654,78 +654,6 @@ static bool intel_dp_link_params_valid(struct intel_dp *intel_dp, int link_rate,
 	return true;
 }
 
-static bool intel_dp_can_link_train_fallback_for_edp(struct intel_dp *intel_dp,
-						     int link_rate,
-						     u8 lane_count)
-{
-	/* FIXME figure out what we actually want here */
-	const struct drm_display_mode *fixed_mode =
-		intel_panel_preferred_fixed_mode(intel_dp->attached_connector);
-	int mode_rate, max_rate;
-
-	mode_rate = intel_dp_link_required(fixed_mode->clock, 18);
-	max_rate = intel_dp_max_link_data_rate(intel_dp, link_rate, lane_count);
-	if (mode_rate > max_rate)
-		return false;
-
-	return true;
-}
-
-int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
-					    int link_rate, u8 lane_count)
-{
-	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
-	int index;
-
-	/*
-	 * TODO: Enable fallback on MST links once MST link compute can handle
-	 * the fallback params.
-	 */
-	if (intel_dp->is_mst) {
-		drm_err(&i915->drm, "Link Training Unsuccessful\n");
-		return -1;
-	}
-
-	if (intel_dp_is_edp(intel_dp) && !intel_dp->use_max_params) {
-		drm_dbg_kms(&i915->drm,
-			    "Retrying Link training for eDP with max parameters\n");
-		intel_dp->use_max_params = true;
-		return 0;
-	}
-
-	index = intel_dp_rate_index(intel_dp->common_rates,
-				    intel_dp->num_common_rates,
-				    link_rate);
-	if (index > 0) {
-		if (intel_dp_is_edp(intel_dp) &&
-		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
-							      intel_dp_common_rate(intel_dp, index - 1),
-							      lane_count)) {
-			drm_dbg_kms(&i915->drm,
-				    "Retrying Link training for eDP with same parameters\n");
-			return 0;
-		}
-		intel_dp->link.max_rate = intel_dp_common_rate(intel_dp, index - 1);
-		intel_dp->link.max_lane_count = lane_count;
-	} else if (lane_count > 1) {
-		if (intel_dp_is_edp(intel_dp) &&
-		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
-							      intel_dp_max_common_rate(intel_dp),
-							      lane_count >> 1)) {
-			drm_dbg_kms(&i915->drm,
-				    "Retrying Link training for eDP with same parameters\n");
-			return 0;
-		}
-		intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
-		intel_dp->link.max_lane_count = lane_count >> 1;
-	} else {
-		drm_err(&i915->drm, "Link Training Unsuccessful\n");
-		return -1;
-	}
-
-	return 0;
-}
-
 u32 intel_dp_mode_to_fec_clock(u32 mode_clock)
 {
 	return div_u64(mul_u32_u32(mode_clock, DP_DSC_FEC_OVERHEAD_FACTOR),
drivers/gpu/drm/i915/display/intel_dp.h +2 -2
index aad2223df2a35..e7b47e7bcd98b 100644
@@ -55,8 +55,6 @@ void intel_dp_connector_sync_state(struct intel_connector *connector,
 				   const struct intel_crtc_state *crtc_state);
 void intel_dp_set_link_params(struct intel_dp *intel_dp,
 			      int link_rate, int lane_count);
-int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
-					    int link_rate, u8 lane_count);
 int intel_dp_get_active_pipes(struct intel_dp *intel_dp,
 			      struct drm_modeset_acquire_ctx *ctx,
 			      u8 *pipe_mask);
@@ -107,6 +105,8 @@ int intel_dp_config_required_rate(const struct intel_crtc_state *crtc_state);
 int intel_dp_rate_select(struct intel_dp *intel_dp, int rate);
 int intel_dp_max_common_rate(struct intel_dp *intel_dp);
 int intel_dp_max_common_lane_count(struct intel_dp *intel_dp);
+int intel_dp_common_rate(struct intel_dp *intel_dp, int index);
+int intel_dp_rate_index(const int *rates, int len, int rate);
 void intel_dp_update_sink_caps(struct intel_dp *intel_dp);
 
 void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock,
drivers/gpu/drm/i915/display/intel_dp_link_training.c +73 -0
index 947575140059d..4db293f256896 100644
@@ -25,6 +25,7 @@
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_link_training.h"
+#include "intel_panel.h"
 
 #define LT_MSG_PREFIX			"[CONNECTOR:%d:%s][ENCODER:%d:%s][%s] "
 #define LT_MSG_ARGS(_intel_dp, _dp_phy)	(_intel_dp)->attached_connector->base.base.id, \
@@ -1091,6 +1092,78 @@ intel_dp_link_train_phy(struct intel_dp *intel_dp,
 	return ret;
 }
 
+static bool intel_dp_can_link_train_fallback_for_edp(struct intel_dp *intel_dp,
+						     int link_rate,
+						     u8 lane_count)
+{
+	/* FIXME figure out what we actually want here */
+	const struct drm_display_mode *fixed_mode =
+		intel_panel_preferred_fixed_mode(intel_dp->attached_connector);
+	int mode_rate, max_rate;
+
+	mode_rate = intel_dp_link_required(fixed_mode->clock, 18);
+	max_rate = intel_dp_max_link_data_rate(intel_dp, link_rate, lane_count);
+	if (mode_rate > max_rate)
+		return false;
+
+	return true;
+}
+
+static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
+						   int link_rate, u8 lane_count)
+{
+	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
+	int index;
+
+	/*
+	 * TODO: Enable fallback on MST links once MST link compute can handle
+	 * the fallback params.
+	 */
+	if (intel_dp->is_mst) {
+		drm_err(&i915->drm, "Link Training Unsuccessful\n");
+		return -1;
+	}
+
+	if (intel_dp_is_edp(intel_dp) && !intel_dp->use_max_params) {
+		drm_dbg_kms(&i915->drm,
+			    "Retrying Link training for eDP with max parameters\n");
+		intel_dp->use_max_params = true;
+		return 0;
+	}
+
+	index = intel_dp_rate_index(intel_dp->common_rates,
+				    intel_dp->num_common_rates,
+				    link_rate);
+	if (index > 0) {
+		if (intel_dp_is_edp(intel_dp) &&
+		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
+							      intel_dp_common_rate(intel_dp, index - 1),
+							      lane_count)) {
+			drm_dbg_kms(&i915->drm,
+				    "Retrying Link training for eDP with same parameters\n");
+			return 0;
+		}
+		intel_dp->link.max_rate = intel_dp_common_rate(intel_dp, index - 1);
+		intel_dp->link.max_lane_count = lane_count;
+	} else if (lane_count > 1) {
+		if (intel_dp_is_edp(intel_dp) &&
+		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
+							      intel_dp_max_common_rate(intel_dp),
+							      lane_count >> 1)) {
+			drm_dbg_kms(&i915->drm,
+				    "Retrying Link training for eDP with same parameters\n");
+			return 0;
+		}
+		intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
+		intel_dp->link.max_lane_count = lane_count >> 1;
+	} else {
+		drm_err(&i915->drm, "Link Training Unsuccessful\n");
+		return -1;
+	}
+
+	return 0;
+}
+
 static void intel_dp_schedule_fallback_link_training(struct intel_dp *intel_dp,
 						     const struct intel_crtc_state *crtc_state)
 {
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
Reviewed-by
#6 lore raw

Re: [PATCH v2 03/21] drm/i915/dp: Move link train fallback to intel_dp_link_training.c

Looks good to me,

Manasi

Quoted 235 lines · Ville Syrjälä
Quoted 4 lines · Imre Deak

Move the functions used to reduce the link parameters during link training to intel_dp_link_training.c .

Quoted 221 lines
---
 drivers/gpu/drm/i915/display/intel_dp.c       | 76 +------------------
 drivers/gpu/drm/i915/display/intel_dp.h       |  4 +-
 .../drm/i915/display/intel_dp_link_training.c | 73 ++++++++++++++++++
 3 files changed, 77 insertions(+), 76 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +2 -74
index ceedd3ef41946..81e620dd33bb7 100644
@@ -329,7 +329,7 @@ static int intel_dp_common_len_rate_limit(const struct intel_dp *intel_dp,
                                     intel_dp->num_common_rates, max_rate);
 }
 
-static int intel_dp_common_rate(struct intel_dp *intel_dp, int index)
+int intel_dp_common_rate(struct intel_dp *intel_dp, int index)
 {
      if (drm_WARN_ON(&dp_to_i915(intel_dp)->drm,
                      index < 0 || index >= intel_dp->num_common_rates))
@@ -604,7 +604,7 @@ static int intersect_rates(const int *source_rates, int source_len,
 }
 
 /* return index of rate in rates array, or -1 if not found */
-static int intel_dp_rate_index(const int *rates, int len, int rate)
+int intel_dp_rate_index(const int *rates, int len, int rate)
 {
      int i;
 
@@ -654,78 +654,6 @@ static bool intel_dp_link_params_valid(struct intel_dp *intel_dp, int link_rate,
      return true;
 }
 
-static bool intel_dp_can_link_train_fallback_for_edp(struct intel_dp *intel_dp,
-                                                  int link_rate,
-                                                  u8 lane_count)
-{
-     /* FIXME figure out what we actually want here */
-     const struct drm_display_mode *fixed_mode =
-             intel_panel_preferred_fixed_mode(intel_dp->attached_connector);
-     int mode_rate, max_rate;
-
-     mode_rate = intel_dp_link_required(fixed_mode->clock, 18);
-     max_rate = intel_dp_max_link_data_rate(intel_dp, link_rate, lane_count);
-     if (mode_rate > max_rate)
-             return false;
-
-     return true;
-}
-
-int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
-                                         int link_rate, u8 lane_count)
-{
-     struct drm_i915_private *i915 = dp_to_i915(intel_dp);
-     int index;
-
-     /*
-      * TODO: Enable fallback on MST links once MST link compute can handle
-      * the fallback params.
-      */
-     if (intel_dp->is_mst) {
-             drm_err(&i915->drm, "Link Training Unsuccessful\n");
-             return -1;
-     }
-
-     if (intel_dp_is_edp(intel_dp) && !intel_dp->use_max_params) {
-             drm_dbg_kms(&i915->drm,
-                         "Retrying Link training for eDP with max parameters\n");
-             intel_dp->use_max_params = true;
-             return 0;
-     }
-
-     index = intel_dp_rate_index(intel_dp->common_rates,
-                                 intel_dp->num_common_rates,
-                                 link_rate);
-     if (index > 0) {
-             if (intel_dp_is_edp(intel_dp) &&
-                 !intel_dp_can_link_train_fallback_for_edp(intel_dp,
-                                                           intel_dp_common_rate(intel_dp, index - 1),
-                                                           lane_count)) {
-                     drm_dbg_kms(&i915->drm,
-                                 "Retrying Link training for eDP with same parameters\n");
-                     return 0;
-             }
-             intel_dp->link.max_rate = intel_dp_common_rate(intel_dp, index - 1);
-             intel_dp->link.max_lane_count = lane_count;
-     } else if (lane_count > 1) {
-             if (intel_dp_is_edp(intel_dp) &&
-                 !intel_dp_can_link_train_fallback_for_edp(intel_dp,
-                                                           intel_dp_max_common_rate(intel_dp),
-                                                           lane_count >> 1)) {
-                     drm_dbg_kms(&i915->drm,
-                                 "Retrying Link training for eDP with same parameters\n");
-                     return 0;
-             }
-             intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
-             intel_dp->link.max_lane_count = lane_count >> 1;
-     } else {
-             drm_err(&i915->drm, "Link Training Unsuccessful\n");
-             return -1;
-     }
-
-     return 0;
-}
-
 u32 intel_dp_mode_to_fec_clock(u32 mode_clock)
 {
      return div_u64(mul_u32_u32(mode_clock, DP_DSC_FEC_OVERHEAD_FACTOR),
drivers/gpu/drm/i915/display/intel_dp.h +2 -2
index aad2223df2a35..e7b47e7bcd98b 100644
@@ -55,8 +55,6 @@ void intel_dp_connector_sync_state(struct intel_connector *connector,
                                 const struct intel_crtc_state *crtc_state);
 void intel_dp_set_link_params(struct intel_dp *intel_dp,
                            int link_rate, int lane_count);
-int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
-                                         int link_rate, u8 lane_count);
 int intel_dp_get_active_pipes(struct intel_dp *intel_dp,
                            struct drm_modeset_acquire_ctx *ctx,
                            u8 *pipe_mask);
@@ -107,6 +105,8 @@ int intel_dp_config_required_rate(const struct intel_crtc_state *crtc_state);
 int intel_dp_rate_select(struct intel_dp *intel_dp, int rate);
 int intel_dp_max_common_rate(struct intel_dp *intel_dp);
 int intel_dp_max_common_lane_count(struct intel_dp *intel_dp);
+int intel_dp_common_rate(struct intel_dp *intel_dp, int index);
+int intel_dp_rate_index(const int *rates, int len, int rate);
 void intel_dp_update_sink_caps(struct intel_dp *intel_dp);
 
 void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock,
drivers/gpu/drm/i915/display/intel_dp_link_training.c +73 -1
index 947575140059d..4db293f256896 100644
@@ -25,6 +25,7 @@
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_link_training.h"
+#include "intel_panel.h"
 
 #define LT_MSG_PREFIX                        "[CONNECTOR:%d:%s][ENCODER:%d:%s][%s] "
 #define LT_MSG_ARGS(_intel_dp, _dp_phy)      (_intel_dp)->attached_connector->base.base.id, \
@@ -1091,6 +1092,78 @@ intel_dp_link_train_phy(struct intel_dp *intel_dp,
      return ret;
 }
 
+static bool intel_dp_can_link_train_fallback_for_edp(struct intel_dp *intel_dp,
+                                                  int link_rate,
+                                                  u8 lane_count)
+{
+     /* FIXME figure out what we actually want here */
+     const struct drm_display_mode *fixed_mode =
+             intel_panel_preferred_fixed_mode(intel_dp->attached_connector);
+     int mode_rate, max_rate;
+
+     mode_rate = intel_dp_link_required(fixed_mode->clock, 18);
+     max_rate = intel_dp_max_link_data_rate(intel_dp, link_rate, lane_count);
+     if (mode_rate > max_rate)
+             return false;
+
+     return true;
+}
+
+static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
+                                                int link_rate, u8 lane_count)
+{
+     struct drm_i915_private *i915 = dp_to_i915(intel_dp);
+     int index;
+
+     /*
+      * TODO: Enable fallback on MST links once MST link compute can handle
+      * the fallback params.
+      */
+     if (intel_dp->is_mst) {
+             drm_err(&i915->drm, "Link Training Unsuccessful\n");
+             return -1;
+     }
+
+     if (intel_dp_is_edp(intel_dp) && !intel_dp->use_max_params) {
+             drm_dbg_kms(&i915->drm,
+                         "Retrying Link training for eDP with max parameters\n");
+             intel_dp->use_max_params = true;
+             return 0;
+     }
+
+     index = intel_dp_rate_index(intel_dp->common_rates,
+                                 intel_dp->num_common_rates,
+                                 link_rate);
+     if (index > 0) {
+             if (intel_dp_is_edp(intel_dp) &&
+                 !intel_dp_can_link_train_fallback_for_edp(intel_dp,
+                                                           intel_dp_common_rate(intel_dp, index - 1),
+                                                           lane_count)) {
+                     drm_dbg_kms(&i915->drm,
+                                 "Retrying Link training for eDP with same parameters\n");
+                     return 0;
+             }
+             intel_dp->link.max_rate = intel_dp_common_rate(intel_dp, index - 1);
+             intel_dp->link.max_lane_count = lane_count;
+     } else if (lane_count > 1) {
+             if (intel_dp_is_edp(intel_dp) &&
+                 !intel_dp_can_link_train_fallback_for_edp(intel_dp,
+                                                           intel_dp_max_common_rate(intel_dp),
+                                                           lane_count >> 1)) {
+                     drm_dbg_kms(&i915->drm,
+                                 "Retrying Link training for eDP with same parameters\n");
+                     return 0;
+             }
+             intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
+             intel_dp->link.max_lane_count = lane_count >> 1;
+     } else {
+             drm_err(&i915->drm, "Link Training Unsuccessful\n");
+             return -1;
+     }
+
+     return 0;
+}
+
 static void intel_dp_schedule_fallback_link_training(struct intel_dp *intel_dp,
                                                   const struct intel_crtc_state *crtc_state)
 {
--
Quoted 1 line

2.43.3

--
Ville Syrjälä
Intel

author
#7 lore raw

PATCH v2 4/21 drm/i915/dp: Sanitize intel_dp_get_link_train_fallback_values()

In reply to Imre Deak

Reduce the indentation in intel_dp_get_link_train_fallback_values() by adding separate helpers to reduce the link rate and lane count. Also simplify things by passing crtc_state to the function.

This also prepares for later patches in the patchset adding a limitation on how the link params are reduced.

---
 .../drm/i915/display/intel_dp_link_training.c | 82 ++++++++++++-------
 1 file changed, 51 insertions(+), 31 deletions(-)
drivers/gpu/drm/i915/display/intel_dp_link_training.c +51 -31
index 4db293f256896..edc970036866a 100644
@@ -1109,11 +1109,37 @@ static bool intel_dp_can_link_train_fallback_for_edp(struct intel_dp *intel_dp,
 	return true;
 }
 
+static int reduce_link_rate(struct intel_dp *intel_dp, int current_rate)
+{
+	int rate_index;
+	int new_rate;
+
+	rate_index = intel_dp_rate_index(intel_dp->common_rates,
+					 intel_dp->num_common_rates,
+					 current_rate);
+
+	if (rate_index <= 0)
+		return -1;
+
+	new_rate = intel_dp_common_rate(intel_dp, rate_index - 1);
+
+	return new_rate;
+}
+
+static int reduce_lane_count(struct intel_dp *intel_dp, int current_lane_count)
+{
+	if (current_lane_count > 1)
+		return current_lane_count >> 1;
+
+	return -1;
+}
+
 static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
-						   int link_rate, u8 lane_count)
+						   const struct intel_crtc_state *crtc_state)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
-	int index;
+	int new_link_rate;
+	int new_lane_count;
 
 	/*
 	 * TODO: Enable fallback on MST links once MST link compute can handle
@@ -1131,36 +1157,32 @@ static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 		return 0;
 	}
 
-	index = intel_dp_rate_index(intel_dp->common_rates,
-				    intel_dp->num_common_rates,
-				    link_rate);
-	if (index > 0) {
-		if (intel_dp_is_edp(intel_dp) &&
-		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
-							      intel_dp_common_rate(intel_dp, index - 1),
-							      lane_count)) {
-			drm_dbg_kms(&i915->drm,
-				    "Retrying Link training for eDP with same parameters\n");
-			return 0;
-		}
-		intel_dp->link.max_rate = intel_dp_common_rate(intel_dp, index - 1);
-		intel_dp->link.max_lane_count = lane_count;
-	} else if (lane_count > 1) {
-		if (intel_dp_is_edp(intel_dp) &&
-		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
-							      intel_dp_max_common_rate(intel_dp),
-							      lane_count >> 1)) {
-			drm_dbg_kms(&i915->drm,
-				    "Retrying Link training for eDP with same parameters\n");
-			return 0;
-		}
-		intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
-		intel_dp->link.max_lane_count = lane_count >> 1;
-	} else {
+	new_lane_count = crtc_state->lane_count;
+	new_link_rate = reduce_link_rate(intel_dp, crtc_state->port_clock);
+	if (new_link_rate < 0) {
+		new_lane_count = reduce_lane_count(intel_dp, crtc_state->lane_count);
+		new_link_rate = intel_dp_max_common_rate(intel_dp);
+	}
+
+	if (new_lane_count < 0) {
 		drm_err(&i915->drm, "Link Training Unsuccessful\n");
 		return -1;
 	}
 
+	if (intel_dp_is_edp(intel_dp) &&
+	    !intel_dp_can_link_train_fallback_for_edp(intel_dp, new_link_rate, new_lane_count)) {
+		drm_dbg_kms(&i915->drm,
+			    "Retrying Link training for eDP with same parameters\n");
+		return 0;
+	}
+
+	drm_dbg_kms(&i915->drm, "Reducing link parameters from %dx%d to %dx%d\n",
+		    crtc_state->lane_count, crtc_state->port_clock,
+		    new_lane_count, new_link_rate);
+
+	intel_dp->link.max_rate = new_link_rate;
+	intel_dp->link.max_lane_count = new_lane_count;
+
 	return 0;
 }
 
@@ -1178,9 +1200,7 @@ static void intel_dp_schedule_fallback_link_training(struct intel_dp *intel_dp,
 		lt_dbg(intel_dp, DP_PHY_DPRX,
 		       "Link Training failed with HOBL active, not enabling it from now on\n");
 		intel_dp->hobl_failed = true;
-	} else if (intel_dp_get_link_train_fallback_values(intel_dp,
-							   crtc_state->port_clock,
-							   crtc_state->lane_count)) {
+	} else if (intel_dp_get_link_train_fallback_values(intel_dp, crtc_state)) {
 		return;
 	}
 
Signature · 1 line
2.43.3
Reviewed-by on v2 4/21
#8 lore raw

Re: [PATCH v2 04/21] drm/i915/dp: Sanitize intel_dp_get_link_train_fallback_values()

Quoted 25 lines · Imre Deak

Reduce the indentation in intel_dp_get_link_train_fallback_values() by adding separate helpers to reduce the link rate and lane count. Also simplify things by passing crtc_state to the function.

This also prepares for later patches in the patchset adding a limitation on how the link params are reduced.

---
 .../drm/i915/display/intel_dp_link_training.c | 82 ++++++++++++-------
 1 file changed, 51 insertions(+), 31 deletions(-)
drivers/gpu/drm/i915/display/intel_dp_link_training.c +5 -0
index 4db293f256896..edc970036866a 100644
@@ -1109,11 +1109,37 @@ static bool intel_dp_can_link_train_fallback_for_edp(struct intel_dp *intel_dp,
 	return true;
 }
 
+static int reduce_link_rate(struct intel_dp *intel_dp, int current_rate)
+{
+	int rate_index;
+	int new_rate;
+

drivers/gpu/drm/i915/display/intel_dp_link_training.c static bool intel_dp_can_link_train_fallback_for_edp(struct intel_dp *intel_dp, · line 1126

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +10 -0
+	rate_index = intel_dp_rate_index(intel_dp->common_rates,
+					 intel_dp->num_common_rates,
+					 current_rate);
+
+	if (rate_index <= 0)
+		return -1;
+
+	new_rate = intel_dp_common_rate(intel_dp, rate_index - 1);
+
+	return new_rate;

This is structured as

if (bad)

	fail;

success;

drivers/gpu/drm/i915/display/intel_dp_link_training.c static bool intel_dp_can_link_train_fallback_for_edp(struct intel_dp *intel_dp, · line 1134

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +8 -0
+}
+
+static int reduce_lane_count(struct intel_dp *intel_dp, int current_lane_count)
+{
+	if (current_lane_count > 1)
+		return current_lane_count >> 1;
+
+	return -1;

whereas this is

if (ok)

	success;

fail;

I'd rearrange one of them so the logic is the same way around in both.

Otherwise lgtm

Quoted 85 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +28 -31
+}
+
 static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
-						   int link_rate, u8 lane_count)
+						   const struct intel_crtc_state *crtc_state)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
-	int index;
+	int new_link_rate;
+	int new_lane_count;
 
 	/*
 	 * TODO: Enable fallback on MST links once MST link compute can handle
@@ -1131,36 +1157,32 @@ static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 		return 0;
 	}
 
-	index = intel_dp_rate_index(intel_dp->common_rates,
-				    intel_dp->num_common_rates,
-				    link_rate);
-	if (index > 0) {
-		if (intel_dp_is_edp(intel_dp) &&
-		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
-							      intel_dp_common_rate(intel_dp, index - 1),
-							      lane_count)) {
-			drm_dbg_kms(&i915->drm,
-				    "Retrying Link training for eDP with same parameters\n");
-			return 0;
-		}
-		intel_dp->link.max_rate = intel_dp_common_rate(intel_dp, index - 1);
-		intel_dp->link.max_lane_count = lane_count;
-	} else if (lane_count > 1) {
-		if (intel_dp_is_edp(intel_dp) &&
-		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
-							      intel_dp_max_common_rate(intel_dp),
-							      lane_count >> 1)) {
-			drm_dbg_kms(&i915->drm,
-				    "Retrying Link training for eDP with same parameters\n");
-			return 0;
-		}
-		intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
-		intel_dp->link.max_lane_count = lane_count >> 1;
-	} else {
+	new_lane_count = crtc_state->lane_count;
+	new_link_rate = reduce_link_rate(intel_dp, crtc_state->port_clock);
+	if (new_link_rate < 0) {
+		new_lane_count = reduce_lane_count(intel_dp, crtc_state->lane_count);
+		new_link_rate = intel_dp_max_common_rate(intel_dp);
+	}
+
+	if (new_lane_count < 0) {
 		drm_err(&i915->drm, "Link Training Unsuccessful\n");
 		return -1;
 	}
 
+	if (intel_dp_is_edp(intel_dp) &&
+	    !intel_dp_can_link_train_fallback_for_edp(intel_dp, new_link_rate, new_lane_count)) {
+		drm_dbg_kms(&i915->drm,
+			    "Retrying Link training for eDP with same parameters\n");
+		return 0;
+	}
+
+	drm_dbg_kms(&i915->drm, "Reducing link parameters from %dx%d to %dx%d\n",
+		    crtc_state->lane_count, crtc_state->port_clock,
+		    new_lane_count, new_link_rate);
+
+	intel_dp->link.max_rate = new_link_rate;
+	intel_dp->link.max_lane_count = new_lane_count;
+
 	return 0;
 }
 
@@ -1178,9 +1200,7 @@ static void intel_dp_schedule_fallback_link_training(struct intel_dp *intel_dp,
 		lt_dbg(intel_dp, DP_PHY_DPRX,
 		       "Link Training failed with HOBL active, not enabling it from now on\n");
 		intel_dp->hobl_failed = true;
-	} else if (intel_dp_get_link_train_fallback_values(intel_dp,
-							   crtc_state->port_clock,
-							   crtc_state->lane_count)) {
+	} else if (intel_dp_get_link_train_fallback_values(intel_dp, crtc_state)) {
 		return;
 	}
 
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
author
#9 lore raw

Re: [PATCH v2 04/21] drm/i915/dp: Sanitize intel_dp_get_link_train_fallback_values()

Quoted 54 lines · Ville Syrjälä
Quoted 25 lines · Imre Deak

Reduce the indentation in intel_dp_get_link_train_fallback_values() by adding separate helpers to reduce the link rate and lane count. Also simplify things by passing crtc_state to the function.

This also prepares for later patches in the patchset adding a limitation on how the link params are reduced.

---
 .../drm/i915/display/intel_dp_link_training.c | 82 ++++++++++++-------
 1 file changed, 51 insertions(+), 31 deletions(-)
drivers/gpu/drm/i915/display/intel_dp_link_training.c +5 -0
index 4db293f256896..edc970036866a 100644
@@ -1109,11 +1109,37 @@ static bool intel_dp_can_link_train_fallback_for_edp(struct intel_dp *intel_dp,
 	return true;
 }
 
+static int reduce_link_rate(struct intel_dp *intel_dp, int current_rate)
+{
+	int rate_index;
+	int new_rate;
+

drivers/gpu/drm/i915/display/intel_dp_link_training.c static bool intel_dp_can_link_train_fallback_for_edp(struct intel_dp *intel_dp, · line 1126

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +10 -0
+	rate_index = intel_dp_rate_index(intel_dp->common_rates,
+					 intel_dp->num_common_rates,
+					 current_rate);
+
+	if (rate_index <= 0)
+		return -1;
+
+	new_rate = intel_dp_common_rate(intel_dp, rate_index - 1);
+
+	return new_rate;

This is structured as

if (bad)

	fail;

success;

drivers/gpu/drm/i915/display/intel_dp_link_training.c static bool intel_dp_can_link_train_fallback_for_edp(struct intel_dp *intel_dp, · line 1134

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +8 -0
+}
+
+static int reduce_lane_count(struct intel_dp *intel_dp, int current_lane_count)
+{
+	if (current_lane_count > 1)
+		return current_lane_count >> 1;
+
+	return -1;

whereas this is

Quoted 5 lines

if (ok)

	success;

fail;

I'd rearrange one of them so the logic is the same way around in both.

Ok, will change that.

Quoted 92 lines

Otherwise lgtm

Quoted 85 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +28 -31
+}
+
 static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
-						   int link_rate, u8 lane_count)
+						   const struct intel_crtc_state *crtc_state)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
-	int index;
+	int new_link_rate;
+	int new_lane_count;
 
 	/*
 	 * TODO: Enable fallback on MST links once MST link compute can handle
@@ -1131,36 +1157,32 @@ static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 		return 0;
 	}
 
-	index = intel_dp_rate_index(intel_dp->common_rates,
-				    intel_dp->num_common_rates,
-				    link_rate);
-	if (index > 0) {
-		if (intel_dp_is_edp(intel_dp) &&
-		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
-							      intel_dp_common_rate(intel_dp, index - 1),
-							      lane_count)) {
-			drm_dbg_kms(&i915->drm,
-				    "Retrying Link training for eDP with same parameters\n");
-			return 0;
-		}
-		intel_dp->link.max_rate = intel_dp_common_rate(intel_dp, index - 1);
-		intel_dp->link.max_lane_count = lane_count;
-	} else if (lane_count > 1) {
-		if (intel_dp_is_edp(intel_dp) &&
-		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
-							      intel_dp_max_common_rate(intel_dp),
-							      lane_count >> 1)) {
-			drm_dbg_kms(&i915->drm,
-				    "Retrying Link training for eDP with same parameters\n");
-			return 0;
-		}
-		intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
-		intel_dp->link.max_lane_count = lane_count >> 1;
-	} else {
+	new_lane_count = crtc_state->lane_count;
+	new_link_rate = reduce_link_rate(intel_dp, crtc_state->port_clock);
+	if (new_link_rate < 0) {
+		new_lane_count = reduce_lane_count(intel_dp, crtc_state->lane_count);
+		new_link_rate = intel_dp_max_common_rate(intel_dp);
+	}
+
+	if (new_lane_count < 0) {
 		drm_err(&i915->drm, "Link Training Unsuccessful\n");
 		return -1;
 	}
 
+	if (intel_dp_is_edp(intel_dp) &&
+	    !intel_dp_can_link_train_fallback_for_edp(intel_dp, new_link_rate, new_lane_count)) {
+		drm_dbg_kms(&i915->drm,
+			    "Retrying Link training for eDP with same parameters\n");
+		return 0;
+	}
+
+	drm_dbg_kms(&i915->drm, "Reducing link parameters from %dx%d to %dx%d\n",
+		    crtc_state->lane_count, crtc_state->port_clock,
+		    new_lane_count, new_link_rate);
+
+	intel_dp->link.max_rate = new_link_rate;
+	intel_dp->link.max_lane_count = new_lane_count;
+
 	return 0;
 }
 
@@ -1178,9 +1200,7 @@ static void intel_dp_schedule_fallback_link_training(struct intel_dp *intel_dp,
 		lt_dbg(intel_dp, DP_PHY_DPRX,
 		       "Link Training failed with HOBL active, not enabling it from now on\n");
 		intel_dp->hobl_failed = true;
-	} else if (intel_dp_get_link_train_fallback_values(intel_dp,
-							   crtc_state->port_clock,
-							   crtc_state->lane_count)) {
+	} else if (intel_dp_get_link_train_fallback_values(intel_dp, crtc_state)) {
 		return;
 	}
 
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
maintainer
#10 lore raw

Re: [PATCH v2 04/21] drm/i915/dp: Sanitize intel_dp_get_link_train_fallback_values()

In reply to Ville Syrjälä
Quoted 54 lines · Ville Syrjälä
Quoted 25 lines · Imre Deak

Reduce the indentation in intel_dp_get_link_train_fallback_values() by adding separate helpers to reduce the link rate and lane count. Also simplify things by passing crtc_state to the function.

This also prepares for later patches in the patchset adding a limitation on how the link params are reduced.

---
 .../drm/i915/display/intel_dp_link_training.c | 82 ++++++++++++-------
 1 file changed, 51 insertions(+), 31 deletions(-)
drivers/gpu/drm/i915/display/intel_dp_link_training.c +5 -0
index 4db293f256896..edc970036866a 100644
@@ -1109,11 +1109,37 @@ static bool intel_dp_can_link_train_fallback_for_edp(struct intel_dp *intel_dp,
 	return true;
 }
 
+static int reduce_link_rate(struct intel_dp *intel_dp, int current_rate)
+{
+	int rate_index;
+	int new_rate;
+

drivers/gpu/drm/i915/display/intel_dp_link_training.c static bool intel_dp_can_link_train_fallback_for_edp(struct intel_dp *intel_dp, · line 1126

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +10 -0
+	rate_index = intel_dp_rate_index(intel_dp->common_rates,
+					 intel_dp->num_common_rates,
+					 current_rate);
+
+	if (rate_index <= 0)
+		return -1;
+
+	new_rate = intel_dp_common_rate(intel_dp, rate_index - 1);
+
+	return new_rate;

This is structured as

if (bad)

	fail;

success;

drivers/gpu/drm/i915/display/intel_dp_link_training.c static bool intel_dp_can_link_train_fallback_for_edp(struct intel_dp *intel_dp, · line 1134

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +8 -0
+}
+
+static int reduce_lane_count(struct intel_dp *intel_dp, int current_lane_count)
+{
+	if (current_lane_count > 1)
+		return current_lane_count >> 1;
+
+	return -1;

whereas this is

Quoted 5 lines

if (ok)

	success;

fail;

I'd rearrange one of them so the logic is the same way around in both.

Usually failures in if branches with early returns and happy day scenario with the least indentation.

BR,
Jani.

Quoted 89 lines

Otherwise lgtm

Quoted 85 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +28 -31
+}
+
 static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
-						   int link_rate, u8 lane_count)
+						   const struct intel_crtc_state *crtc_state)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
-	int index;
+	int new_link_rate;
+	int new_lane_count;
 
 	/*
 	 * TODO: Enable fallback on MST links once MST link compute can handle
@@ -1131,36 +1157,32 @@ static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 		return 0;
 	}
 
-	index = intel_dp_rate_index(intel_dp->common_rates,
-				    intel_dp->num_common_rates,
-				    link_rate);
-	if (index > 0) {
-		if (intel_dp_is_edp(intel_dp) &&
-		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
-							      intel_dp_common_rate(intel_dp, index - 1),
-							      lane_count)) {
-			drm_dbg_kms(&i915->drm,
-				    "Retrying Link training for eDP with same parameters\n");
-			return 0;
-		}
-		intel_dp->link.max_rate = intel_dp_common_rate(intel_dp, index - 1);
-		intel_dp->link.max_lane_count = lane_count;
-	} else if (lane_count > 1) {
-		if (intel_dp_is_edp(intel_dp) &&
-		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
-							      intel_dp_max_common_rate(intel_dp),
-							      lane_count >> 1)) {
-			drm_dbg_kms(&i915->drm,
-				    "Retrying Link training for eDP with same parameters\n");
-			return 0;
-		}
-		intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
-		intel_dp->link.max_lane_count = lane_count >> 1;
-	} else {
+	new_lane_count = crtc_state->lane_count;
+	new_link_rate = reduce_link_rate(intel_dp, crtc_state->port_clock);
+	if (new_link_rate < 0) {
+		new_lane_count = reduce_lane_count(intel_dp, crtc_state->lane_count);
+		new_link_rate = intel_dp_max_common_rate(intel_dp);
+	}
+
+	if (new_lane_count < 0) {
 		drm_err(&i915->drm, "Link Training Unsuccessful\n");
 		return -1;
 	}
 
+	if (intel_dp_is_edp(intel_dp) &&
+	    !intel_dp_can_link_train_fallback_for_edp(intel_dp, new_link_rate, new_lane_count)) {
+		drm_dbg_kms(&i915->drm,
+			    "Retrying Link training for eDP with same parameters\n");
+		return 0;
+	}
+
+	drm_dbg_kms(&i915->drm, "Reducing link parameters from %dx%d to %dx%d\n",
+		    crtc_state->lane_count, crtc_state->port_clock,
+		    new_lane_count, new_link_rate);
+
+	intel_dp->link.max_rate = new_link_rate;
+	intel_dp->link.max_lane_count = new_lane_count;
+
 	return 0;
 }
 
@@ -1178,9 +1200,7 @@ static void intel_dp_schedule_fallback_link_training(struct intel_dp *intel_dp,
 		lt_dbg(intel_dp, DP_PHY_DPRX,
 		       "Link Training failed with HOBL active, not enabling it from now on\n");
 		intel_dp->hobl_failed = true;
-	} else if (intel_dp_get_link_train_fallback_values(intel_dp,
-							   crtc_state->port_clock,
-							   crtc_state->lane_count)) {
+	} else if (intel_dp_get_link_train_fallback_values(intel_dp, crtc_state)) {
 		return;
 	}
 
Signature · 1 line
2.43.3
Signature · 1 line
Jani Nikula, Intel
author
#11 lore raw

PATCH v2 5/21 drm/i915: Factor out function to modeset commit a set of pipes

In reply to Imre Deak

Factor out a function to modeset commit a set of pipes, which a later patch will reuse for DP link retraining.

---
 drivers/gpu/drm/i915/display/intel_ddi.c     | 31 +-----------------
 drivers/gpu/drm/i915/display/intel_display.c | 34 ++++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_display.h |  3 ++
 3 files changed, 38 insertions(+), 30 deletions(-)
drivers/gpu/drm/i915/display/intel_ddi.c +1 -30
index 3c3fc53376ce3..170ba01786cf8 100644
@@ -4441,35 +4441,6 @@ intel_ddi_init_dp_connector(struct intel_digital_port *dig_port)
 	return connector;
 }
 
-static int modeset_pipe(struct drm_crtc *crtc,
-			struct drm_modeset_acquire_ctx *ctx)
-{
-	struct drm_atomic_state *state;
-	struct drm_crtc_state *crtc_state;
-	int ret;
-
-	state = drm_atomic_state_alloc(crtc->dev);
-	if (!state)
-		return -ENOMEM;
-
-	state->acquire_ctx = ctx;
-	to_intel_atomic_state(state)->internal = true;
-
-	crtc_state = drm_atomic_get_crtc_state(state, crtc);
-	if (IS_ERR(crtc_state)) {
-		ret = PTR_ERR(crtc_state);
-		goto out;
-	}
-
-	crtc_state->connectors_changed = true;
-
-	ret = drm_atomic_commit(state);
-out:
-	drm_atomic_state_put(state);
-
-	return ret;
-}
-
 static int intel_hdmi_reset_link(struct intel_encoder *encoder,
 				 struct drm_modeset_acquire_ctx *ctx)
 {
@@ -4539,7 +4510,7 @@ static int intel_hdmi_reset_link(struct intel_encoder *encoder,
 	 * would be perfectly happy if were to just reconfigure
 	 * the SCDC settings on the fly.
 	 */
-	return modeset_pipe(&crtc->base, ctx);
+	return intel_modeset_commit_pipes(dev_priv, BIT(crtc->pipe), ctx);
 }
 
 static enum intel_hotplug_state
drivers/gpu/drm/i915/display/intel_display.c +34 -0
index cce1420fb5417..4edb1ede4a1b4 100644
@@ -5569,6 +5569,40 @@ int intel_modeset_all_pipes_late(struct intel_atomic_state *state,
 	return 0;
 }
 
+int intel_modeset_commit_pipes(struct drm_i915_private *i915,
+			       u8 pipe_mask,
+			       struct drm_modeset_acquire_ctx *ctx)
+{
+	struct drm_atomic_state *state;
+	struct intel_crtc *crtc;
+	int ret;
+
+	state = drm_atomic_state_alloc(&i915->drm);
+	if (!state)
+		return -ENOMEM;
+
+	state->acquire_ctx = ctx;
+	to_intel_atomic_state(state)->internal = true;
+
+	for_each_intel_crtc_in_pipe_mask(&i915->drm, crtc, pipe_mask) {
+		struct intel_crtc_state *crtc_state =
+			intel_atomic_get_crtc_state(state, crtc);
+
+		if (IS_ERR(crtc_state)) {
+			ret = PTR_ERR(crtc_state);
+			goto out;
+		}
+
+		crtc_state->uapi.connectors_changed = true;
+	}
+
+	ret = drm_atomic_commit(state);
+out:
+	drm_atomic_state_put(state);
+
+	return ret;
+}
+
 /*
  * This implements the workaround described in the "notes" section of the mode
  * set sequence documentation. When going from no pipes or single pipe to
drivers/gpu/drm/i915/display/intel_display.h +3 -0
index 56d1c0e3e62cd..dfdc42cef8723 100644
@@ -537,6 +537,9 @@ int intel_modeset_pipes_in_mask_early(struct intel_atomic_state *state,
 				      const char *reason, u8 pipe_mask);
 int intel_modeset_all_pipes_late(struct intel_atomic_state *state,
 				 const char *reason);
+int intel_modeset_commit_pipes(struct drm_i915_private *i915,
+			       u8 pipe_mask,
+			       struct drm_modeset_acquire_ctx *ctx);
 void intel_modeset_get_crtc_power_domains(struct intel_crtc_state *crtc_state,
 					  struct intel_power_domain_mask *old_domains);
 void intel_modeset_put_crtc_power_domains(struct intel_crtc *crtc,
Signature · 1 line
2.43.3
Reviewed-by on v2 5/21
#12 lore raw

Re: [PATCH v2 05/21] drm/i915: Factor out function to modeset commit a set of pipes

Quoted 4 lines · Imre Deak

Factor out a function to modeset commit a set of pipes, which a later patch will reuse for DP link retraining.

Quoted 116 lines
---
 drivers/gpu/drm/i915/display/intel_ddi.c     | 31 +-----------------
 drivers/gpu/drm/i915/display/intel_display.c | 34 ++++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_display.h |  3 ++
 3 files changed, 38 insertions(+), 30 deletions(-)
drivers/gpu/drm/i915/display/intel_ddi.c +1 -30
index 3c3fc53376ce3..170ba01786cf8 100644
@@ -4441,35 +4441,6 @@ intel_ddi_init_dp_connector(struct intel_digital_port *dig_port)
 	return connector;
 }
 
-static int modeset_pipe(struct drm_crtc *crtc,
-			struct drm_modeset_acquire_ctx *ctx)
-{
-	struct drm_atomic_state *state;
-	struct drm_crtc_state *crtc_state;
-	int ret;
-
-	state = drm_atomic_state_alloc(crtc->dev);
-	if (!state)
-		return -ENOMEM;
-
-	state->acquire_ctx = ctx;
-	to_intel_atomic_state(state)->internal = true;
-
-	crtc_state = drm_atomic_get_crtc_state(state, crtc);
-	if (IS_ERR(crtc_state)) {
-		ret = PTR_ERR(crtc_state);
-		goto out;
-	}
-
-	crtc_state->connectors_changed = true;
-
-	ret = drm_atomic_commit(state);
-out:
-	drm_atomic_state_put(state);
-
-	return ret;
-}
-
 static int intel_hdmi_reset_link(struct intel_encoder *encoder,
 				 struct drm_modeset_acquire_ctx *ctx)
 {
@@ -4539,7 +4510,7 @@ static int intel_hdmi_reset_link(struct intel_encoder *encoder,
 	 * would be perfectly happy if were to just reconfigure
 	 * the SCDC settings on the fly.
 	 */
-	return modeset_pipe(&crtc->base, ctx);
+	return intel_modeset_commit_pipes(dev_priv, BIT(crtc->pipe), ctx);
 }
 
 static enum intel_hotplug_state
drivers/gpu/drm/i915/display/intel_display.c +34 -0
index cce1420fb5417..4edb1ede4a1b4 100644
@@ -5569,6 +5569,40 @@ int intel_modeset_all_pipes_late(struct intel_atomic_state *state,
 	return 0;
 }
 
+int intel_modeset_commit_pipes(struct drm_i915_private *i915,
+			       u8 pipe_mask,
+			       struct drm_modeset_acquire_ctx *ctx)
+{
+	struct drm_atomic_state *state;
+	struct intel_crtc *crtc;
+	int ret;
+
+	state = drm_atomic_state_alloc(&i915->drm);
+	if (!state)
+		return -ENOMEM;
+
+	state->acquire_ctx = ctx;
+	to_intel_atomic_state(state)->internal = true;
+
+	for_each_intel_crtc_in_pipe_mask(&i915->drm, crtc, pipe_mask) {
+		struct intel_crtc_state *crtc_state =
+			intel_atomic_get_crtc_state(state, crtc);
+
+		if (IS_ERR(crtc_state)) {
+			ret = PTR_ERR(crtc_state);
+			goto out;
+		}
+
+		crtc_state->uapi.connectors_changed = true;
+	}
+
+	ret = drm_atomic_commit(state);
+out:
+	drm_atomic_state_put(state);
+
+	return ret;
+}
+
 /*
  * This implements the workaround described in the "notes" section of the mode
  * set sequence documentation. When going from no pipes or single pipe to
drivers/gpu/drm/i915/display/intel_display.h +3 -0
index 56d1c0e3e62cd..dfdc42cef8723 100644
@@ -537,6 +537,9 @@ int intel_modeset_pipes_in_mask_early(struct intel_atomic_state *state,
 				      const char *reason, u8 pipe_mask);
 int intel_modeset_all_pipes_late(struct intel_atomic_state *state,
 				 const char *reason);
+int intel_modeset_commit_pipes(struct drm_i915_private *i915,
+			       u8 pipe_mask,
+			       struct drm_modeset_acquire_ctx *ctx);
 void intel_modeset_get_crtc_power_domains(struct intel_crtc_state *crtc_state,
 					  struct intel_power_domain_mask *old_domains);
 void intel_modeset_put_crtc_power_domains(struct intel_crtc *crtc,
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
author
#13 lore raw

PATCH v2 6/21 drm/i915/dp: Use a commit modeset for link retraining MST links

In reply to Imre Deak

Instead of direct calls to the link train functions, retrain the link via a commit modeset. The direct call means that the output port will be disabled/re-enabled while the rest of the pipeline (transcoder) is active, which doesn't seem to work on MST at least. It leads to underruns and black screen, presumedly because the transcoder is not disabled/re-enabled along the port.

Leave switching to a commit modeset on SST for a later patchset, as that seems to work ok currently (though better to using a commit there too, due to the suppressed underruns).

---
 drivers/gpu/drm/i915/display/intel_dp.c | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +19 -6
index 81e620dd33bb7..120f7b420807b 100644
@@ -5147,6 +5147,7 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 	struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
 	struct intel_crtc *crtc;
 	u8 pipe_mask;
+	bool mst_output = false;
 	int ret;
 
 	if (!intel_dp_is_connected(intel_dp))
@@ -5177,6 +5178,11 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 		const struct intel_crtc_state *crtc_state =
 			to_intel_crtc_state(crtc->base.state);
 
+		if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST)) {
+			mst_output = true;
+			break;
+		}
+
 		/* Suppress underruns caused by re-training */
 		intel_set_cpu_fifo_underrun_reporting(dev_priv, crtc->pipe, false);
 		if (crtc_state->has_pch_encoder)
@@ -5184,16 +5190,23 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 							      intel_crtc_pch_transcoder(crtc), false);
 	}
 
+	/* TODO: use a modeset for SST as well. */
+	if (mst_output) {
+		ret = intel_modeset_commit_pipes(dev_priv, pipe_mask, ctx);
+
+		if (ret && ret != -EDEADLK)
+			drm_dbg_kms(&dev_priv->drm,
+				    "[ENCODER:%d:%s] link retraining failed: %pe\n",
+				    encoder->base.base.id, encoder->base.name,
+				    ERR_PTR(ret));
+
+		return ret;
+	}
+
 	for_each_intel_crtc_in_pipe_mask(&dev_priv->drm, crtc, pipe_mask) {
 		const struct intel_crtc_state *crtc_state =
 			to_intel_crtc_state(crtc->base.state);
 
-		/* retrain on the MST master transcoder */
-		if (DISPLAY_VER(dev_priv) >= 12 &&
-		    intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST) &&
-		    !intel_dp_mst_is_master_trans(crtc_state))
-			continue;
-
 		intel_dp_check_frl_training(intel_dp);
 		intel_dp_pcon_dsc_configure(intel_dp, crtc_state);
 		intel_dp_start_link_train(intel_dp, crtc_state);
Signature · 1 line
2.43.3
Reviewed-by on v2 6/21
#14 lore raw

Re: [PATCH v2 06/21] drm/i915/dp: Use a commit modeset for link retraining MST links

Quoted 21 lines · Imre Deak

Instead of direct calls to the link train functions, retrain the link via a commit modeset. The direct call means that the output port will be disabled/re-enabled while the rest of the pipeline (transcoder) is active, which doesn't seem to work on MST at least. It leads to underruns and black screen, presumedly because the transcoder is not disabled/re-enabled along the port.

Leave switching to a commit modeset on SST for a later patchset, as that seems to work ok currently (though better to using a commit there too, due to the suppressed underruns).

---
 drivers/gpu/drm/i915/display/intel_dp.c | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
index 81e620dd33bb7..120f7b420807b 100644

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_retrain_link(struct intel_encoder *encoder, · line 5150

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dp.c +1 -0
@@ -5147,6 +5147,7 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 	struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
 	struct intel_crtc *crtc;
 	u8 pipe_mask;
+	bool mst_output = false;

nit: maybe move that up one line to maintain a bit more of a steady slope

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_retrain_link(struct intel_encoder *encoder, · line 5184

Quoted 11 lines
drivers/gpu/drm/i915/display/intel_dp.c +4 -0
 	int ret;
 
 	if (!intel_dp_is_connected(intel_dp))
@@ -5177,6 +5178,11 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 		const struct intel_crtc_state *crtc_state =
 			to_intel_crtc_state(crtc->base.state);
 
+		if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST)) {
+			mst_output = true;
+			break;
+		}

I was pondering if we need a bit more care to make sure all the pipes agree, but I suppose if that wasn't the case check_digital_port_conflicts() would have a failed at its job. So this seems fine.

Quoted 36 lines
drivers/gpu/drm/i915/display/intel_dp.c +14 -6
+
 		/* Suppress underruns caused by re-training */
 		intel_set_cpu_fifo_underrun_reporting(dev_priv, crtc->pipe, false);
 		if (crtc_state->has_pch_encoder)
@@ -5184,16 +5190,23 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 							      intel_crtc_pch_transcoder(crtc), false);
 	}
 
+	/* TODO: use a modeset for SST as well. */
+	if (mst_output) {
+		ret = intel_modeset_commit_pipes(dev_priv, pipe_mask, ctx);
+
+		if (ret && ret != -EDEADLK)
+			drm_dbg_kms(&dev_priv->drm,
+				    "[ENCODER:%d:%s] link retraining failed: %pe\n",
+				    encoder->base.base.id, encoder->base.name,
+				    ERR_PTR(ret));
+
+		return ret;
+	}
+
 	for_each_intel_crtc_in_pipe_mask(&dev_priv->drm, crtc, pipe_mask) {
 		const struct intel_crtc_state *crtc_state =
 			to_intel_crtc_state(crtc->base.state);
 
-		/* retrain on the MST master transcoder */
-		if (DISPLAY_VER(dev_priv) >= 12 &&
-		    intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST) &&
-		    !intel_dp_mst_is_master_trans(crtc_state))
-			continue;
-
 		intel_dp_check_frl_training(intel_dp);
 		intel_dp_pcon_dsc_configure(intel_dp, crtc_state);
 		intel_dp_start_link_train(intel_dp, crtc_state);
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
author
#15 lore raw

Re: [PATCH v2 06/21] drm/i915/dp: Use a commit modeset for link retraining MST links

Quoted 17 lines · Ville Syrjälä
Quoted 16 lines · Imre Deak

Instead of direct calls to the link train functions, retrain the link via a commit modeset. The direct call means that the output port will be disabled/re-enabled while the rest of the pipeline (transcoder) is active, which doesn't seem to work on MST at least. It leads to underruns and black screen, presumedly because the transcoder is not disabled/re-enabled along the port.

Leave switching to a commit modeset on SST for a later patchset, as that seems to work ok currently (though better to using a commit there too, due to the suppressed underruns).

---
 drivers/gpu/drm/i915/display/intel_dp.c | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)
Quoted 11 lines

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_retrain_link(struct intel_encoder *encoder, · line 5150

Quoted 9 lines
drivers/gpu/drm/i915/display/intel_dp.c +1 -0
index 81e620dd33bb7..120f7b420807b 100644
@@ -5147,6 +5147,7 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 	struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
 	struct intel_crtc *crtc;
 	u8 pipe_mask;
+	bool mst_output = false;

nit: maybe move that up one line to maintain a bit more of a steady slope

Ok.

Quoted 7 lines
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
 	int ret;
 
 	if (!intel_dp_is_connected(intel_dp))
@@ -5177,6 +5178,11 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 		const struct intel_crtc_state *crtc_state =
 			to_intel_crtc_state(crtc->base.state);
 
Quoted 9 lines

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_retrain_link(struct intel_encoder *encoder, · line 5184

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dp.c +4 -0
+		if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST)) {
+			mst_output = true;
+			break;
+		}

I was pondering if we need a bit more care to make sure all the pipes agree, but I suppose if that wasn't the case check_digital_port_conflicts() would have a failed at its job. So this seems fine.

Yes, mixed SST/MST CRTCs connected to the same encoder is what you mean I guess. It would have caused a failure elsewhere or make the commit added here fail during atomic check.

Quoted 42 lines
Quoted 36 lines
drivers/gpu/drm/i915/display/intel_dp.c +14 -6
+
 		/* Suppress underruns caused by re-training */
 		intel_set_cpu_fifo_underrun_reporting(dev_priv, crtc->pipe, false);
 		if (crtc_state->has_pch_encoder)
@@ -5184,16 +5190,23 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 							      intel_crtc_pch_transcoder(crtc), false);
 	}
 
+	/* TODO: use a modeset for SST as well. */
+	if (mst_output) {
+		ret = intel_modeset_commit_pipes(dev_priv, pipe_mask, ctx);
+
+		if (ret && ret != -EDEADLK)
+			drm_dbg_kms(&dev_priv->drm,
+				    "[ENCODER:%d:%s] link retraining failed: %pe\n",
+				    encoder->base.base.id, encoder->base.name,
+				    ERR_PTR(ret));
+
+		return ret;
+	}
+
 	for_each_intel_crtc_in_pipe_mask(&dev_priv->drm, crtc, pipe_mask) {
 		const struct intel_crtc_state *crtc_state =
 			to_intel_crtc_state(crtc->base.state);
 
-		/* retrain on the MST master transcoder */
-		if (DISPLAY_VER(dev_priv) >= 12 &&
-		    intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST) &&
-		    !intel_dp_mst_is_master_trans(crtc_state))
-			continue;
-
 		intel_dp_check_frl_training(intel_dp);
 		intel_dp_pcon_dsc_configure(intel_dp, crtc_state);
 		intel_dp_start_link_train(intel_dp, crtc_state);
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
author
#16 lore raw

PATCH v2 7/21 drm/i915/dp: Recheck link state after modeset

In reply to Imre Deak

Recheck the link state after a passing link training, with a 2 sec delay to account for cases where the link goes bad following the link training and the sink doesn't report this via an HPD IRQ.

The delayed work added here will be also used by a later patch after a failed link training to try to retrain the link with unchanged link params before reducing the link params.

v2: Don't flush an uninitialized delayed work (on HDMI-only DDI ports).
v3: Add the work to intel_digital_port instead of intel_dp.

---
 drivers/gpu/drm/i915/display/g4x_dp.c         |  7 ++++
 drivers/gpu/drm/i915/display/intel_ddi.c      | 34 +++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_ddi.h      |  4 +++
 .../drm/i915/display/intel_display_types.h    |  3 ++
 drivers/gpu/drm/i915/display/intel_dp.c       |  1 +
 .../drm/i915/display/intel_dp_link_training.c | 12 +++++--
 6 files changed, 58 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/g4x_dp.c +7 -0
index 06ec04e667e32..4363e32a834df 100644
@@ -20,6 +20,7 @@
 #include "intel_dp_aux.h"
 #include "intel_dp_link_training.h"
 #include "intel_dpio_phy.h"
+#include "intel_ddi.h"
 #include "intel_fifo_underrun.h"
 #include "intel_hdmi.h"
 #include "intel_hotplug.h"
@@ -1241,6 +1242,10 @@ static bool ilk_digital_port_connected(struct intel_encoder *encoder)
 
 static void intel_dp_encoder_destroy(struct drm_encoder *encoder)
 {
+	struct intel_digital_port *dig_port = enc_to_dig_port(to_intel_encoder(encoder));
+
+	intel_ddi_flush_link_check_work(dig_port);
+
 	intel_dp_encoder_flush_work(encoder);
 
 	drm_encoder_cleanup(encoder);
@@ -1309,6 +1314,8 @@ bool g4x_dp_init(struct drm_i915_private *dev_priv,
 
 	dig_port->aux_ch = AUX_CH_NONE;
 
+	intel_ddi_init_link_check_work(dig_port);
+
 	intel_connector = intel_connector_alloc();
 	if (!intel_connector)
 		goto err_connector_alloc;
drivers/gpu/drm/i915/display/intel_ddi.c +34 -0
index 170ba01786cf8..86358ec27e685 100644
@@ -4360,6 +4360,7 @@ static void intel_ddi_encoder_destroy(struct drm_encoder *encoder)
 	struct drm_i915_private *i915 = to_i915(encoder->dev);
 	struct intel_digital_port *dig_port = enc_to_dig_port(to_intel_encoder(encoder));
 
+	intel_ddi_flush_link_check_work(dig_port);
 	intel_dp_encoder_flush_work(encoder);
 	if (intel_encoder_is_tc(&dig_port->base))
 		intel_tc_port_cleanup(dig_port);
@@ -4441,6 +4442,37 @@ intel_ddi_init_dp_connector(struct intel_digital_port *dig_port)
 	return connector;
 }
 
+static void intel_ddi_link_check_work_fn(struct work_struct *work)
+{
+	struct intel_digital_port *dig_port =
+		container_of(work, typeof(*dig_port), check_link_work.work);
+	struct intel_encoder *encoder = &dig_port->base;
+	struct drm_modeset_acquire_ctx ctx;
+	int ret;
+
+	intel_modeset_lock_ctx_retry(&ctx, NULL, 0, ret)
+		if (dig_port->dp.attached_connector)
+			ret = intel_dp_retrain_link(encoder, &ctx);
+}
+
+void intel_ddi_init_link_check_work(struct intel_digital_port *dig_port)
+{
+	INIT_DELAYED_WORK(&dig_port->check_link_work, intel_ddi_link_check_work_fn);
+}
+
+void intel_ddi_flush_link_check_work(struct intel_digital_port *dig_port)
+{
+	cancel_delayed_work_sync(&dig_port->check_link_work);
+}
+
+void intel_ddi_queue_link_check(struct intel_digital_port *dig_port, int delay_ms)
+{
+	struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
+
+	mod_delayed_work(i915->unordered_wq,
+			 &dig_port->check_link_work, msecs_to_jiffies(delay_ms));
+}
+
 static int intel_hdmi_reset_link(struct intel_encoder *encoder,
 				 struct drm_modeset_acquire_ctx *ctx)
 {
@@ -4911,6 +4943,8 @@ void intel_ddi_init(struct drm_i915_private *dev_priv,
 
 	dig_port->aux_ch = AUX_CH_NONE;
 
+	intel_ddi_init_link_check_work(dig_port);
+
 	encoder = &dig_port->base;
 	encoder->devdata = devdata;
 
drivers/gpu/drm/i915/display/intel_ddi.h +4 -0
index 434de7196875a..b67714483f3cc 100644
@@ -15,6 +15,7 @@ struct intel_bios_encoder_data;
 struct intel_connector;
 struct intel_crtc;
 struct intel_crtc_state;
+struct intel_digital_port;
 struct intel_dp;
 struct intel_dpll_hw_state;
 struct intel_encoder;
@@ -53,6 +54,9 @@ void hsw_prepare_dp_ddi_buffers(struct intel_encoder *encoder,
 				const struct intel_crtc_state *crtc_state);
 void intel_wait_ddi_buf_idle(struct drm_i915_private *dev_priv,
 			     enum port port);
+void intel_ddi_init_link_check_work(struct intel_digital_port *dig_port);
+void intel_ddi_flush_link_check_work(struct intel_digital_port *dig_port);
+void intel_ddi_queue_link_check(struct intel_digital_port *dig_port, int delay_ms);
 void intel_ddi_init(struct drm_i915_private *dev_priv,
 		    const struct intel_bios_encoder_data *devdata);
 bool intel_ddi_get_hw_state(struct intel_encoder *encoder, enum pipe *pipe);
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
index 1e44a23ca2125..9317c1ae04efe 100644
@@ -1880,6 +1880,9 @@ struct intel_digital_port {
 
 	struct intel_tc_port *tc;
 
+	/* Check and recover a bad link status on DP and HDMI ports. */
+	struct delayed_work check_link_work;
+
 	/* protects num_hdcp_streams reference count, hdcp_port_data and hdcp_auth_status */
 	struct mutex hdcp_mutex;
 	/* the number of pipes using HDCP signalling out of this port */
drivers/gpu/drm/i915/display/intel_dp.c +1 -0
index 120f7b420807b..8da277f0c2735 100644
@@ -75,6 +75,7 @@
 #include "intel_hotplug_irq.h"
 #include "intel_lspcon.h"
 #include "intel_lvds.h"
+#include "intel_modeset_lock.h"
 #include "intel_panel.h"
 #include "intel_pch_display.h"
 #include "intel_pps.h"
drivers/gpu/drm/i915/display/intel_dp_link_training.c +9 -3
index edc970036866a..ad1fbb150ff90 100644
@@ -25,6 +25,7 @@
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_link_training.h"
+#include "intel_ddi.h"
 #include "intel_panel.h"
 
 #define LT_MSG_PREFIX			"[CONNECTOR:%d:%s][ENCODER:%d:%s][%s] "
@@ -1464,6 +1465,7 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 			       const struct intel_crtc_state *crtc_state)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
+	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
 	bool passed;
 
 	/*
@@ -1483,6 +1485,11 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 	else
 		passed = intel_dp_link_train_all_phys(intel_dp, crtc_state, lttpr_count);
 
+	if (passed) {
+		intel_ddi_queue_link_check(dig_port, 2000);
+		return;
+	}
+
 	/*
 	 * Ignore the link failure in CI
 	 *
@@ -1495,13 +1502,12 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 	 * For test cases which rely on the link training or processing of HPDs
 	 * ignore_long_hpd flag can unset from the testcase.
 	 */
-	if (!passed && i915->display.hotplug.ignore_long_hpd) {
+	if (i915->display.hotplug.ignore_long_hpd) {
 		lt_dbg(intel_dp, DP_PHY_DPRX, "Ignore the link failure\n");
 		return;
 	}
 
-	if (!passed)
-		intel_dp_schedule_fallback_link_training(intel_dp, crtc_state);
+	intel_dp_schedule_fallback_link_training(intel_dp, crtc_state);
 }
 
 void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp,
Signature · 1 line
2.43.3
author
#17 lore raw

Re: [PATCH v2 07/21] drm/i915/dp: Recheck link state after modeset

drivers/gpu/drm/i915/display/intel_ddi.c intel_ddi_init_dp_connector(struct intel_digital_port *dig_port) · line 4455

Quoted 12 lines · Imre Deak

[...]

drivers/gpu/drm/i915/display/intel_ddi.c +11 -0
+static void intel_ddi_link_check_work_fn(struct work_struct *work)
+{
+	struct intel_digital_port *dig_port =
+		container_of(work, typeof(*dig_port), check_link_work.work);
+	struct intel_encoder *encoder = &dig_port->base;
+	struct drm_modeset_acquire_ctx ctx;
+	int ret;
+
+	intel_modeset_lock_ctx_retry(&ctx, NULL, 0, ret)
+		if (dig_port->dp.attached_connector)
+			ret = intel_dp_retrain_link(encoder, &ctx);

ret should not be let here uninited making the loop spin forever. This can't actually happen since the work won't get schedule w/o dp.attached_connector, but the above check should be also just an assert at this point (at least until handling HDMI is also added).

Quoted 32 lines
drivers/gpu/drm/i915/display/intel_ddi.c +22 -0
+}
+
+void intel_ddi_init_link_check_work(struct intel_digital_port *dig_port)
+{
+	INIT_DELAYED_WORK(&dig_port->check_link_work, intel_ddi_link_check_work_fn);
+}
+
+void intel_ddi_flush_link_check_work(struct intel_digital_port *dig_port)
+{
+	cancel_delayed_work_sync(&dig_port->check_link_work);
+}
+
+void intel_ddi_queue_link_check(struct intel_digital_port *dig_port, int delay_ms)
+{
+	struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
+
+	mod_delayed_work(i915->unordered_wq,
+			 &dig_port->check_link_work, msecs_to_jiffies(delay_ms));
+}
+
 static int intel_hdmi_reset_link(struct intel_encoder *encoder,
 				 struct drm_modeset_acquire_ctx *ctx)
 {
@@ -4911,6 +4943,8 @@ void intel_ddi_init(struct drm_i915_private *dev_priv,
 
 	dig_port->aux_ch = AUX_CH_NONE;
 
+	intel_ddi_init_link_check_work(dig_port);
+
 	encoder = &dig_port->base;
 	encoder->devdata = devdata;
 
#18 lore raw

Re: [PATCH v2 07/21] drm/i915/dp: Recheck link state after modeset

Quoted 10 lines · Imre Deak
Quoted 9 lines · Imre Deak

[...]

drivers/gpu/drm/i915/display/intel_ddi.c +8 -0
+static void intel_ddi_link_check_work_fn(struct work_struct *work)
+{
+	struct intel_digital_port *dig_port =
+		container_of(work, typeof(*dig_port), check_link_work.work);
+	struct intel_encoder *encoder = &dig_port->base;
+	struct drm_modeset_acquire_ctx ctx;
+	int ret;
+
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_ddi.c intel_ddi_init_dp_connector(struct intel_digital_port *dig_port) · line 4455

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_ddi.c +3 -0
+	intel_modeset_lock_ctx_retry(&ctx, NULL, 0, ret)
+		if (dig_port->dp.attached_connector)
+			ret = intel_dp_retrain_link(encoder, &ctx);

ret should not be let here uninited making the loop spin forever. This can't actually happen since the work won't get schedule w/o dp.attached_connector, but the above check should be also just an assert at this point (at least until handling HDMI is also added).

Hmm. Why are we actually initializing ret=-EDEADLK in _intel_modeset_lock_begin()?

Quoted 33 lines
Quoted 33 lines
drivers/gpu/drm/i915/display/intel_ddi.c +22 -0
+}
+
+void intel_ddi_init_link_check_work(struct intel_digital_port *dig_port)
+{
+	INIT_DELAYED_WORK(&dig_port->check_link_work, intel_ddi_link_check_work_fn);
+}
+
+void intel_ddi_flush_link_check_work(struct intel_digital_port *dig_port)
+{
+	cancel_delayed_work_sync(&dig_port->check_link_work);
+}
+
+void intel_ddi_queue_link_check(struct intel_digital_port *dig_port, int delay_ms)
+{
+	struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
+
+	mod_delayed_work(i915->unordered_wq,
+			 &dig_port->check_link_work, msecs_to_jiffies(delay_ms));
+}
+
 static int intel_hdmi_reset_link(struct intel_encoder *encoder,
 				 struct drm_modeset_acquire_ctx *ctx)
 {
@@ -4911,6 +4943,8 @@ void intel_ddi_init(struct drm_i915_private *dev_priv,
 
 	dig_port->aux_ch = AUX_CH_NONE;
 
+	intel_ddi_init_link_check_work(dig_port);
+
 	encoder = &dig_port->base;
 	encoder->devdata = devdata;
 
Signature · 2 lines
Ville Syrjälä
Intel
#19 lore raw

Re: [PATCH v2 07/21] drm/i915/dp: Recheck link state after modeset

Quoted 20 lines · Ville Syrjälä
Quoted 10 lines · Imre Deak
Quoted 9 lines · Imre Deak

[...]

drivers/gpu/drm/i915/display/intel_ddi.c +8 -0
+static void intel_ddi_link_check_work_fn(struct work_struct *work)
+{
+	struct intel_digital_port *dig_port =
+		container_of(work, typeof(*dig_port), check_link_work.work);
+	struct intel_encoder *encoder = &dig_port->base;
+	struct drm_modeset_acquire_ctx ctx;
+	int ret;
+
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_ddi.c intel_ddi_init_dp_connector(struct intel_digital_port *dig_port) · line 4455

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_ddi.c +3 -0
+	intel_modeset_lock_ctx_retry(&ctx, NULL, 0, ret)
+		if (dig_port->dp.attached_connector)
+			ret = intel_dp_retrain_link(encoder, &ctx);

ret should not be let here uninited making the loop spin forever. This can't actually happen since the work won't get schedule w/o dp.attached_connector, but the above check should be also just an assert at this point (at least until handling HDMI is also added).

Quoted 2 lines

Hmm. Why are we actually initializing ret=-EDEADLK in _intel_modeset_lock_begin()?

answer: so that _drm_modeset_lock_loop() actually works

Quoted 38 lines
Quoted 34 lines
Quoted 34 lines
drivers/gpu/drm/i915/display/intel_ddi.c +22 -0
+}
+
+void intel_ddi_init_link_check_work(struct intel_digital_port *dig_port)
+{
+	INIT_DELAYED_WORK(&dig_port->check_link_work, intel_ddi_link_check_work_fn);
+}
+
+void intel_ddi_flush_link_check_work(struct intel_digital_port *dig_port)
+{
+	cancel_delayed_work_sync(&dig_port->check_link_work);
+}
+
+void intel_ddi_queue_link_check(struct intel_digital_port *dig_port, int delay_ms)
+{
+	struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
+
+	mod_delayed_work(i915->unordered_wq,
+			 &dig_port->check_link_work, msecs_to_jiffies(delay_ms));
+}
+
 static int intel_hdmi_reset_link(struct intel_encoder *encoder,
 				 struct drm_modeset_acquire_ctx *ctx)
 {
@@ -4911,6 +4943,8 @@ void intel_ddi_init(struct drm_i915_private *dev_priv,
 
 	dig_port->aux_ch = AUX_CH_NONE;
 
+	intel_ddi_init_link_check_work(dig_port);
+
 	encoder = &dig_port->base;
 	encoder->devdata = devdata;
 
Signature · 2 lines
Ville Syrjälä
Intel
Signature · 2 lines
Ville Syrjälä
Intel
#20 lore raw

Re: [PATCH v2 07/21] drm/i915/dp: Recheck link state after modeset

In reply to Imre Deak
Quoted 45 lines · Imre Deak

Recheck the link state after a passing link training, with a 2 sec delay to account for cases where the link goes bad following the link training and the sink doesn't report this via an HPD IRQ.

The delayed work added here will be also used by a later patch after a failed link training to try to retrain the link with unchanged link params before reducing the link params.

v2: Don't flush an uninitialized delayed work (on HDMI-only DDI ports).
v3: Add the work to intel_digital_port instead of intel_dp.

---
 drivers/gpu/drm/i915/display/g4x_dp.c         |  7 ++++
 drivers/gpu/drm/i915/display/intel_ddi.c      | 34 +++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_ddi.h      |  4 +++
 .../drm/i915/display/intel_display_types.h    |  3 ++
 drivers/gpu/drm/i915/display/intel_dp.c       |  1 +
 .../drm/i915/display/intel_dp_link_training.c | 12 +++++--
 6 files changed, 58 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/g4x_dp.c +5 -0
index 06ec04e667e32..4363e32a834df 100644
@@ -20,6 +20,7 @@
 #include "intel_dp_aux.h"
 #include "intel_dp_link_training.h"
 #include "intel_dpio_phy.h"
+#include "intel_ddi.h"
 #include "intel_fifo_underrun.h"
 #include "intel_hdmi.h"
 #include "intel_hotplug.h"
@@ -1241,6 +1242,10 @@ static bool ilk_digital_port_connected(struct intel_encoder *encoder)
 
 static void intel_dp_encoder_destroy(struct drm_encoder *encoder)
 {
+	struct intel_digital_port *dig_port = enc_to_dig_port(to_intel_encoder(encoder));
+
+	intel_ddi_flush_link_check_work(dig_port);
+
 	intel_dp_encoder_flush_work(encoder);
 
 	drm_encoder_cleanup(encoder);

drivers/gpu/drm/i915/display/g4x_dp.c bool g4x_dp_init(struct drm_i915_private *dev_priv, · line 1317

Quoted 4 lines
drivers/gpu/drm/i915/display/g4x_dp.c +1 -0
@@ -1309,6 +1314,8 @@ bool g4x_dp_init(struct drm_i915_private *dev_priv,
 
 	dig_port->aux_ch = AUX_CH_NONE;
 
+	intel_ddi_init_link_check_work(dig_port);

Using "ddi" for pre-ddi platforms is confusing. The implementation is also in intel_ddi.c for some reason.

Quoted 161 lines
drivers/gpu/drm/i915/display/g4x_dp.c +1 -0
+
 	intel_connector = intel_connector_alloc();
 	if (!intel_connector)
 		goto err_connector_alloc;
drivers/gpu/drm/i915/display/intel_ddi.c +34 -0
index 170ba01786cf8..86358ec27e685 100644
@@ -4360,6 +4360,7 @@ static void intel_ddi_encoder_destroy(struct drm_encoder *encoder)
 	struct drm_i915_private *i915 = to_i915(encoder->dev);
 	struct intel_digital_port *dig_port = enc_to_dig_port(to_intel_encoder(encoder));
 
+	intel_ddi_flush_link_check_work(dig_port);
 	intel_dp_encoder_flush_work(encoder);
 	if (intel_encoder_is_tc(&dig_port->base))
 		intel_tc_port_cleanup(dig_port);
@@ -4441,6 +4442,37 @@ intel_ddi_init_dp_connector(struct intel_digital_port *dig_port)
 	return connector;
 }
 
+static void intel_ddi_link_check_work_fn(struct work_struct *work)
+{
+	struct intel_digital_port *dig_port =
+		container_of(work, typeof(*dig_port), check_link_work.work);
+	struct intel_encoder *encoder = &dig_port->base;
+	struct drm_modeset_acquire_ctx ctx;
+	int ret;
+
+	intel_modeset_lock_ctx_retry(&ctx, NULL, 0, ret)
+		if (dig_port->dp.attached_connector)
+			ret = intel_dp_retrain_link(encoder, &ctx);
+}
+
+void intel_ddi_init_link_check_work(struct intel_digital_port *dig_port)
+{
+	INIT_DELAYED_WORK(&dig_port->check_link_work, intel_ddi_link_check_work_fn);
+}
+
+void intel_ddi_flush_link_check_work(struct intel_digital_port *dig_port)
+{
+	cancel_delayed_work_sync(&dig_port->check_link_work);
+}
+
+void intel_ddi_queue_link_check(struct intel_digital_port *dig_port, int delay_ms)
+{
+	struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
+
+	mod_delayed_work(i915->unordered_wq,
+			 &dig_port->check_link_work, msecs_to_jiffies(delay_ms));
+}
+
 static int intel_hdmi_reset_link(struct intel_encoder *encoder,
 				 struct drm_modeset_acquire_ctx *ctx)
 {
@@ -4911,6 +4943,8 @@ void intel_ddi_init(struct drm_i915_private *dev_priv,
 
 	dig_port->aux_ch = AUX_CH_NONE;
 
+	intel_ddi_init_link_check_work(dig_port);
+
 	encoder = &dig_port->base;
 	encoder->devdata = devdata;
 
drivers/gpu/drm/i915/display/intel_ddi.h +4 -0
index 434de7196875a..b67714483f3cc 100644
@@ -15,6 +15,7 @@ struct intel_bios_encoder_data;
 struct intel_connector;
 struct intel_crtc;
 struct intel_crtc_state;
+struct intel_digital_port;
 struct intel_dp;
 struct intel_dpll_hw_state;
 struct intel_encoder;
@@ -53,6 +54,9 @@ void hsw_prepare_dp_ddi_buffers(struct intel_encoder *encoder,
 				const struct intel_crtc_state *crtc_state);
 void intel_wait_ddi_buf_idle(struct drm_i915_private *dev_priv,
 			     enum port port);
+void intel_ddi_init_link_check_work(struct intel_digital_port *dig_port);
+void intel_ddi_flush_link_check_work(struct intel_digital_port *dig_port);
+void intel_ddi_queue_link_check(struct intel_digital_port *dig_port, int delay_ms);
 void intel_ddi_init(struct drm_i915_private *dev_priv,
 		    const struct intel_bios_encoder_data *devdata);
 bool intel_ddi_get_hw_state(struct intel_encoder *encoder, enum pipe *pipe);
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
index 1e44a23ca2125..9317c1ae04efe 100644
@@ -1880,6 +1880,9 @@ struct intel_digital_port {
 
 	struct intel_tc_port *tc;
 
+	/* Check and recover a bad link status on DP and HDMI ports. */
+	struct delayed_work check_link_work;
+
 	/* protects num_hdcp_streams reference count, hdcp_port_data and hdcp_auth_status */
 	struct mutex hdcp_mutex;
 	/* the number of pipes using HDCP signalling out of this port */
drivers/gpu/drm/i915/display/intel_dp.c +1 -0
index 120f7b420807b..8da277f0c2735 100644
@@ -75,6 +75,7 @@
 #include "intel_hotplug_irq.h"
 #include "intel_lspcon.h"
 #include "intel_lvds.h"
+#include "intel_modeset_lock.h"
 #include "intel_panel.h"
 #include "intel_pch_display.h"
 #include "intel_pps.h"
drivers/gpu/drm/i915/display/intel_dp_link_training.c +9 -3
index edc970036866a..ad1fbb150ff90 100644
@@ -25,6 +25,7 @@
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_link_training.h"
+#include "intel_ddi.h"
 #include "intel_panel.h"
 
 #define LT_MSG_PREFIX			"[CONNECTOR:%d:%s][ENCODER:%d:%s][%s] "
@@ -1464,6 +1465,7 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 			       const struct intel_crtc_state *crtc_state)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
+	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
 	bool passed;
 
 	/*
@@ -1483,6 +1485,11 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 	else
 		passed = intel_dp_link_train_all_phys(intel_dp, crtc_state, lttpr_count);
 
+	if (passed) {
+		intel_ddi_queue_link_check(dig_port, 2000);
+		return;
+	}
+
 	/*
 	 * Ignore the link failure in CI
 	 *
@@ -1495,13 +1502,12 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 	 * For test cases which rely on the link training or processing of HPDs
 	 * ignore_long_hpd flag can unset from the testcase.
 	 */
-	if (!passed && i915->display.hotplug.ignore_long_hpd) {
+	if (i915->display.hotplug.ignore_long_hpd) {
 		lt_dbg(intel_dp, DP_PHY_DPRX, "Ignore the link failure\n");
 		return;
 	}
 
-	if (!passed)
-		intel_dp_schedule_fallback_link_training(intel_dp, crtc_state);
+	intel_dp_schedule_fallback_link_training(intel_dp, crtc_state);
 }
 
 void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp,
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
author
#21 lore raw

Re: [PATCH v2 07/21] drm/i915/dp: Recheck link state after modeset

Quoted 47 lines · Ville Syrjälä
Quoted 46 lines · Imre Deak

Recheck the link state after a passing link training, with a 2 sec delay to account for cases where the link goes bad following the link training and the sink doesn't report this via an HPD IRQ.

The delayed work added here will be also used by a later patch after a failed link training to try to retrain the link with unchanged link params before reducing the link params.

v2: Don't flush an uninitialized delayed work (on HDMI-only DDI ports).
v3: Add the work to intel_digital_port instead of intel_dp.

---
 drivers/gpu/drm/i915/display/g4x_dp.c         |  7 ++++
 drivers/gpu/drm/i915/display/intel_ddi.c      | 34 +++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_ddi.h      |  4 +++
 .../drm/i915/display/intel_display_types.h    |  3 ++
 drivers/gpu/drm/i915/display/intel_dp.c       |  1 +
 .../drm/i915/display/intel_dp_link_training.c | 12 +++++--
 6 files changed, 58 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/g4x_dp.c +5 -0
index 06ec04e667e32..4363e32a834df 100644
@@ -20,6 +20,7 @@
 #include "intel_dp_aux.h"
 #include "intel_dp_link_training.h"
 #include "intel_dpio_phy.h"
+#include "intel_ddi.h"
 #include "intel_fifo_underrun.h"
 #include "intel_hdmi.h"
 #include "intel_hotplug.h"
@@ -1241,6 +1242,10 @@ static bool ilk_digital_port_connected(struct intel_encoder *encoder)
 
 static void intel_dp_encoder_destroy(struct drm_encoder *encoder)
 {
+	struct intel_digital_port *dig_port = enc_to_dig_port(to_intel_encoder(encoder));
+
+	intel_ddi_flush_link_check_work(dig_port);
+
 	intel_dp_encoder_flush_work(encoder);
 
 	drm_encoder_cleanup(encoder);
@@ -1309,6 +1314,8 @@ bool g4x_dp_init(struct drm_i915_private *dev_priv,
 
Quoted 6 lines

drivers/gpu/drm/i915/display/g4x_dp.c bool g4x_dp_init(struct drm_i915_private *dev_priv, · line 1317

Quoted 3 lines
drivers/gpu/drm/i915/display/g4x_dp.c +1 -0
 	dig_port->aux_ch = AUX_CH_NONE;
 
+	intel_ddi_init_link_check_work(dig_port);

Using "ddi" for pre-ddi platforms is confusing. The implementation is also in intel_ddi.c for some reason.

Yes. It's a generic encoder or digital port functionality, neither of which have its own file. How about moving them to intel_display.c and the intel_display_link_{init_work, queue_work, flush_work, work_fn} names?

Quoted 165 lines
Quoted 161 lines
drivers/gpu/drm/i915/display/g4x_dp.c +1 -0
+
 	intel_connector = intel_connector_alloc();
 	if (!intel_connector)
 		goto err_connector_alloc;
drivers/gpu/drm/i915/display/intel_ddi.c +34 -0
index 170ba01786cf8..86358ec27e685 100644
@@ -4360,6 +4360,7 @@ static void intel_ddi_encoder_destroy(struct drm_encoder *encoder)
 	struct drm_i915_private *i915 = to_i915(encoder->dev);
 	struct intel_digital_port *dig_port = enc_to_dig_port(to_intel_encoder(encoder));
 
+	intel_ddi_flush_link_check_work(dig_port);
 	intel_dp_encoder_flush_work(encoder);
 	if (intel_encoder_is_tc(&dig_port->base))
 		intel_tc_port_cleanup(dig_port);
@@ -4441,6 +4442,37 @@ intel_ddi_init_dp_connector(struct intel_digital_port *dig_port)
 	return connector;
 }
 
+static void intel_ddi_link_check_work_fn(struct work_struct *work)
+{
+	struct intel_digital_port *dig_port =
+		container_of(work, typeof(*dig_port), check_link_work.work);
+	struct intel_encoder *encoder = &dig_port->base;
+	struct drm_modeset_acquire_ctx ctx;
+	int ret;
+
+	intel_modeset_lock_ctx_retry(&ctx, NULL, 0, ret)
+		if (dig_port->dp.attached_connector)
+			ret = intel_dp_retrain_link(encoder, &ctx);
+}
+
+void intel_ddi_init_link_check_work(struct intel_digital_port *dig_port)
+{
+	INIT_DELAYED_WORK(&dig_port->check_link_work, intel_ddi_link_check_work_fn);
+}
+
+void intel_ddi_flush_link_check_work(struct intel_digital_port *dig_port)
+{
+	cancel_delayed_work_sync(&dig_port->check_link_work);
+}
+
+void intel_ddi_queue_link_check(struct intel_digital_port *dig_port, int delay_ms)
+{
+	struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
+
+	mod_delayed_work(i915->unordered_wq,
+			 &dig_port->check_link_work, msecs_to_jiffies(delay_ms));
+}
+
 static int intel_hdmi_reset_link(struct intel_encoder *encoder,
 				 struct drm_modeset_acquire_ctx *ctx)
 {
@@ -4911,6 +4943,8 @@ void intel_ddi_init(struct drm_i915_private *dev_priv,
 
 	dig_port->aux_ch = AUX_CH_NONE;
 
+	intel_ddi_init_link_check_work(dig_port);
+
 	encoder = &dig_port->base;
 	encoder->devdata = devdata;
 
drivers/gpu/drm/i915/display/intel_ddi.h +4 -0
index 434de7196875a..b67714483f3cc 100644
@@ -15,6 +15,7 @@ struct intel_bios_encoder_data;
 struct intel_connector;
 struct intel_crtc;
 struct intel_crtc_state;
+struct intel_digital_port;
 struct intel_dp;
 struct intel_dpll_hw_state;
 struct intel_encoder;
@@ -53,6 +54,9 @@ void hsw_prepare_dp_ddi_buffers(struct intel_encoder *encoder,
 				const struct intel_crtc_state *crtc_state);
 void intel_wait_ddi_buf_idle(struct drm_i915_private *dev_priv,
 			     enum port port);
+void intel_ddi_init_link_check_work(struct intel_digital_port *dig_port);
+void intel_ddi_flush_link_check_work(struct intel_digital_port *dig_port);
+void intel_ddi_queue_link_check(struct intel_digital_port *dig_port, int delay_ms);
 void intel_ddi_init(struct drm_i915_private *dev_priv,
 		    const struct intel_bios_encoder_data *devdata);
 bool intel_ddi_get_hw_state(struct intel_encoder *encoder, enum pipe *pipe);
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
index 1e44a23ca2125..9317c1ae04efe 100644
@@ -1880,6 +1880,9 @@ struct intel_digital_port {
 
 	struct intel_tc_port *tc;
 
+	/* Check and recover a bad link status on DP and HDMI ports. */
+	struct delayed_work check_link_work;
+
 	/* protects num_hdcp_streams reference count, hdcp_port_data and hdcp_auth_status */
 	struct mutex hdcp_mutex;
 	/* the number of pipes using HDCP signalling out of this port */
drivers/gpu/drm/i915/display/intel_dp.c +1 -0
index 120f7b420807b..8da277f0c2735 100644
@@ -75,6 +75,7 @@
 #include "intel_hotplug_irq.h"
 #include "intel_lspcon.h"
 #include "intel_lvds.h"
+#include "intel_modeset_lock.h"
 #include "intel_panel.h"
 #include "intel_pch_display.h"
 #include "intel_pps.h"
drivers/gpu/drm/i915/display/intel_dp_link_training.c +9 -3
index edc970036866a..ad1fbb150ff90 100644
@@ -25,6 +25,7 @@
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_link_training.h"
+#include "intel_ddi.h"
 #include "intel_panel.h"
 
 #define LT_MSG_PREFIX			"[CONNECTOR:%d:%s][ENCODER:%d:%s][%s] "
@@ -1464,6 +1465,7 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 			       const struct intel_crtc_state *crtc_state)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
+	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
 	bool passed;
 
 	/*
@@ -1483,6 +1485,11 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 	else
 		passed = intel_dp_link_train_all_phys(intel_dp, crtc_state, lttpr_count);
 
+	if (passed) {
+		intel_ddi_queue_link_check(dig_port, 2000);
+		return;
+	}
+
 	/*
 	 * Ignore the link failure in CI
 	 *
@@ -1495,13 +1502,12 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 	 * For test cases which rely on the link training or processing of HPDs
 	 * ignore_long_hpd flag can unset from the testcase.
 	 */
-	if (!passed && i915->display.hotplug.ignore_long_hpd) {
+	if (i915->display.hotplug.ignore_long_hpd) {
 		lt_dbg(intel_dp, DP_PHY_DPRX, "Ignore the link failure\n");
 		return;
 	}
 
-	if (!passed)
-		intel_dp_schedule_fallback_link_training(intel_dp, crtc_state);
+	intel_dp_schedule_fallback_link_training(intel_dp, crtc_state);
 }
 
 void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp,
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
#22 lore raw

Re: [PATCH v2 07/21] drm/i915/dp: Recheck link state after modeset

Quoted 55 lines · Imre Deak
Quoted 47 lines · Ville Syrjälä
Quoted 46 lines · Imre Deak

Recheck the link state after a passing link training, with a 2 sec delay to account for cases where the link goes bad following the link training and the sink doesn't report this via an HPD IRQ.

The delayed work added here will be also used by a later patch after a failed link training to try to retrain the link with unchanged link params before reducing the link params.

v2: Don't flush an uninitialized delayed work (on HDMI-only DDI ports).
v3: Add the work to intel_digital_port instead of intel_dp.

---
 drivers/gpu/drm/i915/display/g4x_dp.c         |  7 ++++
 drivers/gpu/drm/i915/display/intel_ddi.c      | 34 +++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_ddi.h      |  4 +++
 .../drm/i915/display/intel_display_types.h    |  3 ++
 drivers/gpu/drm/i915/display/intel_dp.c       |  1 +
 .../drm/i915/display/intel_dp_link_training.c | 12 +++++--
 6 files changed, 58 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/g4x_dp.c +5 -0
index 06ec04e667e32..4363e32a834df 100644
@@ -20,6 +20,7 @@
 #include "intel_dp_aux.h"
 #include "intel_dp_link_training.h"
 #include "intel_dpio_phy.h"
+#include "intel_ddi.h"
 #include "intel_fifo_underrun.h"
 #include "intel_hdmi.h"
 #include "intel_hotplug.h"
@@ -1241,6 +1242,10 @@ static bool ilk_digital_port_connected(struct intel_encoder *encoder)
 
 static void intel_dp_encoder_destroy(struct drm_encoder *encoder)
 {
+	struct intel_digital_port *dig_port = enc_to_dig_port(to_intel_encoder(encoder));
+
+	intel_ddi_flush_link_check_work(dig_port);
+
 	intel_dp_encoder_flush_work(encoder);
 
 	drm_encoder_cleanup(encoder);
@@ -1309,6 +1314,8 @@ bool g4x_dp_init(struct drm_i915_private *dev_priv,
 
Quoted 6 lines

drivers/gpu/drm/i915/display/g4x_dp.c bool g4x_dp_init(struct drm_i915_private *dev_priv, · line 1317

Quoted 3 lines
drivers/gpu/drm/i915/display/g4x_dp.c +1 -0
 	dig_port->aux_ch = AUX_CH_NONE;
 
+	intel_ddi_init_link_check_work(dig_port);

Using "ddi" for pre-ddi platforms is confusing. The implementation is also in intel_ddi.c for some reason.

Quoted 4 lines

Yes. It's a generic encoder or digital port functionality, neither of which have its own file. How about moving them to intel_display.c and the intel_display_link_{init_work, queue_work, flush_work, work_fn} names?

We could add some new file for this kind of generic encoder stuff. intel_encoder.c or intel_dig_port.c maybe?

Quoted 166 lines
Quoted 166 lines
Quoted 162 lines
drivers/gpu/drm/i915/display/g4x_dp.c +1 -0
+
 	intel_connector = intel_connector_alloc();
 	if (!intel_connector)
 		goto err_connector_alloc;
drivers/gpu/drm/i915/display/intel_ddi.c +34 -0
index 170ba01786cf8..86358ec27e685 100644
@@ -4360,6 +4360,7 @@ static void intel_ddi_encoder_destroy(struct drm_encoder *encoder)
 	struct drm_i915_private *i915 = to_i915(encoder->dev);
 	struct intel_digital_port *dig_port = enc_to_dig_port(to_intel_encoder(encoder));
 
+	intel_ddi_flush_link_check_work(dig_port);
 	intel_dp_encoder_flush_work(encoder);
 	if (intel_encoder_is_tc(&dig_port->base))
 		intel_tc_port_cleanup(dig_port);
@@ -4441,6 +4442,37 @@ intel_ddi_init_dp_connector(struct intel_digital_port *dig_port)
 	return connector;
 }
 
+static void intel_ddi_link_check_work_fn(struct work_struct *work)
+{
+	struct intel_digital_port *dig_port =
+		container_of(work, typeof(*dig_port), check_link_work.work);
+	struct intel_encoder *encoder = &dig_port->base;
+	struct drm_modeset_acquire_ctx ctx;
+	int ret;
+
+	intel_modeset_lock_ctx_retry(&ctx, NULL, 0, ret)
+		if (dig_port->dp.attached_connector)
+			ret = intel_dp_retrain_link(encoder, &ctx);
+}
+
+void intel_ddi_init_link_check_work(struct intel_digital_port *dig_port)
+{
+	INIT_DELAYED_WORK(&dig_port->check_link_work, intel_ddi_link_check_work_fn);
+}
+
+void intel_ddi_flush_link_check_work(struct intel_digital_port *dig_port)
+{
+	cancel_delayed_work_sync(&dig_port->check_link_work);
+}
+
+void intel_ddi_queue_link_check(struct intel_digital_port *dig_port, int delay_ms)
+{
+	struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
+
+	mod_delayed_work(i915->unordered_wq,
+			 &dig_port->check_link_work, msecs_to_jiffies(delay_ms));
+}
+
 static int intel_hdmi_reset_link(struct intel_encoder *encoder,
 				 struct drm_modeset_acquire_ctx *ctx)
 {
@@ -4911,6 +4943,8 @@ void intel_ddi_init(struct drm_i915_private *dev_priv,
 
 	dig_port->aux_ch = AUX_CH_NONE;
 
+	intel_ddi_init_link_check_work(dig_port);
+
 	encoder = &dig_port->base;
 	encoder->devdata = devdata;
 
drivers/gpu/drm/i915/display/intel_ddi.h +4 -0
index 434de7196875a..b67714483f3cc 100644
@@ -15,6 +15,7 @@ struct intel_bios_encoder_data;
 struct intel_connector;
 struct intel_crtc;
 struct intel_crtc_state;
+struct intel_digital_port;
 struct intel_dp;
 struct intel_dpll_hw_state;
 struct intel_encoder;
@@ -53,6 +54,9 @@ void hsw_prepare_dp_ddi_buffers(struct intel_encoder *encoder,
 				const struct intel_crtc_state *crtc_state);
 void intel_wait_ddi_buf_idle(struct drm_i915_private *dev_priv,
 			     enum port port);
+void intel_ddi_init_link_check_work(struct intel_digital_port *dig_port);
+void intel_ddi_flush_link_check_work(struct intel_digital_port *dig_port);
+void intel_ddi_queue_link_check(struct intel_digital_port *dig_port, int delay_ms);
 void intel_ddi_init(struct drm_i915_private *dev_priv,
 		    const struct intel_bios_encoder_data *devdata);
 bool intel_ddi_get_hw_state(struct intel_encoder *encoder, enum pipe *pipe);
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
index 1e44a23ca2125..9317c1ae04efe 100644
@@ -1880,6 +1880,9 @@ struct intel_digital_port {
 
 	struct intel_tc_port *tc;
 
+	/* Check and recover a bad link status on DP and HDMI ports. */
+	struct delayed_work check_link_work;
+
 	/* protects num_hdcp_streams reference count, hdcp_port_data and hdcp_auth_status */
 	struct mutex hdcp_mutex;
 	/* the number of pipes using HDCP signalling out of this port */
drivers/gpu/drm/i915/display/intel_dp.c +1 -0
index 120f7b420807b..8da277f0c2735 100644
@@ -75,6 +75,7 @@
 #include "intel_hotplug_irq.h"
 #include "intel_lspcon.h"
 #include "intel_lvds.h"
+#include "intel_modeset_lock.h"
 #include "intel_panel.h"
 #include "intel_pch_display.h"
 #include "intel_pps.h"
drivers/gpu/drm/i915/display/intel_dp_link_training.c +9 -3
index edc970036866a..ad1fbb150ff90 100644
@@ -25,6 +25,7 @@
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_link_training.h"
+#include "intel_ddi.h"
 #include "intel_panel.h"
 
 #define LT_MSG_PREFIX			"[CONNECTOR:%d:%s][ENCODER:%d:%s][%s] "
@@ -1464,6 +1465,7 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 			       const struct intel_crtc_state *crtc_state)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
+	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
 	bool passed;
 
 	/*
@@ -1483,6 +1485,11 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 	else
 		passed = intel_dp_link_train_all_phys(intel_dp, crtc_state, lttpr_count);
 
+	if (passed) {
+		intel_ddi_queue_link_check(dig_port, 2000);
+		return;
+	}
+
 	/*
 	 * Ignore the link failure in CI
 	 *
@@ -1495,13 +1502,12 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 	 * For test cases which rely on the link training or processing of HPDs
 	 * ignore_long_hpd flag can unset from the testcase.
 	 */
-	if (!passed && i915->display.hotplug.ignore_long_hpd) {
+	if (i915->display.hotplug.ignore_long_hpd) {
 		lt_dbg(intel_dp, DP_PHY_DPRX, "Ignore the link failure\n");
 		return;
 	}
 
-	if (!passed)
-		intel_dp_schedule_fallback_link_training(intel_dp, crtc_state);
+	intel_dp_schedule_fallback_link_training(intel_dp, crtc_state);
 }
 
 void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp,
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
Signature · 2 lines
Ville Syrjälä
Intel
author
#23 lore raw

Re: [PATCH v2 07/21] drm/i915/dp: Recheck link state after modeset

Quoted 56 lines · Ville Syrjälä
Quoted 55 lines · Imre Deak
Quoted 53 lines · Ville Syrjälä
Quoted 45 lines · Imre Deak

Recheck the link state after a passing link training, with a 2 sec delay to account for cases where the link goes bad following the link training and the sink doesn't report this via an HPD IRQ.

The delayed work added here will be also used by a later patch after a failed link training to try to retrain the link with unchanged link params before reducing the link params.

v2: Don't flush an uninitialized delayed work (on HDMI-only DDI ports).
v3: Add the work to intel_digital_port instead of intel_dp.

---
 drivers/gpu/drm/i915/display/g4x_dp.c         |  7 ++++
 drivers/gpu/drm/i915/display/intel_ddi.c      | 34 +++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_ddi.h      |  4 +++
 .../drm/i915/display/intel_display_types.h    |  3 ++
 drivers/gpu/drm/i915/display/intel_dp.c       |  1 +
 .../drm/i915/display/intel_dp_link_training.c | 12 +++++--
 6 files changed, 58 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/g4x_dp.c +5 -0
index 06ec04e667e32..4363e32a834df 100644
@@ -20,6 +20,7 @@
 #include "intel_dp_aux.h"
 #include "intel_dp_link_training.h"
 #include "intel_dpio_phy.h"
+#include "intel_ddi.h"
 #include "intel_fifo_underrun.h"
 #include "intel_hdmi.h"
 #include "intel_hotplug.h"
@@ -1241,6 +1242,10 @@ static bool ilk_digital_port_connected(struct intel_encoder *encoder)
 
 static void intel_dp_encoder_destroy(struct drm_encoder *encoder)
 {
+	struct intel_digital_port *dig_port = enc_to_dig_port(to_intel_encoder(encoder));
+
+	intel_ddi_flush_link_check_work(dig_port);
+
 	intel_dp_encoder_flush_work(encoder);
 
 	drm_encoder_cleanup(encoder);

drivers/gpu/drm/i915/display/g4x_dp.c bool g4x_dp_init(struct drm_i915_private *dev_priv, · line 1317

Quoted 4 lines
drivers/gpu/drm/i915/display/g4x_dp.c +1 -0
@@ -1309,6 +1314,8 @@ bool g4x_dp_init(struct drm_i915_private *dev_priv,
 
 	dig_port->aux_ch = AUX_CH_NONE;
 
+	intel_ddi_init_link_check_work(dig_port);

Using "ddi" for pre-ddi platforms is confusing. The implementation is also in intel_ddi.c for some reason.

Quoted 7 lines
Quoted 4 lines

Yes. It's a generic encoder or digital port functionality, neither of which have its own file. How about moving them to intel_display.c and the intel_display_link_{init_work, queue_work, flush_work, work_fn} names?

We could add some new file for this kind of generic encoder stuff. intel_encoder.c or intel_dig_port.c maybe?

Ok, there seems to be more encoder functions that could be moved there, so I'll add intel_encoder.c.

Quoted 169 lines
Quoted 165 lines
Quoted 165 lines
Quoted 161 lines
drivers/gpu/drm/i915/display/g4x_dp.c +1 -0
+
 	intel_connector = intel_connector_alloc();
 	if (!intel_connector)
 		goto err_connector_alloc;
drivers/gpu/drm/i915/display/intel_ddi.c +34 -0
index 170ba01786cf8..86358ec27e685 100644
@@ -4360,6 +4360,7 @@ static void intel_ddi_encoder_destroy(struct drm_encoder *encoder)
 	struct drm_i915_private *i915 = to_i915(encoder->dev);
 	struct intel_digital_port *dig_port = enc_to_dig_port(to_intel_encoder(encoder));
 
+	intel_ddi_flush_link_check_work(dig_port);
 	intel_dp_encoder_flush_work(encoder);
 	if (intel_encoder_is_tc(&dig_port->base))
 		intel_tc_port_cleanup(dig_port);
@@ -4441,6 +4442,37 @@ intel_ddi_init_dp_connector(struct intel_digital_port *dig_port)
 	return connector;
 }
 
+static void intel_ddi_link_check_work_fn(struct work_struct *work)
+{
+	struct intel_digital_port *dig_port =
+		container_of(work, typeof(*dig_port), check_link_work.work);
+	struct intel_encoder *encoder = &dig_port->base;
+	struct drm_modeset_acquire_ctx ctx;
+	int ret;
+
+	intel_modeset_lock_ctx_retry(&ctx, NULL, 0, ret)
+		if (dig_port->dp.attached_connector)
+			ret = intel_dp_retrain_link(encoder, &ctx);
+}
+
+void intel_ddi_init_link_check_work(struct intel_digital_port *dig_port)
+{
+	INIT_DELAYED_WORK(&dig_port->check_link_work, intel_ddi_link_check_work_fn);
+}
+
+void intel_ddi_flush_link_check_work(struct intel_digital_port *dig_port)
+{
+	cancel_delayed_work_sync(&dig_port->check_link_work);
+}
+
+void intel_ddi_queue_link_check(struct intel_digital_port *dig_port, int delay_ms)
+{
+	struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
+
+	mod_delayed_work(i915->unordered_wq,
+			 &dig_port->check_link_work, msecs_to_jiffies(delay_ms));
+}
+
 static int intel_hdmi_reset_link(struct intel_encoder *encoder,
 				 struct drm_modeset_acquire_ctx *ctx)
 {
@@ -4911,6 +4943,8 @@ void intel_ddi_init(struct drm_i915_private *dev_priv,
 
 	dig_port->aux_ch = AUX_CH_NONE;
 
+	intel_ddi_init_link_check_work(dig_port);
+
 	encoder = &dig_port->base;
 	encoder->devdata = devdata;
 
drivers/gpu/drm/i915/display/intel_ddi.h +4 -0
index 434de7196875a..b67714483f3cc 100644
@@ -15,6 +15,7 @@ struct intel_bios_encoder_data;
 struct intel_connector;
 struct intel_crtc;
 struct intel_crtc_state;
+struct intel_digital_port;
 struct intel_dp;
 struct intel_dpll_hw_state;
 struct intel_encoder;
@@ -53,6 +54,9 @@ void hsw_prepare_dp_ddi_buffers(struct intel_encoder *encoder,
 				const struct intel_crtc_state *crtc_state);
 void intel_wait_ddi_buf_idle(struct drm_i915_private *dev_priv,
 			     enum port port);
+void intel_ddi_init_link_check_work(struct intel_digital_port *dig_port);
+void intel_ddi_flush_link_check_work(struct intel_digital_port *dig_port);
+void intel_ddi_queue_link_check(struct intel_digital_port *dig_port, int delay_ms);
 void intel_ddi_init(struct drm_i915_private *dev_priv,
 		    const struct intel_bios_encoder_data *devdata);
 bool intel_ddi_get_hw_state(struct intel_encoder *encoder, enum pipe *pipe);
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
index 1e44a23ca2125..9317c1ae04efe 100644
@@ -1880,6 +1880,9 @@ struct intel_digital_port {
 
 	struct intel_tc_port *tc;
 
+	/* Check and recover a bad link status on DP and HDMI ports. */
+	struct delayed_work check_link_work;
+
 	/* protects num_hdcp_streams reference count, hdcp_port_data and hdcp_auth_status */
 	struct mutex hdcp_mutex;
 	/* the number of pipes using HDCP signalling out of this port */
drivers/gpu/drm/i915/display/intel_dp.c +1 -0
index 120f7b420807b..8da277f0c2735 100644
@@ -75,6 +75,7 @@
 #include "intel_hotplug_irq.h"
 #include "intel_lspcon.h"
 #include "intel_lvds.h"
+#include "intel_modeset_lock.h"
 #include "intel_panel.h"
 #include "intel_pch_display.h"
 #include "intel_pps.h"
drivers/gpu/drm/i915/display/intel_dp_link_training.c +9 -3
index edc970036866a..ad1fbb150ff90 100644
@@ -25,6 +25,7 @@
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_link_training.h"
+#include "intel_ddi.h"
 #include "intel_panel.h"
 
 #define LT_MSG_PREFIX			"[CONNECTOR:%d:%s][ENCODER:%d:%s][%s] "
@@ -1464,6 +1465,7 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 			       const struct intel_crtc_state *crtc_state)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
+	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
 	bool passed;
 
 	/*
@@ -1483,6 +1485,11 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 	else
 		passed = intel_dp_link_train_all_phys(intel_dp, crtc_state, lttpr_count);
 
+	if (passed) {
+		intel_ddi_queue_link_check(dig_port, 2000);
+		return;
+	}
+
 	/*
 	 * Ignore the link failure in CI
 	 *
@@ -1495,13 +1502,12 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 	 * For test cases which rely on the link training or processing of HPDs
 	 * ignore_long_hpd flag can unset from the testcase.
 	 */
-	if (!passed && i915->display.hotplug.ignore_long_hpd) {
+	if (i915->display.hotplug.ignore_long_hpd) {
 		lt_dbg(intel_dp, DP_PHY_DPRX, "Ignore the link failure\n");
 		return;
 	}
 
-	if (!passed)
-		intel_dp_schedule_fallback_link_training(intel_dp, crtc_state);
+	intel_dp_schedule_fallback_link_training(intel_dp, crtc_state);
 }
 
 void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp,
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
Signature · 2 lines
Ville Syrjälä
Intel
author
#24 lore raw

PATCH v2 8/21 drm/i915/dp: Reduce link params only after retrying with unchanged params

In reply to Imre Deak

Try to maintain the current link parameters by retrying the link training with unchanged link parameters before reducing these parameters (sending an uevent to userspace to retrain the link instead).

---
 drivers/gpu/drm/i915/display/intel_display_types.h    | 2 ++
 drivers/gpu/drm/i915/display/intel_dp.c               | 4 ++++
 drivers/gpu/drm/i915/display/intel_dp_link_training.c | 8 ++++++++
 3 files changed, 14 insertions(+)
drivers/gpu/drm/i915/display/intel_display_types.h +2 -0
index 9317c1ae04efe..bde518c843468 100644
@@ -1765,6 +1765,8 @@ struct intel_dp {
 		int max_lane_count;
 		/* Max rate for the current link */
 		int max_rate;
+		/* Sequential link training failures after a passing LT */
+		int seq_train_failures;
 	} link;
 	bool reset_link_params;
 	int mso_link_count;
drivers/gpu/drm/i915/display/intel_dp.c +4 -0
index 8da277f0c2735..7c824c5a13346 100644
@@ -2950,6 +2950,7 @@ static void intel_dp_reset_link_params(struct intel_dp *intel_dp)
 {
 	intel_dp->link.max_lane_count = intel_dp_max_common_lane_count(intel_dp);
 	intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
+	intel_dp->link.seq_train_failures = 0;
 }
 
 /* Enable backlight PWM and backlight PP control. */
@@ -5056,6 +5057,9 @@ intel_dp_needs_link_retrain(struct intel_dp *intel_dp)
 					intel_dp->lane_count))
 		return false;
 
+	if (intel_dp->link.seq_train_failures)
+		return true;
+
 	/* Retrain if link not ok */
 	return !intel_dp_link_ok(intel_dp, link_status);
 }
drivers/gpu/drm/i915/display/intel_dp_link_training.c +8 -0
index ad1fbb150ff90..e804f0b801c02 100644
@@ -1486,10 +1486,13 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 		passed = intel_dp_link_train_all_phys(intel_dp, crtc_state, lttpr_count);
 
 	if (passed) {
+		intel_dp->link.seq_train_failures = 0;
 		intel_ddi_queue_link_check(dig_port, 2000);
 		return;
 	}
 
+	intel_dp->link.seq_train_failures++;
+
 	/*
 	 * Ignore the link failure in CI
 	 *
@@ -1507,6 +1510,11 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,
 		return;
 	}
 
+	if (intel_dp->link.seq_train_failures < 2) {
+		intel_ddi_queue_link_check(dig_port, 0);
+		return;
+	}
+
 	intel_dp_schedule_fallback_link_training(intel_dp, crtc_state);
 }
 
Signature · 1 line
2.43.3
author
#25 lore raw

PATCH v2 9/21 drm/i915/dp: Pass atomic state to link training function

In reply to Imre Deak

From: Imre Deak <[email protected]>

The next patch adds sending a modeset-retry uevent after a link training failure to all MST connectors on link. This requires the atomic state, so pass it to intel_dp_start_link_train(). In case of SST where retraining still happens by calling this function directly instead of a modeset commit the atomic state is not available and NULL is passed instead. This is ok, since in this case the encoder's only DP connector is available from intel_dp->attached_connector not requiring the atomic state.

---
 drivers/gpu/drm/i915/display/g4x_dp.c                 | 2 +-
 drivers/gpu/drm/i915/display/intel_ddi.c              | 6 +++---
 drivers/gpu/drm/i915/display/intel_dp.c               | 2 +-
 drivers/gpu/drm/i915/display/intel_dp_link_training.c | 4 +++-
 drivers/gpu/drm/i915/display/intel_dp_link_training.h | 4 +++-
 5 files changed, 11 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/g4x_dp.c +1 -1
index 4363e32a834df..0d7424a7581e6 100644
@@ -707,7 +707,7 @@ static void intel_enable_dp(struct intel_atomic_state *state,
 	intel_dp_configure_protocol_converter(intel_dp, pipe_config);
 	intel_dp_check_frl_training(intel_dp);
 	intel_dp_pcon_dsc_configure(intel_dp, pipe_config);
-	intel_dp_start_link_train(intel_dp, pipe_config);
+	intel_dp_start_link_train(state, intel_dp, pipe_config);
 	intel_dp_stop_link_train(intel_dp, pipe_config);
 }
 
drivers/gpu/drm/i915/display/intel_ddi.c +3 -3
index 86358ec27e685..58e57a7704811 100644
@@ -2586,7 +2586,7 @@ static void mtl_ddi_pre_enable_dp(struct intel_atomic_state *state,
 	 *     Pattern, wait for 5 idle patterns (DP_TP_STATUS Min_Idles_Sent)
 	 *     (timeout after 800 us)
 	 */
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 
 	/* 6.n Set DP_TP_CTL link training to Normal */
 	if (!is_trans_port_sync_mode(crtc_state))
@@ -2728,7 +2728,7 @@ static void tgl_ddi_pre_enable_dp(struct intel_atomic_state *state,
 	 *     Pattern, wait for 5 idle patterns (DP_TP_STATUS Min_Idles_Sent)
 	 *     (timeout after 800 us)
 	 */
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 
 	/* 7.k Set DP_TP_CTL link training to Normal */
 	if (!is_trans_port_sync_mode(crtc_state))
@@ -2795,7 +2795,7 @@ static void hsw_ddi_pre_enable_dp(struct intel_atomic_state *state,
 						   to_intel_connector(conn_state->connector),
 						   crtc_state);
 	intel_dp_sink_set_fec_ready(intel_dp, crtc_state, true);
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 	if ((port != PORT_A || DISPLAY_VER(dev_priv) >= 9) &&
 	    !is_trans_port_sync_mode(crtc_state))
 		intel_dp_stop_link_train(intel_dp, crtc_state);
drivers/gpu/drm/i915/display/intel_dp.c +1 -1
index 7c824c5a13346..1f0b7cceea2dc 100644
@@ -5214,7 +5214,7 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 
 		intel_dp_check_frl_training(intel_dp);
 		intel_dp_pcon_dsc_configure(intel_dp, crtc_state);
-		intel_dp_start_link_train(intel_dp, crtc_state);
+		intel_dp_start_link_train(NULL, intel_dp, crtc_state);
 		intel_dp_stop_link_train(intel_dp, crtc_state);
 		break;
 	}
drivers/gpu/drm/i915/display/intel_dp_link_training.c +3 -1
index e804f0b801c02..4f60daa97407d 100644
@@ -1453,6 +1453,7 @@ intel_dp_128b132b_link_train(struct intel_dp *intel_dp,
 
 /**
  * intel_dp_start_link_train - start link training
+ * @state: Atomic state
  * @intel_dp: DP struct
  * @crtc_state: state for CRTC attached to the encoder
  *
@@ -1461,7 +1462,8 @@ intel_dp_128b132b_link_train(struct intel_dp *intel_dp,
  * fails.
  * After calling this function intel_dp_stop_link_train() must be called.
  */
-void intel_dp_start_link_train(struct intel_dp *intel_dp,
+void intel_dp_start_link_train(struct intel_atomic_state *state,
+			       struct intel_dp *intel_dp,
 			       const struct intel_crtc_state *crtc_state)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
drivers/gpu/drm/i915/display/intel_dp_link_training.h +3 -1
index 19836a8a4f904..f658230960333 100644
@@ -8,6 +8,7 @@
 
 #include <drm/display/drm_dp_helper.h>
 
+struct intel_atomic_state;
 struct intel_crtc_state;
 struct intel_dp;
 
@@ -25,7 +26,8 @@ void intel_dp_program_link_training_pattern(struct intel_dp *intel_dp,
 void intel_dp_set_signal_levels(struct intel_dp *intel_dp,
 				const struct intel_crtc_state *crtc_state,
 				enum drm_dp_phy dp_phy);
-void intel_dp_start_link_train(struct intel_dp *intel_dp,
+void intel_dp_start_link_train(struct intel_atomic_state *state,
+			       struct intel_dp *intel_dp,
 			       const struct intel_crtc_state *crtc_state);
 void intel_dp_stop_link_train(struct intel_dp *intel_dp,
 			      const struct intel_crtc_state *crtc_state);
Signature · 1 line
2.43.3
#26 lore raw

Re: [PATCH v2 09/21] drm/i915/dp: Pass atomic state to link training function

Quoted 69 lines · Imre Deak

From: Imre Deak <[email protected]>

The next patch adds sending a modeset-retry uevent after a link training failure to all MST connectors on link. This requires the atomic state, so pass it to intel_dp_start_link_train(). In case of SST where retraining still happens by calling this function directly instead of a modeset commit the atomic state is not available and NULL is passed instead. This is ok, since in this case the encoder's only DP connector is available from intel_dp->attached_connector not requiring the atomic state.

---
 drivers/gpu/drm/i915/display/g4x_dp.c                 | 2 +-
 drivers/gpu/drm/i915/display/intel_ddi.c              | 6 +++---
 drivers/gpu/drm/i915/display/intel_dp.c               | 2 +-
 drivers/gpu/drm/i915/display/intel_dp_link_training.c | 4 +++-
 drivers/gpu/drm/i915/display/intel_dp_link_training.h | 4 +++-
 5 files changed, 11 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/g4x_dp.c +1 -1
index 4363e32a834df..0d7424a7581e6 100644
@@ -707,7 +707,7 @@ static void intel_enable_dp(struct intel_atomic_state *state,
 	intel_dp_configure_protocol_converter(intel_dp, pipe_config);
 	intel_dp_check_frl_training(intel_dp);
 	intel_dp_pcon_dsc_configure(intel_dp, pipe_config);
-	intel_dp_start_link_train(intel_dp, pipe_config);
+	intel_dp_start_link_train(state, intel_dp, pipe_config);
 	intel_dp_stop_link_train(intel_dp, pipe_config);
 }
 
drivers/gpu/drm/i915/display/intel_ddi.c +3 -3
index 86358ec27e685..58e57a7704811 100644
@@ -2586,7 +2586,7 @@ static void mtl_ddi_pre_enable_dp(struct intel_atomic_state *state,
 	 *     Pattern, wait for 5 idle patterns (DP_TP_STATUS Min_Idles_Sent)
 	 *     (timeout after 800 us)
 	 */
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 
 	/* 6.n Set DP_TP_CTL link training to Normal */
 	if (!is_trans_port_sync_mode(crtc_state))
@@ -2728,7 +2728,7 @@ static void tgl_ddi_pre_enable_dp(struct intel_atomic_state *state,
 	 *     Pattern, wait for 5 idle patterns (DP_TP_STATUS Min_Idles_Sent)
 	 *     (timeout after 800 us)
 	 */
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 
 	/* 7.k Set DP_TP_CTL link training to Normal */
 	if (!is_trans_port_sync_mode(crtc_state))
@@ -2795,7 +2795,7 @@ static void hsw_ddi_pre_enable_dp(struct intel_atomic_state *state,
 						   to_intel_connector(conn_state->connector),
 						   crtc_state);
 	intel_dp_sink_set_fec_ready(intel_dp, crtc_state, true);
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 	if ((port != PORT_A || DISPLAY_VER(dev_priv) >= 9) &&
 	    !is_trans_port_sync_mode(crtc_state))
 		intel_dp_stop_link_train(intel_dp, crtc_state);
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
index 7c824c5a13346..1f0b7cceea2dc 100644

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_retrain_link(struct intel_encoder *encoder, · line 5217

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_dp.c +1 -1
@@ -5214,7 +5214,7 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 
 		intel_dp_check_frl_training(intel_dp);
 		intel_dp_pcon_dsc_configure(intel_dp, crtc_state);
-		intel_dp_start_link_train(intel_dp, crtc_state);
+		intel_dp_start_link_train(NULL, intel_dp, crtc_state);

I was going to suggest s/crtc_state/crtc/ for this, but the state==NULL definitiely makes that impossible. I think we need to document each and every function where the atomic state may be NULL and thus needs to be passed the crtc_state as well. Otherwise someone (probably me) is likely going to attempt some cleanups which will then explode, or someone will just attempt to dig out something from the full atomic state (eg. state->base.dev).

Quoted 49 lines
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
 		intel_dp_stop_link_train(intel_dp, crtc_state);
 		break;
 	}
drivers/gpu/drm/i915/display/intel_dp_link_training.c +3 -1
index e804f0b801c02..4f60daa97407d 100644
@@ -1453,6 +1453,7 @@ intel_dp_128b132b_link_train(struct intel_dp *intel_dp,
 
 /**
  * intel_dp_start_link_train - start link training
+ * @state: Atomic state
  * @intel_dp: DP struct
  * @crtc_state: state for CRTC attached to the encoder
  *
@@ -1461,7 +1462,8 @@ intel_dp_128b132b_link_train(struct intel_dp *intel_dp,
  * fails.
  * After calling this function intel_dp_stop_link_train() must be called.
  */
-void intel_dp_start_link_train(struct intel_dp *intel_dp,
+void intel_dp_start_link_train(struct intel_atomic_state *state,
+			       struct intel_dp *intel_dp,
 			       const struct intel_crtc_state *crtc_state)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
drivers/gpu/drm/i915/display/intel_dp_link_training.h +3 -1
index 19836a8a4f904..f658230960333 100644
@@ -8,6 +8,7 @@
 
 #include <drm/display/drm_dp_helper.h>
 
+struct intel_atomic_state;
 struct intel_crtc_state;
 struct intel_dp;
 
@@ -25,7 +26,8 @@ void intel_dp_program_link_training_pattern(struct intel_dp *intel_dp,
 void intel_dp_set_signal_levels(struct intel_dp *intel_dp,
 				const struct intel_crtc_state *crtc_state,
 				enum drm_dp_phy dp_phy);
-void intel_dp_start_link_train(struct intel_dp *intel_dp,
+void intel_dp_start_link_train(struct intel_atomic_state *state,
+			       struct intel_dp *intel_dp,
 			       const struct intel_crtc_state *crtc_state);
 void intel_dp_stop_link_train(struct intel_dp *intel_dp,
 			      const struct intel_crtc_state *crtc_state);
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
author
#27 lore raw

Re: [PATCH v2 09/21] drm/i915/dp: Pass atomic state to link training function

Quoted 71 lines · Ville Syrjälä
Quoted 70 lines · Imre Deak

From: Imre Deak <[email protected]>

The next patch adds sending a modeset-retry uevent after a link training failure to all MST connectors on link. This requires the atomic state, so pass it to intel_dp_start_link_train(). In case of SST where retraining still happens by calling this function directly instead of a modeset commit the atomic state is not available and NULL is passed instead. This is ok, since in this case the encoder's only DP connector is available from intel_dp->attached_connector not requiring the atomic state.

---
 drivers/gpu/drm/i915/display/g4x_dp.c                 | 2 +-
 drivers/gpu/drm/i915/display/intel_ddi.c              | 6 +++---
 drivers/gpu/drm/i915/display/intel_dp.c               | 2 +-
 drivers/gpu/drm/i915/display/intel_dp_link_training.c | 4 +++-
 drivers/gpu/drm/i915/display/intel_dp_link_training.h | 4 +++-
 5 files changed, 11 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/g4x_dp.c +1 -1
index 4363e32a834df..0d7424a7581e6 100644
@@ -707,7 +707,7 @@ static void intel_enable_dp(struct intel_atomic_state *state,
 	intel_dp_configure_protocol_converter(intel_dp, pipe_config);
 	intel_dp_check_frl_training(intel_dp);
 	intel_dp_pcon_dsc_configure(intel_dp, pipe_config);
-	intel_dp_start_link_train(intel_dp, pipe_config);
+	intel_dp_start_link_train(state, intel_dp, pipe_config);
 	intel_dp_stop_link_train(intel_dp, pipe_config);
 }
 
drivers/gpu/drm/i915/display/intel_ddi.c +3 -3
index 86358ec27e685..58e57a7704811 100644
@@ -2586,7 +2586,7 @@ static void mtl_ddi_pre_enable_dp(struct intel_atomic_state *state,
 	 *     Pattern, wait for 5 idle patterns (DP_TP_STATUS Min_Idles_Sent)
 	 *     (timeout after 800 us)
 	 */
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 
 	/* 6.n Set DP_TP_CTL link training to Normal */
 	if (!is_trans_port_sync_mode(crtc_state))
@@ -2728,7 +2728,7 @@ static void tgl_ddi_pre_enable_dp(struct intel_atomic_state *state,
 	 *     Pattern, wait for 5 idle patterns (DP_TP_STATUS Min_Idles_Sent)
 	 *     (timeout after 800 us)
 	 */
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 
 	/* 7.k Set DP_TP_CTL link training to Normal */
 	if (!is_trans_port_sync_mode(crtc_state))
@@ -2795,7 +2795,7 @@ static void hsw_ddi_pre_enable_dp(struct intel_atomic_state *state,
 						   to_intel_connector(conn_state->connector),
 						   crtc_state);
 	intel_dp_sink_set_fec_ready(intel_dp, crtc_state, true);
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 	if ((port != PORT_A || DISPLAY_VER(dev_priv) >= 9) &&
 	    !is_trans_port_sync_mode(crtc_state))
 		intel_dp_stop_link_train(intel_dp, crtc_state);
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
index 7c824c5a13346..1f0b7cceea2dc 100644
@@ -5214,7 +5214,7 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 
Quoted 12 lines

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_retrain_link(struct intel_encoder *encoder, · line 5217

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dp.c +1 -1
 		intel_dp_check_frl_training(intel_dp);
 		intel_dp_pcon_dsc_configure(intel_dp, crtc_state);
-		intel_dp_start_link_train(intel_dp, crtc_state);
+		intel_dp_start_link_train(NULL, intel_dp, crtc_state);

I was going to suggest s/crtc_state/crtc/ for this, but the state==NULL definitiely makes that impossible. I think we need to document each and every function where the atomic state may be NULL and thus needs to be passed the crtc_state as well. Otherwise someone (probably me) is likely going to attempt some cleanups which will then explode, or someone will just attempt to dig out something from the full atomic state (eg. state->base.dev).

This is meant to be a temporary solution, for maybe a few weeks after this gets merged after which retraining should be switched over to be a modeset in all cases; but agreed it's better to document that in intel_dp_start_link_train(), will add that.

Quoted 54 lines
Quoted 50 lines
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
 		intel_dp_stop_link_train(intel_dp, crtc_state);
 		break;
 	}
drivers/gpu/drm/i915/display/intel_dp_link_training.c +3 -1
index e804f0b801c02..4f60daa97407d 100644
@@ -1453,6 +1453,7 @@ intel_dp_128b132b_link_train(struct intel_dp *intel_dp,
 
 /**
  * intel_dp_start_link_train - start link training
+ * @state: Atomic state
  * @intel_dp: DP struct
  * @crtc_state: state for CRTC attached to the encoder
  *
@@ -1461,7 +1462,8 @@ intel_dp_128b132b_link_train(struct intel_dp *intel_dp,
  * fails.
  * After calling this function intel_dp_stop_link_train() must be called.
  */
-void intel_dp_start_link_train(struct intel_dp *intel_dp,
+void intel_dp_start_link_train(struct intel_atomic_state *state,
+			       struct intel_dp *intel_dp,
 			       const struct intel_crtc_state *crtc_state)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
drivers/gpu/drm/i915/display/intel_dp_link_training.h +3 -1
index 19836a8a4f904..f658230960333 100644
@@ -8,6 +8,7 @@
 
 #include <drm/display/drm_dp_helper.h>
 
+struct intel_atomic_state;
 struct intel_crtc_state;
 struct intel_dp;
 
@@ -25,7 +26,8 @@ void intel_dp_program_link_training_pattern(struct intel_dp *intel_dp,
 void intel_dp_set_signal_levels(struct intel_dp *intel_dp,
 				const struct intel_crtc_state *crtc_state,
 				enum drm_dp_phy dp_phy);
-void intel_dp_start_link_train(struct intel_dp *intel_dp,
+void intel_dp_start_link_train(struct intel_atomic_state *state,
+			       struct intel_dp *intel_dp,
 			       const struct intel_crtc_state *crtc_state);
 void intel_dp_stop_link_train(struct intel_dp *intel_dp,
 			      const struct intel_crtc_state *crtc_state);
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
#28 lore raw

Re: [PATCH v2 09/21] drm/i915/dp: Pass atomic state to link training function

Quoted 85 lines · Imre Deak
Quoted 71 lines · Ville Syrjälä
Quoted 70 lines · Imre Deak

From: Imre Deak <[email protected]>

The next patch adds sending a modeset-retry uevent after a link training failure to all MST connectors on link. This requires the atomic state, so pass it to intel_dp_start_link_train(). In case of SST where retraining still happens by calling this function directly instead of a modeset commit the atomic state is not available and NULL is passed instead. This is ok, since in this case the encoder's only DP connector is available from intel_dp->attached_connector not requiring the atomic state.

---
 drivers/gpu/drm/i915/display/g4x_dp.c                 | 2 +-
 drivers/gpu/drm/i915/display/intel_ddi.c              | 6 +++---
 drivers/gpu/drm/i915/display/intel_dp.c               | 2 +-
 drivers/gpu/drm/i915/display/intel_dp_link_training.c | 4 +++-
 drivers/gpu/drm/i915/display/intel_dp_link_training.h | 4 +++-
 5 files changed, 11 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/g4x_dp.c +1 -1
index 4363e32a834df..0d7424a7581e6 100644
@@ -707,7 +707,7 @@ static void intel_enable_dp(struct intel_atomic_state *state,
 	intel_dp_configure_protocol_converter(intel_dp, pipe_config);
 	intel_dp_check_frl_training(intel_dp);
 	intel_dp_pcon_dsc_configure(intel_dp, pipe_config);
-	intel_dp_start_link_train(intel_dp, pipe_config);
+	intel_dp_start_link_train(state, intel_dp, pipe_config);
 	intel_dp_stop_link_train(intel_dp, pipe_config);
 }
 
drivers/gpu/drm/i915/display/intel_ddi.c +3 -3
index 86358ec27e685..58e57a7704811 100644
@@ -2586,7 +2586,7 @@ static void mtl_ddi_pre_enable_dp(struct intel_atomic_state *state,
 	 *     Pattern, wait for 5 idle patterns (DP_TP_STATUS Min_Idles_Sent)
 	 *     (timeout after 800 us)
 	 */
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 
 	/* 6.n Set DP_TP_CTL link training to Normal */
 	if (!is_trans_port_sync_mode(crtc_state))
@@ -2728,7 +2728,7 @@ static void tgl_ddi_pre_enable_dp(struct intel_atomic_state *state,
 	 *     Pattern, wait for 5 idle patterns (DP_TP_STATUS Min_Idles_Sent)
 	 *     (timeout after 800 us)
 	 */
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 
 	/* 7.k Set DP_TP_CTL link training to Normal */
 	if (!is_trans_port_sync_mode(crtc_state))
@@ -2795,7 +2795,7 @@ static void hsw_ddi_pre_enable_dp(struct intel_atomic_state *state,
 						   to_intel_connector(conn_state->connector),
 						   crtc_state);
 	intel_dp_sink_set_fec_ready(intel_dp, crtc_state, true);
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 	if ((port != PORT_A || DISPLAY_VER(dev_priv) >= 9) &&
 	    !is_trans_port_sync_mode(crtc_state))
 		intel_dp_stop_link_train(intel_dp, crtc_state);
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
index 7c824c5a13346..1f0b7cceea2dc 100644
@@ -5214,7 +5214,7 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 
Quoted 12 lines

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_retrain_link(struct intel_encoder *encoder, · line 5217

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dp.c +1 -1
 		intel_dp_check_frl_training(intel_dp);
 		intel_dp_pcon_dsc_configure(intel_dp, crtc_state);
-		intel_dp_start_link_train(intel_dp, crtc_state);
+		intel_dp_start_link_train(NULL, intel_dp, crtc_state);

I was going to suggest s/crtc_state/crtc/ for this, but the state==NULL definitiely makes that impossible. I think we need to document each and every function where the atomic state may be NULL and thus needs to be passed the crtc_state as well. Otherwise someone (probably me) is likely going to attempt some cleanups which will then explode, or someone will just attempt to dig out something from the full atomic state (eg. state->base.dev).

Quoted 4 lines

This is meant to be a temporary solution, for maybe a few weeks after this gets merged after which retraining should be switched over to be a modeset in all cases; but agreed it's better to document that in intel_dp_start_link_train(), will add that.

The documentation should go all the way to the bottom IMO. Anything that gets passed the state by this guy can now also end up with state==NULL.

Quoted 55 lines
Quoted 55 lines
Quoted 51 lines
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
 		intel_dp_stop_link_train(intel_dp, crtc_state);
 		break;
 	}
drivers/gpu/drm/i915/display/intel_dp_link_training.c +3 -1
index e804f0b801c02..4f60daa97407d 100644
@@ -1453,6 +1453,7 @@ intel_dp_128b132b_link_train(struct intel_dp *intel_dp,
 
 /**
  * intel_dp_start_link_train - start link training
+ * @state: Atomic state
  * @intel_dp: DP struct
  * @crtc_state: state for CRTC attached to the encoder
  *
@@ -1461,7 +1462,8 @@ intel_dp_128b132b_link_train(struct intel_dp *intel_dp,
  * fails.
  * After calling this function intel_dp_stop_link_train() must be called.
  */
-void intel_dp_start_link_train(struct intel_dp *intel_dp,
+void intel_dp_start_link_train(struct intel_atomic_state *state,
+			       struct intel_dp *intel_dp,
 			       const struct intel_crtc_state *crtc_state)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
drivers/gpu/drm/i915/display/intel_dp_link_training.h +3 -1
index 19836a8a4f904..f658230960333 100644
@@ -8,6 +8,7 @@
 
 #include <drm/display/drm_dp_helper.h>
 
+struct intel_atomic_state;
 struct intel_crtc_state;
 struct intel_dp;
 
@@ -25,7 +26,8 @@ void intel_dp_program_link_training_pattern(struct intel_dp *intel_dp,
 void intel_dp_set_signal_levels(struct intel_dp *intel_dp,
 				const struct intel_crtc_state *crtc_state,
 				enum drm_dp_phy dp_phy);
-void intel_dp_start_link_train(struct intel_dp *intel_dp,
+void intel_dp_start_link_train(struct intel_atomic_state *state,
+			       struct intel_dp *intel_dp,
 			       const struct intel_crtc_state *crtc_state);
 void intel_dp_stop_link_train(struct intel_dp *intel_dp,
 			      const struct intel_crtc_state *crtc_state);
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
Signature · 2 lines
Ville Syrjälä
Intel
author
#29 lore raw

Re: [PATCH v2 09/21] drm/i915/dp: Pass atomic state to link training function

Quoted 86 lines · Ville Syrjälä
Quoted 85 lines · Imre Deak
Quoted 83 lines · Ville Syrjälä
Quoted 69 lines · Imre Deak

From: Imre Deak <[email protected]>

The next patch adds sending a modeset-retry uevent after a link training failure to all MST connectors on link. This requires the atomic state, so pass it to intel_dp_start_link_train(). In case of SST where retraining still happens by calling this function directly instead of a modeset commit the atomic state is not available and NULL is passed instead. This is ok, since in this case the encoder's only DP connector is available from intel_dp->attached_connector not requiring the atomic state.

---
 drivers/gpu/drm/i915/display/g4x_dp.c                 | 2 +-
 drivers/gpu/drm/i915/display/intel_ddi.c              | 6 +++---
 drivers/gpu/drm/i915/display/intel_dp.c               | 2 +-
 drivers/gpu/drm/i915/display/intel_dp_link_training.c | 4 +++-
 drivers/gpu/drm/i915/display/intel_dp_link_training.h | 4 +++-
 5 files changed, 11 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/g4x_dp.c +1 -1
index 4363e32a834df..0d7424a7581e6 100644
@@ -707,7 +707,7 @@ static void intel_enable_dp(struct intel_atomic_state *state,
 	intel_dp_configure_protocol_converter(intel_dp, pipe_config);
 	intel_dp_check_frl_training(intel_dp);
 	intel_dp_pcon_dsc_configure(intel_dp, pipe_config);
-	intel_dp_start_link_train(intel_dp, pipe_config);
+	intel_dp_start_link_train(state, intel_dp, pipe_config);
 	intel_dp_stop_link_train(intel_dp, pipe_config);
 }
 
drivers/gpu/drm/i915/display/intel_ddi.c +3 -3
index 86358ec27e685..58e57a7704811 100644
@@ -2586,7 +2586,7 @@ static void mtl_ddi_pre_enable_dp(struct intel_atomic_state *state,
 	 *     Pattern, wait for 5 idle patterns (DP_TP_STATUS Min_Idles_Sent)
 	 *     (timeout after 800 us)
 	 */
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 
 	/* 6.n Set DP_TP_CTL link training to Normal */
 	if (!is_trans_port_sync_mode(crtc_state))
@@ -2728,7 +2728,7 @@ static void tgl_ddi_pre_enable_dp(struct intel_atomic_state *state,
 	 *     Pattern, wait for 5 idle patterns (DP_TP_STATUS Min_Idles_Sent)
 	 *     (timeout after 800 us)
 	 */
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 
 	/* 7.k Set DP_TP_CTL link training to Normal */
 	if (!is_trans_port_sync_mode(crtc_state))
@@ -2795,7 +2795,7 @@ static void hsw_ddi_pre_enable_dp(struct intel_atomic_state *state,
 						   to_intel_connector(conn_state->connector),
 						   crtc_state);
 	intel_dp_sink_set_fec_ready(intel_dp, crtc_state, true);
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 	if ((port != PORT_A || DISPLAY_VER(dev_priv) >= 9) &&
 	    !is_trans_port_sync_mode(crtc_state))
 		intel_dp_stop_link_train(intel_dp, crtc_state);
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
index 7c824c5a13346..1f0b7cceea2dc 100644

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_retrain_link(struct intel_encoder *encoder, · line 5217

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_dp.c +1 -1
@@ -5214,7 +5214,7 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 
 		intel_dp_check_frl_training(intel_dp);
 		intel_dp_pcon_dsc_configure(intel_dp, crtc_state);
-		intel_dp_start_link_train(intel_dp, crtc_state);
+		intel_dp_start_link_train(NULL, intel_dp, crtc_state);

I was going to suggest s/crtc_state/crtc/ for this, but the state==NULL definitiely makes that impossible. I think we need to document each and every function where the atomic state may be NULL and thus needs to be passed the crtc_state as well. Otherwise someone (probably me) is likely going to attempt some cleanups which will then explode, or someone will just attempt to dig out something from the full atomic state (eg. state->base.dev).

Quoted 8 lines
Quoted 4 lines

This is meant to be a temporary solution, for maybe a few weeks after this gets merged after which retraining should be switched over to be a modeset in all cases; but agreed it's better to document that in intel_dp_start_link_train(), will add that.

The documentation should go all the way to the bottom IMO. Anything that gets passed the state by this guy can now also end up with state==NULL.

Ok, makes sense.

Quoted 60 lines
Quoted 56 lines
Quoted 56 lines
Quoted 52 lines
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
 		intel_dp_stop_link_train(intel_dp, crtc_state);
 		break;
 	}
drivers/gpu/drm/i915/display/intel_dp_link_training.c +3 -1
index e804f0b801c02..4f60daa97407d 100644
@@ -1453,6 +1453,7 @@ intel_dp_128b132b_link_train(struct intel_dp *intel_dp,
 
 /**
  * intel_dp_start_link_train - start link training
+ * @state: Atomic state
  * @intel_dp: DP struct
  * @crtc_state: state for CRTC attached to the encoder
  *
@@ -1461,7 +1462,8 @@ intel_dp_128b132b_link_train(struct intel_dp *intel_dp,
  * fails.
  * After calling this function intel_dp_stop_link_train() must be called.
  */
-void intel_dp_start_link_train(struct intel_dp *intel_dp,
+void intel_dp_start_link_train(struct intel_atomic_state *state,
+			       struct intel_dp *intel_dp,
 			       const struct intel_crtc_state *crtc_state)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
drivers/gpu/drm/i915/display/intel_dp_link_training.h +3 -1
index 19836a8a4f904..f658230960333 100644
@@ -8,6 +8,7 @@
 
 #include <drm/display/drm_dp_helper.h>
 
+struct intel_atomic_state;
 struct intel_crtc_state;
 struct intel_dp;
 
@@ -25,7 +26,8 @@ void intel_dp_program_link_training_pattern(struct intel_dp *intel_dp,
 void intel_dp_set_signal_levels(struct intel_dp *intel_dp,
 				const struct intel_crtc_state *crtc_state,
 				enum drm_dp_phy dp_phy);
-void intel_dp_start_link_train(struct intel_dp *intel_dp,
+void intel_dp_start_link_train(struct intel_atomic_state *state,
+			       struct intel_dp *intel_dp,
 			       const struct intel_crtc_state *crtc_state);
 void intel_dp_stop_link_train(struct intel_dp *intel_dp,
 			      const struct intel_crtc_state *crtc_state);
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
Signature · 2 lines
Ville Syrjälä
Intel
#30 lore raw

Re: [PATCH v2 09/21] drm/i915/dp: Pass atomic state to link training function

In reply to Ville Syrjälä
Quoted 86 lines · Ville Syrjälä
Quoted 85 lines · Imre Deak
Quoted 83 lines · Ville Syrjälä
Quoted 69 lines · Imre Deak

From: Imre Deak <[email protected]>

The next patch adds sending a modeset-retry uevent after a link training failure to all MST connectors on link. This requires the atomic state, so pass it to intel_dp_start_link_train(). In case of SST where retraining still happens by calling this function directly instead of a modeset commit the atomic state is not available and NULL is passed instead. This is ok, since in this case the encoder's only DP connector is available from intel_dp->attached_connector not requiring the atomic state.

---
 drivers/gpu/drm/i915/display/g4x_dp.c                 | 2 +-
 drivers/gpu/drm/i915/display/intel_ddi.c              | 6 +++---
 drivers/gpu/drm/i915/display/intel_dp.c               | 2 +-
 drivers/gpu/drm/i915/display/intel_dp_link_training.c | 4 +++-
 drivers/gpu/drm/i915/display/intel_dp_link_training.h | 4 +++-
 5 files changed, 11 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/g4x_dp.c +1 -1
index 4363e32a834df..0d7424a7581e6 100644
@@ -707,7 +707,7 @@ static void intel_enable_dp(struct intel_atomic_state *state,
 	intel_dp_configure_protocol_converter(intel_dp, pipe_config);
 	intel_dp_check_frl_training(intel_dp);
 	intel_dp_pcon_dsc_configure(intel_dp, pipe_config);
-	intel_dp_start_link_train(intel_dp, pipe_config);
+	intel_dp_start_link_train(state, intel_dp, pipe_config);
 	intel_dp_stop_link_train(intel_dp, pipe_config);
 }
 
drivers/gpu/drm/i915/display/intel_ddi.c +3 -3
index 86358ec27e685..58e57a7704811 100644
@@ -2586,7 +2586,7 @@ static void mtl_ddi_pre_enable_dp(struct intel_atomic_state *state,
 	 *     Pattern, wait for 5 idle patterns (DP_TP_STATUS Min_Idles_Sent)
 	 *     (timeout after 800 us)
 	 */
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 
 	/* 6.n Set DP_TP_CTL link training to Normal */
 	if (!is_trans_port_sync_mode(crtc_state))
@@ -2728,7 +2728,7 @@ static void tgl_ddi_pre_enable_dp(struct intel_atomic_state *state,
 	 *     Pattern, wait for 5 idle patterns (DP_TP_STATUS Min_Idles_Sent)
 	 *     (timeout after 800 us)
 	 */
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 
 	/* 7.k Set DP_TP_CTL link training to Normal */
 	if (!is_trans_port_sync_mode(crtc_state))
@@ -2795,7 +2795,7 @@ static void hsw_ddi_pre_enable_dp(struct intel_atomic_state *state,
 						   to_intel_connector(conn_state->connector),
 						   crtc_state);
 	intel_dp_sink_set_fec_ready(intel_dp, crtc_state, true);
-	intel_dp_start_link_train(intel_dp, crtc_state);
+	intel_dp_start_link_train(state, intel_dp, crtc_state);
 	if ((port != PORT_A || DISPLAY_VER(dev_priv) >= 9) &&
 	    !is_trans_port_sync_mode(crtc_state))
 		intel_dp_stop_link_train(intel_dp, crtc_state);
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
index 7c824c5a13346..1f0b7cceea2dc 100644

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_retrain_link(struct intel_encoder *encoder, · line 5217

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_dp.c +1 -1
@@ -5214,7 +5214,7 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 
 		intel_dp_check_frl_training(intel_dp);
 		intel_dp_pcon_dsc_configure(intel_dp, crtc_state);
-		intel_dp_start_link_train(intel_dp, crtc_state);
+		intel_dp_start_link_train(NULL, intel_dp, crtc_state);

I was going to suggest s/crtc_state/crtc/ for this, but the state==NULL definitiely makes that impossible. I think we need to document each and every function where the atomic state may be NULL and thus needs to be passed the crtc_state as well. Otherwise someone (probably me) is likely going to attempt some cleanups which will then explode, or someone will just attempt to dig out something from the full atomic state (eg. state->base.dev).

Quoted 8 lines
Quoted 4 lines

This is meant to be a temporary solution, for maybe a few weeks after this gets merged after which retraining should be switched over to be a modeset in all cases; but agreed it's better to document that in intel_dp_start_link_train(), will add that.

The documentation should go all the way to the bottom IMO. Anything that gets passed the state by this guy can now also end up with state==NULL.

Hmm. Is there some could_be_null(state) trick we could use to tell the compiler/static analyzers that this indeed may be NULL? Would essentially need some kind of nop NULL check I suppose.

Signature · 2 lines
Ville Syrjälä
Intel
author
#31 lore raw

PATCH v2 10/21 drm/i915/dp: Send a link training modeset-retry uevent to all MST connectors

In reply to Imre Deak

Send a modeset-retry uevent to all connectors in the same MST topology after a link training failure and reduction of the link parameters. This matches the way the same uevent is sent after a DP tunnel BW allocation failure.

---
 drivers/gpu/drm/i915/display/intel_dp.c               | 2 +-
 drivers/gpu/drm/i915/display/intel_dp.h               | 1 -
 drivers/gpu/drm/i915/display/intel_dp_link_training.c | 9 +++++----
 3 files changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +1 -1
index 1f0b7cceea2dc..87f9f12814b93 100644
@@ -2791,7 +2791,7 @@ intel_dp_audio_compute_config(struct intel_encoder *encoder,
 					intel_dp_is_uhbr(pipe_config);
 }
 
-void intel_dp_queue_modeset_retry_work(struct intel_connector *connector)
+static void intel_dp_queue_modeset_retry_work(struct intel_connector *connector)
 {
 	struct drm_i915_private *i915 = to_i915(connector->base.dev);
 
drivers/gpu/drm/i915/display/intel_dp.h +0 -1
index e7b47e7bcd98b..24777c035e2ad 100644
@@ -44,7 +44,6 @@ bool intel_dp_limited_color_range(const struct intel_crtc_state *crtc_state,
 				  const struct drm_connector_state *conn_state);
 int intel_dp_min_bpp(enum intel_output_format output_format);
 void intel_dp_init_modeset_retry_work(struct intel_connector *connector);
-void intel_dp_queue_modeset_retry_work(struct intel_connector *connector);
 void
 intel_dp_queue_modeset_retry_for_link(struct intel_atomic_state *state,
 				      struct intel_encoder *encoder,
drivers/gpu/drm/i915/display/intel_dp_link_training.c +5 -4
index 4f60daa97407d..97d499e4b6ef7 100644
@@ -1187,10 +1187,11 @@ static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 	return 0;
 }
 
-static void intel_dp_schedule_fallback_link_training(struct intel_dp *intel_dp,
+static void intel_dp_schedule_fallback_link_training(struct intel_atomic_state *state,
+						     struct intel_dp *intel_dp,
 						     const struct intel_crtc_state *crtc_state)
 {
-	struct intel_connector *intel_connector = intel_dp->attached_connector;
+	struct intel_encoder *encoder = &dp_to_dig_port(intel_dp)->base;
 
 	if (!intel_digital_port_connected(&dp_to_dig_port(intel_dp)->base)) {
 		lt_dbg(intel_dp, DP_PHY_DPRX, "Link Training failed on disconnected sink.\n");
@@ -1206,7 +1207,7 @@ static void intel_dp_schedule_fallback_link_training(struct intel_dp *intel_dp,
 	}
 
 	/* Schedule a Hotplug Uevent to userspace to start modeset */
-	intel_dp_queue_modeset_retry_work(intel_connector);
+	intel_dp_queue_modeset_retry_for_link(state, encoder, crtc_state);
 }
 
 /* Perform the link training on all LTTPRs and the DPRX on a link. */
@@ -1517,7 +1518,7 @@ void intel_dp_start_link_train(struct intel_atomic_state *state,
 		return;
 	}
 
-	intel_dp_schedule_fallback_link_training(intel_dp, crtc_state);
+	intel_dp_schedule_fallback_link_training(state, intel_dp, crtc_state);
 }
 
 void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp,
Signature · 1 line
2.43.3
author
#32 lore raw

PATCH v2 11/21 drm/i915/dp: Use check link state work in the hotplug handler

In reply to Imre Deak

Simplify things by retraining a DP link if a bad link is detected in the hotplug handler from the encoder's check link state work, similarly to how this is done after a modeset link training failure.

---
 drivers/gpu/drm/i915/display/g4x_dp.c    | 20 +-------------------
 drivers/gpu/drm/i915/display/intel_ddi.c | 11 +++++------
 drivers/gpu/drm/i915/display/intel_dp.c  |  8 ++++++++
 drivers/gpu/drm/i915/display/intel_dp.h  |  1 +
 4 files changed, 15 insertions(+), 25 deletions(-)
drivers/gpu/drm/i915/display/g4x_dp.c +1 -19
index 0d7424a7581e6..1f3b6b3956a1c 100644
@@ -1160,9 +1160,7 @@ intel_dp_hotplug(struct intel_encoder *encoder,
 		 struct intel_connector *connector)
 {
 	struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
-	struct drm_modeset_acquire_ctx ctx;
 	enum intel_hotplug_state state;
-	int ret;
 
 	if (intel_dp->compliance.test_active &&
 	    intel_dp->compliance.test_type == DP_TEST_LINK_PHY_TEST_PATTERN) {
@@ -1173,23 +1171,7 @@ intel_dp_hotplug(struct intel_encoder *encoder,
 
 	state = intel_encoder_hotplug(encoder, connector);
 
-	drm_modeset_acquire_init(&ctx, 0);
-
-	for (;;) {
-		ret = intel_dp_retrain_link(encoder, &ctx);
-
-		if (ret == -EDEADLK) {
-			drm_modeset_backoff(&ctx);
-			continue;
-		}
-
-		break;
-	}
-
-	drm_modeset_drop_locks(&ctx);
-	drm_modeset_acquire_fini(&ctx);
-	drm_WARN(encoder->base.dev, ret,
-		 "Acquiring modeset locks failed with %i\n", ret);
+	intel_dp_check_link_state(intel_dp);
 
 	/*
 	 * Keeping it consistent with intel_ddi_hotplug() and
drivers/gpu/drm/i915/display/intel_ddi.c +5 -6
index 58e57a7704811..ea24404724075 100644
@@ -4566,14 +4566,13 @@ intel_ddi_hotplug(struct intel_encoder *encoder,
 	state = intel_encoder_hotplug(encoder, connector);
 
 	if (!intel_tc_port_link_reset(dig_port)) {
-		intel_modeset_lock_ctx_retry(&ctx, NULL, 0, ret) {
-			if (connector->base.connector_type == DRM_MODE_CONNECTOR_HDMIA)
+		if (connector->base.connector_type == DRM_MODE_CONNECTOR_HDMIA) {
+			intel_modeset_lock_ctx_retry(&ctx, NULL, 0, ret)
 				ret = intel_hdmi_reset_link(encoder, &ctx);
-			else
-				ret = intel_dp_retrain_link(encoder, &ctx);
+			drm_WARN_ON(encoder->base.dev, ret);
+		} else {
+			intel_dp_check_link_state(intel_dp);
 		}
-
-		drm_WARN_ON(encoder->base.dev, ret);
 	}
 
 	/*
drivers/gpu/drm/i915/display/intel_dp.c +8 -0
index 87f9f12814b93..ff4ed6bb520d8 100644
@@ -5064,6 +5064,14 @@ intel_dp_needs_link_retrain(struct intel_dp *intel_dp)
 	return !intel_dp_link_ok(intel_dp, link_status);
 }
 
+void intel_dp_check_link_state(struct intel_dp *intel_dp)
+{
+	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
+
+	if (intel_dp_needs_link_retrain(intel_dp))
+		intel_ddi_queue_link_check(dig_port, 0);
+}
+
 static bool intel_dp_has_connector(struct intel_dp *intel_dp,
 				   const struct drm_connector_state *conn_state)
 {
drivers/gpu/drm/i915/display/intel_dp.h +1 -0
index 24777c035e2ad..3fa53ac601d58 100644
@@ -57,6 +57,7 @@ void intel_dp_set_link_params(struct intel_dp *intel_dp,
 int intel_dp_get_active_pipes(struct intel_dp *intel_dp,
 			      struct drm_modeset_acquire_ctx *ctx,
 			      u8 *pipe_mask);
+void intel_dp_check_link_state(struct intel_dp *intel_dp);
 int intel_dp_retrain_link(struct intel_encoder *encoder,
 			  struct drm_modeset_acquire_ctx *ctx);
 void intel_dp_set_power(struct intel_dp *intel_dp, u8 mode);
Signature · 1 line
2.43.3
author
#33 lore raw

PATCH v2 12/21 drm/i915/dp: Use check link state work in the detect handler

In reply to Imre Deak

Simplify things by retraining a DP link if a bad link is detected in the connector detect handler from the encoder's check link state work, similarly to how this is done after a modeset link training failure.

---
 drivers/gpu/drm/i915/display/intel_dp.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +2 -5
index ff4ed6bb520d8..70b00e5ae7ad7 100644
@@ -5863,11 +5863,8 @@ intel_dp_detect(struct drm_connector *connector,
 	 * Some external monitors do not signal loss of link synchronization
 	 * with an IRQ_HPD, so force a link status check.
 	 */
-	if (!intel_dp_is_edp(intel_dp)) {
-		ret = intel_dp_retrain_link(encoder, ctx);
-		if (ret)
-			return ret;
-	}
+	if (!intel_dp_is_edp(intel_dp))
+		intel_dp_check_link_state(intel_dp);
 
 	/*
 	 * Clearing NACK and defer counts to get their exact values
Signature · 1 line
2.43.3
#34 lore raw

Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

Quoted 14 lines · Imre Deak

Simplify things by retraining a DP link if a bad link is detected in the connector detect handler from the encoder's check link state work, similarly to how this is done after a modeset link training failure.

---
 drivers/gpu/drm/i915/display/intel_dp.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
index ff4ed6bb520d8..70b00e5ae7ad7 100644

drivers/gpu/drm/i915/display/intel_dp.c intel_dp_detect(struct drm_connector *connector, · line 5867

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp.c +2 -5
@@ -5863,11 +5863,8 @@ intel_dp_detect(struct drm_connector *connector,
 	 * Some external monitors do not signal loss of link synchronization
 	 * with an IRQ_HPD, so force a link status check.
 	 */
-	if (!intel_dp_is_edp(intel_dp)) {
-		ret = intel_dp_retrain_link(encoder, ctx);
-		if (ret)
-			return ret;
-	}
+	if (!intel_dp_is_edp(intel_dp))
+		intel_dp_check_link_state(intel_dp);

I would like to see this hack nuked entirely. But that could be a followup.

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
 	/*
 	 * Clearing NACK and defer counts to get their exact values
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
author
#35 lore raw

Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

Quoted 20 lines · Ville Syrjälä
Quoted 19 lines · Imre Deak

Simplify things by retraining a DP link if a bad link is detected in the connector detect handler from the encoder's check link state work, similarly to how this is done after a modeset link training failure.

---
 drivers/gpu/drm/i915/display/intel_dp.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +0 -2
index ff4ed6bb520d8..70b00e5ae7ad7 100644
@@ -5863,11 +5863,8 @@ intel_dp_detect(struct drm_connector *connector,
 	 * Some external monitors do not signal loss of link synchronization
 	 * with an IRQ_HPD, so force a link status check.
 	 */
-	if (!intel_dp_is_edp(intel_dp)) {
-		ret = intel_dp_retrain_link(encoder, ctx);
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_dp.c intel_dp_detect(struct drm_connector *connector, · line 5867

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_dp.c +2 -3
-		if (ret)
-			return ret;
-	}
+	if (!intel_dp_is_edp(intel_dp))
+		intel_dp_check_link_state(intel_dp);

I would like to see this hack nuked entirely. But that could be a followup.

Okay. This tries to keep the current behavior, but can add a note that the above workaround can be removed after the link state is checked after modesets.

I also wondered about the link state check in the hotplug handler. If that's only a way to defer doing this from the HPD IRQ handler - which is now changed by patch 13 - that could be also removed eventually?

Quoted 10 lines
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
 	/*
 	 * Clearing NACK and defer counts to get their exact values
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
#36 lore raw

Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

Quoted 30 lines · Imre Deak
Quoted 20 lines · Ville Syrjälä
Quoted 19 lines · Imre Deak

Simplify things by retraining a DP link if a bad link is detected in the connector detect handler from the encoder's check link state work, similarly to how this is done after a modeset link training failure.

---
 drivers/gpu/drm/i915/display/intel_dp.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +0 -2
index ff4ed6bb520d8..70b00e5ae7ad7 100644
@@ -5863,11 +5863,8 @@ intel_dp_detect(struct drm_connector *connector,
 	 * Some external monitors do not signal loss of link synchronization
 	 * with an IRQ_HPD, so force a link status check.
 	 */
-	if (!intel_dp_is_edp(intel_dp)) {
-		ret = intel_dp_retrain_link(encoder, ctx);
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_dp.c intel_dp_detect(struct drm_connector *connector, · line 5867

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_dp.c +2 -3
-		if (ret)
-			return ret;
-	}
+	if (!intel_dp_is_edp(intel_dp))
+		intel_dp_check_link_state(intel_dp);

I would like to see this hack nuked entirely. But that could be a followup.

Quoted 7 lines

Okay. This tries to keep the current behavior, but can add a note that the above workaround can be removed after the link state is checked after modesets.

I also wondered about the link state check in the hotplug handler. If that's only a way to defer doing this from the HPD IRQ handler - which is now changed by patch 13 - that could be also removed eventually?

Not sure which one you want to removed exactly. I presume there are still at least these cases we need to handle:
- long HDP dropped and came back without any userspace initiated modeset in between
-> kick off a retrain from the long HPD handler
- short HPD indicated some link badness
-> kick off a retrain from the short HDP handler
- link dropped on its own soon after modeset without any HPD for some reason
-> kick off a retrain from the post modeset link check

And the one we should remove:
- something weird happened to the link and no one noticed, and for some random reason userspace just happens to do a getconnector() which ends up randomly fixing things

Did I miss anything else?

Signature · 2 lines
Ville Syrjälä
Intel
author
#37 lore raw

Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

Quoted 39 lines · Ville Syrjälä
Quoted 30 lines · Imre Deak
Quoted 20 lines · Ville Syrjälä
Quoted 19 lines · Imre Deak

Simplify things by retraining a DP link if a bad link is detected in the connector detect handler from the encoder's check link state work, similarly to how this is done after a modeset link training failure.

---
 drivers/gpu/drm/i915/display/intel_dp.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +0 -2
index ff4ed6bb520d8..70b00e5ae7ad7 100644
@@ -5863,11 +5863,8 @@ intel_dp_detect(struct drm_connector *connector,
 	 * Some external monitors do not signal loss of link synchronization
 	 * with an IRQ_HPD, so force a link status check.
 	 */
-	if (!intel_dp_is_edp(intel_dp)) {
-		ret = intel_dp_retrain_link(encoder, ctx);
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_dp.c intel_dp_detect(struct drm_connector *connector, · line 5867

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_dp.c +2 -3
-		if (ret)
-			return ret;
-	}
+	if (!intel_dp_is_edp(intel_dp))
+		intel_dp_check_link_state(intel_dp);

I would like to see this hack nuked entirely. But that could be a followup.

Quoted 7 lines

Okay. This tries to keep the current behavior, but can add a note that the above workaround can be removed after the link state is checked after modesets.

I also wondered about the link state check in the hotplug handler. If that's only a way to defer doing this from the HPD IRQ handler - which is now changed by patch 13 - that could be also removed eventually?

Quoted 5 lines

Not sure which one you want to removed exactly. I presume there are still at least these cases we need to handle:
- long HDP dropped and came back without any userspace initiated modeset in between
-> kick off a retrain from the long HPD handler

I meant this one, but didn't think of the case where the link can be actually retrained after a long HPD. I guess with a full modeset it works, so should continue doing that.

Quoted 10 lines

- short HPD indicated some link badness
-> kick off a retrain from the short HDP handler
- link dropped on its own soon after modeset without any HPD for some reason
-> kick off a retrain from the post modeset link check

And the one we should remove:
- something weird happened to the link and no one noticed, and for some random reason userspace just happens to do a getconnector() which ends up randomly fixing things

Yes, this is clear.

Quoted 5 lines

Did I miss anything else?

Signature · 2 lines
Ville Syrjälä
Intel
#38 lore raw

PATCH v2 12/21 drm/i915/dp: Use check link state work in the detect handler

In reply to Imre Deak

A bad link in MST is not retrained. Please also consider MST.
The issue ticket is https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10902.

	if (intel_dp->is_mst) {
		/*
		 * If we are in MST mode then this connector
		 * won't appear connected or have anything
		 * with EDID on it
		 */
		status = connector_status_disconnected;
		goto out;
	}

	/*
	 * Some external monitors do not signal loss of link synchronization
	 * with an IRQ_HPD, so force a link status check.
	 */
	if (!intel_dp_is_edp(intel_dp)) {
		ret = intel_dp_retrain_link(encoder, ctx);
		if (ret)
			return ret;
	}
author
#39 lore raw

Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

On Mon, May 27, 2024 at 01:14:32PM +0800, [email protected] wrote:
Hi,

Quoted 14 lines

A bad link in MST is not retrained. Please also consider MST.
The issue ticket is https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10902.

	if (intel_dp->is_mst) {
		/*
		 * If we are in MST mode then this connector
		 * won't appear connected or have anything
		 * with EDID on it
		 */
		status = connector_status_disconnected;
		goto out;
	}

	/*
Quoted 8 lines
	 * Some external monitors do not signal loss of link synchronization
	 * with an IRQ_HPD, so force a link status check.
	 */
	if (!intel_dp_is_edp(intel_dp)) {
		ret = intel_dp_retrain_link(encoder, ctx);
		if (ret)
			return ret;
	}

this is not the proper place to retrain the link, the plan is to remove the above. Could you give a try to the patchset and follow up with a dmesg log on the ticket?

Thanks,
Imre

#40 lore raw

RE: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

Hi Max,

Please provide the test results.

Hi Imre,

Meanwhile, my question here is the link status is not checked in MST mode according to the current flow. The changes below
for MST are same as https://patchwork.freedesktop.org/patch/591953/?series=132685&rev=6. Please check it.

drivers/gpu/drm/i915/display/intel_dp.c +7 -7
index 0923a5adc14b..bf008a70304f 100644
@@ -5927,6 +5927,13 @@ intel_dp_detect(struct drm_connector *connector,
 
        intel_dp_print_rates(intel_dp);
 
+        /*
+         * Some external monitors do not signal loss of link synchronization
+         * with an IRQ_HPD, so force a link status check.
+         */
+        if (!intel_dp_is_edp(intel_dp))
+                intel_dp_check_link_state(intel_dp);
+
        if (intel_dp->is_mst) {
                /*
                 * If we are in MST mode then this connector
@@ -5937,13 +5944,6 @@ intel_dp_detect(struct drm_connector *connector,
                goto out;
        }
 
-       /*
-        * Some external monitors do not signal loss of link synchronization
-        * with an IRQ_HPD, so force a link status check.
-        */
-       if (!intel_dp_is_edp(intel_dp))
-               intel_dp_check_link_state(intel_dp);
-
        /*
         * Clearing NACK and defer counts to get their exact values
         * while reading EDID which are required by Compliance tests

Thanks,
Gareth

Quoted 41 lines

-----Original Message-----
From: Deak, Imre <[email protected]>
Sent: Monday, May 27, 2024 7:30 PM
To: Yu, Gareth <[email protected]>
Cc: [email protected]; Ville Syrjälä <[email protected]>
Subject: Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

On Mon, May 27, 2024 at 01:14:32PM +0800, [email protected] wrote:
Hi,

Quoted 2 lines

A bad link in MST is not retrained. Please also consider MST. The issue ticket is https://gitlab.freedesktop.org/drm/i915/kernel/-

/issues/10902.

Quoted 12 lines
	if (intel_dp->is_mst) {
		/*
		 * If we are in MST mode then this connector
		 * won't appear connected or have anything
		 * with EDID on it
		 */
		status = connector_status_disconnected;
		goto out;
	}

	/*
Quoted 8 lines
	 * Some external monitors do not signal loss of link synchronization
	 * with an IRQ_HPD, so force a link status check.
	 */
	if (!intel_dp_is_edp(intel_dp)) {
		ret = intel_dp_retrain_link(encoder, ctx);
		if (ret)
			return ret;
	}

this is not the proper place to retrain the link, the plan is to remove the above. Could you give a try to the patchset and follow up with a dmesg log on the ticket?

Thanks,
Imre

author
#41 lore raw

PATCH v2 13/21 drm/i915/dp: Use check link state work in the HPD IRQ handler

In reply to Imre Deak

Simplify things by retraining a DP link if a bad link is detected in the HPD IRQ handler from the encoder's check link state work, similarly to how this is done after a modeset link training failure.

---
 drivers/gpu/drm/i915/display/intel_dp.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +6 -4
index 70b00e5ae7ad7..b72dbd7becb74 100644
@@ -4950,6 +4950,7 @@ static bool
 intel_dp_check_mst_status(struct intel_dp *intel_dp)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
+	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
 	bool link_ok = true;
 	bool reprobe_needed = false;
 
@@ -4995,7 +4996,10 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp)
 			drm_dp_mst_hpd_irq_send_new_request(&intel_dp->mst_mgr);
 	}
 
-	return link_ok && !reprobe_needed;
+	if (!link_ok)
+		intel_ddi_queue_link_check(dig_port, 0);
+
+	return !reprobe_needed;
 }
 
 static void
@@ -5453,9 +5457,7 @@ intel_dp_short_pulse(struct intel_dp *intel_dp)
 	/* Handle CEC interrupts, if any */
 	drm_dp_cec_irq(&intel_dp->aux);
 
-	/* defer to the hotplug work for link retraining if needed */
-	if (intel_dp_needs_link_retrain(intel_dp))
-		return false;
+	intel_dp_check_link_state(intel_dp);
 
 	intel_psr_short_pulse(intel_dp);
 
Signature · 1 line
2.43.3
author
#42 lore raw

PATCH v2 14/21 drm/i915/dp: Disable link retraining after the last fallback step

In reply to Imre Deak

After a link training failure if the link parameters can't be further reduced, there is no point in trying to retrain the link in the driver. This avoids excessive retrain attempts after detecting a bad link, for instance while handling MST HPD IRQs, which is likely redundant as the link training failed already twice with the same minimum link parameters. Userspace can still try to retrain the link with these parameters via a modeset.

While at it make the error message more accurate and emit instead a debug message if the link training failure was only forced for testing purposes.

---
 .../drm/i915/display/intel_display_types.h    |  1 +
 drivers/gpu/drm/i915/display/intel_dp.c       |  4 ++++
 .../drm/i915/display/intel_dp_link_training.c | 22 +++++++++++++------
 3 files changed, 20 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
index bde518c843468..eb0cac3e27acf 100644
@@ -1765,6 +1765,7 @@ struct intel_dp {
 		int max_lane_count;
 		/* Max rate for the current link */
 		int max_rate;
+		bool retrain_disabled;
 		/* Sequential link training failures after a passing LT */
 		int seq_train_failures;
 	} link;
drivers/gpu/drm/i915/display/intel_dp.c +4 -0
index b72dbd7becb74..34d64fe3302ef 100644
@@ -2950,6 +2950,7 @@ static void intel_dp_reset_link_params(struct intel_dp *intel_dp)
 {
 	intel_dp->link.max_lane_count = intel_dp_max_common_lane_count(intel_dp);
 	intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
+	intel_dp->link.retrain_disabled = false;
 	intel_dp->link.seq_train_failures = 0;
 }
 
@@ -5061,6 +5062,9 @@ intel_dp_needs_link_retrain(struct intel_dp *intel_dp)
 					intel_dp->lane_count))
 		return false;
 
+	if (intel_dp->link.retrain_disabled)
+		return false;
+
 	if (intel_dp->link.seq_train_failures)
 		return true;
 
drivers/gpu/drm/i915/display/intel_dp_link_training.c +15 -7
index 97d499e4b6ef7..375f59afd4dec 100644
@@ -1165,10 +1165,8 @@ static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 		new_link_rate = intel_dp_max_common_rate(intel_dp);
 	}
 
-	if (new_lane_count < 0) {
-		drm_err(&i915->drm, "Link Training Unsuccessful\n");
+	if (new_lane_count < 0)
 		return -1;
-	}
 
 	if (intel_dp_is_edp(intel_dp) &&
 	    !intel_dp_can_link_train_fallback_for_edp(intel_dp, new_link_rate, new_lane_count)) {
@@ -1187,7 +1185,7 @@ static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 	return 0;
 }
 
-static void intel_dp_schedule_fallback_link_training(struct intel_atomic_state *state,
+static bool intel_dp_schedule_fallback_link_training(struct intel_atomic_state *state,
 						     struct intel_dp *intel_dp,
 						     const struct intel_crtc_state *crtc_state)
 {
@@ -1195,7 +1193,7 @@ static void intel_dp_schedule_fallback_link_training(struct intel_atomic_state *
 
 	if (!intel_digital_port_connected(&dp_to_dig_port(intel_dp)->base)) {
 		lt_dbg(intel_dp, DP_PHY_DPRX, "Link Training failed on disconnected sink.\n");
-		return;
+		return true;
 	}
 
 	if (intel_dp->hobl_active) {
@@ -1203,11 +1201,13 @@ static void intel_dp_schedule_fallback_link_training(struct intel_atomic_state *
 		       "Link Training failed with HOBL active, not enabling it from now on\n");
 		intel_dp->hobl_failed = true;
 	} else if (intel_dp_get_link_train_fallback_values(intel_dp, crtc_state)) {
-		return;
+		return false;
 	}
 
 	/* Schedule a Hotplug Uevent to userspace to start modeset */
 	intel_dp_queue_modeset_retry_for_link(state, encoder, crtc_state);
+
+	return true;
 }
 
 /* Perform the link training on all LTTPRs and the DPRX on a link. */
@@ -1518,7 +1518,15 @@ void intel_dp_start_link_train(struct intel_atomic_state *state,
 		return;
 	}
 
-	intel_dp_schedule_fallback_link_training(state, intel_dp, crtc_state);
+	if (intel_dp_schedule_fallback_link_training(state, intel_dp, crtc_state))
+		return;
+
+	intel_dp->link.retrain_disabled = true;
+
+	if (!passed)
+		lt_err(intel_dp, DP_PHY_DPRX, "Can't reduce link training parameters after failure\n");
+	else
+		lt_dbg(intel_dp, DP_PHY_DPRX, "Can't reduce link training parameters after forced failure\n");
 }
 
 void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp,
Signature · 1 line
2.43.3
#43 lore raw

Re: [PATCH v2 14/21] drm/i915/dp: Disable link retraining after the last fallback step

Quoted 106 lines · Imre Deak

After a link training failure if the link parameters can't be further reduced, there is no point in trying to retrain the link in the driver. This avoids excessive retrain attempts after detecting a bad link, for instance while handling MST HPD IRQs, which is likely redundant as the link training failed already twice with the same minimum link parameters. Userspace can still try to retrain the link with these parameters via a modeset.

While at it make the error message more accurate and emit instead a debug message if the link training failure was only forced for testing purposes.

---
 .../drm/i915/display/intel_display_types.h    |  1 +
 drivers/gpu/drm/i915/display/intel_dp.c       |  4 ++++
 .../drm/i915/display/intel_dp_link_training.c | 22 +++++++++++++------
 3 files changed, 20 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
index bde518c843468..eb0cac3e27acf 100644
@@ -1765,6 +1765,7 @@ struct intel_dp {
 		int max_lane_count;
 		/* Max rate for the current link */
 		int max_rate;
+		bool retrain_disabled;
 		/* Sequential link training failures after a passing LT */
 		int seq_train_failures;
 	} link;
drivers/gpu/drm/i915/display/intel_dp.c +4 -0
index b72dbd7becb74..34d64fe3302ef 100644
@@ -2950,6 +2950,7 @@ static void intel_dp_reset_link_params(struct intel_dp *intel_dp)
 {
 	intel_dp->link.max_lane_count = intel_dp_max_common_lane_count(intel_dp);
 	intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
+	intel_dp->link.retrain_disabled = false;
 	intel_dp->link.seq_train_failures = 0;
 }
 
@@ -5061,6 +5062,9 @@ intel_dp_needs_link_retrain(struct intel_dp *intel_dp)
 					intel_dp->lane_count))
 		return false;
 
+	if (intel_dp->link.retrain_disabled)
+		return false;
+
 	if (intel_dp->link.seq_train_failures)
 		return true;
 
drivers/gpu/drm/i915/display/intel_dp_link_training.c +6 -6
index 97d499e4b6ef7..375f59afd4dec 100644
@@ -1165,10 +1165,8 @@ static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 		new_link_rate = intel_dp_max_common_rate(intel_dp);
 	}
 
-	if (new_lane_count < 0) {
-		drm_err(&i915->drm, "Link Training Unsuccessful\n");
+	if (new_lane_count < 0)
 		return -1;
-	}
 
 	if (intel_dp_is_edp(intel_dp) &&
 	    !intel_dp_can_link_train_fallback_for_edp(intel_dp, new_link_rate, new_lane_count)) {
@@ -1187,7 +1185,7 @@ static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 	return 0;
 }
 
-static void intel_dp_schedule_fallback_link_training(struct intel_atomic_state *state,
+static bool intel_dp_schedule_fallback_link_training(struct intel_atomic_state *state,
 						     struct intel_dp *intel_dp,
 						     const struct intel_crtc_state *crtc_state)
 {
@@ -1195,7 +1193,7 @@ static void intel_dp_schedule_fallback_link_training(struct intel_atomic_state *
 
 	if (!intel_digital_port_connected(&dp_to_dig_port(intel_dp)->base)) {
 		lt_dbg(intel_dp, DP_PHY_DPRX, "Link Training failed on disconnected sink.\n");
-		return;
+		return true;
 	}
 
 	if (intel_dp->hobl_active) {
@@ -1203,11 +1201,13 @@ static void intel_dp_schedule_fallback_link_training(struct intel_atomic_state *
 		       "Link Training failed with HOBL active, not enabling it from now on\n");
 		intel_dp->hobl_failed = true;
 	} else if (intel_dp_get_link_train_fallback_values(intel_dp, crtc_state)) {
-		return;
+		return false;
 	}
 
 	/* Schedule a Hotplug Uevent to userspace to start modeset */
 	intel_dp_queue_modeset_retry_for_link(state, encoder, crtc_state);
+
+	return true;
 }
 
 /* Perform the link training on all LTTPRs and the DPRX on a link. */
@@ -1518,7 +1518,15 @@ void intel_dp_start_link_train(struct intel_atomic_state *state,
 		return;
 	}
 

drivers/gpu/drm/i915/display/intel_dp_link_training.c void intel_dp_start_link_train(struct intel_atomic_state *state, · line 1529

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +9 -1
-	intel_dp_schedule_fallback_link_training(state, intel_dp, crtc_state);
+	if (intel_dp_schedule_fallback_link_training(state, intel_dp, crtc_state))
+		return;
+
+	intel_dp->link.retrain_disabled = true;
+
+	if (!passed)
+		lt_err(intel_dp, DP_PHY_DPRX, "Can't reduce link training parameters after failure\n");
+	else
+		lt_dbg(intel_dp, DP_PHY_DPRX, "Can't reduce link training parameters after forced failure\n");

The forced failure stuff is in later patch, is it not?

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +0 -0
 }
 
 void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp,
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
author
#44 lore raw

Re: [PATCH v2 14/21] drm/i915/dp: Disable link retraining after the last fallback step

Quoted 107 lines · Ville Syrjälä
Quoted 106 lines · Imre Deak

After a link training failure if the link parameters can't be further reduced, there is no point in trying to retrain the link in the driver. This avoids excessive retrain attempts after detecting a bad link, for instance while handling MST HPD IRQs, which is likely redundant as the link training failed already twice with the same minimum link parameters. Userspace can still try to retrain the link with these parameters via a modeset.

While at it make the error message more accurate and emit instead a debug message if the link training failure was only forced for testing purposes.

---
 .../drm/i915/display/intel_display_types.h    |  1 +
 drivers/gpu/drm/i915/display/intel_dp.c       |  4 ++++
 .../drm/i915/display/intel_dp_link_training.c | 22 +++++++++++++------
 3 files changed, 20 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
index bde518c843468..eb0cac3e27acf 100644
@@ -1765,6 +1765,7 @@ struct intel_dp {
 		int max_lane_count;
 		/* Max rate for the current link */
 		int max_rate;
+		bool retrain_disabled;
 		/* Sequential link training failures after a passing LT */
 		int seq_train_failures;
 	} link;
drivers/gpu/drm/i915/display/intel_dp.c +4 -0
index b72dbd7becb74..34d64fe3302ef 100644
@@ -2950,6 +2950,7 @@ static void intel_dp_reset_link_params(struct intel_dp *intel_dp)
 {
 	intel_dp->link.max_lane_count = intel_dp_max_common_lane_count(intel_dp);
 	intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
+	intel_dp->link.retrain_disabled = false;
 	intel_dp->link.seq_train_failures = 0;
 }
 
@@ -5061,6 +5062,9 @@ intel_dp_needs_link_retrain(struct intel_dp *intel_dp)
 					intel_dp->lane_count))
 		return false;
 
+	if (intel_dp->link.retrain_disabled)
+		return false;
+
 	if (intel_dp->link.seq_train_failures)
 		return true;
 
drivers/gpu/drm/i915/display/intel_dp_link_training.c +6 -6
index 97d499e4b6ef7..375f59afd4dec 100644
@@ -1165,10 +1165,8 @@ static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 		new_link_rate = intel_dp_max_common_rate(intel_dp);
 	}
 
-	if (new_lane_count < 0) {
-		drm_err(&i915->drm, "Link Training Unsuccessful\n");
+	if (new_lane_count < 0)
 		return -1;
-	}
 
 	if (intel_dp_is_edp(intel_dp) &&
 	    !intel_dp_can_link_train_fallback_for_edp(intel_dp, new_link_rate, new_lane_count)) {
@@ -1187,7 +1185,7 @@ static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 	return 0;
 }
 
-static void intel_dp_schedule_fallback_link_training(struct intel_atomic_state *state,
+static bool intel_dp_schedule_fallback_link_training(struct intel_atomic_state *state,
 						     struct intel_dp *intel_dp,
 						     const struct intel_crtc_state *crtc_state)
 {
@@ -1195,7 +1193,7 @@ static void intel_dp_schedule_fallback_link_training(struct intel_atomic_state *
 
 	if (!intel_digital_port_connected(&dp_to_dig_port(intel_dp)->base)) {
 		lt_dbg(intel_dp, DP_PHY_DPRX, "Link Training failed on disconnected sink.\n");
-		return;
+		return true;
 	}
 
 	if (intel_dp->hobl_active) {
@@ -1203,11 +1201,13 @@ static void intel_dp_schedule_fallback_link_training(struct intel_atomic_state *
 		       "Link Training failed with HOBL active, not enabling it from now on\n");
 		intel_dp->hobl_failed = true;
 	} else if (intel_dp_get_link_train_fallback_values(intel_dp, crtc_state)) {
-		return;
+		return false;
 	}
 
 	/* Schedule a Hotplug Uevent to userspace to start modeset */
 	intel_dp_queue_modeset_retry_for_link(state, encoder, crtc_state);
+
+	return true;
 }
 
 /* Perform the link training on all LTTPRs and the DPRX on a link. */
@@ -1518,7 +1518,15 @@ void intel_dp_start_link_train(struct intel_atomic_state *state,
 		return;
 	}
 
Quoted 12 lines

drivers/gpu/drm/i915/display/intel_dp_link_training.c void intel_dp_start_link_train(struct intel_atomic_state *state, · line 1529

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +9 -1
-	intel_dp_schedule_fallback_link_training(state, intel_dp, crtc_state);
+	if (intel_dp_schedule_fallback_link_training(state, intel_dp, crtc_state))
+		return;
+
+	intel_dp->link.retrain_disabled = true;
+
+	if (!passed)
+		lt_err(intel_dp, DP_PHY_DPRX, "Can't reduce link training parameters after failure\n");
+	else
+		lt_dbg(intel_dp, DP_PHY_DPRX, "Can't reduce link training parameters after forced failure\n");

The forced failure stuff is in later patch, is it not?

Yes, I had a different patch order earlier, will move the error->debug message change there.

Quoted 10 lines
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +0 -0
 }
 
 void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp,
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
author
#45 lore raw

PATCH v2 15/21 drm/i915/dp_mst: Reset intel_dp->link_trained during disabling

In reply to Imre Deak

Reset the flag indicating an active link after disabling an MST link, similarly to how this is done for SST outputs. This avoids trying to retrain an MST link while its disabled.

---
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/display/intel_dp_mst.c +3 -0
index c9c5d235744ab..66c1c59268167 100644
@@ -981,6 +981,9 @@ static void intel_mst_disable_dp(struct intel_atomic_state *state,
 	drm_dbg_kms(&i915->drm, "active links %d\n",
 		    intel_dp->active_mst_links);
 
+	if (intel_dp->active_mst_links == 1)
+		intel_dp->link_trained = false;
+
 	intel_hdcp_disable(intel_mst->connector);
 
 	intel_dp_sink_disable_decompression(state, connector, old_crtc_state);
Signature · 1 line
2.43.3
author
#46 lore raw

PATCH v2 16/21 drm/i915/dp_mst: Enable link training fallback for MST

In reply to Imre Deak

Reduce the link parameters after a link training failure for MST outputs, similarly to how this is done for SST.

For now allow the reduction only by staying in the 8b/10b vs. 128b/132b mode. Enabling the mode switch is left for a follow-up patchset, after taking measures ensuring that the mode switch happens properly. In particular a rediscovery of the whole MST topology may be required for such a switch, see the References below.

---
 drivers/gpu/drm/i915/display/intel_dp.c             |  6 +-----
 .../gpu/drm/i915/display/intel_dp_link_training.c   | 13 ++++---------
 2 files changed, 5 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +1 -5
index 34d64fe3302ef..c8d940a2ef7af 100644
@@ -5844,11 +5844,7 @@ intel_dp_detect(struct drm_connector *connector,
 
 	intel_dp_mst_configure(intel_dp);
 
-	/*
-	 * TODO: Reset link params when switching to MST mode, until MST
-	 * supports link training fallback params.
-	 */
-	if (intel_dp->reset_link_params || intel_dp->is_mst) {
+	if (intel_dp->reset_link_params) {
 		intel_dp_reset_link_params(intel_dp);
 		intel_dp->reset_link_params = false;
 	}
drivers/gpu/drm/i915/display/intel_dp_link_training.c +4 -9
index 375f59afd4dec..9a59a28ca36d2 100644
@@ -1124,6 +1124,10 @@ static int reduce_link_rate(struct intel_dp *intel_dp, int current_rate)
 
 	new_rate = intel_dp_common_rate(intel_dp, rate_index - 1);
 
+	/* TODO: Make switching from UHBR to non-UHBR rates work. */
+	if (drm_dp_is_uhbr_rate(current_rate) != drm_dp_is_uhbr_rate(new_rate))
+		return -1;
+
 	return new_rate;
 }
 
@@ -1142,15 +1146,6 @@ static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 	int new_link_rate;
 	int new_lane_count;
 
-	/*
-	 * TODO: Enable fallback on MST links once MST link compute can handle
-	 * the fallback params.
-	 */
-	if (intel_dp->is_mst) {
-		drm_err(&i915->drm, "Link Training Unsuccessful\n");
-		return -1;
-	}
-
 	if (intel_dp_is_edp(intel_dp) && !intel_dp->use_max_params) {
 		drm_dbg_kms(&i915->drm,
 			    "Retrying Link training for eDP with max parameters\n");
Signature · 1 line
2.43.3
author
#47 lore raw

PATCH v2 17/21 drm/i915/dp: Add debugfs entries to set a target link rate/lane count

In reply to Imre Deak

Add connector debugfs entries to set a target link rate/lane count to be used by a link training afterwards. After setting a target link rate/lane count reset the link training parameters and for a non-auto target disable reducing the link parameters via the fallback logic. The former one can be used after testing link training failure scenarios
- via debugfs entries added later - to reset the reduced link parameters after the test.

v2:
- Add the entries from intel_dp_link_training.c (Jani)
- Rename the entries to i915_dp_set_link_rate/lane_count.

---
 .../drm/i915/display/intel_display_debugfs.c  |   2 +
 .../drm/i915/display/intel_display_types.h    |   2 +
 drivers/gpu/drm/i915/display/intel_dp.c       |  63 ++++-
 drivers/gpu/drm/i915/display/intel_dp.h       |   2 +
 .../drm/i915/display/intel_dp_link_training.c | 230 ++++++++++++++++++
 .../drm/i915/display/intel_dp_link_training.h |   4 +
 6 files changed, 294 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_display_debugfs.c +2 -0
index 35f9f86ef70f4..f83ffa2534925 100644
@@ -23,6 +23,7 @@
 #include "intel_display_types.h"
 #include "intel_dmc.h"
 #include "intel_dp.h"
+#include "intel_dp_link_training.h"
 #include "intel_dp_mst.h"
 #include "intel_drrs.h"
 #include "intel_fbc.h"
@@ -1515,6 +1516,7 @@ void intel_connector_debugfs_add(struct intel_connector *connector)
 	intel_drrs_connector_debugfs_add(connector);
 	intel_pps_connector_debugfs_add(connector);
 	intel_psr_connector_debugfs_add(connector);
+	intel_dp_link_training_debugfs_add(connector);
 
 	if (connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
 	    connector_type == DRM_MODE_CONNECTOR_HDMIA ||
drivers/gpu/drm/i915/display/intel_display_types.h +2 -0
index eb0cac3e27acf..e1c41cece249d 100644
@@ -1765,6 +1765,8 @@ struct intel_dp {
 		int max_lane_count;
 		/* Max rate for the current link */
 		int max_rate;
+		int requested_lane_count;
+		int requested_rate;
 		bool retrain_disabled;
 		/* Sequential link training failures after a passing LT */
 		int seq_train_failures;
drivers/gpu/drm/i915/display/intel_dp.c +54 -9

124 lines not on this page · raw message

drivers/gpu/drm/i915/display/intel_dp.h +2 -0
index 3fa53ac601d58..79914e5080251 100644
@@ -99,6 +99,7 @@ void intel_edp_backlight_off(const struct drm_connector_state *conn_state);
 void intel_edp_fixup_vbt_bpp(struct intel_encoder *encoder, int pipe_bpp);
 void intel_dp_mst_suspend(struct drm_i915_private *dev_priv);
 void intel_dp_mst_resume(struct drm_i915_private *dev_priv);
+int intel_dp_max_source_lane_count(struct intel_digital_port *dig_port);
 int intel_dp_max_link_rate(struct intel_dp *intel_dp);
 int intel_dp_max_lane_count(struct intel_dp *intel_dp);
 int intel_dp_config_required_rate(const struct intel_crtc_state *crtc_state);
@@ -108,6 +109,7 @@ int intel_dp_max_common_lane_count(struct intel_dp *intel_dp);
 int intel_dp_common_rate(struct intel_dp *intel_dp, int index);
 int intel_dp_rate_index(const int *rates, int len, int rate);
 void intel_dp_update_sink_caps(struct intel_dp *intel_dp);
+void intel_dp_reset_link_params(struct intel_dp *intel_dp);
 
 void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock,
 			   u8 *link_bw, u8 *rate_select);
drivers/gpu/drm/i915/display/intel_dp_link_training.c +230 -0

245 lines not on this page · raw message

drivers/gpu/drm/i915/display/intel_dp_link_training.h +4 -0
index f658230960333..42e7fc6cb171a 100644
@@ -9,6 +9,7 @@
 #include <drm/display/drm_dp_helper.h>
 
 struct intel_atomic_state;
+struct intel_connector;
 struct intel_crtc_state;
 struct intel_dp;
 
@@ -44,4 +45,7 @@ static inline u8 intel_dp_training_pattern_symbol(u8 pattern)
 
 void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp,
 				 const struct intel_crtc_state *crtc_state);
+
+void intel_dp_link_training_debugfs_add(struct intel_connector *connector);
+
 #endif /* __INTEL_DP_LINK_TRAINING_H__ */
Signature · 1 line
2.43.3
#48 lore raw

Re: [PATCH v2 17/21] drm/i915/dp: Add debugfs entries to set a target link rate/lane count

Quoted 48 lines · Imre Deak

Add connector debugfs entries to set a target link rate/lane count to be used by a link training afterwards. After setting a target link rate/lane count reset the link training parameters and for a non-auto target disable reducing the link parameters via the fallback logic. The former one can be used after testing link training failure scenarios
- via debugfs entries added later - to reset the reduced link parameters after the test.

v2:
- Add the entries from intel_dp_link_training.c (Jani)
- Rename the entries to i915_dp_set_link_rate/lane_count.

---
 .../drm/i915/display/intel_display_debugfs.c  |   2 +
 .../drm/i915/display/intel_display_types.h    |   2 +
 drivers/gpu/drm/i915/display/intel_dp.c       |  63 ++++-
 drivers/gpu/drm/i915/display/intel_dp.h       |   2 +
 .../drm/i915/display/intel_dp_link_training.c | 230 ++++++++++++++++++
 .../drm/i915/display/intel_dp_link_training.h |   4 +
 6 files changed, 294 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_display_debugfs.c +2 -0
index 35f9f86ef70f4..f83ffa2534925 100644
@@ -23,6 +23,7 @@
 #include "intel_display_types.h"
 #include "intel_dmc.h"
 #include "intel_dp.h"
+#include "intel_dp_link_training.h"
 #include "intel_dp_mst.h"
 #include "intel_drrs.h"
 #include "intel_fbc.h"
@@ -1515,6 +1516,7 @@ void intel_connector_debugfs_add(struct intel_connector *connector)
 	intel_drrs_connector_debugfs_add(connector);
 	intel_pps_connector_debugfs_add(connector);
 	intel_psr_connector_debugfs_add(connector);
+	intel_dp_link_training_debugfs_add(connector);
 
 	if (connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
 	    connector_type == DRM_MODE_CONNECTOR_HDMIA ||
drivers/gpu/drm/i915/display/intel_display_types.h +0 -0
index eb0cac3e27acf..e1c41cece249d 100644

drivers/gpu/drm/i915/display/intel_display_types.h struct intel_dp { · line 1769

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display_types.h +2 -0
@@ -1765,6 +1765,8 @@ struct intel_dp {
 		int max_lane_count;
 		/* Max rate for the current link */
 		int max_rate;
+		int requested_lane_count;
+		int requested_rate;

"requested" is perhaps a bit weak. Maybe "force" or "override" although perhaps those might give the impression that it ignores the sink limits or something?

Quoted 116 lines
drivers/gpu/drm/i915/display/intel_display_types.h +0 -0
 		bool retrain_disabled;
 		/* Sequential link training failures after a passing LT */
 		int seq_train_failures;
drivers/gpu/drm/i915/display/intel_dp.c +49 -6
index c8d940a2ef7af..cf4a768fccd15 100644
@@ -345,7 +345,7 @@ int intel_dp_max_common_rate(struct intel_dp *intel_dp)
 	return intel_dp_common_rate(intel_dp, intel_dp->num_common_rates - 1);
 }
 
-static int intel_dp_max_source_lane_count(struct intel_digital_port *dig_port)
+int intel_dp_max_source_lane_count(struct intel_digital_port *dig_port)
 {
 	int vbt_max_lanes = intel_bios_dp_max_lane_count(dig_port->base.devdata);
 	int max_lanes = dig_port->max_lanes;
@@ -371,19 +371,39 @@ int intel_dp_max_common_lane_count(struct intel_dp *intel_dp)
 	return min3(source_max, sink_max, lane_max);
 }
 
+static int requested_lane_count(struct intel_dp *intel_dp)
+{
+	return clamp(intel_dp->link.requested_lane_count, 1, intel_dp_max_common_lane_count(intel_dp));
+}
+
 int intel_dp_max_lane_count(struct intel_dp *intel_dp)
 {
-	switch (intel_dp->link.max_lane_count) {
+	int lane_count;
+
+	if (intel_dp->link.requested_lane_count)
+		lane_count = requested_lane_count(intel_dp);
+	else
+		lane_count = intel_dp->link.max_lane_count;
+
+	switch (lane_count) {
 	case 1:
 	case 2:
 	case 4:
-		return intel_dp->link.max_lane_count;
+		return lane_count;
 	default:
-		MISSING_CASE(intel_dp->link.max_lane_count);
+		MISSING_CASE(lane_count);
 		return 1;
 	}
 }
 
+static int intel_dp_min_lane_count(struct intel_dp *intel_dp)
+{
+	if (intel_dp->link.requested_lane_count)
+		return requested_lane_count(intel_dp);
+
+	return 1;
+}
+
 /*
  * The required data bandwidth for a mode with given pixel clock and bpp. This
  * is the required net bandwidth independent of the data bandwidth efficiency.
@@ -1306,16 +1326,38 @@ static void intel_dp_print_rates(struct intel_dp *intel_dp)
 	drm_dbg_kms(&i915->drm, "common rates: %s\n", str);
 }
 
+static int requested_rate(struct intel_dp *intel_dp)
+{
+	int len = intel_dp_common_len_rate_limit(intel_dp, intel_dp->link.requested_rate);
+
+	if (len == 0)
+		return intel_dp_common_rate(intel_dp, 0);
+
+	return intel_dp_common_rate(intel_dp, len - 1);
+}
+
 int
 intel_dp_max_link_rate(struct intel_dp *intel_dp)
 {
 	int len;
 
+	if (intel_dp->link.requested_rate)
+		return requested_rate(intel_dp);
+
 	len = intel_dp_common_len_rate_limit(intel_dp, intel_dp->link.max_rate);
 
 	return intel_dp_common_rate(intel_dp, len - 1);
 }
 
+static int
+intel_dp_min_link_rate(struct intel_dp *intel_dp)
+{
+	if (intel_dp->link.requested_rate)
+		return requested_rate(intel_dp);
+
+	return intel_dp_common_rate(intel_dp, 0);
+}
+
 int intel_dp_rate_select(struct intel_dp *intel_dp, int rate)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
@@ -2285,13 +2327,14 @@ intel_dp_compute_config_limits(struct intel_dp *intel_dp,
 			       bool dsc,
 			       struct link_config_limits *limits)
 {
-	limits->min_rate = intel_dp_common_rate(intel_dp, 0);
+	limits->min_rate = intel_dp_min_link_rate(intel_dp);
 	limits->max_rate = intel_dp_max_link_rate(intel_dp);
 
 	/* FIXME 128b/132b SST support missing */
 	limits->max_rate = min(limits->max_rate, 810000);
+	limits->min_rate = min(limits->min_rate, limits->max_rate);
 
-	limits->min_lane_count = 1;
+	limits->min_lane_count = intel_dp_min_lane_count(intel_dp);
 	limits->max_lane_count = intel_dp_max_lane_count(intel_dp);
 
 	limits->pipe.min_bpp = intel_dp_min_bpp(crtc_state->output_format);

drivers/gpu/drm/i915/display/intel_dp.c intel_dp_compute_config_limits(struct intel_dp *intel_dp, · line 2356

Quoted 9 lines
drivers/gpu/drm/i915/display/intel_dp.c +4 -2
@@ -2307,8 +2350,10 @@ intel_dp_compute_config_limits(struct intel_dp *intel_dp,
 		 * configuration, and typically on older panels these
 		 * values correspond to the native resolution of the panel.
 		 */
-		limits->min_lane_count = limits->max_lane_count;
-		limits->min_rate = limits->max_rate;
+		if (intel_dp->link.requested_lane_count == 0)
+			limits->min_lane_count = limits->max_lane_count;
+		if (intel_dp->link.requested_rate == 0)
+			limits->min_rate = limits->max_rate;

Aren't the min and max the same anyway if the debugfs override is in use?

Quoted 68 lines
drivers/gpu/drm/i915/display/intel_dp.c +1 -1
 	}
 
 	intel_dp_adjust_compliance_config(intel_dp, crtc_state, limits);
@@ -2946,7 +2991,7 @@ void intel_dp_set_link_params(struct intel_dp *intel_dp,
 	intel_dp->lane_count = lane_count;
 }
 
-static void intel_dp_reset_link_params(struct intel_dp *intel_dp)
+void intel_dp_reset_link_params(struct intel_dp *intel_dp)
 {
 	intel_dp->link.max_lane_count = intel_dp_max_common_lane_count(intel_dp);
 	intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
drivers/gpu/drm/i915/display/intel_dp.h +2 -0
index 3fa53ac601d58..79914e5080251 100644
@@ -99,6 +99,7 @@ void intel_edp_backlight_off(const struct drm_connector_state *conn_state);
 void intel_edp_fixup_vbt_bpp(struct intel_encoder *encoder, int pipe_bpp);
 void intel_dp_mst_suspend(struct drm_i915_private *dev_priv);
 void intel_dp_mst_resume(struct drm_i915_private *dev_priv);
+int intel_dp_max_source_lane_count(struct intel_digital_port *dig_port);
 int intel_dp_max_link_rate(struct intel_dp *intel_dp);
 int intel_dp_max_lane_count(struct intel_dp *intel_dp);
 int intel_dp_config_required_rate(const struct intel_crtc_state *crtc_state);
@@ -108,6 +109,7 @@ int intel_dp_max_common_lane_count(struct intel_dp *intel_dp);
 int intel_dp_common_rate(struct intel_dp *intel_dp, int index);
 int intel_dp_rate_index(const int *rates, int len, int rate);
 void intel_dp_update_sink_caps(struct intel_dp *intel_dp);
+void intel_dp_reset_link_params(struct intel_dp *intel_dp);
 
 void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock,
 			   u8 *link_bw, u8 *rate_select);
drivers/gpu/drm/i915/display/intel_dp_link_training.c +14 -0
index 9a59a28ca36d2..a6021e17cc1ef 100644
@@ -1115,6 +1115,9 @@ static int reduce_link_rate(struct intel_dp *intel_dp, int current_rate)
 	int rate_index;
 	int new_rate;
 
+	if (intel_dp->link.requested_rate)
+		return -1;
+
 	rate_index = intel_dp_rate_index(intel_dp->common_rates,
 					 intel_dp->num_common_rates,
 					 current_rate);
@@ -1133,6 +1136,9 @@ static int reduce_link_rate(struct intel_dp *intel_dp, int current_rate)
 
 static int reduce_lane_count(struct intel_dp *intel_dp, int current_lane_count)
 {
+	if (intel_dp->link.requested_lane_count)
+		return -1;
+
 	if (current_lane_count > 1)
 		return current_lane_count >> 1;
 
@@ -1543,3 +1549,227 @@ void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp,
 
 	lt_dbg(intel_dp, DP_PHY_DPRX, "DP2.0 SDP CRC16 for 128b/132b enabled\n");
 }
+
+static struct intel_dp *intel_connector_to_intel_dp(struct intel_connector *connector)
+{
+	if (connector->mst_port)
+		return connector->mst_port;
+	else
+		return enc_to_intel_dp(intel_attached_encoder(connector));
+}

drivers/gpu/drm/i915/display/intel_dp_link_training.c void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp, · line 1569

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +10 -0
+
+static int i915_dp_set_link_rate_show(struct seq_file *m, void *data)
+{
+	struct intel_connector *connector = to_intel_connector(m->private);
+	struct drm_i915_private *i915 = to_i915(connector->base.dev);
+	struct intel_dp *intel_dp;
+	int ret;
+	int i;
+
+	ret = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex);

What is this lock protecting exactly?

Quoted 228 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +206 -0
+	if (ret)
+		return ret;
+
+	intel_dp = intel_connector_to_intel_dp(connector);
+
+	seq_printf(m, "%sauto%s",
+		   intel_dp->link.requested_rate == 0 ? "[" : "",
+		   intel_dp->link.requested_rate == 0 ? "]" : "");
+
+	for (i = 0; i < intel_dp->num_source_rates; i++)
+		seq_printf(m, " %s%d%s%s",
+			   intel_dp->source_rates[i] == intel_dp->link.requested_rate ? "[" : "",
+			   intel_dp->source_rates[i],
+			   intel_dp->link_trained &&
+				intel_dp->source_rates[i] == intel_dp->link_rate ? "*" : "",
+			   intel_dp->source_rates[i] == intel_dp->link.requested_rate ? "]" : "");
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	seq_putc(m, '\n');
+
+	return 0;
+}
+
+static int parse_link_rate(struct intel_dp *intel_dp, const char __user *ubuf, size_t len)
+{
+	char *kbuf;
+	const char *p;
+	int rate;
+	int ret = 0;
+
+	kbuf = memdup_user_nul(ubuf, len);
+	if (IS_ERR(kbuf))
+		return PTR_ERR(kbuf);
+
+	p = strim(kbuf);
+
+	if (!strcmp(p, "auto")) {
+		rate = 0;
+	} else {
+		ret = kstrtoint(p, 0, &rate);
+		if (ret < 0)
+			goto out_free;
+
+		if (intel_dp_rate_index(intel_dp->source_rates,
+					intel_dp->num_source_rates,
+					rate) < 0)
+			ret = -EINVAL;
+	}
+
+out_free:
+	kfree(kbuf);
+
+	return ret < 0 ? ret : rate;
+}
+
+static ssize_t i915_dp_set_link_rate_write(struct file *file,
+					   const char __user *ubuf,
+					   size_t len, loff_t *offp)
+{
+	struct seq_file *m = file->private_data;
+	struct intel_connector *connector = to_intel_connector(m->private);
+	struct drm_i915_private *i915 = to_i915(connector->base.dev);
+	struct intel_dp *intel_dp = intel_connector_to_intel_dp(connector);
+	int rate;
+	int ret;
+
+	ret = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex);
+	if (ret)
+		return ret;
+
+	intel_dp = intel_connector_to_intel_dp(connector);
+
+	rate = parse_link_rate(intel_dp, ubuf, len);
+	if (rate < 0) {
+		drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+		return rate;
+	}
+
+	intel_dp_reset_link_params(intel_dp);
+	intel_dp->link.requested_rate = rate;
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	*offp += len;
+
+	return len;
+}
+DEFINE_SHOW_STORE_ATTRIBUTE(i915_dp_set_link_rate);
+
+static int i915_dp_set_lane_count_show(struct seq_file *m, void *data)
+{
+	struct intel_connector *connector = to_intel_connector(m->private);
+	struct drm_i915_private *i915 = to_i915(connector->base.dev);
+	struct intel_dp *intel_dp;
+	int ret;
+	int i;
+
+	ret = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex);
+	if (ret)
+		return ret;
+
+	intel_dp = intel_connector_to_intel_dp(connector);
+
+	seq_printf(m, "%sauto%s",
+		   intel_dp->link.requested_lane_count == 0 ? "[" : "",
+		   intel_dp->link.requested_lane_count == 0 ? "]" : "");
+
+	for (i = 1; i <= 4; i <<= 1)
+		seq_printf(m, " %s%d%s%s",
+			   i == intel_dp->link.requested_lane_count ? "[" : "",
+			   i,
+			   intel_dp->link_trained &&
+				i == intel_dp->lane_count ? "*" : "",
+			   i == intel_dp->link.requested_lane_count ? "]" : "");
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	seq_putc(m, '\n');
+
+	return 0;
+}
+
+static int parse_lane_count(const char __user *ubuf, size_t len)
+{
+	char *kbuf;
+	const char *p;
+	int lane_count;
+	int ret = 0;
+
+	kbuf = memdup_user_nul(ubuf, len);
+	if (IS_ERR(kbuf))
+		return PTR_ERR(kbuf);
+
+	p = strim(kbuf);
+
+	if (!strcmp(p, "auto")) {
+		lane_count = 0;
+	} else {
+		ret = kstrtoint(p, 0, &lane_count);
+		if (ret < 0)
+			goto out_free;
+
+		switch (lane_count) {
+		case 1:
+		case 2:
+		case 4:
+			break;
+		default:
+			ret = -EINVAL;
+		}
+	}
+
+out_free:
+	kfree(kbuf);
+
+	return ret < 0 ? ret : lane_count;
+}
+
+static ssize_t i915_dp_set_lane_count_write(struct file *file,
+					    const char __user *ubuf,
+					    size_t len, loff_t *offp)
+{
+	struct seq_file *m = file->private_data;
+	struct intel_connector *connector = to_intel_connector(m->private);
+	struct drm_i915_private *i915 = to_i915(connector->base.dev);
+	struct intel_dp *intel_dp;
+	int lane_count;
+	int ret;
+
+	lane_count = parse_lane_count(ubuf, len);
+	if (lane_count < 0)
+		return lane_count;
+
+	ret = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex);
+	if (ret)
+		return ret;
+
+	intel_dp = intel_connector_to_intel_dp(connector);
+
+	intel_dp_reset_link_params(intel_dp);
+	intel_dp->link.requested_lane_count = lane_count;
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	*offp += len;
+
+	return len;
+}
+DEFINE_SHOW_STORE_ATTRIBUTE(i915_dp_set_lane_count);
+
+void intel_dp_link_training_debugfs_add(struct intel_connector *connector)
+{
+	struct dentry *root = connector->base.debugfs_entry;
+
+	if (connector->base.connector_type != DRM_MODE_CONNECTOR_DisplayPort &&
+	    connector->base.connector_type != DRM_MODE_CONNECTOR_eDP)
+		return;
+
+	debugfs_create_file("i915_dp_set_link_rate", 0644, root,
+			    connector, &i915_dp_set_link_rate_fops);
+
+	debugfs_create_file("i915_dp_set_lane_count", 0644, root,
+			    connector, &i915_dp_set_lane_count_fops);
+}
drivers/gpu/drm/i915/display/intel_dp_link_training.h +4 -0
index f658230960333..42e7fc6cb171a 100644
@@ -9,6 +9,7 @@
 #include <drm/display/drm_dp_helper.h>
 
 struct intel_atomic_state;
+struct intel_connector;
 struct intel_crtc_state;
 struct intel_dp;
 
@@ -44,4 +45,7 @@ static inline u8 intel_dp_training_pattern_symbol(u8 pattern)
 
 void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp,
 				 const struct intel_crtc_state *crtc_state);
+
+void intel_dp_link_training_debugfs_add(struct intel_connector *connector);
+
 #endif /* __INTEL_DP_LINK_TRAINING_H__ */
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
author
#49 lore raw

Re: [PATCH v2 17/21] drm/i915/dp: Add debugfs entries to set a target link rate/lane count

Quoted 42 lines · Ville Syrjälä
Quoted 41 lines · Imre Deak

Add connector debugfs entries to set a target link rate/lane count to be used by a link training afterwards. After setting a target link rate/lane count reset the link training parameters and for a non-auto target disable reducing the link parameters via the fallback logic. The former one can be used after testing link training failure scenarios
- via debugfs entries added later - to reset the reduced link parameters after the test.

v2:
- Add the entries from intel_dp_link_training.c (Jani)
- Rename the entries to i915_dp_set_link_rate/lane_count.

---
 .../drm/i915/display/intel_display_debugfs.c  |   2 +
 .../drm/i915/display/intel_display_types.h    |   2 +
 drivers/gpu/drm/i915/display/intel_dp.c       |  63 ++++-
 drivers/gpu/drm/i915/display/intel_dp.h       |   2 +
 .../drm/i915/display/intel_dp_link_training.c | 230 ++++++++++++++++++
 .../drm/i915/display/intel_dp_link_training.h |   4 +
 6 files changed, 294 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_display_debugfs.c +2 -0
index 35f9f86ef70f4..f83ffa2534925 100644
@@ -23,6 +23,7 @@
 #include "intel_display_types.h"
 #include "intel_dmc.h"
 #include "intel_dp.h"
+#include "intel_dp_link_training.h"
 #include "intel_dp_mst.h"
 #include "intel_drrs.h"
 #include "intel_fbc.h"
@@ -1515,6 +1516,7 @@ void intel_connector_debugfs_add(struct intel_connector *connector)
 	intel_drrs_connector_debugfs_add(connector);
 	intel_pps_connector_debugfs_add(connector);
 	intel_psr_connector_debugfs_add(connector);
+	intel_dp_link_training_debugfs_add(connector);
 
Quoted 16 lines

drivers/gpu/drm/i915/display/intel_display_types.h struct intel_dp { · line 1769

Quoted 12 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +0 -0
 	if (connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
 	    connector_type == DRM_MODE_CONNECTOR_HDMIA ||
drivers/gpu/drm/i915/display/intel_display_types.h +2 -0
index eb0cac3e27acf..e1c41cece249d 100644
@@ -1765,6 +1765,8 @@ struct intel_dp {
 		int max_lane_count;
 		/* Max rate for the current link */
 		int max_rate;
+		int requested_lane_count;
+		int requested_rate;

"requested" is perhaps a bit weak. Maybe "force" or "override" although perhaps those might give the impression that it ignores the sink limits or something?

It determines the rate/lane count within the valid common range. Can rename it to force.

Quoted 115 lines
Quoted 115 lines
drivers/gpu/drm/i915/display/intel_display_types.h +0 -0
 		bool retrain_disabled;
 		/* Sequential link training failures after a passing LT */
 		int seq_train_failures;
drivers/gpu/drm/i915/display/intel_dp.c +49 -6
index c8d940a2ef7af..cf4a768fccd15 100644
@@ -345,7 +345,7 @@ int intel_dp_max_common_rate(struct intel_dp *intel_dp)
 	return intel_dp_common_rate(intel_dp, intel_dp->num_common_rates - 1);
 }
 
-static int intel_dp_max_source_lane_count(struct intel_digital_port *dig_port)
+int intel_dp_max_source_lane_count(struct intel_digital_port *dig_port)
 {
 	int vbt_max_lanes = intel_bios_dp_max_lane_count(dig_port->base.devdata);
 	int max_lanes = dig_port->max_lanes;
@@ -371,19 +371,39 @@ int intel_dp_max_common_lane_count(struct intel_dp *intel_dp)
 	return min3(source_max, sink_max, lane_max);
 }
 
+static int requested_lane_count(struct intel_dp *intel_dp)
+{
+	return clamp(intel_dp->link.requested_lane_count, 1, intel_dp_max_common_lane_count(intel_dp));
+}
+
 int intel_dp_max_lane_count(struct intel_dp *intel_dp)
 {
-	switch (intel_dp->link.max_lane_count) {
+	int lane_count;
+
+	if (intel_dp->link.requested_lane_count)
+		lane_count = requested_lane_count(intel_dp);
+	else
+		lane_count = intel_dp->link.max_lane_count;
+
+	switch (lane_count) {
 	case 1:
 	case 2:
 	case 4:
-		return intel_dp->link.max_lane_count;
+		return lane_count;
 	default:
-		MISSING_CASE(intel_dp->link.max_lane_count);
+		MISSING_CASE(lane_count);
 		return 1;
 	}
 }
 
+static int intel_dp_min_lane_count(struct intel_dp *intel_dp)
+{
+	if (intel_dp->link.requested_lane_count)
+		return requested_lane_count(intel_dp);
+
+	return 1;
+}
+
 /*
  * The required data bandwidth for a mode with given pixel clock and bpp. This
  * is the required net bandwidth independent of the data bandwidth efficiency.
@@ -1306,16 +1326,38 @@ static void intel_dp_print_rates(struct intel_dp *intel_dp)
 	drm_dbg_kms(&i915->drm, "common rates: %s\n", str);
 }
 
+static int requested_rate(struct intel_dp *intel_dp)
+{
+	int len = intel_dp_common_len_rate_limit(intel_dp, intel_dp->link.requested_rate);
+
+	if (len == 0)
+		return intel_dp_common_rate(intel_dp, 0);
+
+	return intel_dp_common_rate(intel_dp, len - 1);
+}
+
 int
 intel_dp_max_link_rate(struct intel_dp *intel_dp)
 {
 	int len;
 
+	if (intel_dp->link.requested_rate)
+		return requested_rate(intel_dp);
+
 	len = intel_dp_common_len_rate_limit(intel_dp, intel_dp->link.max_rate);
 
 	return intel_dp_common_rate(intel_dp, len - 1);
 }
 
+static int
+intel_dp_min_link_rate(struct intel_dp *intel_dp)
+{
+	if (intel_dp->link.requested_rate)
+		return requested_rate(intel_dp);
+
+	return intel_dp_common_rate(intel_dp, 0);
+}
+
 int intel_dp_rate_select(struct intel_dp *intel_dp, int rate)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
@@ -2285,13 +2327,14 @@ intel_dp_compute_config_limits(struct intel_dp *intel_dp,
 			       bool dsc,
 			       struct link_config_limits *limits)
 {
-	limits->min_rate = intel_dp_common_rate(intel_dp, 0);
+	limits->min_rate = intel_dp_min_link_rate(intel_dp);
 	limits->max_rate = intel_dp_max_link_rate(intel_dp);
 
 	/* FIXME 128b/132b SST support missing */
 	limits->max_rate = min(limits->max_rate, 810000);
+	limits->min_rate = min(limits->min_rate, limits->max_rate);
 
-	limits->min_lane_count = 1;
+	limits->min_lane_count = intel_dp_min_lane_count(intel_dp);
 	limits->max_lane_count = intel_dp_max_lane_count(intel_dp);
 
Quoted 14 lines

drivers/gpu/drm/i915/display/intel_dp.c intel_dp_compute_config_limits(struct intel_dp *intel_dp, · line 2356

Quoted 11 lines
drivers/gpu/drm/i915/display/intel_dp.c +4 -2
 	limits->pipe.min_bpp = intel_dp_min_bpp(crtc_state->output_format);
@@ -2307,8 +2350,10 @@ intel_dp_compute_config_limits(struct intel_dp *intel_dp,
 		 * configuration, and typically on older panels these
 		 * values correspond to the native resolution of the panel.
 		 */
-		limits->min_lane_count = limits->max_lane_count;
-		limits->min_rate = limits->max_rate;
+		if (intel_dp->link.requested_lane_count == 0)
+			limits->min_lane_count = limits->max_lane_count;
+		if (intel_dp->link.requested_rate == 0)
+			limits->min_rate = limits->max_rate;

Aren't the min and max the same anyway if the debugfs override is in use?

Yes, thanks for spotting that, this eDP override can stay as-is.

Quoted 72 lines
Quoted 72 lines
drivers/gpu/drm/i915/display/intel_dp.c +1 -1
 	}
 
 	intel_dp_adjust_compliance_config(intel_dp, crtc_state, limits);
@@ -2946,7 +2991,7 @@ void intel_dp_set_link_params(struct intel_dp *intel_dp,
 	intel_dp->lane_count = lane_count;
 }
 
-static void intel_dp_reset_link_params(struct intel_dp *intel_dp)
+void intel_dp_reset_link_params(struct intel_dp *intel_dp)
 {
 	intel_dp->link.max_lane_count = intel_dp_max_common_lane_count(intel_dp);
 	intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
drivers/gpu/drm/i915/display/intel_dp.h +2 -0
index 3fa53ac601d58..79914e5080251 100644
@@ -99,6 +99,7 @@ void intel_edp_backlight_off(const struct drm_connector_state *conn_state);
 void intel_edp_fixup_vbt_bpp(struct intel_encoder *encoder, int pipe_bpp);
 void intel_dp_mst_suspend(struct drm_i915_private *dev_priv);
 void intel_dp_mst_resume(struct drm_i915_private *dev_priv);
+int intel_dp_max_source_lane_count(struct intel_digital_port *dig_port);
 int intel_dp_max_link_rate(struct intel_dp *intel_dp);
 int intel_dp_max_lane_count(struct intel_dp *intel_dp);
 int intel_dp_config_required_rate(const struct intel_crtc_state *crtc_state);
@@ -108,6 +109,7 @@ int intel_dp_max_common_lane_count(struct intel_dp *intel_dp);
 int intel_dp_common_rate(struct intel_dp *intel_dp, int index);
 int intel_dp_rate_index(const int *rates, int len, int rate);
 void intel_dp_update_sink_caps(struct intel_dp *intel_dp);
+void intel_dp_reset_link_params(struct intel_dp *intel_dp);
 
 void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock,
 			   u8 *link_bw, u8 *rate_select);
drivers/gpu/drm/i915/display/intel_dp_link_training.c +18 -0
index 9a59a28ca36d2..a6021e17cc1ef 100644
@@ -1115,6 +1115,9 @@ static int reduce_link_rate(struct intel_dp *intel_dp, int current_rate)
 	int rate_index;
 	int new_rate;
 
+	if (intel_dp->link.requested_rate)
+		return -1;
+
 	rate_index = intel_dp_rate_index(intel_dp->common_rates,
 					 intel_dp->num_common_rates,
 					 current_rate);
@@ -1133,6 +1136,9 @@ static int reduce_link_rate(struct intel_dp *intel_dp, int current_rate)
 
 static int reduce_lane_count(struct intel_dp *intel_dp, int current_lane_count)
 {
+	if (intel_dp->link.requested_lane_count)
+		return -1;
+
 	if (current_lane_count > 1)
 		return current_lane_count >> 1;
 
@@ -1543,3 +1549,227 @@ void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp,
 
 	lt_dbg(intel_dp, DP_PHY_DPRX, "DP2.0 SDP CRC16 for 128b/132b enabled\n");
 }
+
+static struct intel_dp *intel_connector_to_intel_dp(struct intel_connector *connector)
+{
+	if (connector->mst_port)
+		return connector->mst_port;
+	else
+		return enc_to_intel_dp(intel_attached_encoder(connector));
+}
+
+static int i915_dp_set_link_rate_show(struct seq_file *m, void *data)
+{
+	struct intel_connector *connector = to_intel_connector(m->private);
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_dp_link_training.c void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp, · line 1569

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +6 -0
+	struct drm_i915_private *i915 = to_i915(connector->base.dev);
+	struct intel_dp *intel_dp;
+	int ret;
+	int i;
+
+	ret = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex);

What is this lock protecting exactly?

The connector state, for instace from getting removed after a disconnect event and the link caps in intel_dp.

Quoted 233 lines
Quoted 229 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +206 -0
+	if (ret)
+		return ret;
+
+	intel_dp = intel_connector_to_intel_dp(connector);
+
+	seq_printf(m, "%sauto%s",
+		   intel_dp->link.requested_rate == 0 ? "[" : "",
+		   intel_dp->link.requested_rate == 0 ? "]" : "");
+
+	for (i = 0; i < intel_dp->num_source_rates; i++)
+		seq_printf(m, " %s%d%s%s",
+			   intel_dp->source_rates[i] == intel_dp->link.requested_rate ? "[" : "",
+			   intel_dp->source_rates[i],
+			   intel_dp->link_trained &&
+				intel_dp->source_rates[i] == intel_dp->link_rate ? "*" : "",
+			   intel_dp->source_rates[i] == intel_dp->link.requested_rate ? "]" : "");
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	seq_putc(m, '\n');
+
+	return 0;
+}
+
+static int parse_link_rate(struct intel_dp *intel_dp, const char __user *ubuf, size_t len)
+{
+	char *kbuf;
+	const char *p;
+	int rate;
+	int ret = 0;
+
+	kbuf = memdup_user_nul(ubuf, len);
+	if (IS_ERR(kbuf))
+		return PTR_ERR(kbuf);
+
+	p = strim(kbuf);
+
+	if (!strcmp(p, "auto")) {
+		rate = 0;
+	} else {
+		ret = kstrtoint(p, 0, &rate);
+		if (ret < 0)
+			goto out_free;
+
+		if (intel_dp_rate_index(intel_dp->source_rates,
+					intel_dp->num_source_rates,
+					rate) < 0)
+			ret = -EINVAL;
+	}
+
+out_free:
+	kfree(kbuf);
+
+	return ret < 0 ? ret : rate;
+}
+
+static ssize_t i915_dp_set_link_rate_write(struct file *file,
+					   const char __user *ubuf,
+					   size_t len, loff_t *offp)
+{
+	struct seq_file *m = file->private_data;
+	struct intel_connector *connector = to_intel_connector(m->private);
+	struct drm_i915_private *i915 = to_i915(connector->base.dev);
+	struct intel_dp *intel_dp = intel_connector_to_intel_dp(connector);
+	int rate;
+	int ret;
+
+	ret = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex);
+	if (ret)
+		return ret;
+
+	intel_dp = intel_connector_to_intel_dp(connector);
+
+	rate = parse_link_rate(intel_dp, ubuf, len);
+	if (rate < 0) {
+		drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+		return rate;
+	}
+
+	intel_dp_reset_link_params(intel_dp);
+	intel_dp->link.requested_rate = rate;
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	*offp += len;
+
+	return len;
+}
+DEFINE_SHOW_STORE_ATTRIBUTE(i915_dp_set_link_rate);
+
+static int i915_dp_set_lane_count_show(struct seq_file *m, void *data)
+{
+	struct intel_connector *connector = to_intel_connector(m->private);
+	struct drm_i915_private *i915 = to_i915(connector->base.dev);
+	struct intel_dp *intel_dp;
+	int ret;
+	int i;
+
+	ret = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex);
+	if (ret)
+		return ret;
+
+	intel_dp = intel_connector_to_intel_dp(connector);
+
+	seq_printf(m, "%sauto%s",
+		   intel_dp->link.requested_lane_count == 0 ? "[" : "",
+		   intel_dp->link.requested_lane_count == 0 ? "]" : "");
+
+	for (i = 1; i <= 4; i <<= 1)
+		seq_printf(m, " %s%d%s%s",
+			   i == intel_dp->link.requested_lane_count ? "[" : "",
+			   i,
+			   intel_dp->link_trained &&
+				i == intel_dp->lane_count ? "*" : "",
+			   i == intel_dp->link.requested_lane_count ? "]" : "");
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	seq_putc(m, '\n');
+
+	return 0;
+}
+
+static int parse_lane_count(const char __user *ubuf, size_t len)
+{
+	char *kbuf;
+	const char *p;
+	int lane_count;
+	int ret = 0;
+
+	kbuf = memdup_user_nul(ubuf, len);
+	if (IS_ERR(kbuf))
+		return PTR_ERR(kbuf);
+
+	p = strim(kbuf);
+
+	if (!strcmp(p, "auto")) {
+		lane_count = 0;
+	} else {
+		ret = kstrtoint(p, 0, &lane_count);
+		if (ret < 0)
+			goto out_free;
+
+		switch (lane_count) {
+		case 1:
+		case 2:
+		case 4:
+			break;
+		default:
+			ret = -EINVAL;
+		}
+	}
+
+out_free:
+	kfree(kbuf);
+
+	return ret < 0 ? ret : lane_count;
+}
+
+static ssize_t i915_dp_set_lane_count_write(struct file *file,
+					    const char __user *ubuf,
+					    size_t len, loff_t *offp)
+{
+	struct seq_file *m = file->private_data;
+	struct intel_connector *connector = to_intel_connector(m->private);
+	struct drm_i915_private *i915 = to_i915(connector->base.dev);
+	struct intel_dp *intel_dp;
+	int lane_count;
+	int ret;
+
+	lane_count = parse_lane_count(ubuf, len);
+	if (lane_count < 0)
+		return lane_count;
+
+	ret = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex);
+	if (ret)
+		return ret;
+
+	intel_dp = intel_connector_to_intel_dp(connector);
+
+	intel_dp_reset_link_params(intel_dp);
+	intel_dp->link.requested_lane_count = lane_count;
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	*offp += len;
+
+	return len;
+}
+DEFINE_SHOW_STORE_ATTRIBUTE(i915_dp_set_lane_count);
+
+void intel_dp_link_training_debugfs_add(struct intel_connector *connector)
+{
+	struct dentry *root = connector->base.debugfs_entry;
+
+	if (connector->base.connector_type != DRM_MODE_CONNECTOR_DisplayPort &&
+	    connector->base.connector_type != DRM_MODE_CONNECTOR_eDP)
+		return;
+
+	debugfs_create_file("i915_dp_set_link_rate", 0644, root,
+			    connector, &i915_dp_set_link_rate_fops);
+
+	debugfs_create_file("i915_dp_set_lane_count", 0644, root,
+			    connector, &i915_dp_set_lane_count_fops);
+}
drivers/gpu/drm/i915/display/intel_dp_link_training.h +4 -0
index f658230960333..42e7fc6cb171a 100644
@@ -9,6 +9,7 @@
 #include <drm/display/drm_dp_helper.h>
 
 struct intel_atomic_state;
+struct intel_connector;
 struct intel_crtc_state;
 struct intel_dp;
 
@@ -44,4 +45,7 @@ static inline u8 intel_dp_training_pattern_symbol(u8 pattern)
 
 void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp,
 				 const struct intel_crtc_state *crtc_state);
+
+void intel_dp_link_training_debugfs_add(struct intel_connector *connector);
+
 #endif /* __INTEL_DP_LINK_TRAINING_H__ */
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
author
#50 lore raw

PATCH v2 18/21 drm/i915/dp: Add debugfs entries to get the max link rate/lane count

In reply to Imre Deak

Add connector debugfs entries to get the maximum link rate and lane count.

---
 .../drm/i915/display/intel_dp_link_training.c | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)
drivers/gpu/drm/i915/display/intel_dp_link_training.c +46 -0
index a6021e17cc1ef..764187bc42ff9 100644
@@ -1759,6 +1759,46 @@ static ssize_t i915_dp_set_lane_count_write(struct file *file,
 }
 DEFINE_SHOW_STORE_ATTRIBUTE(i915_dp_set_lane_count);
 
+static int i915_dp_max_link_rate_show(void *data, u64 *val)
+{
+	struct intel_connector *connector = to_intel_connector(data);
+	struct drm_i915_private *i915 = to_i915(connector->base.dev);
+	struct intel_dp *intel_dp;
+	int err;
+
+	err = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex);
+	if (err)
+		return err;
+
+	intel_dp = intel_connector_to_intel_dp(connector);
+	*val = intel_dp->link.max_rate;
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	return 0;
+}
+DEFINE_DEBUGFS_ATTRIBUTE(i915_dp_max_link_rate_fops, i915_dp_max_link_rate_show, NULL, "%llu\n");
+
+static int i915_dp_max_lane_count_show(void *data, u64 *val)
+{
+	struct intel_connector *connector = to_intel_connector(data);
+	struct drm_i915_private *i915 = to_i915(connector->base.dev);
+	struct intel_dp *intel_dp;
+	int err;
+
+	err = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex);
+	if (err)
+		return err;
+
+	intel_dp = intel_connector_to_intel_dp(connector);
+	*val = intel_dp->link.max_lane_count;
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	return 0;
+}
+DEFINE_DEBUGFS_ATTRIBUTE(i915_dp_max_lane_count_fops, i915_dp_max_lane_count_show, NULL, "%llu\n");
+
 void intel_dp_link_training_debugfs_add(struct intel_connector *connector)
 {
 	struct dentry *root = connector->base.debugfs_entry;
@@ -1772,4 +1812,10 @@ void intel_dp_link_training_debugfs_add(struct intel_connector *connector)
 
 	debugfs_create_file("i915_dp_set_lane_count", 0644, root,
 			    connector, &i915_dp_set_lane_count_fops);
+
+	debugfs_create_file("i915_dp_max_link_rate", 0444, root,
+			    connector, &i915_dp_max_link_rate_fops);
+
+	debugfs_create_file("i915_dp_max_lane_count", 0444, root,
+			    connector, &i915_dp_max_lane_count_fops);
 }
Signature · 1 line
2.43.3
author
#51 lore raw

PATCH v2 19/21 drm/i915/dp: Add debugfs entry to force link training failure

In reply to Imre Deak

Add a connector debugfs entry to force a failure during the following 1-2 link training. The entry will auto-reset after the specified link training events are complete.

v2: Add the entry from intel_dp_link_training.c (Jani)

---
 .../drm/i915/display/intel_display_types.h    |  1 +
 .../drm/i915/display/intel_dp_link_training.c | 52 ++++++++++++++++++-
 2 files changed, 52 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
index e1c41cece249d..dbe1468fe471d 100644
@@ -1770,6 +1770,7 @@ struct intel_dp {
 		bool retrain_disabled;
 		/* Sequential link training failures after a passing LT */
 		int seq_train_failures;
+		int force_train_failure;
 	} link;
 	bool reset_link_params;
 	int mso_link_count;
drivers/gpu/drm/i915/display/intel_dp_link_training.c +51 -1

68 lines not on this page · raw message

Signature · 1 line
2.43.3
#52 lore raw

Re: [PATCH v2 19/21] drm/i915/dp: Add debugfs entry to force link training failure

Quoted 62 lines · Imre Deak

Add a connector debugfs entry to force a failure during the following 1-2 link training. The entry will auto-reset after the specified link training events are complete.

v2: Add the entry from intel_dp_link_training.c (Jani)

---
 .../drm/i915/display/intel_display_types.h    |  1 +
 .../drm/i915/display/intel_dp_link_training.c | 52 ++++++++++++++++++-
 2 files changed, 52 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
index e1c41cece249d..dbe1468fe471d 100644
@@ -1770,6 +1770,7 @@ struct intel_dp {
 		bool retrain_disabled;
 		/* Sequential link training failures after a passing LT */
 		int seq_train_failures;
+		int force_train_failure;
 	} link;
 	bool reset_link_params;
 	int mso_link_count;
drivers/gpu/drm/i915/display/intel_dp_link_training.c +21 -1
index 764187bc42ff9..b40148a42f442 100644
@@ -1489,7 +1489,10 @@ void intel_dp_start_link_train(struct intel_atomic_state *state,
 	else
 		passed = intel_dp_link_train_all_phys(intel_dp, crtc_state, lttpr_count);
 
-	if (passed) {
+	if (intel_dp->link.force_train_failure) {
+		intel_dp->link.force_train_failure--;
+		lt_dbg(intel_dp, DP_PHY_DPRX, "Forcing link training failure\n");
+	} else if (passed) {
 		intel_dp->link.seq_train_failures = 0;
 		intel_ddi_queue_link_check(dig_port, 2000);
 		return;
@@ -1799,6 +1802,50 @@ static int i915_dp_max_lane_count_show(void *data, u64 *val)
 }
 DEFINE_DEBUGFS_ATTRIBUTE(i915_dp_max_lane_count_fops, i915_dp_max_lane_count_show, NULL, "%llu\n");
 
+static int i915_dp_force_link_training_failure_show(void *data, u64 *val)
+{
+	struct intel_connector *connector = to_intel_connector(data);
+	struct drm_i915_private *i915 = to_i915(connector->base.dev);
+	struct intel_dp *intel_dp;
+	int err;
+
+	err = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex);
+	if (err)
+		return err;
+
+	intel_dp = intel_connector_to_intel_dp(connector);
+	*val = intel_dp->link.force_train_failure;
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	return 0;

drivers/gpu/drm/i915/display/intel_dp_link_training.c static int i915_dp_max_lane_count_show(void *data, u64 *val) · line 1831

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +10 -0
+}
+
+static int i915_dp_force_link_training_failure_write(void *data, u64 val)
+{
+	struct intel_connector *connector = to_intel_connector(data);
+	struct drm_i915_private *i915 = to_i915(connector->base.dev);
+	struct intel_dp *intel_dp;
+	int err;
+
+	if (val > 2)

Why 2 specifically?

Quoted 30 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +20 -0
+		return -EINVAL;
+
+	err = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex);
+	if (err)
+		return err;
+
+	intel_dp = intel_connector_to_intel_dp(connector);
+	intel_dp->link.force_train_failure = val;
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	return 0;
+}
+DEFINE_DEBUGFS_ATTRIBUTE(i915_dp_force_link_training_failure_fops,
+			 i915_dp_force_link_training_failure_show,
+			 i915_dp_force_link_training_failure_write, "%llu\n");
+
 void intel_dp_link_training_debugfs_add(struct intel_connector *connector)
 {
 	struct dentry *root = connector->base.debugfs_entry;
@@ -1818,4 +1865,7 @@ void intel_dp_link_training_debugfs_add(struct intel_connector *connector)
 
 	debugfs_create_file("i915_dp_max_lane_count", 0444, root,
 			    connector, &i915_dp_max_lane_count_fops);
+
+	debugfs_create_file("i915_dp_force_link_training_failure", 0644, root,
+			    connector, &i915_dp_force_link_training_failure_fops);
 }
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
author
#53 lore raw

Re: [PATCH v2 19/21] drm/i915/dp: Add debugfs entry to force link training failure

Quoted 67 lines · Ville Syrjälä
Quoted 66 lines · Imre Deak

Add a connector debugfs entry to force a failure during the following 1-2 link training. The entry will auto-reset after the specified link training events are complete.

v2: Add the entry from intel_dp_link_training.c (Jani)

---
 .../drm/i915/display/intel_display_types.h    |  1 +
 .../drm/i915/display/intel_dp_link_training.c | 52 ++++++++++++++++++-
 2 files changed, 52 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
index e1c41cece249d..dbe1468fe471d 100644
@@ -1770,6 +1770,7 @@ struct intel_dp {
 		bool retrain_disabled;
 		/* Sequential link training failures after a passing LT */
 		int seq_train_failures;
+		int force_train_failure;
 	} link;
 	bool reset_link_params;
 	int mso_link_count;
drivers/gpu/drm/i915/display/intel_dp_link_training.c +25 -1
index 764187bc42ff9..b40148a42f442 100644
@@ -1489,7 +1489,10 @@ void intel_dp_start_link_train(struct intel_atomic_state *state,
 	else
 		passed = intel_dp_link_train_all_phys(intel_dp, crtc_state, lttpr_count);
 
-	if (passed) {
+	if (intel_dp->link.force_train_failure) {
+		intel_dp->link.force_train_failure--;
+		lt_dbg(intel_dp, DP_PHY_DPRX, "Forcing link training failure\n");
+	} else if (passed) {
 		intel_dp->link.seq_train_failures = 0;
 		intel_ddi_queue_link_check(dig_port, 2000);
 		return;
@@ -1799,6 +1802,50 @@ static int i915_dp_max_lane_count_show(void *data, u64 *val)
 }
 DEFINE_DEBUGFS_ATTRIBUTE(i915_dp_max_lane_count_fops, i915_dp_max_lane_count_show, NULL, "%llu\n");
 
+static int i915_dp_force_link_training_failure_show(void *data, u64 *val)
+{
+	struct intel_connector *connector = to_intel_connector(data);
+	struct drm_i915_private *i915 = to_i915(connector->base.dev);
+	struct intel_dp *intel_dp;
+	int err;
+
+	err = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex);
+	if (err)
+		return err;
+
+	intel_dp = intel_connector_to_intel_dp(connector);
+	*val = intel_dp->link.force_train_failure;
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	return 0;
+}
+
+static int i915_dp_force_link_training_failure_write(void *data, u64 val)
+{
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_dp_link_training.c static int i915_dp_max_lane_count_show(void *data, u64 *val) · line 1831

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +6 -0
+	struct intel_connector *connector = to_intel_connector(data);
+	struct drm_i915_private *i915 = to_i915(connector->base.dev);
+	struct intel_dp *intel_dp;
+	int err;
+
+	if (val > 2)

Why 2 specifically?

There are 2 back-to-back link trainings that can fail after a modeset or later after detecting a bad link state, the initial one and a second with the same LT parameters. That's followed by reducing the LT parameters and probably a modeset changing the mode.

Quoted 34 lines
Quoted 30 lines
drivers/gpu/drm/i915/display/intel_dp_link_training.c +20 -0
+		return -EINVAL;
+
+	err = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex);
+	if (err)
+		return err;
+
+	intel_dp = intel_connector_to_intel_dp(connector);
+	intel_dp->link.force_train_failure = val;
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	return 0;
+}
+DEFINE_DEBUGFS_ATTRIBUTE(i915_dp_force_link_training_failure_fops,
+			 i915_dp_force_link_training_failure_show,
+			 i915_dp_force_link_training_failure_write, "%llu\n");
+
 void intel_dp_link_training_debugfs_add(struct intel_connector *connector)
 {
 	struct dentry *root = connector->base.debugfs_entry;
@@ -1818,4 +1865,7 @@ void intel_dp_link_training_debugfs_add(struct intel_connector *connector)
 
 	debugfs_create_file("i915_dp_max_lane_count", 0444, root,
 			    connector, &i915_dp_max_lane_count_fops);
+
+	debugfs_create_file("i915_dp_force_link_training_failure", 0644, root,
+			    connector, &i915_dp_force_link_training_failure_fops);
 }
Signature · 1 line
2.43.3
Signature · 2 lines
Ville Syrjälä
Intel
author
#54 lore raw

PATCH v2 20/21 drm/i915/dp: Add debugfs entry to force link retrain

In reply to Imre Deak

Add a connector debugfs entry to force retrain an active link. This can be used to test both custom link parameters (previously set via the target link lane count/rate entries) or link train failure scenarios (previously forced via the force-failure entry). The entry will autoreset after the link-retrain is complete.

v2: Add the entry from intel_dp_link_training.c (Jani)

---
 .../drm/i915/display/intel_display_types.h    |  1 +
 drivers/gpu/drm/i915/display/intel_dp.c       | 18 +++++--
 .../drm/i915/display/intel_dp_link_training.c | 47 +++++++++++++++++++
 3 files changed, 61 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
index dbe1468fe471d..52c69c7eb52f5 100644
@@ -1771,6 +1771,7 @@ struct intel_dp {
 		/* Sequential link training failures after a passing LT */
 		int seq_train_failures;
 		int force_train_failure;
+		bool force_retrain;
 	} link;
 	bool reset_link_params;
 	int mso_link_count;
drivers/gpu/drm/i915/display/intel_dp.c +13 -5
index cf4a768fccd15..895074d548671 100644
@@ -5042,7 +5042,7 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp)
 			drm_dp_mst_hpd_irq_send_new_request(&intel_dp->mst_mgr);
 	}
 
-	if (!link_ok)
+	if (!link_ok || intel_dp->link.force_retrain)
 		intel_ddi_queue_link_check(dig_port, 0);
 
 	return !reprobe_needed;
@@ -5091,6 +5091,9 @@ intel_dp_needs_link_retrain(struct intel_dp *intel_dp)
 	if (intel_psr_enabled(intel_dp))
 		return false;
 
+	if (intel_dp->link.force_retrain)
+		return true;
+
 	if (drm_dp_dpcd_read_phy_link_status(&intel_dp->aux, DP_PHY_DPRX,
 					     link_status) < 0)
 		return false;
@@ -5237,8 +5240,9 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 	if (!intel_dp_needs_link_retrain(intel_dp))
 		return 0;
 
-	drm_dbg_kms(&dev_priv->drm, "[ENCODER:%d:%s] retraining link\n",
-		    encoder->base.base.id, encoder->base.name);
+	drm_dbg_kms(&dev_priv->drm, "[ENCODER:%d:%s] retraining link (forced %s)\n",
+		    encoder->base.base.id, encoder->base.name,
+		    str_yes_no(intel_dp->link.force_retrain));
 
 	for_each_intel_crtc_in_pipe_mask(&dev_priv->drm, crtc, pipe_mask) {
 		const struct intel_crtc_state *crtc_state =
@@ -5266,7 +5270,7 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 				    encoder->base.base.id, encoder->base.name,
 				    ERR_PTR(ret));
 
-		return ret;
+		goto out;
 	}
 
 	for_each_intel_crtc_in_pipe_mask(&dev_priv->drm, crtc, pipe_mask) {
@@ -5293,7 +5297,11 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 							      intel_crtc_pch_transcoder(crtc), true);
 	}
 
-	return 0;
+out:
+	if (ret != -EDEADLK)
+		intel_dp->link.force_retrain = false;
+
+	return ret;
 }
 
 static int intel_dp_prep_phy_test(struct intel_dp *intel_dp,
drivers/gpu/drm/i915/display/intel_dp_link_training.c +47 -0

63 lines not on this page · raw message

Signature · 1 line
2.43.3
author
#55 lore raw

PATCH v2 21/21 drm/i915/dp: Add debugfs entry for link training info

In reply to Imre Deak

Add counters for link training pass/failure events and a connector debugfs entry showing these and relevant link training information. This is meant to be used by automated testing of the driver's link retraining and link parameter fallback functionality.

v2:
- Add the entry from intel_dp_link_training.c (Jani)
- Add separate entries for the max link rate/lane count.

---
 .../drm/i915/display/intel_display_types.h    |  3 ++
 drivers/gpu/drm/i915/display/intel_dp.c       |  7 +++-
 .../drm/i915/display/intel_dp_link_training.c | 37 +++++++++++++++++++
 3 files changed, 46 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
index 52c69c7eb52f5..6f37f2cca2e99 100644
@@ -1768,6 +1768,9 @@ struct intel_dp {
 		int requested_lane_count;
 		int requested_rate;
 		bool retrain_disabled;
+		int train_count;
+		int retrain_count;
+		int all_train_failures;
 		/* Sequential link training failures after a passing LT */
 		int seq_train_failures;
 		int force_train_failure;
drivers/gpu/drm/i915/display/intel_dp.c +6 -1
index 895074d548671..0337be8416082 100644
@@ -2996,6 +2996,9 @@ void intel_dp_reset_link_params(struct intel_dp *intel_dp)
 	intel_dp->link.max_lane_count = intel_dp_max_common_lane_count(intel_dp);
 	intel_dp->link.max_rate = intel_dp_max_common_rate(intel_dp);
 	intel_dp->link.retrain_disabled = false;
+	intel_dp->link.train_count = 0;
+	intel_dp->link.retrain_count = 0;
+	intel_dp->link.all_train_failures = 0;
 	intel_dp->link.seq_train_failures = 0;
 }
 
@@ -5298,8 +5301,10 @@ int intel_dp_retrain_link(struct intel_encoder *encoder,
 	}
 
 out:
-	if (ret != -EDEADLK)
+	if (ret != -EDEADLK) {
+		intel_dp->link.retrain_count++;
 		intel_dp->link.force_retrain = false;
+	}
 
 	return ret;
 }
drivers/gpu/drm/i915/display/intel_dp_link_training.c +37 -0
index 6fac8421a6918..969a5fc4c7b2e 100644
@@ -1490,6 +1490,8 @@ void intel_dp_start_link_train(struct intel_atomic_state *state,
 	else
 		passed = intel_dp_link_train_all_phys(intel_dp, crtc_state, lttpr_count);
 
+	intel_dp->link.train_count++;
+
 	if (intel_dp->link.force_train_failure) {
 		intel_dp->link.force_train_failure--;
 		lt_dbg(intel_dp, DP_PHY_DPRX, "Forcing link training failure\n");
@@ -1499,6 +1501,7 @@ void intel_dp_start_link_train(struct intel_atomic_state *state,
 		return;
 	}
 
+	intel_dp->link.all_train_failures++;
 	intel_dp->link.seq_train_failures++;
 
 	/*
@@ -1890,6 +1893,37 @@ DEFINE_DEBUGFS_ATTRIBUTE(i915_dp_force_link_retrain_fops,
 			 i915_dp_force_link_retrain_show,
 			 i915_dp_force_link_retrain_write, "%llu\n");
 
+static int i915_dp_link_training_info_show(struct seq_file *m, void *data)
+{
+	struct intel_connector *connector = to_intel_connector(m->private);
+	struct drm_i915_private *i915 = to_i915(connector->base.dev);
+	struct intel_dp *intel_dp;
+	int ret;
+
+	ret = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex);
+	if (ret)
+		return ret;
+
+	intel_dp = intel_connector_to_intel_dp(connector);
+
+	seq_printf(m,
+		   "retrain_disabled: %s\n"
+		   "train_count: %d\n"
+		   "retrain_count: %d\n"
+		   "all_train_failures: %d\n"
+		   "seq_train_failures: %d\n",
+		   str_yes_no(intel_dp->link.retrain_disabled),
+		   intel_dp->link.train_count,
+		   intel_dp->link.retrain_count,
+		   intel_dp->link.all_train_failures,
+		   intel_dp->link.seq_train_failures);
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(i915_dp_link_training_info);
+
 void intel_dp_link_training_debugfs_add(struct intel_connector *connector)
 {
 	struct dentry *root = connector->base.debugfs_entry;
@@ -1915,4 +1949,7 @@ void intel_dp_link_training_debugfs_add(struct intel_connector *connector)
 
 	debugfs_create_file("i915_dp_force_link_retrain", 0644, root,
 			    connector, &i915_dp_force_link_retrain_fops);
+
+	debugfs_create_file("i915_dp_link_training_info", 0444, root,
+			    connector, &i915_dp_link_training_info_fops);
 }
Signature · 1 line
2.43.3
#56 lore raw

✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp_mst: Enable link training fallback (rev3)

In reply to Imre Deak
== Series Details ==

== Series Details ==

Series: drm/i915/dp_mst: Enable link training fallback (rev3)
URL : https://patchwork.freedesktop.org/series/133624/
State : warning

== Summary ==

Error: dim checkpatch failed
3901134df2a3 drm/i915/dp_mst: Align TUs to avoid splitting symbols across MTPs 28d65f0e37e3 drm/i915/dp: Move link train params to a substruct in intel_dp ff4e8e37d80a drm/i915/dp: Move link train fallback to intel_dp_link_training.c -:196: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #196: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:1140:
+ intel_dp_common_rate(intel_dp, index - 1),

total: 0 errors, 1 warnings, 0 checks, 195 lines checked
9b5277bae76d drm/i915/dp: Sanitize intel_dp_get_link_train_fallback_values() 2a76291f9545 drm/i915: Factor out function to modeset commit a set of pipes 7bf5284c899d drm/i915/dp: Use a commit modeset for link retraining MST links 82047795cc89 drm/i915/dp: Recheck link state after modeset
2628e40a6de7 drm/i915/dp: Reduce link params only after retrying with unchanged params 44933405fc08 drm/i915/dp: Pass atomic state to link training function eefedc87bcc1 drm/i915/dp: Send a link training modeset-retry uevent to all MST connectors 62a79366ba9d drm/i915/dp: Use check link state work in the hotplug handler b709e61f0cc5 drm/i915/dp: Use check link state work in the detect handler b8bb9bccea89 drm/i915/dp: Use check link state work in the HPD IRQ handler 872973e3096d drm/i915/dp: Disable link retraining after the last fallback step 1f4c395aa4ea drm/i915/dp_mst: Reset intel_dp->link_trained during disabling c9e59063ea28 drm/i915/dp_mst: Enable link training fallback for MST 6572f48d2ae8 drm/i915/dp: Add debugfs entries to set a target link rate/lane count -:74: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#74: FILE: drivers/gpu/drm/i915/display/intel_dp.c:376:
+ return clamp(intel_dp->link.requested_lane_count, 1, intel_dp_max_common_lane_count(intel_dp));

total: 0 errors, 1 warnings, 0 checks, 419 lines checked b4d9d57db44b drm/i915/dp: Add debugfs entries to get the max link rate/lane count 66d34360dd51 drm/i915/dp: Add debugfs entry to force link training failure 52bf93fe9d04 drm/i915/dp: Add debugfs entry to force link retrain d08235d7f4ac drm/i915/dp: Add debugfs entry for link training info

#57 lore raw

✗ Fi.CI.SPARSE: warning for drm/i915/dp_mst: Enable link training fallback (rev3)

In reply to Imre Deak
== Series Details ==

== Series Details ==

Series: drm/i915/dp_mst: Enable link training fallback (rev3)
URL : https://patchwork.freedesktop.org/series/133624/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +drivers/gpu/drm/i915/display/intel_de.h:105:15: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_tlb.h:21:16: warning: trying to copy expression type 31 +./drivers/gpu/drm/i915/intel_uncore.h:346:1: warning: trying to copy expression type 31 +./drivers/gpu/drm/i915/intel_uncore.h:346:1: warning: trying to copy expression type 31 +./drivers/gpu/drm/i915/intel_uncore.h:346:1: warning: trying to copy expression type 31 +./drivers/gpu/drm/i915/intel_uncore.h:351:1: warning: trying to copy expression type 31 +./drivers/gpu/drm/i915/intel_uncore.h:351:1: warning: trying to copy expression type 31 +./drivers/gpu/drm/i915/intel_uncore.h:351:1: warning: trying to copy expression type 31 +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/linux/find.h:63:31: warning: shift count is negative (-24)

#58 lore raw

✓ Fi.CI.BAT: success for drm/i915/dp_mst: Enable link training fallback (rev3)

In reply to Imre Deak
== Series Details ==

== Series Details ==

Series: drm/i915/dp_mst: Enable link training fallback (rev3)
URL : https://patchwork.freedesktop.org/series/133624/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_14785 -> Patchwork_133624v3
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/index.html

Participating hosts (41 -> 39)
------------------------------

Missing (2): bat-dg2-11 bat-jsl-3

Known issues
------------

Here are the changes found in Patchwork_133624v3 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_lmem_swapping@basic@lmem0:
- bat-atsm-1: [PASS][1] -> [FAIL][2] ([i915#10378])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/bat-atsm-1/igt@gem_lmem_swapping@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/bat-atsm-1/igt@gem_lmem_swapping@[email protected]
- bat-dg2-9: [PASS][3] -> [FAIL][4] ([i915#10378])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/bat-dg2-9/igt@gem_lmem_swapping@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/bat-dg2-9/igt@gem_lmem_swapping@[email protected]

* igt@i915_module_load@load:
- bat-arls-3: [PASS][5] -> [ABORT][6] ([i915#11041])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/bat-arls-3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/bat-arls-3/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- bat-arls-2: [PASS][7] -> [DMESG-WARN][8] ([i915#7507])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/bat-arls-2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/bat-arls-2/igt@[email protected]

#### Possible fixes ####

* igt@i915_module_load@load:
- bat-dg2-8: [DMESG-WARN][9] ([i915#10014]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/bat-dg2-8/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/bat-dg2-8/igt@[email protected]

* igt@i915_selftest@live@gt_timelines:
- bat-arls-2: [INCOMPLETE][11] -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/bat-arls-2/igt@i915_selftest@live@gt_timelines.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/bat-arls-2/igt@i915_selftest@live@gt_timelines.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#10014]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10014
[i915#10378]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10378
[i915#11041]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11041
[i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982
[i915#7507]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7507

Build changes
-------------

* Linux: CI_DRM_14785 -> Patchwork_133624v3

CI-20190529: 20190529
CI_DRM_14785: 1ba62f8cea9c797427d45108df1d453f4b343240 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7863: fa1dc232d5d840532521df8a6fcf1fe82c514304 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_133624v3: 1ba62f8cea9c797427d45108df1d453f4b343240 @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/index.html

#59 lore raw

✗ Fi.CI.IGT: failure for drm/i915/dp_mst: Enable link training fallback (rev3)

In reply to Imre Deak
== Series Details ==

== Series Details ==

Series: drm/i915/dp_mst: Enable link training fallback (rev3)
URL : https://patchwork.freedesktop.org/series/133624/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_14785_full -> Patchwork_133624v3_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_133624v3_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_133624v3_full, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (9 -> 9)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_133624v3_full:

### IGT changes ###

#### Possible regressions ####

* igt@device_reset@unbind-reset-rebind:
- shard-dg1: NOTRUN -> [ABORT][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@i915_pm_rps@reset:
- shard-tglu: NOTRUN -> [INCOMPLETE][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]

* igt@kms_vrr@seamless-rr-switch-virtual:
- shard-dg2: NOTRUN -> [SKIP][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]

New tests
---------

New tests have been introduced between CI_DRM_14785_full and Patchwork_133624v3_full:

### New IGT tests (1) ###

* igt@perf@blocking@1-vcs1:
- Statuses : 1 pass(s)
- Exec time: [10.03] s

Known issues
------------

Here are the changes found in Patchwork_133624v3_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@drm_fdinfo@virtual-busy-idle-all:
- shard-dg1: NOTRUN -> [SKIP][5] ([i915#8414]) +1 other test skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@drm_fdinfo@virtual-idle:
- shard-rkl: NOTRUN -> [FAIL][6] ([i915#7742])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@gem_ccs@block-multicopy-compressed:
- shard-rkl: NOTRUN -> [SKIP][7] ([i915#9323])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@gem_ccs@ctrl-surf-copy:
- shard-dg1: NOTRUN -> [SKIP][8] ([i915#3555] / [i915#9323])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gem_close_race@multigpu-basic-process:
- shard-rkl: NOTRUN -> [SKIP][9] ([i915#7697])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@[email protected]

* igt@gem_ctx_exec@basic-nohangcheck:
- shard-rkl: [PASS][10] -> [FAIL][11] ([i915#6268])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-rkl-3/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]

* igt@gem_ctx_persistence@heartbeat-stop:
- shard-dg2: NOTRUN -> [SKIP][12] ([i915#8555])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@gem_exec_balancer@bonded-sync:
- shard-dg1: NOTRUN -> [SKIP][13] ([i915#4771])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gem_exec_balancer@parallel-ordering:
- shard-rkl: NOTRUN -> [SKIP][14] ([i915#4525]) +1 other test skip
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@[email protected]

* igt@gem_exec_capture@capture-recoverable:
- shard-rkl: NOTRUN -> [SKIP][15] ([i915#6344])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@gem_exec_capture@many-4k-incremental:
- shard-dg1: NOTRUN -> [FAIL][16] ([i915#9606])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-dg1: NOTRUN -> [SKIP][17] ([i915#3539] / [i915#4852]) +5 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gem_exec_fair@basic-pace:
- shard-dg2: NOTRUN -> [SKIP][18] ([i915#3539])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglu: [PASS][19] -> [FAIL][20] ([i915#2842])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-tglu-6/igt@gem_exec_fair@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-rkl: NOTRUN -> [FAIL][21] ([i915#2842])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglu: NOTRUN -> [FAIL][22] ([i915#2842]) +5 other tests fail
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle:
- shard-dg1: NOTRUN -> [SKIP][23] ([i915#3539])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gem_exec_reloc@basic-scanout:
- shard-rkl: NOTRUN -> [SKIP][24] ([i915#3281]) +9 other tests skip
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@gem_exec_reloc@basic-write-gtt-active:
- shard-dg1: NOTRUN -> [SKIP][25] ([i915#3281]) +3 other tests skip
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gem_exec_reloc@basic-write-read-active:
- shard-dg2: NOTRUN -> [SKIP][26] ([i915#3281]) +5 other tests skip
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@gem_exec_schedule@pi-distinct-iova:
- shard-snb: NOTRUN -> [SKIP][27] +25 other tests skip
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-snb2/igt@[email protected]

* igt@gem_exec_schedule@reorder-wide:
- shard-dg1: NOTRUN -> [SKIP][28] ([i915#4812]) +1 other test skip
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gem_exec_suspend@basic-s4-devices@smem:
- shard-rkl: NOTRUN -> [ABORT][29] ([i915#7975] / [i915#8213])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@gem_exec_suspend@[email protected]

* igt@gem_fenced_exec_thrash@no-spare-fences-interruptible:
- shard-dg2: NOTRUN -> [SKIP][30] ([i915#4860])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@gem_lmem_swapping@basic@lmem0:
- shard-dg2: [PASS][31] -> [FAIL][32] ([i915#10378]) +1 other test fail
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-1/igt@gem_lmem_swapping@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-4/igt@gem_lmem_swapping@[email protected]

* igt@gem_lmem_swapping@heavy-multi@lmem0:
- shard-dg1: [PASS][33] -> [FAIL][34] ([i915#10378])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg1-16/igt@gem_lmem_swapping@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-16/igt@gem_lmem_swapping@[email protected]

* igt@gem_lmem_swapping@heavy-random@lmem0:
- shard-dg1: NOTRUN -> [FAIL][35] ([i915#10378])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@gem_lmem_swapping@[email protected]

* igt@gem_lmem_swapping@massive-random:
- shard-tglu: NOTRUN -> [SKIP][36] ([i915#4613])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-rkl: NOTRUN -> [SKIP][37] ([i915#4613]) +4 other tests skip
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@gem_lmem_swapping@verify-random-ccs:
- shard-glk: NOTRUN -> [SKIP][38] ([i915#4613]) +1 other test skip
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-glk6/igt@[email protected]

* igt@gem_mmap_wc@bad-size:
- shard-dg2: NOTRUN -> [SKIP][39] ([i915#4083]) +2 other tests skip
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@gem_mmap_wc@invalid-flags:
- shard-dg1: NOTRUN -> [SKIP][40] ([i915#4083]) +2 other tests skip
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gem_partial_pwrite_pread@writes-after-reads:
- shard-dg1: NOTRUN -> [SKIP][41] ([i915#3282]) +3 other tests skip
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gem_pwrite@basic-random:
- shard-dg2: NOTRUN -> [SKIP][42] ([i915#3282]) +2 other tests skip
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@gem_pwrite@basic-self:
- shard-rkl: NOTRUN -> [SKIP][43] ([i915#3282]) +8 other tests skip
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@gem_pxp@create-regular-buffer:
- shard-rkl: NOTRUN -> [SKIP][44] ([i915#4270]) +4 other tests skip
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]

* igt@gem_pxp@protected-encrypted-src-copy-not-readible:
- shard-dg1: NOTRUN -> [SKIP][45] ([i915#4270]) +2 other tests skip
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@gem_pxp@verify-pxp-key-change-after-suspend-resume:
- shard-tglu: NOTRUN -> [SKIP][46] ([i915#4270]) +1 other test skip
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-y-tiled:
- shard-dg2: NOTRUN -> [SKIP][47] ([i915#5190] / [i915#8428]) +1 other test skip
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@gem_set_tiling_vs_blt@tiled-to-tiled:
- shard-dg1: NOTRUN -> [SKIP][48] ([i915#4079])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@gem_set_tiling_vs_blt@tiled-to-untiled:
- shard-rkl: NOTRUN -> [SKIP][49] ([i915#8411])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@gem_tiled_partial_pwrite_pread@writes-after-reads:
- shard-dg1: NOTRUN -> [SKIP][50] ([i915#4077]) +6 other tests skip
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@gem_userptr_blits@create-destroy-unsync:
- shard-rkl: NOTRUN -> [SKIP][51] ([i915#3297]) +2 other tests skip
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate:
- shard-dg1: NOTRUN -> [SKIP][52] ([i915#3297] / [i915#4880])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@gem_userptr_blits@unsync-unmap:
- shard-dg1: NOTRUN -> [SKIP][53] ([i915#3297]) +1 other test skip
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@gen9_exec_parse@basic-rejected-ctx-param:
- shard-tglu: NOTRUN -> [SKIP][54] ([i915#2527] / [i915#2856])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@gen9_exec_parse@bb-chained:
- shard-dg1: NOTRUN -> [SKIP][55] ([i915#2527])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gen9_exec_parse@unaligned-access:
- shard-rkl: NOTRUN -> [SKIP][56] ([i915#2527]) +4 other tests skip
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-rkl: [PASS][57] -> [ABORT][58] ([i915#9820])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-rkl-5/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]
- shard-glk: [PASS][59] -> [INCOMPLETE][60] ([i915#9849])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-glk8/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-glk8/igt@[email protected]
- shard-mtlp: [PASS][61] -> [ABORT][62] ([i915#10131] / [i915#10887] / [i915#9697])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-mtlp-1/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-mtlp-8/igt@[email protected]

* igt@i915_module_load@resize-bar:
- shard-rkl: NOTRUN -> [SKIP][63] ([i915#6412])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-glk: NOTRUN -> [SKIP][64] +70 other tests skip
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-glk6/igt@[email protected]

* igt@i915_pm_rps@basic-api:
- shard-dg1: NOTRUN -> [SKIP][65] ([i915#6621])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@i915_pm_rps@thresholds-idle@gt0:
- shard-dg1: NOTRUN -> [SKIP][66] ([i915#8925])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@i915_pm_rps@[email protected]

* igt@i915_pm_sseu@full-enable:
- shard-rkl: NOTRUN -> [SKIP][67] ([i915#4387])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][68] ([i915#4387])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@i915_query@test-query-geometry-subslices:
- shard-rkl: NOTRUN -> [SKIP][69] ([i915#5723])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- shard-rkl: [PASS][70] -> [FAIL][71] ([i915#10031])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-rkl-5/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@intel_hwmon@hwmon-read:
- shard-tglu: NOTRUN -> [SKIP][72] ([i915#7707])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]

* igt@intel_hwmon@hwmon-write:
- shard-rkl: NOTRUN -> [SKIP][73] ([i915#7707])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling:
- shard-dg1: NOTRUN -> [SKIP][74] ([i915#4212])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- shard-rkl: NOTRUN -> [SKIP][75] ([i915#3826])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@[email protected]

* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-1-y-rc-ccs-cc:
- shard-rkl: NOTRUN -> [SKIP][76] ([i915#8709]) +3 other tests skip
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-1-y-rc-ccs-cc.html

* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-3-y-rc-ccs:
- shard-dg1: NOTRUN -> [SKIP][77] ([i915#8709]) +7 other tests skip
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@kms_async_flips@[email protected]

* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-dg1: NOTRUN -> [SKIP][78] ([i915#9531])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_big_fb@4-tiled-8bpp-rotate-0:
- shard-rkl: NOTRUN -> [SKIP][79] ([i915#5286]) +7 other tests skip
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@kms_big_fb@4-tiled-addfb:
- shard-tglu: NOTRUN -> [SKIP][80] ([i915#5286]) +2 other tests skip
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0:
- shard-dg1: NOTRUN -> [SKIP][81] ([i915#4538] / [i915#5286]) +1 other test skip
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-mtlp: [PASS][82] -> [DMESG-FAIL][83] ([i915#2017])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-mtlp-5/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-mtlp-2/igt@[email protected]

* igt@kms_big_fb@linear-64bpp-rotate-90:
- shard-rkl: NOTRUN -> [SKIP][84] ([i915#3638]) +2 other tests skip
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_big_fb@y-tiled-64bpp-rotate-270:
- shard-dg1: NOTRUN -> [SKIP][85] ([i915#3638]) +2 other tests skip
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-dg2: NOTRUN -> [SKIP][86] ([i915#4538] / [i915#5190]) +3 other tests skip
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html

* igt@kms_big_fb@yf-tiled-32bpp-rotate-270:
- shard-dg1: NOTRUN -> [SKIP][87] ([i915#4538])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@kms_ccs@bad-rotation-90-4-tiled-xe2-ccs:
- shard-dg1: NOTRUN -> [SKIP][88] ([i915#10278])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_ccs@bad-rotation-90-y-tiled-gen12-rc-ccs-cc@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [SKIP][89] ([i915#10307] / [i915#6095]) +173 other tests skip
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@kms_ccs@[email protected]

* igt@kms_ccs@ccs-on-another-bo-4-tiled-mtl-rc-ccs@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][90] ([i915#10307] / [i915#10434] / [i915#6095]) +5 other tests skip
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-4/igt@kms_ccs@[email protected]

* igt@kms_ccs@crc-primary-rotation-180-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][91] ([i915#6095]) +67 other tests skip
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-1/igt@kms_ccs@[email protected]

* igt@kms_ccs@crc-primary-rotation-180-4-tiled-xe2-ccs:
- shard-rkl: NOTRUN -> [SKIP][92] ([i915#10278]) +1 other test skip
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_ccs@random-ccs-data-4-tiled-mtl-mc-ccs@pipe-a-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][93] ([i915#6095]) +11 other tests skip
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@kms_ccs@[email protected]

* igt@kms_ccs@random-ccs-data-yf-tiled-ccs@pipe-a-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][94] ([i915#6095]) +87 other tests skip
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@kms_ccs@[email protected]

* igt@kms_cdclk@plane-scaling:
- shard-rkl: NOTRUN -> [SKIP][95] ([i915#3742]) +1 other test skip
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][96] ([i915#3742])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_cdclk@plane-scaling@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][97] ([i915#4087]) +3 other tests skip
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-10/igt@kms_cdclk@[email protected]

* igt@kms_chamelium_audio@hdmi-audio-edid:
- shard-dg1: NOTRUN -> [SKIP][98] ([i915#7828]) +6 other tests skip
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_chamelium_color@ctm-0-25:
- shard-dg2: NOTRUN -> [SKIP][99] +3 other tests skip
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- shard-tglu: NOTRUN -> [SKIP][100] ([i915#7828]) +3 other tests skip
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]

* igt@kms_chamelium_hpd@hdmi-hpd-after-suspend:
- shard-dg2: NOTRUN -> [SKIP][101] ([i915#7828]) +1 other test skip
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@kms_chamelium_hpd@vga-hpd-fast:
- shard-rkl: NOTRUN -> [SKIP][102] ([i915#7828]) +8 other tests skip
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_content_protection@atomic-dpms@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][103] ([i915#7173])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@kms_content_protection@[email protected]

* igt@kms_content_protection@dp-mst-type-1:
- shard-dg2: NOTRUN -> [SKIP][104] ([i915#3299])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_content_protection@uevent:
- shard-rkl: NOTRUN -> [SKIP][105] ([i915#7118] / [i915#9424])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_cursor_crc@cursor-onscreen-32x32:
- shard-rkl: NOTRUN -> [SKIP][106] ([i915#3555]) +8 other tests skip
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@[email protected]

* igt@kms_cursor_crc@cursor-onscreen-max-size:
- shard-dg2: NOTRUN -> [SKIP][107] ([i915#3555]) +2 other tests skip
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_cursor_crc@cursor-random-512x512:
- shard-dg1: NOTRUN -> [SKIP][108] ([i915#3359]) +2 other tests skip
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_cursor_crc@cursor-sliding-512x512:
- shard-rkl: NOTRUN -> [SKIP][109] ([i915#3359]) +1 other test skip
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size:
- shard-rkl: NOTRUN -> [SKIP][110] ([i915#4103])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size.html

* igt@kms_dirtyfb@drrs-dirtyfb-ioctl:
- shard-rkl: NOTRUN -> [SKIP][111] ([i915#9723]) +1 other test skip
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_dirtyfb@fbc-dirtyfb-ioctl@a-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][112] ([i915#9227])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-6/igt@kms_dirtyfb@[email protected]

* igt@kms_dirtyfb@fbc-dirtyfb-ioctl@a-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][113] ([i915#9723])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@kms_dirtyfb@[email protected]

* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][114] ([i915#3804])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@kms_dither@[email protected]

* igt@kms_draw_crc@draw-method-mmap-wc:
- shard-dg1: NOTRUN -> [SKIP][115] ([i915#8812])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@kms_dsc@dsc-fractional-bpp:
- shard-rkl: NOTRUN -> [SKIP][116] ([i915#3840])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_dsc@dsc-with-formats:
- shard-tglu: NOTRUN -> [SKIP][117] ([i915#3555] / [i915#3840])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]

* igt@kms_dsc@dsc-with-output-formats:
- shard-dg2: NOTRUN -> [SKIP][118] ([i915#3555] / [i915#3840]) +1 other test skip
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_feature_discovery@display-2x:
- shard-rkl: NOTRUN -> [SKIP][119] ([i915#1839])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@[email protected]

* igt@kms_feature_discovery@display-4x:
- shard-dg1: NOTRUN -> [SKIP][120] ([i915#1839])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_flip@2x-flip-vs-panning-interruptible:
- shard-tglu: NOTRUN -> [SKIP][121] ([i915#3637])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_flip@2x-plain-flip:
- shard-rkl: NOTRUN -> [SKIP][122] +54 other tests skip
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_flip@2x-plain-flip-interruptible:
- shard-dg1: NOTRUN -> [SKIP][123] ([i915#9934]) +1 other test skip
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@kms_flip@2x-plain-flip-ts-check:
- shard-tglu: NOTRUN -> [SKIP][124] ([i915#3637] / [i915#3966])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_flip@2x-wf_vblank-ts-check-interruptible@ab-vga1-hdmi-a1:
- shard-snb: [PASS][125] -> [FAIL][126] ([i915#2122])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-snb5/igt@kms_flip@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-snb7/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-dg1: NOTRUN -> [SKIP][127] ([i915#2587] / [i915#2672])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-valid-mode:
- shard-rkl: NOTRUN -> [SKIP][128] ([i915#2672]) +3 other tests skip
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@kms_flip_scaled_crc@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-tglu: NOTRUN -> [SKIP][129] ([i915#2587] / [i915#2672]) +1 other test skip
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][130] ([i915#2672])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-valid-mode.html

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-dg2: [PASS][131] -> [FAIL][132] ([i915#6880]) +1 other test fail
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-cpu.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
- shard-dg2: NOTRUN -> [SKIP][133] ([i915#5354]) +9 other tests skip
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-gtt:
- shard-dg1: NOTRUN -> [SKIP][134] ([i915#8708]) +11 other tests skip
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-dg2: NOTRUN -> [SKIP][135] ([i915#3458]) +5 other tests skip
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][136] ([i915#8708]) +3 other tests skip
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@fbcpsr-tiling-4:
- shard-dg1: NOTRUN -> [SKIP][137] ([i915#5439])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@kms_frontbuffer_tracking@pipe-fbc-rte:
- shard-rkl: NOTRUN -> [SKIP][138] ([i915#9766])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][139] ([i915#9766])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-blt:
- shard-dg1: NOTRUN -> [SKIP][140] ([i915#3458]) +7 other tests skip
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-rkl: NOTRUN -> [SKIP][141] ([i915#3023]) +29 other tests skip
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt:
- shard-rkl: NOTRUN -> [SKIP][142] ([i915#1825]) +39 other tests skip
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-rgb565-draw-blt:
- shard-tglu: NOTRUN -> [SKIP][143] +24 other tests skip
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_hdr@static-toggle:
- shard-rkl: NOTRUN -> [SKIP][144] ([i915#3555] / [i915#8228]) +3 other tests skip
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][145] ([i915#3555] / [i915#8228])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_plane_multiple@tiling-y:
- shard-dg2: NOTRUN -> [SKIP][146] ([i915#8806])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_plane_multiple@tiling-yf:
- shard-dg1: NOTRUN -> [SKIP][147] ([i915#3555]) +4 other tests skip
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-1:
- shard-tglu: NOTRUN -> [FAIL][148] ([i915#8292])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4:
- shard-dg1: NOTRUN -> [FAIL][149] ([i915#8292])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-17/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-c-hdmi-a-2:
- shard-dg2: NOTRUN -> [SKIP][150] ([i915#9423]) +7 other tests skip
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-c-hdmi-a-2.html

* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][151] ([i915#9423]) +9 other tests skip
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-d-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][152] ([i915#9423]) +11 other tests skip
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][153] ([i915#5176] / [i915#9423]) +1 other test skip
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-hdmi-a-1.html

* igt@kms_plane_scaling@plane-upscale-20x20-with-rotation@pipe-d-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][154] ([i915#9423]) +3 other tests skip
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-c-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][155] ([i915#5235]) +7 other tests skip
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][156] ([i915#5235]) +7 other tests skip
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-2.html

* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][157] ([i915#5235] / [i915#9423]) +15 other tests skip
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-10/igt@kms_plane_scaling@[email protected]

* igt@kms_pm_backlight@basic-brightness:
- shard-dg1: NOTRUN -> [SKIP][158] ([i915#5354])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@kms_pm_backlight@fade-with-dpms:
- shard-rkl: NOTRUN -> [SKIP][159] ([i915#5354]) +2 other tests skip
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_pm_dc@dc3co-vpb-simulation:
- shard-rkl: NOTRUN -> [SKIP][160] ([i915#9685])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@kms_pm_dc@dc6-dpms:
- shard-tglu: [PASS][161] -> [FAIL][162] ([i915#9295])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-tglu-10/igt@[email protected]
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-8/igt@[email protected]

* igt@kms_pm_lpsp@screens-disabled:
- shard-tglu: NOTRUN -> [SKIP][163] ([i915#8430])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]
- shard-dg2: NOTRUN -> [SKIP][164] ([i915#8430])
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@kms_pm_rpm@dpms-lpsp:
- shard-dg2: NOTRUN -> [SKIP][165] ([i915#9519])
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_pm_rpm@dpms-mode-unset-lpsp:
- shard-dg1: NOTRUN -> [SKIP][166] ([i915#9519])
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@kms_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-rkl: [PASS][167] -> [SKIP][168] ([i915#9519])
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-rkl-4/igt@[email protected]
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-1/igt@[email protected]

* igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-rkl: NOTRUN -> [SKIP][169] ([i915#9519])
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@kms_pm_rpm@pm-tiling:
- shard-dg2: NOTRUN -> [SKIP][170] ([i915#4077]) +3 other tests skip
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@kms_prime@basic-crc-hybrid:
- shard-rkl: NOTRUN -> [SKIP][171] ([i915#6524])
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_psr2_sf@fbc-overlay-plane-update-sf-dmg-area:
- shard-dg1: NOTRUN -> [SKIP][172] +35 other tests skip
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-dg1: NOTRUN -> [SKIP][173] ([i915#9683])
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@kms_psr2_su@page_flip-xrgb8888.html

* igt@kms_psr@fbc-pr-no-drrs:
- shard-tglu: NOTRUN -> [SKIP][174] ([i915#9732]) +7 other tests skip
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]

* igt@kms_psr@fbc-pr-suspend:
- shard-dg2: NOTRUN -> [SKIP][175] ([i915#1072] / [i915#9673] / [i915#9732]) +3 other tests skip
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_psr@fbc-psr2-sprite-blt:
- shard-dg2: NOTRUN -> [SKIP][176] ([i915#1072] / [i915#9732]) +2 other tests skip
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@kms_psr@fbc-psr2-sprite-render:
- shard-rkl: NOTRUN -> [SKIP][177] ([i915#1072] / [i915#9732]) +25 other tests skip
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@kms_psr@psr2-sprite-blt:
- shard-dg1: NOTRUN -> [SKIP][178] ([i915#1072] / [i915#9732]) +10 other tests skip
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-dg2: NOTRUN -> [SKIP][179] ([i915#9685])
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180:
- shard-rkl: NOTRUN -> [SKIP][180] ([i915#5289]) +2 other tests skip
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][181] ([i915#5289]) +1 other test skip
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_rotation_crc@sprite-rotation-270:
- shard-dg2: NOTRUN -> [SKIP][182] ([i915#4235]) +1 other test skip
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_scaling_modes@scaling-mode-full-aspect:
- shard-tglu: NOTRUN -> [SKIP][183] ([i915#3555]) +3 other tests skip
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]

* igt@kms_setmode@basic@pipe-a-vga-1-pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [FAIL][184] ([i915#5465]) +3 other tests fail
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-snb7/igt@kms_setmode@[email protected]

* igt@kms_tiled_display@basic-test-pattern-with-chamelium:
- shard-rkl: NOTRUN -> [SKIP][185] ([i915#8623])
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][186] ([i915#8623])
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_vrr@flip-basic-fastset:
- shard-dg1: NOTRUN -> [SKIP][187] ([i915#9906])
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_vrr@seamless-rr-switch-drrs:
- shard-rkl: NOTRUN -> [SKIP][188] ([i915#9906])
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][189] ([i915#9906])
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_writeback@writeback-fb-id-xrgb2101010:
- shard-rkl: NOTRUN -> [SKIP][190] ([i915#2437] / [i915#9412])
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_writeback@writeback-invalid-parameters:
- shard-dg1: NOTRUN -> [SKIP][191] ([i915#2437]) +1 other test skip
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]
- shard-dg2: NOTRUN -> [SKIP][192] ([i915#2437])
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@perf_pmu@cpu-hotplug:
- shard-rkl: NOTRUN -> [SKIP][193] ([i915#8850])
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@perf_pmu@rc6-all-gts:
- shard-dg1: NOTRUN -> [SKIP][194] ([i915#8516])
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@prime_vgem@fence-flip-hang:
- shard-rkl: NOTRUN -> [SKIP][195] ([i915#3708])
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@[email protected]

* igt@prime_vgem@fence-write-hang:
- shard-dg1: NOTRUN -> [SKIP][196] ([i915#3708])
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@sriov_basic@bind-unbind-vf:
- shard-dg2: NOTRUN -> [SKIP][197] ([i915#9917])
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@sriov_basic@enable-vfs-autoprobe-on:
- shard-tglu: NOTRUN -> [SKIP][198] ([i915#9917])
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]
- shard-rkl: NOTRUN -> [SKIP][199] ([i915#9917]) +1 other test skip
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]

* igt@syncobj_wait@invalid-wait-zero-handles:
- shard-rkl: NOTRUN -> [FAIL][200] ([i915#9779])
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@v3d/v3d_mmap@mmap-bad-handle:
- shard-dg2: NOTRUN -> [SKIP][201] ([i915#2575]) +1 other test skip
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@v3d/[email protected]

* igt@v3d/v3d_perfmon@create-perfmon-0:
- shard-dg1: NOTRUN -> [SKIP][202] ([i915#2575]) +6 other tests skip
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@v3d/[email protected]

* igt@v3d/v3d_submit_cl@single-in-sync:
- shard-tglu: NOTRUN -> [SKIP][203] ([i915#2575]) +5 other tests skip
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@v3d/[email protected]

* igt@vc4/vc4_label_bo@set-label:
- shard-rkl: NOTRUN -> [SKIP][204] ([i915#7711]) +9 other tests skip
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@vc4/[email protected]

* igt@vc4/vc4_purgeable_bo@access-purgeable-bo-mem:
- shard-dg1: NOTRUN -> [SKIP][205] ([i915#7711]) +4 other tests skip
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@vc4/[email protected]

* igt@vc4/vc4_tiling@get-bad-modifier:
- shard-dg2: NOTRUN -> [SKIP][206] ([i915#7711]) +1 other test skip
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@vc4/[email protected]

#### Possible fixes ####

* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- shard-rkl: [FAIL][207] ([i915#7742]) -> [PASS][208]
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-rkl-4/igt@drm_fdinfo@[email protected]
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@drm_fdinfo@[email protected]

* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglu: [FAIL][209] ([i915#6268]) -> [PASS][210]
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-tglu-5/igt@[email protected]
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-5/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-rkl: [FAIL][211] ([i915#2842]) -> [PASS][212]
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-rkl-1/igt@gem_exec_fair@[email protected]
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@heavy-verify-multi@lmem0:
- shard-dg1: [FAIL][213] ([i915#10378]) -> [PASS][214]
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg1-16/igt@gem_lmem_swapping@[email protected]
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-17/igt@gem_lmem_swapping@[email protected]
- shard-dg2: [FAIL][215] ([i915#10378]) -> [PASS][216] +1 other test pass
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-6/igt@gem_lmem_swapping@[email protected]
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-10/igt@gem_lmem_swapping@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-tglu: [INCOMPLETE][217] ([i915#10047] / [i915#9820]) -> [PASS][218]
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-tglu-5/igt@[email protected]
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]
- shard-dg2: [ABORT][219] ([i915#9820]) -> [PASS][220]
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-8/igt@[email protected]
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@i915_pm_freq_api@freq-suspend@gt0:
- shard-dg2: [INCOMPLETE][221] ([i915#9407]) -> [PASS][222]
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-10/igt@i915_pm_freq_api@[email protected]
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@i915_pm_freq_api@[email protected]

* igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
- shard-snb: [SKIP][223] -> [PASS][224]
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-snb5/igt@[email protected]
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-snb7/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1:
- shard-snb: [INCOMPLETE][225] ([i915#4839]) -> [PASS][226]
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-snb6/igt@kms_flip@[email protected]
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-snb2/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-dg2: [FAIL][227] ([i915#6880]) -> [PASS][228]
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-5/igt@[email protected]
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-10/igt@[email protected]

* igt@kms_pm_rpm@i2c:
- shard-dg2: [FAIL][229] ([i915#8717]) -> [PASS][230]
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-2/igt@[email protected]
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-10/igt@[email protected]

* igt@kms_pm_rpm@modeset-lpsp-stress:
- shard-rkl: [SKIP][231] ([i915#9519]) -> [PASS][232]
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-rkl-3/igt@[email protected]
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]

* igt@kms_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-dg2: [SKIP][233] ([i915#9519]) -> [PASS][234] +2 other tests pass
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-6/igt@[email protected]
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-10/igt@[email protected]

* igt@kms_setmode@basic@pipe-a-hdmi-a-1:
- shard-snb: [FAIL][235] ([i915#5465]) -> [PASS][236] +1 other test pass
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-snb5/igt@kms_setmode@[email protected]
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-snb7/igt@kms_setmode@[email protected]

* igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1:
- shard-tglu: [FAIL][237] ([i915#9196]) -> [PASS][238]
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-tglu-8/igt@kms_universal_plane@[email protected]
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-5/igt@kms_universal_plane@[email protected]

#### Warnings ####

* igt@gem_lmem_swapping@heavy-verify-random-ccs@lmem0:
- shard-dg2: [FAIL][239] ([i915#10446]) -> [FAIL][240] ([i915#10378])
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-8/igt@gem_lmem_swapping@[email protected]
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@gem_lmem_swapping@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-dg1: [ABORT][241] ([i915#9820]) -> [INCOMPLETE][242] ([i915#1982] / [i915#9820] / [i915#9849])
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg1-13/igt@[email protected]
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-16/igt@[email protected]

* igt@kms_content_protection@mei-interface:
- shard-dg1: [SKIP][243] ([i915#9433]) -> [SKIP][244] ([i915#9424])
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg1-13/igt@[email protected]
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-16/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-cpu:
- shard-dg2: [SKIP][245] ([i915#10433] / [i915#3458]) -> [SKIP][246] ([i915#3458]) +1 other test skip
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-4/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-cpu.html
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
- shard-dg2: [SKIP][247] ([i915#3458]) -> [SKIP][248] ([i915#10433] / [i915#3458]) +4 other tests skip
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-7/igt@[email protected]
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-4/igt@[email protected]

* igt@kms_psr@pr-cursor-plane-move:
- shard-dg2: [SKIP][249] ([i915#1072] / [i915#9673] / [i915#9732]) -> [SKIP][250] ([i915#1072] / [i915#9732]) +8 other tests skip
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-11/igt@[email protected]
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-1/igt@[email protected]

* igt@kms_psr@psr-primary-mmap-cpu:
- shard-dg2: [SKIP][251] ([i915#1072] / [i915#9732]) -> [SKIP][252] ([i915#1072] / [i915#9673] / [i915#9732]) +10 other tests skip
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-8/igt@[email protected]
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: [FAIL][253] ([i915#7484]) -> [FAIL][254] ([i915#9100])
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-8/igt@perf@[email protected]
[254]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@perf@[email protected]

[i915#10031]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10031
[i915#10047]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10047
[i915#10131]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10131
[i915#10278]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10278
[i915#10307]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10307
[i915#10378]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10378
[i915#10433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10433
[i915#10434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10434
[i915#10446]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10446
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#10887]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10887
[i915#1825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1839
[i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982
[i915#2017]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2017
[i915#2122]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2122
[i915#2437]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3804
[i915#3826]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#3966]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3966
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4087]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4087
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4212
[i915#4235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4235
[i915#4270]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4270
[i915#4387]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4812
[i915#4839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4839
[i915#4852]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4880
[i915#5176]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5176
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#5439]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5439
[i915#5465]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5465
[i915#5723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5723
[i915#6095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6268
[i915#6344]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6344
[i915#6412]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6412
[i915#6524]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6524
[i915#6621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6621
[i915#6880]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6880
[i915#7118]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7118
[i915#7173]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7173
[i915#7484]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7484
[i915#7697]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7697
[i915#7707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7828
[i915#7975]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7975
[i915#8213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8228
[i915#8292]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8292
[i915#8411]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8411
[i915#8414]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8414
[i915#8428]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8428
[i915#8430]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8430
[i915#8516]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8516
[i915#8555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8555
[i915#8623]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8623
[i915#8708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8708
[i915#8709]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8709
[i915#8717]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8717
[i915#8806]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8806
[i915#8812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8812
[i915#8850]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8850
[i915#8925]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8925
[i915#9100]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9100
[i915#9196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9196
[i915#9227]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9227
[i915#9295]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9295
[i915#9323]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9323
[i915#9407]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9407
[i915#9412]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9412
[i915#9423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9423
[i915#9424]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9424
[i915#9433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9433
[i915#9519]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9519
[i915#9531]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9531
[i915#9606]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9606
[i915#9673]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9673
[i915#9683]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9683
[i915#9685]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9685
[i915#9697]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9697
[i915#9723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9723
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9766]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9766
[i915#9779]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9779
[i915#9820]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9820
[i915#9849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9849
[i915#9906]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9906
[i915#9917]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9917
[i915#9934]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9934

Build changes
-------------

* Linux: CI_DRM_14785 -> Patchwork_133624v3

CI-20190529: 20190529
CI_DRM_14785: 1ba62f8cea9c797427d45108df1d453f4b343240 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7863: fa1dc232d5d840532521df8a6fcf1fe82c514304 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_133624v3: 1ba62f8cea9c797427d45108df1d453f4b343240 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/index.html

#60 lore raw

✓ Fi.CI.IGT: success for drm/i915/dp_mst: Enable link training fallback (rev3)

In reply to Imre Deak
== Series Details ==

== Series Details ==

Series: drm/i915/dp_mst: Enable link training fallback (rev3)
URL : https://patchwork.freedesktop.org/series/133624/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_14785_full -> Patchwork_133624v3_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (9 -> 9)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in Patchwork_133624v3_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@device_reset@unbind-reset-rebind:
- shard-dg1: NOTRUN -> [ABORT][1] ([i915#11164])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@drm_fdinfo@virtual-busy-idle-all:
- shard-dg1: NOTRUN -> [SKIP][2] ([i915#8414]) +1 other test skip
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@drm_fdinfo@virtual-idle:
- shard-rkl: NOTRUN -> [FAIL][3] ([i915#7742])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@gem_ccs@block-multicopy-compressed:
- shard-rkl: NOTRUN -> [SKIP][4] ([i915#9323])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@gem_ccs@ctrl-surf-copy:
- shard-dg1: NOTRUN -> [SKIP][5] ([i915#3555] / [i915#9323])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gem_close_race@multigpu-basic-process:
- shard-rkl: NOTRUN -> [SKIP][6] ([i915#7697])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@[email protected]

* igt@gem_ctx_exec@basic-nohangcheck:
- shard-rkl: [PASS][7] -> [FAIL][8] ([i915#6268])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-rkl-3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]

* igt@gem_ctx_persistence@heartbeat-stop:
- shard-dg2: NOTRUN -> [SKIP][9] ([i915#8555])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@gem_exec_balancer@bonded-sync:
- shard-dg1: NOTRUN -> [SKIP][10] ([i915#4771])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gem_exec_balancer@parallel-ordering:
- shard-rkl: NOTRUN -> [SKIP][11] ([i915#4525]) +1 other test skip
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@[email protected]

* igt@gem_exec_capture@capture-recoverable:
- shard-rkl: NOTRUN -> [SKIP][12] ([i915#6344])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@gem_exec_capture@many-4k-incremental:
- shard-dg1: NOTRUN -> [FAIL][13] ([i915#9606])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-dg1: NOTRUN -> [SKIP][14] ([i915#3539] / [i915#4852]) +5 other tests skip
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gem_exec_fair@basic-pace:
- shard-dg2: NOTRUN -> [SKIP][15] ([i915#3539])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglu: [PASS][16] -> [FAIL][17] ([i915#2842])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-tglu-6/igt@gem_exec_fair@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-rkl: NOTRUN -> [FAIL][18] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglu: NOTRUN -> [FAIL][19] ([i915#2842]) +5 other tests fail
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle:
- shard-dg1: NOTRUN -> [SKIP][20] ([i915#3539])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gem_exec_reloc@basic-scanout:
- shard-rkl: NOTRUN -> [SKIP][21] ([i915#3281]) +9 other tests skip
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@gem_exec_reloc@basic-write-gtt-active:
- shard-dg1: NOTRUN -> [SKIP][22] ([i915#3281]) +3 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gem_exec_reloc@basic-write-read-active:
- shard-dg2: NOTRUN -> [SKIP][23] ([i915#3281]) +5 other tests skip
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@gem_exec_schedule@pi-distinct-iova:
- shard-snb: NOTRUN -> [SKIP][24] +25 other tests skip
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-snb2/igt@[email protected]

* igt@gem_exec_schedule@reorder-wide:
- shard-dg1: NOTRUN -> [SKIP][25] ([i915#4812]) +1 other test skip
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gem_exec_suspend@basic-s4-devices@smem:
- shard-rkl: NOTRUN -> [ABORT][26] ([i915#7975] / [i915#8213])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@gem_exec_suspend@[email protected]

* igt@gem_fenced_exec_thrash@no-spare-fences-interruptible:
- shard-dg2: NOTRUN -> [SKIP][27] ([i915#4860])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@gem_lmem_swapping@basic@lmem0:
- shard-dg2: [PASS][28] -> [FAIL][29] ([i915#10378]) +1 other test fail
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-1/igt@gem_lmem_swapping@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-4/igt@gem_lmem_swapping@[email protected]

* igt@gem_lmem_swapping@heavy-multi@lmem0:
- shard-dg1: [PASS][30] -> [FAIL][31] ([i915#10378])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg1-16/igt@gem_lmem_swapping@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-16/igt@gem_lmem_swapping@[email protected]

* igt@gem_lmem_swapping@heavy-random@lmem0:
- shard-dg1: NOTRUN -> [FAIL][32] ([i915#10378])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@gem_lmem_swapping@[email protected]

* igt@gem_lmem_swapping@massive-random:
- shard-tglu: NOTRUN -> [SKIP][33] ([i915#4613])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-rkl: NOTRUN -> [SKIP][34] ([i915#4613]) +4 other tests skip
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@gem_lmem_swapping@verify-random-ccs:
- shard-glk: NOTRUN -> [SKIP][35] ([i915#4613]) +1 other test skip
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-glk6/igt@[email protected]

* igt@gem_mmap_wc@bad-size:
- shard-dg2: NOTRUN -> [SKIP][36] ([i915#4083]) +2 other tests skip
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@gem_mmap_wc@invalid-flags:
- shard-dg1: NOTRUN -> [SKIP][37] ([i915#4083]) +2 other tests skip
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gem_partial_pwrite_pread@writes-after-reads:
- shard-dg1: NOTRUN -> [SKIP][38] ([i915#3282]) +3 other tests skip
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gem_pwrite@basic-random:
- shard-dg2: NOTRUN -> [SKIP][39] ([i915#3282]) +2 other tests skip
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@gem_pwrite@basic-self:
- shard-rkl: NOTRUN -> [SKIP][40] ([i915#3282]) +8 other tests skip
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@gem_pxp@create-regular-buffer:
- shard-rkl: NOTRUN -> [SKIP][41] ([i915#4270]) +4 other tests skip
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]

* igt@gem_pxp@protected-encrypted-src-copy-not-readible:
- shard-dg1: NOTRUN -> [SKIP][42] ([i915#4270]) +2 other tests skip
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@gem_pxp@verify-pxp-key-change-after-suspend-resume:
- shard-tglu: NOTRUN -> [SKIP][43] ([i915#4270]) +1 other test skip
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-y-tiled:
- shard-dg2: NOTRUN -> [SKIP][44] ([i915#5190] / [i915#8428]) +1 other test skip
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@gem_set_tiling_vs_blt@tiled-to-tiled:
- shard-dg1: NOTRUN -> [SKIP][45] ([i915#4079])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@gem_set_tiling_vs_blt@tiled-to-untiled:
- shard-rkl: NOTRUN -> [SKIP][46] ([i915#8411])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@gem_tiled_partial_pwrite_pread@writes-after-reads:
- shard-dg1: NOTRUN -> [SKIP][47] ([i915#4077]) +6 other tests skip
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@gem_userptr_blits@create-destroy-unsync:
- shard-rkl: NOTRUN -> [SKIP][48] ([i915#3297]) +2 other tests skip
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate:
- shard-dg1: NOTRUN -> [SKIP][49] ([i915#3297] / [i915#4880])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@gem_userptr_blits@unsync-unmap:
- shard-dg1: NOTRUN -> [SKIP][50] ([i915#3297]) +1 other test skip
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@gen9_exec_parse@basic-rejected-ctx-param:
- shard-tglu: NOTRUN -> [SKIP][51] ([i915#2527] / [i915#2856])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@gen9_exec_parse@bb-chained:
- shard-dg1: NOTRUN -> [SKIP][52] ([i915#2527])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@gen9_exec_parse@unaligned-access:
- shard-rkl: NOTRUN -> [SKIP][53] ([i915#2527]) +4 other tests skip
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-rkl: [PASS][54] -> [ABORT][55] ([i915#9820])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-rkl-5/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]
- shard-glk: [PASS][56] -> [INCOMPLETE][57] ([i915#9849])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-glk8/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-glk8/igt@[email protected]
- shard-mtlp: [PASS][58] -> [ABORT][59] ([i915#10131] / [i915#10887] / [i915#9697])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-mtlp-1/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-mtlp-8/igt@[email protected]

* igt@i915_module_load@resize-bar:
- shard-rkl: NOTRUN -> [SKIP][60] ([i915#6412])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-glk: NOTRUN -> [SKIP][61] +70 other tests skip
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-glk6/igt@[email protected]

* igt@i915_pm_rps@basic-api:
- shard-dg1: NOTRUN -> [SKIP][62] ([i915#6621])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@i915_pm_rps@reset:
- shard-tglu: NOTRUN -> [INCOMPLETE][63] ([i915#11165])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]

* igt@i915_pm_rps@thresholds-idle@gt0:
- shard-dg1: NOTRUN -> [SKIP][64] ([i915#8925])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@i915_pm_rps@[email protected]

* igt@i915_pm_sseu@full-enable:
- shard-rkl: NOTRUN -> [SKIP][65] ([i915#4387])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][66] ([i915#4387])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@i915_query@test-query-geometry-subslices:
- shard-rkl: NOTRUN -> [SKIP][67] ([i915#5723])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- shard-rkl: [PASS][68] -> [FAIL][69] ([i915#10031])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-rkl-5/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@intel_hwmon@hwmon-read:
- shard-tglu: NOTRUN -> [SKIP][70] ([i915#7707])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]

* igt@intel_hwmon@hwmon-write:
- shard-rkl: NOTRUN -> [SKIP][71] ([i915#7707])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling:
- shard-dg1: NOTRUN -> [SKIP][72] ([i915#4212])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- shard-rkl: NOTRUN -> [SKIP][73] ([i915#3826])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@[email protected]

* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-1-y-rc-ccs-cc:
- shard-rkl: NOTRUN -> [SKIP][74] ([i915#8709]) +3 other tests skip
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-1-y-rc-ccs-cc.html

* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-3-y-rc-ccs:
- shard-dg1: NOTRUN -> [SKIP][75] ([i915#8709]) +7 other tests skip
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@kms_async_flips@[email protected]

* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-dg1: NOTRUN -> [SKIP][76] ([i915#9531])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_big_fb@4-tiled-8bpp-rotate-0:
- shard-rkl: NOTRUN -> [SKIP][77] ([i915#5286]) +7 other tests skip
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@kms_big_fb@4-tiled-addfb:
- shard-tglu: NOTRUN -> [SKIP][78] ([i915#5286]) +2 other tests skip
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0:
- shard-dg1: NOTRUN -> [SKIP][79] ([i915#4538] / [i915#5286]) +1 other test skip
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-mtlp: [PASS][80] -> [DMESG-FAIL][81] ([i915#2017])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-mtlp-5/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-mtlp-2/igt@[email protected]

* igt@kms_big_fb@linear-64bpp-rotate-90:
- shard-rkl: NOTRUN -> [SKIP][82] ([i915#3638]) +2 other tests skip
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_big_fb@y-tiled-64bpp-rotate-270:
- shard-dg1: NOTRUN -> [SKIP][83] ([i915#3638]) +2 other tests skip
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-dg2: NOTRUN -> [SKIP][84] ([i915#4538] / [i915#5190]) +3 other tests skip
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html

* igt@kms_big_fb@yf-tiled-32bpp-rotate-270:
- shard-dg1: NOTRUN -> [SKIP][85] ([i915#4538])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@kms_ccs@bad-rotation-90-4-tiled-xe2-ccs:
- shard-dg1: NOTRUN -> [SKIP][86] ([i915#10278])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_ccs@bad-rotation-90-y-tiled-gen12-rc-ccs-cc@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [SKIP][87] ([i915#10307] / [i915#6095]) +173 other tests skip
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@kms_ccs@[email protected]

* igt@kms_ccs@ccs-on-another-bo-4-tiled-mtl-rc-ccs@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][88] ([i915#10307] / [i915#10434] / [i915#6095]) +5 other tests skip
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-4/igt@kms_ccs@[email protected]

* igt@kms_ccs@crc-primary-rotation-180-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][89] ([i915#6095]) +67 other tests skip
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-1/igt@kms_ccs@[email protected]

* igt@kms_ccs@crc-primary-rotation-180-4-tiled-xe2-ccs:
- shard-rkl: NOTRUN -> [SKIP][90] ([i915#10278]) +1 other test skip
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_ccs@random-ccs-data-4-tiled-mtl-mc-ccs@pipe-a-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][91] ([i915#6095]) +11 other tests skip
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@kms_ccs@[email protected]

* igt@kms_ccs@random-ccs-data-yf-tiled-ccs@pipe-a-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][92] ([i915#6095]) +87 other tests skip
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@kms_ccs@[email protected]

* igt@kms_cdclk@plane-scaling:
- shard-rkl: NOTRUN -> [SKIP][93] ([i915#3742]) +1 other test skip
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][94] ([i915#3742])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_cdclk@plane-scaling@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][95] ([i915#4087]) +3 other tests skip
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-10/igt@kms_cdclk@[email protected]

* igt@kms_chamelium_audio@hdmi-audio-edid:
- shard-dg1: NOTRUN -> [SKIP][96] ([i915#7828]) +6 other tests skip
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_chamelium_color@ctm-0-25:
- shard-dg2: NOTRUN -> [SKIP][97] +3 other tests skip
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- shard-tglu: NOTRUN -> [SKIP][98] ([i915#7828]) +3 other tests skip
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]

* igt@kms_chamelium_hpd@hdmi-hpd-after-suspend:
- shard-dg2: NOTRUN -> [SKIP][99] ([i915#7828]) +1 other test skip
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@kms_chamelium_hpd@vga-hpd-fast:
- shard-rkl: NOTRUN -> [SKIP][100] ([i915#7828]) +8 other tests skip
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_content_protection@atomic-dpms@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][101] ([i915#7173])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@kms_content_protection@[email protected]

* igt@kms_content_protection@dp-mst-type-1:
- shard-dg2: NOTRUN -> [SKIP][102] ([i915#3299])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_content_protection@uevent:
- shard-rkl: NOTRUN -> [SKIP][103] ([i915#7118] / [i915#9424])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_cursor_crc@cursor-onscreen-32x32:
- shard-rkl: NOTRUN -> [SKIP][104] ([i915#3555]) +8 other tests skip
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@[email protected]

* igt@kms_cursor_crc@cursor-onscreen-max-size:
- shard-dg2: NOTRUN -> [SKIP][105] ([i915#3555]) +2 other tests skip
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_cursor_crc@cursor-random-512x512:
- shard-dg1: NOTRUN -> [SKIP][106] ([i915#3359]) +2 other tests skip
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_cursor_crc@cursor-sliding-512x512:
- shard-rkl: NOTRUN -> [SKIP][107] ([i915#3359]) +1 other test skip
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size:
- shard-rkl: NOTRUN -> [SKIP][108] ([i915#4103])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size.html

* igt@kms_dirtyfb@drrs-dirtyfb-ioctl:
- shard-rkl: NOTRUN -> [SKIP][109] ([i915#9723]) +1 other test skip
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_dirtyfb@fbc-dirtyfb-ioctl@a-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][110] ([i915#9227])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-6/igt@kms_dirtyfb@[email protected]

* igt@kms_dirtyfb@fbc-dirtyfb-ioctl@a-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][111] ([i915#9723])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@kms_dirtyfb@[email protected]

* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][112] ([i915#3804])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@kms_dither@[email protected]

* igt@kms_draw_crc@draw-method-mmap-wc:
- shard-dg1: NOTRUN -> [SKIP][113] ([i915#8812])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@kms_dsc@dsc-fractional-bpp:
- shard-rkl: NOTRUN -> [SKIP][114] ([i915#3840])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_dsc@dsc-with-formats:
- shard-tglu: NOTRUN -> [SKIP][115] ([i915#3555] / [i915#3840])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]

* igt@kms_dsc@dsc-with-output-formats:
- shard-dg2: NOTRUN -> [SKIP][116] ([i915#3555] / [i915#3840]) +1 other test skip
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_feature_discovery@display-2x:
- shard-rkl: NOTRUN -> [SKIP][117] ([i915#1839])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@[email protected]

* igt@kms_feature_discovery@display-4x:
- shard-dg1: NOTRUN -> [SKIP][118] ([i915#1839])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_flip@2x-flip-vs-panning-interruptible:
- shard-tglu: NOTRUN -> [SKIP][119] ([i915#3637])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_flip@2x-plain-flip:
- shard-rkl: NOTRUN -> [SKIP][120] +54 other tests skip
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_flip@2x-plain-flip-interruptible:
- shard-dg1: NOTRUN -> [SKIP][121] ([i915#9934]) +1 other test skip
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@kms_flip@2x-plain-flip-ts-check:
- shard-tglu: NOTRUN -> [SKIP][122] ([i915#3637] / [i915#3966])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_flip@2x-wf_vblank-ts-check-interruptible@ab-vga1-hdmi-a1:
- shard-snb: [PASS][123] -> [FAIL][124] ([i915#2122])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-snb5/igt@kms_flip@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-snb7/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-dg1: NOTRUN -> [SKIP][125] ([i915#2587] / [i915#2672])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-valid-mode:
- shard-rkl: NOTRUN -> [SKIP][126] ([i915#2672]) +3 other tests skip
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@kms_flip_scaled_crc@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-tglu: NOTRUN -> [SKIP][127] ([i915#2587] / [i915#2672]) +1 other test skip
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][128] ([i915#2672])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-valid-mode.html

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-dg2: [PASS][129] -> [FAIL][130] ([i915#6880]) +1 other test fail
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-cpu.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
- shard-dg2: NOTRUN -> [SKIP][131] ([i915#5354]) +9 other tests skip
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-gtt:
- shard-dg1: NOTRUN -> [SKIP][132] ([i915#8708]) +11 other tests skip
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-dg2: NOTRUN -> [SKIP][133] ([i915#3458]) +5 other tests skip
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][134] ([i915#8708]) +3 other tests skip
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@fbcpsr-tiling-4:
- shard-dg1: NOTRUN -> [SKIP][135] ([i915#5439])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@kms_frontbuffer_tracking@pipe-fbc-rte:
- shard-rkl: NOTRUN -> [SKIP][136] ([i915#9766])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][137] ([i915#9766])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-blt:
- shard-dg1: NOTRUN -> [SKIP][138] ([i915#3458]) +7 other tests skip
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-rkl: NOTRUN -> [SKIP][139] ([i915#3023]) +29 other tests skip
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt:
- shard-rkl: NOTRUN -> [SKIP][140] ([i915#1825]) +39 other tests skip
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-rgb565-draw-blt:
- shard-tglu: NOTRUN -> [SKIP][141] +24 other tests skip
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_hdr@static-toggle:
- shard-rkl: NOTRUN -> [SKIP][142] ([i915#3555] / [i915#8228]) +3 other tests skip
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][143] ([i915#3555] / [i915#8228])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_plane_multiple@tiling-y:
- shard-dg2: NOTRUN -> [SKIP][144] ([i915#8806])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_plane_multiple@tiling-yf:
- shard-dg1: NOTRUN -> [SKIP][145] ([i915#3555]) +4 other tests skip
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-1:
- shard-tglu: NOTRUN -> [FAIL][146] ([i915#8292])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4:
- shard-dg1: NOTRUN -> [FAIL][147] ([i915#8292])
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-17/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-c-hdmi-a-2:
- shard-dg2: NOTRUN -> [SKIP][148] ([i915#9423]) +7 other tests skip
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-c-hdmi-a-2.html

* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][149] ([i915#9423]) +9 other tests skip
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-d-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][150] ([i915#9423]) +11 other tests skip
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][151] ([i915#5176] / [i915#9423]) +1 other test skip
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-hdmi-a-1.html

* igt@kms_plane_scaling@plane-upscale-20x20-with-rotation@pipe-d-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][152] ([i915#9423]) +3 other tests skip
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-c-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][153] ([i915#5235]) +7 other tests skip
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][154] ([i915#5235]) +7 other tests skip
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-2.html

* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][155] ([i915#5235] / [i915#9423]) +15 other tests skip
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-10/igt@kms_plane_scaling@[email protected]

* igt@kms_pm_backlight@basic-brightness:
- shard-dg1: NOTRUN -> [SKIP][156] ([i915#5354])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@kms_pm_backlight@fade-with-dpms:
- shard-rkl: NOTRUN -> [SKIP][157] ([i915#5354]) +2 other tests skip
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_pm_dc@dc3co-vpb-simulation:
- shard-rkl: NOTRUN -> [SKIP][158] ([i915#9685])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@kms_pm_dc@dc6-dpms:
- shard-tglu: [PASS][159] -> [FAIL][160] ([i915#9295])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-tglu-10/igt@[email protected]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-8/igt@[email protected]

* igt@kms_pm_lpsp@screens-disabled:
- shard-tglu: NOTRUN -> [SKIP][161] ([i915#8430])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]
- shard-dg2: NOTRUN -> [SKIP][162] ([i915#8430])
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@kms_pm_rpm@dpms-lpsp:
- shard-dg2: NOTRUN -> [SKIP][163] ([i915#9519])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_pm_rpm@dpms-mode-unset-lpsp:
- shard-dg1: NOTRUN -> [SKIP][164] ([i915#9519])
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@kms_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-rkl: [PASS][165] -> [SKIP][166] ([i915#9519])
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-rkl-4/igt@[email protected]
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-1/igt@[email protected]

* igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-rkl: NOTRUN -> [SKIP][167] ([i915#9519])
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@kms_pm_rpm@pm-tiling:
- shard-dg2: NOTRUN -> [SKIP][168] ([i915#4077]) +3 other tests skip
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@kms_prime@basic-crc-hybrid:
- shard-rkl: NOTRUN -> [SKIP][169] ([i915#6524])
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_psr2_sf@fbc-overlay-plane-update-sf-dmg-area:
- shard-dg1: NOTRUN -> [SKIP][170] +35 other tests skip
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-dg1: NOTRUN -> [SKIP][171] ([i915#9683])
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@kms_psr2_su@page_flip-xrgb8888.html

* igt@kms_psr@fbc-pr-no-drrs:
- shard-tglu: NOTRUN -> [SKIP][172] ([i915#9732]) +7 other tests skip
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]

* igt@kms_psr@fbc-pr-suspend:
- shard-dg2: NOTRUN -> [SKIP][173] ([i915#1072] / [i915#9673] / [i915#9732]) +3 other tests skip
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_psr@fbc-psr2-sprite-blt:
- shard-dg2: NOTRUN -> [SKIP][174] ([i915#1072] / [i915#9732]) +2 other tests skip
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@kms_psr@fbc-psr2-sprite-render:
- shard-rkl: NOTRUN -> [SKIP][175] ([i915#1072] / [i915#9732]) +25 other tests skip
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@kms_psr@psr2-sprite-blt:
- shard-dg1: NOTRUN -> [SKIP][176] ([i915#1072] / [i915#9732]) +10 other tests skip
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-dg2: NOTRUN -> [SKIP][177] ([i915#9685])
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180:
- shard-rkl: NOTRUN -> [SKIP][178] ([i915#5289]) +2 other tests skip
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][179] ([i915#5289]) +1 other test skip
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_rotation_crc@sprite-rotation-270:
- shard-dg2: NOTRUN -> [SKIP][180] ([i915#4235]) +1 other test skip
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@kms_scaling_modes@scaling-mode-full-aspect:
- shard-tglu: NOTRUN -> [SKIP][181] ([i915#3555]) +3 other tests skip
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]

* igt@kms_setmode@basic@pipe-a-vga-1-pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [FAIL][182] ([i915#5465]) +3 other tests fail
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-snb7/igt@kms_setmode@[email protected]

* igt@kms_tiled_display@basic-test-pattern-with-chamelium:
- shard-rkl: NOTRUN -> [SKIP][183] ([i915#8623])
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][184] ([i915#8623])
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_vrr@flip-basic-fastset:
- shard-dg1: NOTRUN -> [SKIP][185] ([i915#9906])
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@kms_vrr@seamless-rr-switch-drrs:
- shard-rkl: NOTRUN -> [SKIP][186] ([i915#9906])
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]
- shard-tglu: NOTRUN -> [SKIP][187] ([i915#9906]) +1 other test skip
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]

* igt@kms_vrr@seamless-rr-switch-virtual:
- shard-dg2: NOTRUN -> [SKIP][188] ([i915#9906])
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@kms_writeback@writeback-fb-id-xrgb2101010:
- shard-rkl: NOTRUN -> [SKIP][189] ([i915#2437] / [i915#9412])
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@kms_writeback@writeback-invalid-parameters:
- shard-dg1: NOTRUN -> [SKIP][190] ([i915#2437]) +1 other test skip
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]
- shard-dg2: NOTRUN -> [SKIP][191] ([i915#2437])
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@perf_pmu@cpu-hotplug:
- shard-rkl: NOTRUN -> [SKIP][192] ([i915#8850])
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-2/igt@[email protected]

* igt@perf_pmu@rc6-all-gts:
- shard-dg1: NOTRUN -> [SKIP][193] ([i915#8516])
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@[email protected]

* igt@prime_vgem@fence-flip-hang:
- shard-rkl: NOTRUN -> [SKIP][194] ([i915#3708])
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-4/igt@[email protected]

* igt@prime_vgem@fence-write-hang:
- shard-dg1: NOTRUN -> [SKIP][195] ([i915#3708])
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@[email protected]

* igt@sriov_basic@bind-unbind-vf:
- shard-dg2: NOTRUN -> [SKIP][196] ([i915#9917])
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@sriov_basic@enable-vfs-autoprobe-on:
- shard-tglu: NOTRUN -> [SKIP][197] ([i915#9917])
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@[email protected]
- shard-rkl: NOTRUN -> [SKIP][198] ([i915#9917]) +1 other test skip
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]

* igt@syncobj_wait@invalid-wait-zero-handles:
- shard-rkl: NOTRUN -> [FAIL][199] ([i915#9779])
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@[email protected]

* igt@v3d/v3d_mmap@mmap-bad-handle:
- shard-dg2: NOTRUN -> [SKIP][200] ([i915#2575]) +1 other test skip
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@v3d/[email protected]

* igt@v3d/v3d_perfmon@create-perfmon-0:
- shard-dg1: NOTRUN -> [SKIP][201] ([i915#2575]) +6 other tests skip
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-13/igt@v3d/[email protected]

* igt@v3d/v3d_submit_cl@single-in-sync:
- shard-tglu: NOTRUN -> [SKIP][202] ([i915#2575]) +5 other tests skip
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-7/igt@v3d/[email protected]

* igt@vc4/vc4_label_bo@set-label:
- shard-rkl: NOTRUN -> [SKIP][203] ([i915#7711]) +9 other tests skip
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@vc4/[email protected]

* igt@vc4/vc4_purgeable_bo@access-purgeable-bo-mem:
- shard-dg1: NOTRUN -> [SKIP][204] ([i915#7711]) +4 other tests skip
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-18/igt@vc4/[email protected]

* igt@vc4/vc4_tiling@get-bad-modifier:
- shard-dg2: NOTRUN -> [SKIP][205] ([i915#7711]) +1 other test skip
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@vc4/[email protected]

#### Possible fixes ####

* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- shard-rkl: [FAIL][206] ([i915#7742]) -> [PASS][207]
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-rkl-4/igt@drm_fdinfo@[email protected]
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@drm_fdinfo@[email protected]

* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglu: [FAIL][208] ([i915#6268]) -> [PASS][209]
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-tglu-5/igt@[email protected]
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-5/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-rkl: [FAIL][210] ([i915#2842]) -> [PASS][211]
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-rkl-1/igt@gem_exec_fair@[email protected]
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-3/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@heavy-verify-multi@lmem0:
- shard-dg1: [FAIL][212] ([i915#10378]) -> [PASS][213]
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg1-16/igt@gem_lmem_swapping@[email protected]
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-17/igt@gem_lmem_swapping@[email protected]
- shard-dg2: [FAIL][214] ([i915#10378]) -> [PASS][215] +1 other test pass
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-6/igt@gem_lmem_swapping@[email protected]
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-10/igt@gem_lmem_swapping@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-tglu: [INCOMPLETE][216] ([i915#10047] / [i915#9820]) -> [PASS][217]
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-tglu-5/igt@[email protected]
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-10/igt@[email protected]
- shard-dg2: [ABORT][218] ([i915#9820]) -> [PASS][219]
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-8/igt@[email protected]
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@[email protected]

* igt@i915_pm_freq_api@freq-suspend@gt0:
- shard-dg2: [INCOMPLETE][220] ([i915#9407]) -> [PASS][221]
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-10/igt@i915_pm_freq_api@[email protected]
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@i915_pm_freq_api@[email protected]

* igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
- shard-snb: [SKIP][222] -> [PASS][223]
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-snb5/igt@[email protected]
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-snb7/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1:
- shard-snb: [INCOMPLETE][224] ([i915#4839]) -> [PASS][225]
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-snb6/igt@kms_flip@[email protected]
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-snb2/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-dg2: [FAIL][226] ([i915#6880]) -> [PASS][227]
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-5/igt@[email protected]
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-10/igt@[email protected]

* igt@kms_pm_rpm@i2c:
- shard-dg2: [FAIL][228] ([i915#8717]) -> [PASS][229]
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-2/igt@[email protected]
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-10/igt@[email protected]

* igt@kms_pm_rpm@modeset-lpsp-stress:
- shard-rkl: [SKIP][230] ([i915#9519]) -> [PASS][231]
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-rkl-3/igt@[email protected]
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-rkl-5/igt@[email protected]

* igt@kms_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-dg2: [SKIP][232] ([i915#9519]) -> [PASS][233] +2 other tests pass
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-6/igt@[email protected]
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-10/igt@[email protected]

* igt@kms_setmode@basic@pipe-a-hdmi-a-1:
- shard-snb: [FAIL][234] ([i915#5465]) -> [PASS][235] +1 other test pass
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-snb5/igt@kms_setmode@[email protected]
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-snb7/igt@kms_setmode@[email protected]

* igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1:
- shard-tglu: [FAIL][236] ([i915#9196]) -> [PASS][237]
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-tglu-8/igt@kms_universal_plane@[email protected]
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-tglu-5/igt@kms_universal_plane@[email protected]

#### Warnings ####

* igt@gem_lmem_swapping@heavy-verify-random-ccs@lmem0:
- shard-dg2: [FAIL][238] ([i915#10446]) -> [FAIL][239] ([i915#10378])
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-8/igt@gem_lmem_swapping@[email protected]
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-3/igt@gem_lmem_swapping@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-dg1: [ABORT][240] ([i915#9820]) -> [INCOMPLETE][241] ([i915#1982] / [i915#9820] / [i915#9849])
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg1-13/igt@[email protected]
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-16/igt@[email protected]

* igt@kms_content_protection@mei-interface:
- shard-dg1: [SKIP][242] ([i915#9433]) -> [SKIP][243] ([i915#9424])
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg1-13/igt@[email protected]
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg1-16/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-cpu:
- shard-dg2: [SKIP][244] ([i915#10433] / [i915#3458]) -> [SKIP][245] ([i915#3458]) +1 other test skip
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-4/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-cpu.html
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
- shard-dg2: [SKIP][246] ([i915#3458]) -> [SKIP][247] ([i915#10433] / [i915#3458]) +4 other tests skip
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-7/igt@[email protected]
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-4/igt@[email protected]

* igt@kms_psr@pr-cursor-plane-move:
- shard-dg2: [SKIP][248] ([i915#1072] / [i915#9673] / [i915#9732]) -> [SKIP][249] ([i915#1072] / [i915#9732]) +8 other tests skip
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-11/igt@[email protected]
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-1/igt@[email protected]

* igt@kms_psr@psr-primary-mmap-cpu:
- shard-dg2: [SKIP][250] ([i915#1072] / [i915#9732]) -> [SKIP][251] ([i915#1072] / [i915#9673] / [i915#9732]) +10 other tests skip
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-8/igt@[email protected]
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@[email protected]

* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: [FAIL][252] ([i915#7484]) -> [FAIL][253] ([i915#9100])
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14785/shard-dg2-8/igt@perf@[email protected]
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/shard-dg2-11/igt@perf@[email protected]

[i915#10031]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10031
[i915#10047]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10047
[i915#10131]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10131
[i915#10278]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10278
[i915#10307]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10307
[i915#10378]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10378
[i915#10433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10433
[i915#10434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10434
[i915#10446]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10446
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#10887]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10887
[i915#11164]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11164
[i915#11165]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11165
[i915#1825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1839
[i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982
[i915#2017]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2017
[i915#2122]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2122
[i915#2437]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3804
[i915#3826]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#3966]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3966
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4087]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4087
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4212
[i915#4235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4235
[i915#4270]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4270
[i915#4387]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4812
[i915#4839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4839
[i915#4852]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4880
[i915#5176]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5176
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#5439]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5439
[i915#5465]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5465
[i915#5723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5723
[i915#6095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6268
[i915#6344]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6344
[i915#6412]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6412
[i915#6524]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6524
[i915#6621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6621
[i915#6880]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6880
[i915#7118]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7118
[i915#7173]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7173
[i915#7484]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7484
[i915#7697]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7697
[i915#7707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7828
[i915#7975]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7975
[i915#8213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8228
[i915#8292]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8292
[i915#8411]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8411
[i915#8414]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8414
[i915#8428]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8428
[i915#8430]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8430
[i915#8516]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8516
[i915#8555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8555
[i915#8623]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8623
[i915#8708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8708
[i915#8709]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8709
[i915#8717]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8717
[i915#8806]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8806
[i915#8812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8812
[i915#8850]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8850
[i915#8925]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8925
[i915#9100]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9100
[i915#9196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9196
[i915#9227]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9227
[i915#9295]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9295
[i915#9323]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9323
[i915#9407]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9407
[i915#9412]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9412
[i915#9423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9423
[i915#9424]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9424
[i915#9433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9433
[i915#9519]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9519
[i915#9531]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9531
[i915#9606]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9606
[i915#9673]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9673
[i915#9683]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9683
[i915#9685]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9685
[i915#9697]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9697
[i915#9723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9723
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9766]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9766
[i915#9779]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9779
[i915#9820]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9820
[i915#9849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9849
[i915#9906]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9906
[i915#9917]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9917
[i915#9934]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9934

Build changes
-------------

* Linux: CI_DRM_14785 -> Patchwork_133624v3

CI-20190529: 20190529
CI_DRM_14785: 1ba62f8cea9c797427d45108df1d453f4b343240 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7863: fa1dc232d5d840532521df8a6fcf1fe82c514304 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_133624v3: 1ba62f8cea9c797427d45108df1d453f4b343240 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133624v3/index.html