ASoC: dt-bindings: omap-mcpdm: Convert to DT schema
Subsystems (3)
PATCH v6 1/1 ASoC: dt-bindings: omap-mcpdm: Convert to DT schema
From: Mithil Bavishi <[email protected]>
Convert the OMAP4+ McPDM bindings to DT schema.
---
Changelog v6:
- Add dma property
- Add dma-names property
- Add reg-names property
- Remove ti,hwmods completely (no longer needed since the sysc conversion)
- Update example to match one in DTS
Changelog v5:
- Add imports for constants
- Add desc to ti,hwmods
Changelog v4:
- Changed maintainer name
- Use $ref and enum in ti-hwmods property
- Make clocks property only have maxItems, no description
- Add items to clock-names
- Fix address of node in example
- Remove extra line
.../devicetree/bindings/sound/omap-mcpdm.txt | 30 -------- .../bindings/sound/ti,omap4-mcpdm.yaml | 73 +++++++++++++++++++ 2 files changed, 73 insertions(+), 30 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/omap-mcpdm.txt create mode 100644 Documentation/devicetree/bindings/sound/ti,omap4-mcpdm.yaml
Documentation/devicetree/bindings/sound/omap-mcpdm.txt deleted +0 -30
@@ -1,30 +0,0 @@ -* Texas Instruments OMAP4+ McPDM - -Required properties: -- compatible: "ti,omap4-mcpdm" -- reg: Register location and size as an array: - <MPU access base address, size>, - <L3 interconnect address, size>; -- interrupts: Interrupt number for McPDM -- ti,hwmods: Name of the hwmod associated to the McPDM -- clocks: phandle for the pdmclk provider, likely <&twl6040> -- clock-names: Must be "pdmclk" - -Example: - -mcpdm: mcpdm@40132000 { - compatible = "ti,omap4-mcpdm"; - reg = <0x40132000 0x7f>, /* MPU private access */ - <0x49032000 0x7f>; /* L3 Interconnect */ - interrupts = <0 112 0x4>; - interrupt-parent = <&gic>; - ti,hwmods = "mcpdm"; -}; - -In board DTS file the pdmclk needs to be added: - -&mcpdm { - clocks = <&twl6040>; - clock-names = "pdmclk"; - status = "okay"; -};
Documentation/devicetree/bindings/sound/ti,omap4-mcpdm.yaml new file +73 -0
73 lines not on this page · raw message
Signature · 1 line
2.34.1
Quoted 21 lines · Mighty
From: Mithil Bavishi <[email protected]>
Convert the OMAP4+ McPDM bindings to DT schema.
Signed-off-by Mithil Bavishi <[email protected]>Documentation/devicetree/bindings/sound/ti,omap4-mcpdm.yaml new file +15
-0+ +properties: + compatible: + const: ti,omap4-mcpdm + + reg: + items: + - description: MPU access base address + - description: L3 interconnect address + + reg-names: + items: + - const: mpu + - const: dma +
Documentation/devicetree/bindings/sound/ti,omap4-mcpdm.yaml line 38
Quoted 10 lines
Documentation/devicetree/bindings/sound/ti,omap4-mcpdm.yaml new file +10
-0+ interrupts: + maxItems: 1 + + dmas: + maxItems: 2 + + dma-names: + items: + - const: up_link + - const: dn_link
Please mention in the commit msg all changes (and explain why!) done during conversion (comparing to original binding). I am pretty sure I gave this feedback already.
Best regards,
Krzysztof
Quoted 3 lines
Please mention in the commit msg all changes (and explain why!) done during conversion (comparing to original binding). I am pretty sure I gave this feedback already.
I read that i'm supposed to add the changelog below the --- line, my bad. I'll mention the changes in the commit message itself and that too from v2 right?
Signature · 2 lines
Best Regards, Mithil
Quoted 6 lines · Mithil
Quoted 3 lines
Please mention in the commit msg all changes (and explain why!) done during conversion (comparing to original binding). I am pretty sure I gave this feedback already.
I read that i'm supposed to add the changelog below the --- line, my bad. I'll mention the changes in the commit message itself and that too from v2 right?
I think you are now mixing different things. changelog and differences comparing to pure 1-to-1 conversion.
Best regards,
Krzysztof
Quoted 2 lines · Krzysztof Kozlowski
I think you are now mixing different things. changelog and differences comparing to pure 1-to-1 conversion.
Oh my apologies, the commit message being more descriptive? Should it also include the changelogs, or just a general description about mcpdm and it being used in omap4/omap5 platforms?
Signature · 2 lines
Best Regards, Mithil
Quoted 7 lines · Mithil
Quoted 3 lines
Please mention in the commit msg all changes (and explain why!) done during conversion (comparing to original binding). I am pretty sure I gave this feedback already.
I read that i'm supposed to add the changelog below the --- line, my bad. I'll mention the changes in the commit message itself and that too from v2 right?
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
Best regards,
Krzysztof
Quoted 6 lines · Krzysztof Kozlowski
https://lore.kernel.org/all/[email protected]/
Understood, thanks a lot!
So something along the lines of
Convert the OMAP4+ McPDM bindings from txt to yaml (dtschema). Drop ti.hwmods property as it is not needed since the sysc conversion. Add dma, dma-names, reg-names properties to match the DTS so as to not break the already existing ABI.
Update example to match the existing node.
Also update the changelog from the start noting all changes.
This much for v7 correct?
Signature · 2 lines
Best Regards, Mithil