ASoC: SOF: ipc4-topology: Fix nhlt configuration blob selection
Subsystems (3)
Peter Ujfalusi
maintainercover ASoC: SOF: ipc4-topology: Fix nhlt configuration blob selection
Hi,
the existing logic to pick a DMIC blob is based on several historical assumptions that the NHLT in BIOS always contains 32-bits per sample type (first patch, [1]).
The other issue with the existing logic is that it was designed to care only about the bit depth of the format and fails to find the existing and correct blob when rate/channels are different on the FE side compared to what we should be using on the DAI side (we have components in path which can change rate/channel count).
These issues have not been observed in past but with new MTL based (Windows) laptops and new topologies to enhance the audio quality, we started to see weird issues around how our assumptions of vendors failed.
Since some NHLT blob handling cleanup has been done for 6.10, this series will complete that work to cover even cases that we don't anticipate to see.
[1] https://github.com/thesofproject/linux/issues/4973
Regards,
Peter
---
Peter Ujfalusi (5):
ASoC: SOF: ipc4-topology: Add support for NHLT with 16-bit only DMIC
blob
ASoC: SOF: ipc4-topology: Print out the channel count in
sof_ipc4_dbg_audio_format
ASoC: SOF: ipc4-topology/pcm: Rename
sof_ipc4_copier_is_single_format()
ASoC: SOF: ipc4-topology: Improve readability of
sof_ipc4_prepare_dai_copier()
ASoC: SOF: ipc4-topology: Adjust the params based on DAI formats
sound/soc/sof/ipc4-pcm.c | 12 +-- sound/soc/sof/ipc4-topology.c | 155 +++++++++++++++++++++++----------- sound/soc/sof/ipc4-topology.h | 6 +- 3 files changed, 115 insertions(+), 58 deletions(-)
Signature · 1 line
2.45.1
Peter Ujfalusi
maintainerPATCH 1/5 ASoC: SOF: ipc4-topology: Add support for NHLT with 16-bit only DMIC blob
The ACPI NHLT table always had 32-bit DMIC blob even if 16-bit was also present and taken as a 'rule' which obviously got broken and there is at least one device on the market which ships with only 16-bit DMIC configuration blob.
This corner case has never been supported and it is going to need topology updates for DMIC copier to support multiple formats.
As for the kernel side: if the copier supports multiple formats and the preferred 32-bit DMIC blob is not found then we will try to get a 16-bit DMIC configuration and look for a 16-bit copier config.
--- sound/soc/sof/ipc4-topology.c | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-)
sound/soc/sof/ipc4-topology.c +22 -3
@@ -1491,6 +1491,8 @@ snd_sof_get_nhlt_endpoint_data(struct snd_sof_dev *sdev, struct snd_sof_dai *dai dir, dev_type);if (!cfg) { +bool get_new_blob = false; +if (format_change) {/* * The 32-bit blob was not found in NHLT table, try to
@@ -1498,7 +1500,20 @@ snd_sof_get_nhlt_endpoint_data(struct snd_sof_dev *sdev, struct snd_sof_dai *dai*/ bit_depth =params_width (params); format_change = false; + get_new_blob = true; + }else if (linktype ==SOF_DAI_INTEL_DMIC && !single_format) { +/* +* The requested 32-bit blob (no format change for the +* blob request) was not found in NHLT table, try to +* look for 16-bit blob if the copier supports multiple +* formats +*/ + bit_depth =16 ; + format_change = true; + get_new_blob = true; + } +if (get_new_blob) { cfg = intel_nhlt_get_endpoint_blob(sdev->dev, ipc4_data->nhlt, dai_index, nhlt_type, bit_depth, bit_depth,
@@ -1521,8 +1536,8 @@ snd_sof_get_nhlt_endpoint_data(struct snd_sof_dev *sdev, struct snd_sof_dai *daiif (format_change) {/* -* Update the params to reflect that we have loaded 32-bit blob -* instead of the 16-bit. +* Update the params to reflect that different blob was loaded +* instead of the requested bit depth (16 -> 32 or 32 -> 16). * This information is going to be used by the caller to find * matching copier format on the dai side. */
@@ -1530,7 +1545,11 @@ snd_sof_get_nhlt_endpoint_data(struct snd_sof_dev *sdev, struct snd_sof_dai *dai m =hw_param_mask (params,SNDRV_PCM_HW_PARAM_FORMAT );snd_mask_none (m); -snd_mask_set_format (m,SNDRV_PCM_FORMAT_S32_LE ); +if (bit_depth ==16 ) +snd_mask_set_format (m,SNDRV_PCM_FORMAT_S16_LE ); +else +snd_mask_set_format (m,SNDRV_PCM_FORMAT_S32_LE ); + }return 0 ;
Signature · 1 line
2.45.1
Peter Ujfalusi
maintainerPATCH 2/5 ASoC: SOF: ipc4-topology: Print out the channel count in sof_ipc4_dbg_audio_format
In reply to Peter UjfalusiPrint out the number of channels for the format explicitly instead of having the reader to understand how to interpret the ch_map and ch_cfg values.
--- sound/soc/sof/ipc4-topology.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
sound/soc/sof/ipc4-topology.c +4 -3
@@ -195,9 +195,10 @@ static void sof_ipc4_dbg_audio_format(struct device *dev, struct sof_ipc4_pin_fofor (i =0 ; i < num_formats; i++) {struct sof_ipc4_audio_format *fmt = &pin_fmt[i].audio_fmt;dev_dbg (dev, -"Pin index #%d: %uHz, %ubit (ch_map %#x ch_cfg %u interleaving_style %u fmt_cfg %#x) buffer size %d\n" , - pin_fmt[i].pin_index, fmt->sampling_frequency, fmt->bit_depth, fmt->ch_map, - fmt->ch_cfg, fmt->interleaving_style, fmt->fmt_cfg, +"Pin index #%d: %uHz, %ubit, %luch (ch_map %#x ch_cfg %u interleaving_style %u fmt_cfg %#x) buffer size %d\n" , + pin_fmt[i].pin_index, fmt->sampling_frequency, fmt->bit_depth, +SOF_IPC4_AUDIO_FORMAT_CFG_CHANNELS_COUNT (fmt->fmt_cfg), + fmt->ch_map, fmt->ch_cfg, fmt->interleaving_style, fmt->fmt_cfg, pin_fmt[i].buffer_size); } }
Signature · 1 line
2.45.1
Peter Ujfalusi
maintainerPATCH 3/5 ASoC: SOF: ipc4-topology/pcm: Rename sof_ipc4_copier_is_single_format()
In reply to Peter UjfalusiRename the sof_ipc4_copier_is_single_format() to sof_ipc4_copier_is_single_bitdepth() to clear the confusion of the use of 'format' when we are querying information on the bit depth. Format is used to describe a combination of parameters (rate, channels, sample format / bit depth).
Rename the flags used to store the result at the same time.
--- sound/soc/sof/ipc4-pcm.c | 12 +++++------ sound/soc/sof/ipc4-topology.c | 40 +++++++++++++++++------------------ sound/soc/sof/ipc4-topology.h | 6 +++--- 3 files changed, 29 insertions(+), 29 deletions(-)
sound/soc/sof/ipc4-pcm.c +6 -6
@@ -650,7 +650,7 @@ static int sof_ipc4_pcm_dai_link_fixup(struct snd_soc_pcm_runtime *rtd,struct snd_soc_dai *cpu_dai =snd_soc_rtd_to_cpu (rtd,0 );struct sof_ipc4_audio_format *ipc4_fmt;struct sof_ipc4_copier *ipc4_copier; -bool single_fmt = false; +bool single_bitdepth = false;u32 valid_bits =0 ;int dir, ret;
@@ -682,18 +682,18 @@ static int sof_ipc4_pcm_dai_link_fixup(struct snd_soc_pcm_runtime *rtd,return 0 ;if (dir ==SNDRV_PCM_STREAM_PLAYBACK ) { -if (sof_ipc4_copier_is_single_format (sdev, +if (sof_ipc4_copier_is_single_bitdepth (sdev, available_fmt->output_pin_fmts, available_fmt->num_output_formats)) { ipc4_fmt = &available_fmt->output_pin_fmts->audio_fmt; - single_fmt = true; + single_bitdepth = true; } }else { -if (sof_ipc4_copier_is_single_format (sdev, +if (sof_ipc4_copier_is_single_bitdepth (sdev, available_fmt->input_pin_fmts, available_fmt->num_input_formats)) { ipc4_fmt = &available_fmt->input_pin_fmts->audio_fmt; - single_fmt = true; + single_bitdepth = true; } } }
@@ -703,7 +703,7 @@ static int sof_ipc4_pcm_dai_link_fixup(struct snd_soc_pcm_runtime *rtd,if (ret)return ret; -if (single_fmt) { +if (single_bitdepth) {snd_mask_none (fmt); valid_bits =SOF_IPC4_AUDIO_FORMAT_CFG_V_BIT_DEPTH (ipc4_fmt->fmt_cfg);dev_dbg (component->dev,"Set %s to %d bit format\n" , dai->name, valid_bits);
sound/soc/sof/ipc4-topology.c +20 -20
@@ -1431,7 +1431,7 @@ static int snd_sof_get_hw_config_params(struct snd_sof_dev *sdev, struct snd_sofstatic int snd_sof_get_nhlt_endpoint_data (struct snd_sof_dev *sdev,struct snd_sof_dai *dai, -bool single_format, +bool single_bitdepth,struct snd_pcm_hw_params *params,u32 dai_index,u32 linktype,u8 dir,u32 **dst,u32 *len) {
@@ -1454,7 +1454,7 @@ snd_sof_get_nhlt_endpoint_data(struct snd_sof_dev *sdev, struct snd_sof_dai *dai* Look for 32-bit blob first instead of 16-bit if copier * supports multiple formats */ -if (bit_depth ==16 && !single_format) { +if (bit_depth ==16 && !single_bitdepth) {dev_dbg (sdev->dev,"Looking for 32-bit blob first for DMIC\n" ); format_change = true; bit_depth =32 ;
@@ -1502,7 +1502,7 @@ snd_sof_get_nhlt_endpoint_data(struct snd_sof_dev *sdev, struct snd_sof_dai *dai bit_depth =params_width (params); format_change = false; get_new_blob = true; - }else if (linktype ==SOF_DAI_INTEL_DMIC && !single_format) { + }else if (linktype ==SOF_DAI_INTEL_DMIC && !single_bitdepth) {/* * The requested 32-bit blob (no format change for the * blob request) was not found in NHLT table, try to
@@ -1558,7 +1558,7 @@ snd_sof_get_nhlt_endpoint_data(struct snd_sof_dev *sdev, struct snd_sof_dai *dai#else static int snd_sof_get_nhlt_endpoint_data (struct snd_sof_dev *sdev,struct snd_sof_dai *dai, -bool single_format, +bool single_bitdepth,struct snd_pcm_hw_params *params,u32 dai_index,u32 linktype,u8 dir,u32 **dst,u32 *len) {
@@ -1566,9 +1566,9 @@ snd_sof_get_nhlt_endpoint_data(struct snd_sof_dev *sdev, struct snd_sof_dai *dai }#endif -bool sof_ipc4_copier_is_single_format (struct snd_sof_dev *sdev, -struct sof_ipc4_pin_format *pin_fmts, -u32 pin_fmts_size) +bool sof_ipc4_copier_is_single_bitdepth (struct snd_sof_dev *sdev, +struct sof_ipc4_pin_format *pin_fmts, +u32 pin_fmts_size) {struct sof_ipc4_audio_format *fmt;u32 valid_bits;
@@ -1599,7 +1599,7 @@ sof_ipc4_prepare_dai_copier(struct snd_sof_dev *sdev, struct snd_sof_dai *dai,struct snd_pcm_hw_params dai_params = *params;struct sof_ipc4_copier_data *copier_data;struct sof_ipc4_copier *ipc4_copier; -bool single_format; +bool single_bitdepth;int ret; ipc4_copier = dai->private;
@@ -1613,12 +1613,12 @@ sof_ipc4_prepare_dai_copier(struct snd_sof_dev *sdev, struct snd_sof_dai *dai,* format lookup */ if (dir ==SNDRV_PCM_STREAM_PLAYBACK ) { - single_format =sof_ipc4_copier_is_single_format (sdev, + single_bitdepth =sof_ipc4_copier_is_single_bitdepth (sdev, available_fmt->output_pin_fmts, available_fmt->num_output_formats);/* Update the dai_params with the only supported format */ -if (single_format) { +if (single_bitdepth) { ret =sof_ipc4_update_hw_params (sdev, &dai_params, &available_fmt->output_pin_fmts[0 ].audio_fmt,BIT (SNDRV_PCM_HW_PARAM_FORMAT ));
@@ -1626,12 +1626,12 @@ sof_ipc4_prepare_dai_copier(struct snd_sof_dev *sdev, struct snd_sof_dai *dai,return ret; } }else { - single_format =sof_ipc4_copier_is_single_format (sdev, + single_bitdepth =sof_ipc4_copier_is_single_bitdepth (sdev, available_fmt->input_pin_fmts, available_fmt->num_input_formats);/* Update the dai_params with the only supported format */ -if (single_format) { +if (single_bitdepth) { ret =sof_ipc4_update_hw_params (sdev, &dai_params, &available_fmt->input_pin_fmts[0 ].audio_fmt,BIT (SNDRV_PCM_HW_PARAM_FORMAT ));
@@ -1640,7 +1640,7 @@ sof_ipc4_prepare_dai_copier(struct snd_sof_dev *sdev, struct snd_sof_dai *dai, } } - ret = snd_sof_get_nhlt_endpoint_data(sdev, dai, single_format, + ret = snd_sof_get_nhlt_endpoint_data(sdev, dai, single_bitdepth, &dai_params, ipc4_copier->dai_index, ipc4_copier->dai_type, dir,
@@ -1675,7 +1675,7 @@ sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget,u32 out_ref_rate, out_ref_channels;u32 deep_buffer_dma_ms =0 ;int output_fmt_index; -bool single_output_format; +bool single_output_bitdepth;int i;dev_dbg (sdev->dev,"copier %s, type %d" , swidget->widget->name, swidget->id);
@@ -1812,9 +1812,9 @@ sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget,return ret;/* set the reference params for output format selection */ - single_output_format =sof_ipc4_copier_is_single_format (sdev, - available_fmt->output_pin_fmts, - available_fmt->num_output_formats); + single_output_bitdepth =sof_ipc4_copier_is_single_bitdepth (sdev, + available_fmt->output_pin_fmts, + available_fmt->num_output_formats);switch (swidget->id) {case snd_soc_dapm_aif_in:case snd_soc_dapm_dai_out:
@@ -1826,7 +1826,7 @@ sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget, out_ref_rate = in_fmt->sampling_frequency; out_ref_channels =SOF_IPC4_AUDIO_FORMAT_CFG_CHANNELS_COUNT (in_fmt->fmt_cfg); -if (!single_output_format) +if (!single_output_bitdepth) out_ref_valid_bits =SOF_IPC4_AUDIO_FORMAT_CFG_V_BIT_DEPTH (in_fmt->fmt_cfg);break ;
@@ -1835,7 +1835,7 @@ sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget,case snd_soc_dapm_dai_in: out_ref_rate =params_rate (fe_params); out_ref_channels =params_channels (fe_params); -if (!single_output_format) { +if (!single_output_bitdepth) { out_ref_valid_bits =sof_ipc4_get_valid_bits (sdev, fe_params);if (out_ref_valid_bits <0 )return out_ref_valid_bits;
@@ -1853,7 +1853,7 @@ sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget,* if the output format is the same across all available output formats, choose * that as the reference. */ -if (single_output_format) { +if (single_output_bitdepth) {struct sof_ipc4_audio_format *out_fmt; out_fmt = &available_fmt->output_pin_fmts[0 ].audio_fmt;
sound/soc/sof/ipc4-topology.h +3 -3
@@ -476,7 +476,7 @@ struct sof_ipc4_process { u32 init_config; }; -bool sof_ipc4_copier_is_single_format (struct snd_sof_dev *sdev, -struct sof_ipc4_pin_format *pin_fmts, -u32 pin_fmts_size); +bool sof_ipc4_copier_is_single_bitdepth (struct snd_sof_dev *sdev, +struct sof_ipc4_pin_format *pin_fmts, +u32 pin_fmts_size);#endif
Signature · 1 line
2.45.1
Peter Ujfalusi
maintainerPATCH 4/5 ASoC: SOF: ipc4-topology: Improve readability of sof_ipc4_prepare_dai_copier()
In reply to Peter UjfalusiRemove the duplicated code paths to check for single bit depth and to update the params with storing the parameters needed by the function and have a single code section.
No functional change but the code is easier to follow.
--- sound/soc/sof/ipc4-topology.c | 42 +++++++++++++++-------------------- 1 file changed, 18 insertions(+), 24 deletions(-)
sound/soc/sof/ipc4-topology.c +18 -24
@@ -1598,8 +1598,10 @@ sof_ipc4_prepare_dai_copier(struct snd_sof_dev *sdev, struct snd_sof_dai *dai,struct sof_ipc4_available_audio_format *available_fmt;struct snd_pcm_hw_params dai_params = *params;struct sof_ipc4_copier_data *copier_data; +struct sof_ipc4_pin_format *pin_fmts;struct sof_ipc4_copier *ipc4_copier;bool single_bitdepth; +u32 num_pin_fmts;int ret; ipc4_copier = dai->private;
@@ -1613,31 +1615,23 @@ sof_ipc4_prepare_dai_copier(struct snd_sof_dev *sdev, struct snd_sof_dai *dai,* format lookup */ if (dir ==SNDRV_PCM_STREAM_PLAYBACK ) { - single_bitdepth =sof_ipc4_copier_is_single_bitdepth (sdev, - available_fmt->output_pin_fmts, - available_fmt->num_output_formats); - -/* Update the dai_params with the only supported format */ -if (single_bitdepth) { - ret =sof_ipc4_update_hw_params (sdev, &dai_params, - &available_fmt->output_pin_fmts[0 ].audio_fmt, -BIT (SNDRV_PCM_HW_PARAM_FORMAT )); -if (ret) -return ret; - } + pin_fmts = available_fmt->output_pin_fmts; + num_pin_fmts = available_fmt->num_output_formats; }else { - single_bitdepth =sof_ipc4_copier_is_single_bitdepth (sdev, - available_fmt->input_pin_fmts, - available_fmt->num_input_formats); - -/* Update the dai_params with the only supported format */ -if (single_bitdepth) { - ret =sof_ipc4_update_hw_params (sdev, &dai_params, - &available_fmt->input_pin_fmts[0 ].audio_fmt, -BIT (SNDRV_PCM_HW_PARAM_FORMAT )); -if (ret) -return ret; - } + pin_fmts = available_fmt->input_pin_fmts; + num_pin_fmts = available_fmt->num_input_formats; + } + + single_bitdepth =sof_ipc4_copier_is_single_bitdepth (sdev, pin_fmts, + num_pin_fmts); + +/* Update the dai_params with the only supported format */ +if (single_bitdepth) { + ret =sof_ipc4_update_hw_params (sdev, &dai_params, + &pin_fmts[0 ].audio_fmt, +BIT (SNDRV_PCM_HW_PARAM_FORMAT )); +if (ret) +return ret; } ret = snd_sof_get_nhlt_endpoint_data(sdev, dai, single_bitdepth,
Signature · 1 line
2.45.1
Peter Ujfalusi
maintainerPATCH 5/5 ASoC: SOF: ipc4-topology: Adjust the params based on DAI formats
In reply to Peter UjfalusiCurrently we only check the bit depth value among to DAI formats, but other parameters might be constant, like number of channels and/or rate.
In capture we use the fe params as a reference to find the format and blob which should be used, but in the path we can have components which can handle expanding/narrowing number of channels or do a resample.
In these cases the topology is expected to have 'fixed' parameter for channels/rates/bit depth and the conversion to the fe format is going to be done within the path.
In practice this patch fixes issues like:
All DMIC formats are fixed four channels
We have a component which converts the four channel to stereo FE is opened with 2 channel
Even if we have the correct bit depth format and blob (for four channel) we will still be looking for stereo configurations, which will fail.
Note: the adjustment of params have switched order with the checking of single bit depth (needed for the NHLT blob fallback support). This change is non function, just that if the sof_ipc4_narrow_params_to_format() would fail, there is no point of checking the single bit depth.
--- sound/soc/sof/ipc4-topology.c | 71 ++++++++++++++++++++++++++++------- 1 file changed, 57 insertions(+), 14 deletions(-)
sound/soc/sof/ipc4-topology.c +57 -14
@@ -1591,6 +1591,55 @@ bool sof_ipc4_copier_is_single_bitdepth(struct snd_sof_dev *sdev,return true; } +static int +sof_ipc4_adjust_params_to_dai_format (struct snd_sof_dev *sdev, +struct snd_pcm_hw_params *params, +struct sof_ipc4_pin_format *pin_fmts, +u32 pin_fmts_size) +{ +u32 params_mask =BIT (SNDRV_PCM_HW_PARAM_RATE ) | +BIT (SNDRV_PCM_HW_PARAM_CHANNELS ) | +BIT (SNDRV_PCM_HW_PARAM_FORMAT ); +struct sof_ipc4_audio_format *fmt; +u32 rate, channels, valid_bits; +int i; + + fmt = &pin_fmts[0 ].audio_fmt; + rate = fmt->sampling_frequency; + channels =SOF_IPC4_AUDIO_FORMAT_CFG_CHANNELS_COUNT (fmt->fmt_cfg); + valid_bits =SOF_IPC4_AUDIO_FORMAT_CFG_V_BIT_DEPTH (fmt->fmt_cfg); + +/* check if parameters in topology defined formats are the same */ +for (i =1 ; i < pin_fmts_size; i++) { +u32 val; + + fmt = &pin_fmts[i].audio_fmt; + +if (params_mask &BIT (SNDRV_PCM_HW_PARAM_RATE )) { + val = fmt->sampling_frequency; +if (val != rate) + params_mask &= ~BIT (SNDRV_PCM_HW_PARAM_RATE ); + } +if (params_mask &BIT (SNDRV_PCM_HW_PARAM_CHANNELS )) { + val =SOF_IPC4_AUDIO_FORMAT_CFG_CHANNELS_COUNT (fmt->fmt_cfg); +if (val != channels) + params_mask &= ~BIT (SNDRV_PCM_HW_PARAM_CHANNELS ); + } +if (params_mask &BIT (SNDRV_PCM_HW_PARAM_FORMAT )) { + val =SOF_IPC4_AUDIO_FORMAT_CFG_V_BIT_DEPTH (fmt->fmt_cfg); +if (val != valid_bits) + params_mask &= ~BIT (SNDRV_PCM_HW_PARAM_FORMAT ); + } + } + +if (params_mask) +return sof_ipc4_update_hw_params (sdev, params, + &pin_fmts[0 ].audio_fmt, + params_mask); + +return 0 ; +} +static int sof_ipc4_prepare_dai_copier (struct snd_sof_dev *sdev,struct snd_sof_dai *dai,struct snd_pcm_hw_params *params,int dir)
@@ -1609,10 +1658,9 @@ sof_ipc4_prepare_dai_copier(struct snd_sof_dev *sdev, struct snd_sof_dai *dai, available_fmt = &ipc4_copier->available_fmt;/* -* If the copier on the DAI side supports only single bit depth then -* this depth (format) should be used to look for the NHLT blob (if -* needed) and in case of capture this should be used for the input -* format lookup +* Fixup the params based on the format parameters of the DAI. If any +* of the RATE, CHANNELS, bit depth is static among the formats then +* narrow the params to only allow that specific parameter value. */ if (dir ==SNDRV_PCM_STREAM_PLAYBACK ) { pin_fmts = available_fmt->output_pin_fmts;
@@ -1622,18 +1670,13 @@ sof_ipc4_prepare_dai_copier(struct snd_sof_dev *sdev, struct snd_sof_dai *dai, num_pin_fmts = available_fmt->num_input_formats; } + ret =sof_ipc4_adjust_params_to_dai_format (sdev, &dai_params, pin_fmts, + num_pin_fmts); +if (ret) +return ret; + single_bitdepth =sof_ipc4_copier_is_single_bitdepth (sdev, pin_fmts, num_pin_fmts); - -/* Update the dai_params with the only supported format */ -if (single_bitdepth) { - ret =sof_ipc4_update_hw_params (sdev, &dai_params, - &pin_fmts[0 ].audio_fmt, -BIT (SNDRV_PCM_HW_PARAM_FORMAT )); -if (ret) -return ret; - } - ret = snd_sof_get_nhlt_endpoint_data(sdev, dai, single_bitdepth, &dai_params, ipc4_copier->dai_index,
Signature · 1 line
2.45.1
Mark Brown
maintainerQuoted 10 lines · Peter Ujfalusi
the existing logic to pick a DMIC blob is based on several historical assumptions that the NHLT in BIOS always contains 32-bits per sample type (first patch, [1]).
The other issue with the existing logic is that it was designed to care only about the bit depth of the format and fails to find the existing and correct blob when rate/channels are different on the FE side compared to what we should be using on the DAI side (we have components in path which can change rate/channel count).
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/5] ASoC: SOF: ipc4-topology: Add support for NHLT with 16-bit only DMIC blob
commit: 49cb894d567980235b6e64d5e69950ff77debd8c
[2/5] ASoC: SOF: ipc4-topology: Print out the channel count in sof_ipc4_dbg_audio_format
commit: 2a865c9c3fb0289a95f1cb51b42d248736ff45cb
[3/5] ASoC: SOF: ipc4-topology/pcm: Rename sof_ipc4_copier_is_single_format()
commit: 3b64fd2f83f203f5a34faed3dadf6464313f827d
[4/5] ASoC: SOF: ipc4-topology: Improve readability of sof_ipc4_prepare_dai_copier()
commit: 2fcad03eaba1b86e6b829f73a9e75e681b7f3106
[5/5] ASoC: SOF: ipc4-topology: Adjust the params based on DAI formats
commit: b65456b7b379e20ab225a4e906dc4a0c98fddd7aAll being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark