ASoC: SOF: ipc4-topology: Fix nhlt configuration blob selection
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | ASoC: SOF: ipc4-topology: Add support for NHLT with 16-bit only DMIC blobsound/ | +22 | 0 replies | |
| 2/5 | ASoC: SOF: ipc4-topology: Print out the channel count in sof_ipc4_dbg_audio_formatsound/ | +4 | 0 replies | |
| 3/5 | ASoC: SOF: ipc4-topology/pcm: Rename sof_ipc4_copier_is_single_format()sound/ sound/ sound/ | +29 | 0 replies | |
| 4/5 | ASoC: SOF: ipc4-topology: Improve readability of sof_ipc4_prepare_dai_copier()sound/ | +18 | 0 replies | |
| 5/5 | ASoC: SOF: ipc4-topology: Adjust the params based on DAI formatssound/ | +57 | 0 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Seppo Ingalsuo | Pierre-Louis Bossart | Ranjani Sridharan | Bard Liao |
|---|---|---|---|---|
| 1/5 | R-b | R-b | R-b | |
| 2/5 | R-b | R-b | R-b | |
| 3/5 | R-b | R-b | R-b | R-b |
| 4/5 | R-b | R-b | R-b | R-b |
| 5/5 | R-b | R-b | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH 6.10 0/5] ASoC: SOF: ipc4-topology: Fix nhlt configuration blob selection
Hi,
the existing logic to pick a DMIC blob is based on several historical assumptions that the NHLT in BIOS always contains 32-bits per sample type (first patch, [1]).
The other issue with the existing logic is that it was designed to care only about the bit depth of the format and fails to find the existing and correct blob when rate/channels are different on the FE side compared to what we should be using on the DAI side (we have components in path which can change rate/channel count).
These issues have not been observed in past but with new MTL based (Windows) laptops and new topologies to enhance the audio quality, we started to see weird issues around how our assumptions of vendors failed.
Since some NHLT blob handling cleanup has been done for 6.10, this series will complete that work to cover even cases that we don't anticipate to see.
[1] https://github.com/thesofproject/linux/issues/4973
Regards,
Peter
---
Peter Ujfalusi (5):
ASoC: SOF: ipc4-topology: Add support for NHLT with 16-bit only DMIC
blob
ASoC: SOF: ipc4-topology: Print out the channel count in
sof_ipc4_dbg_audio_format
ASoC: SOF: ipc4-topology/pcm: Rename
sof_ipc4_copier_is_single_format()
ASoC: SOF: ipc4-topology: Improve readability of
sof_ipc4_prepare_dai_copier()
ASoC: SOF: ipc4-topology: Adjust the params based on DAI formats
sound/soc/sof/ipc4-pcm.c | 12 +-- sound/soc/sof/ipc4-topology.c | 155 +++++++++++++++++++++++----------- sound/soc/sof/ipc4-topology.h | 6 +- 3 files changed, 115 insertions(+), 58 deletions(-)
Signature · 1 line
2.45.1