Skip to contentSkip to conversation

mailbox: omap: Fix mailbox interrupt sharing

PATCH In review Andrew Davis 2 participants 2 messages Jun 11, 2024 – Jun 12, 2024 Mailbox API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mailbox: omap: Fix mailbox interrupt sharing

Multiple mailbox users can share one interrupt line. This flag was mistakenly dropped as part of the FIFO removal. Mark the IRQ as shared.

Fixes 3f58c1f4206f ("mailbox: omap: Remove kernel FIFO message queuing")
---
 drivers/mailbox/omap-mailbox.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mailbox/omap-mailbox.c +2 -1
index 46747559b438f..7a87424657a15 100644
@@ -230,7 +230,8 @@ static int omap_mbox_startup(struct omap_mbox *mbox)
 	int ret = 0;
 
 	ret = request_threaded_irq(mbox->irq, NULL, mbox_interrupt,
-				   IRQF_ONESHOT, mbox->name, mbox);
+				   IRQF_SHARED | IRQF_ONESHOT, mbox->name,
+				   mbox);
 	if (unlikely(ret)) {
 		pr_err("failed to register mailbox interrupt:%d\n", ret);
 		return ret;
Signature · 1 line
2.39.2
Tested-by on v1 1/1
#1 lore raw
Quoted 6 lines · Andrew Davis

Multiple mailbox users can share one interrupt line. This flag was mistakenly dropped as part of the FIFO removal. Mark the IRQ as shared.

Fixes 3f58c1f4206f ("mailbox: omap: Remove kernel FIFO message queuing")
Quoted 18 lines
---
  drivers/mailbox/omap-mailbox.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mailbox/omap-mailbox.c +2 -1
index 46747559b438f..7a87424657a15 100644
@@ -230,7 +230,8 @@ static int omap_mbox_startup(struct omap_mbox *mbox)
  	int ret = 0;
 
  	ret = request_threaded_irq(mbox->irq, NULL, mbox_interrupt,
-				   IRQF_ONESHOT, mbox->name, mbox);
+				   IRQF_SHARED | IRQF_ONESHOT, mbox->name,
+				   mbox);
  	if (unlikely(ret)) {
  		pr_err("failed to register mailbox interrupt:%d\n", ret);
  		return ret;