mailbox: omap: Fix mailbox interrupt sharing
PATCH 1/1 mailbox: omap: Fix mailbox interrupt sharing
Multiple mailbox users can share one interrupt line. This flag was mistakenly dropped as part of the FIFO removal. Mark the IRQ as shared.
Reported-by Beleswar Padhi <[email protected]>
Fixes 3f58c1f4206f ("mailbox: omap: Remove kernel FIFO message queuing")
Signed-off-by Andrew Davis <[email protected]>
--- drivers/mailbox/omap-mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mailbox/omap-mailbox.c +2 -1
@@ -230,7 +230,8 @@ static int omap_mbox_startup(struct omap_mbox *mbox)int ret =0 ; ret =request_threaded_irq (mbox->irq,NULL , mbox_interrupt, -IRQF_ONESHOT , mbox->name, mbox); +IRQF_SHARED |IRQF_ONESHOT , mbox->name, + mbox);if (unlikely (ret)) {pr_err ("failed to register mailbox interrupt:%d\n" , ret);return ret;
Signature · 1 line
2.39.2
Quoted 6 lines · Andrew Davis
Multiple mailbox users can share one interrupt line. This flag was mistakenly dropped as part of the FIFO removal. Mark the IRQ as shared.
Reported-by Beleswar Padhi <[email protected]>Fixes 3f58c1f4206f ("mailbox: omap: Remove kernel FIFO message queuing")Signed-off-by Andrew Davis <[email protected]>
Tested-by Beleswar Padhi <[email protected]>
Quoted 18 lines
--- drivers/mailbox/omap-mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/mailbox/omap-mailbox.c +2
-1@@ -230,7 +230,8 @@ static int omap_mbox_startup(struct omap_mbox *mbox)int ret =0 ; ret =request_threaded_irq (mbox->irq,NULL , mbox_interrupt, -IRQF_ONESHOT , mbox->name, mbox); +IRQF_SHARED |IRQF_ONESHOT , mbox->name, + mbox);if (unlikely (ret)) {pr_err ("failed to register mailbox interrupt:%d\n" , ret);return ret;