Skip to contentSkip to conversation

hw/net: Fix Coverity Issue for nocm-gmac

PATCH New Nabih Estefan 2 participants 3 messages Jun 18, 2024 – Jun 19, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/net: Fix Coverity Issue for nocm-gmac

There is an extra buf= set that is not used by npcm-gmac. Remove it for coverity to be happy.

---
 hw/net/npcm_gmac.c | 1 -
 1 file changed, 1 deletion(-)
hw/net/npcm_gmac.c +0 -1
index 1b71e2526e..b397fd5064 100644
@@ -614,7 +614,6 @@ static void gmac_try_send_next_packet(NPCMGMACState *gmac)
             net_checksum_calculate(tx_send_buffer, length, csum);
             qemu_send_packet(qemu_get_queue(gmac->nic), tx_send_buffer, length);
             trace_npcm_gmac_packet_sent(DEVICE(gmac)->canonical_path, length);
-            buf = tx_send_buffer;
             length = 0;
         }
 
Signature · 1 line
2.45.2.627.g7a2c4fd464-goog
#1 lore raw

PATCH 1/1 hw/net: Fix Coverity Issue for npcm-gmac

There is an extra buf= set that is not used by npcm-gmac. Remove it for coverity to be happy.

---
 hw/net/npcm_gmac.c | 1 -
 1 file changed, 1 deletion(-)
hw/net/npcm_gmac.c +0 -1
index 1b71e2526e..b397fd5064 100644
@@ -614,7 +614,6 @@ static void gmac_try_send_next_packet(NPCMGMACState *gmac)
             net_checksum_calculate(tx_send_buffer, length, csum);
             qemu_send_packet(qemu_get_queue(gmac->nic), tx_send_buffer, length);
             trace_npcm_gmac_packet_sent(DEVICE(gmac)->canonical_path, length);
-            buf = tx_send_buffer;
             length = 0;
         }
 
Signature · 1 line
2.45.2.627.g7a2c4fd464-goog
Reviewed-by on v1 1/1
#2 lore raw

RE: [PATCH] hw/net: Fix Coverity Issue for npcm-gmac

Quoted 12 lines

-----Original Message-----
From: [email protected] <qemu- [email protected]> On Behalf Of Nabih Estefan
Sent: Wednesday, June 19, 2024 1:25 AM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: [PATCH] hw/net: Fix Coverity Issue for npcm-gmac

Quoted 3 lines

There is an extra buf= set that is not used by npcm-gmac. Remove it for coverity to be happy.

Looks good to me.
By the way, I see this function comments the Steps 1/2/3...
But I can't find the page 384 of datasheet, please add more details about the datasheet(versions of datasheet, URL....).

Thanks
Chen

Quoted 23 lines
---
 hw/net/npcm_gmac.c | 1 -
 1 file changed, 1 deletion(-)
hw/net/npcm_gmac.c index renamed from hw/net/npcm_gmac.c +0 -0

1b71e2526e..b397fd5064 100644

hw/net/npcm_gmac.c +0 -1
@@ -614,7 +614,6 @@ static void
 gmac_try_send_next_packet(NPCMGMACState *gmac)
             net_checksum_calculate(tx_send_buffer, length, csum);
             qemu_send_packet(qemu_get_queue(gmac->nic), tx_send_buffer,
 length);
             trace_npcm_gmac_packet_sent(DEVICE(gmac)->canonical_path,
 length);
-            buf = tx_send_buffer;
             length = 0;
         }

--
2.45.2.627.g7a2c4fd464-goog