hw/net: Fix Coverity Issue for nocm-gmac
PATCH 1/1 hw/net: Fix Coverity Issue for nocm-gmac
There is an extra buf= set that is not used by npcm-gmac. Remove it for coverity to be happy.
--- hw/net/npcm_gmac.c | 1 - 1 file changed, 1 deletion(-)
hw/net/npcm_gmac.c +0 -1
@@ -614,7 +614,6 @@ static void gmac_try_send_next_packet(NPCMGMACState *gmac)net_checksum_calculate (tx_send_buffer, length, csum);qemu_send_packet (qemu_get_queue (gmac->nic), tx_send_buffer, length);trace_npcm_gmac_packet_sent (DEVICE (gmac)->canonical_path, length); - buf = tx_send_buffer; length =0 ; }
Signature · 1 line
2.45.2.627.g7a2c4fd464-goog
PATCH 1/1 hw/net: Fix Coverity Issue for npcm-gmac
There is an extra buf= set that is not used by npcm-gmac. Remove it for coverity to be happy.
--- hw/net/npcm_gmac.c | 1 - 1 file changed, 1 deletion(-)
hw/net/npcm_gmac.c +0 -1
@@ -614,7 +614,6 @@ static void gmac_try_send_next_packet(NPCMGMACState *gmac)net_checksum_calculate (tx_send_buffer, length, csum);qemu_send_packet (qemu_get_queue (gmac->nic), tx_send_buffer, length);trace_npcm_gmac_packet_sent (DEVICE (gmac)->canonical_path, length); - buf = tx_send_buffer; length =0 ; }
Signature · 1 line
2.45.2.627.g7a2c4fd464-goog
RE: [PATCH] hw/net: Fix Coverity Issue for npcm-gmac
Quoted 12 lines
-----Original Message-----
From: [email protected] <qemu- [email protected]> On Behalf Of Nabih Estefan
Sent: Wednesday, June 19, 2024 1:25 AM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: [PATCH] hw/net: Fix Coverity Issue for npcm-gmac
Quoted 3 lines
There is an extra
buf=set that is not used by npcm-gmac. Remove it for coverity to be happy.
Looks good to me.
By the way, I see this function comments the Steps 1/2/3...
But I can't find the page 384 of datasheet, please add more details about the datasheet(versions of datasheet, URL....).
Thanks
Chen
Quoted 23 lines
Signed-off-by Nabih Estefan <[email protected]>--- hw/net/npcm_gmac.c | 1 - 1 file changed, 1 deletion(-)hw/net/npcm_gmac.c index renamed from hw/net/npcm_gmac.c +0
-0
1b71e2526e..b397fd5064100644hw/net/npcm_gmac.c +0
-1@@ -614,7 +614,6 @@ static void gmac_try_send_next_packet(NPCMGMACState *gmac)net_checksum_calculate (tx_send_buffer, length, csum);qemu_send_packet (qemu_get_queue (gmac->nic), tx_send_buffer, length);trace_npcm_gmac_packet_sent (DEVICE (gmac)->canonical_path, length); - buf = tx_send_buffer;length = 0; }--
2.45.2.627.g7a2c4fd464-goog