dt-bindings: i2c: convert to dt schema
PATCH 1/1 dt-bindings: i2c: convert to dt schema
Convert the NXP I2C controller for LPC2xxx/178x/18xx/43xx to newer DT schema. Created DT schema based on the .txt file which had compatible, reg, interrupts, clocks, #address-cells and #size-cells as required properties.
Additional changes to the original .txt binding
- added maintainer from the MAINTAINERS file.
- added resets property required by the corresponding DTS files.
--- .../devicetree/bindings/i2c/i2c-lpc2k.txt | 33 ---------- .../bindings/i2c/nxp,lpc1788-i2c.yaml | 66 +++++++++++++++++++ 2 files changed, 66 insertions(+), 33 deletions(-) delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-lpc2k.txt create mode 100644 Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml
Documentation/devicetree/bindings/i2c/i2c-lpc2k.txt deleted +0 -33
@@ -1,33 +0,0 @@ -NXP I2C controller for LPC2xxx/178x/18xx/43xx - -Required properties: - - compatible: must be "nxp,lpc1788-i2c" - - reg: physical address and length of the device registers - - interrupts: a single interrupt specifier - - clocks: clock for the device - - #address-cells: should be <1> - - #size-cells: should be <0> - -Optional properties: -- clock-frequency: the desired I2C bus clock frequency in Hz; in - absence of this property the default value is used (100 kHz). - -Example: -i2c0: i2c@400a1000 { - compatible = "nxp,lpc1788-i2c"; - reg = <0x400a1000 0x1000>; - interrupts = <18>; - clocks = <&ccu1 CLK_APB1_I2C0>; - #address-cells = <1>; - #size-cells = <0>; -}; - -&i2c0 { - clock-frequency = <400000>; - - lm75@48 { - compatible = "nxp,lm75"; - reg = <0x48>; - }; -}; -
Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml new file +66 -0
66 lines not on this page · raw message
Signature · 1 line
2.45.2
On Wed, Jun 19, 2024 at 09:19:36PM +0530, Kanak Shilledar wrote:
$subject is missing a prefix for the device in question.
Quoted 16 lines
Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml new file +10
-0@@ -0,0 +1,66 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/i2c/nxp,lpc1788-i2c.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP I2C controller for LPC2xxx/178x/18xx/43xx + +maintainers: + - Vladimir Zapolskiy <[email protected]>
Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml line 20
Quoted 10 lines
Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml new file +10
-0+ +allOf: + - $ref: /schemas/i2c/i2c-controller.yaml# + +properties: + compatible: + const: nxp,lpc1788-i2c + + reg: + description: physical address and length of the device registers
Drop all of these descriptions as they're obvious, other than...
Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml line 32
Quoted 12 lines
Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml new file +12
-0+ maxItems: 1 + + interrupts: + description: a single interrupt specifier + maxItems: 1 + + clocks: + description: clock for the device + maxItems: 1 + + clock-frequency: + description: the desired I2C bus clock frequency in Hz
..maybe this one. Otherwise this looks okay to me.
Thanks,
Conor.
Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml line 43
Quoted 11 lines
Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml new file +11
-0+ default: 100000 + + resets: + description: reset for the device + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 0
These two come for free with the ref to i2c-controller.yaml :)
Quoted 26 lines
Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml new file +23
-0+ +required: + - compatible + - reg + - interrupts + - clocks + - "#address-cells" + - "#size-cells" + +unevaluatedProperties: false + +examples: + - | + #include "dt-bindings/clock/lpc18xx-ccu.h" + + i2c@400a1000 { + compatible = "nxp,lpc1788-i2c"; + reg = <0x400a1000 0x1000>; + interrupts = <18>; + clocks = <&ccu1 CLK_APB1_I2C0>; + #address-cells = <1>; + #size-cells = <0>; + };Signature · 1 line
2.45.2
kernel test robot
build botkernel test robot noticed the following build warnings:
Hi Kanak,
kernel test robot noticed the following build warnings:
[auto build test WARNING on andi-shyti/i2c/i2c-host]
[also build test WARNING on linus/master v6.10-rc4 next-20240619] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kanak-Shilledar/dt-bindings-i2c-convert-to-dt-schema/20240620-000339 base: git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host patch link: https://lore.kernel.org/r/20240619154941.144011-2-kanakshilledar%40gmail.com patch subject: [PATCH] dt-bindings: i2c: convert to dt schema reproduce: (https://download.01.org/0day-ci/archive/20240620/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
Warning: Documentation/devicetree/bindings/power/wakeup-source.txt references a file that doesn't exist: Documentation/devicetree/bindings/input/qcom,pm8xxx-keypad.txt
Warning: Documentation/devicetree/bindings/regulator/siliconmitus,sm5703-regulator.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/siliconmitus,sm5703.yaml
>> Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/i2c/i2c-lpc2k.txt
Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/reserved-memory/qcom
Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/display/exynos/ Using alabaster theme
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki