Skip to contentSkip to conversation

rockchip: puma-rk3399: increase Ethernet PHY timeout to 30s

PATCH In review Quentin Schulz 2 participants 2 messages Jun 19, 2024 – Jul 16, 2024

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 rockchip: puma-rk3399: increase Ethernet PHY timeout to 30s

From: Quentin Schulz <[email protected]>

On Puma v2.1 with a KSZ9031, the Ethernet PHY often doesn't detect the link in the 4-second default timeout.

After some boot-loop test for about a thousand boots, 70% were below 10s, 90% below 15s and 100% below 30s. Let's play it safe and make it 30s so that hopefully all links that should be detected are.

---
Changes in v2:
- rebase on next
- use Kconfig symbol instead of constant in include/configs/
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 configs/puma-rk3399_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/puma-rk3399_defconfig +1 -0
index 5319239f989..4293cf0ae44 100644
@@ -69,6 +69,7 @@ CONFIG_MMC_SDHCI_ROCKCHIP=y
 CONFIG_SF_DEFAULT_BUS=1
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_WINBOND=y
+CONFIG_PHY_ANEG_TIMEOUT=30000
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ90X1=y
 CONFIG_ETH_DESIGNWARE=y

---
base-commit: 01a5d7547ed3a51a8ac5837c31a150f85bc475f8
change-id: 20240619-puma-eth-timeout-41be9c243ed7

Best regards,

Signature · 1 line
Quentin Schulz <[email protected]>
Reviewed-by on v2 1/1
#1 lore raw
Quoted 10 lines · Quentin Schulz

From: Quentin Schulz <[email protected]>

On Puma v2.1 with a KSZ9031, the Ethernet PHY often doesn't detect the link in the 4-second default timeout.

After some boot-loop test for about a thousand boots, 70% were below 10s, 90% below 15s and 100% below 30s. Let's play it safe and make it 30s so that hopefully all links that should be detected are.

Thanks,
- Kever

Quoted 27 lines

---
Changes in v2:
- rebase on next
- use Kconfig symbol instead of constant in include/configs/
- Link to v1: https://lore.kernel.org/r/[email protected]

---
  configs/puma-rk3399_defconfig | 1 +
  1 file changed, 1 insertion(+)
configs/puma-rk3399_defconfig +1 -1
index 5319239f989..4293cf0ae44 100644
@@ -69,6 +69,7 @@ CONFIG_MMC_SDHCI_ROCKCHIP=y
  CONFIG_SF_DEFAULT_BUS=1
  CONFIG_SPI_FLASH_GIGADEVICE=y
  CONFIG_SPI_FLASH_WINBOND=y
+CONFIG_PHY_ANEG_TIMEOUT=30000
  CONFIG_PHY_MICREL=y
  CONFIG_PHY_MICREL_KSZ90X1=y
  CONFIG_ETH_DESIGNWARE=y
 
---

base-commit: 01a5d7547ed3a51a8ac5837c31a150f85bc475f8
change-id: 20240619-puma-eth-timeout-41be9c243ed7

Best regards,