Skip to contentSkip to conversation

util: constant -1 with expression of type char

PATCH Applied [email protected] 2 participants 2 messages Jun 19, 2024 – Jun 26, 2024 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 util: constant -1 with expression of type char

From: Yunseong Kim <[email protected]>

This patch resolve following warning.

tools/perf/util/evsel.c:1620:9: error: result of comparison of constant -1 with expression of type 'char' is always false
-Werror,-Wtautological-constant-out-of-range-compare
1620 | if (c == -1)
| ~ ^ ~~

---
 tools/perf/util/evsel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/evsel.c +1 -1
index 25857894c047..bc603193c477 100644
@@ -1620,7 +1620,7 @@ static int evsel__read_group(struct evsel *leader, int cpu_map_idx, int thread)
 
 static bool read_until_char(struct io *io, char e)
 {
-	char c;
+	int c;
 
 	do {
 		c = io__get_char(io);
Signature · 1 line
2.45.2
maintainer Applied
#1 lore raw
Quoted 9 lines · On Thu, 20 Jun 2024 05:34:29 +0900, [email protected] wrote:

This patch resolve following warning.

tools/perf/util/evsel.c:1620:9: error: result of comparison of constant -1 with expression of type 'char' is always false
-Werror,-Wtautological-constant-out-of-range-compare
1620 | if (c == -1)
| ~ ^ ~~

[...]

Applied to perf-tools-next, thanks!

Best regards,
Namhyung