util: constant -1 with expression of type char
PATCH 1/1 util: constant -1 with expression of type char
From: Yunseong Kim <[email protected]>
This patch resolve following warning.
tools/perf/util/evsel.c:1620:9: error: result of comparison of constant -1 with expression of type 'char' is always false
-Werror,-Wtautological-constant-out-of-range-compare
1620 | if (c == -1)
| ~ ^ ~~
Signed-off-by Yunseong Kim <[email protected]>
--- tools/perf/util/evsel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/evsel.c +1 -1
@@ -1620,7 +1620,7 @@ static int evsel__read_group(struct evsel *leader, int cpu_map_idx, int thread)static bool read_until_char (struct io *io,char e) { -char c; +int c; do { c = io__get_char(io);
Signature · 1 line
2.45.2
Quoted 9 lines · On Thu, 20 Jun 2024 05:34:29 +0900, [email protected] wrote:
This patch resolve following warning.
tools/perf/util/evsel.c:1620:9: error: result of comparison of constant -1 with expression of type 'char' is always false
-Werror,-Wtautological-constant-out-of-range-compare
1620 | if (c == -1)
| ~ ^ ~~[...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung